All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Timur Tabi <timur@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	thierry.reding@gmail.com, david.brown@linaro.org,
	andy.gross@linaro.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Varadarajan Narayanan <varada@codeaurora.org>,
	Archit Taneja <architt@codeaurora.org>
Subject: Re: [PATCH 2/3] [v8] pinctrl: qcom: disable GPIO groups with no pins
Date: Wed, 13 Dec 2017 14:37:38 -0800	[thread overview]
Message-ID: <20171213223738.GR7997@codeaurora.org> (raw)
In-Reply-To: <1513189818-7384-3-git-send-email-timur@codeaurora.org>

On 12/13, Timur Tabi wrote:
> pinctrl-msm only accepts an array of GPIOs from 0 to n-1, and it expects
> each group to support have only one pin (npins == 1).
> 
> We can support "sparse" GPIO maps if we allow for some groups to have zero
> pins (npins == 0).  These pins are "hidden" from the rest of the driver
> and gpiolib.
> 
> Access to unavailable GPIOs is blocked via a request callback.  If the
> requested GPIO is unavailable, -EACCES is returned, which prevents
> further access to that GPIO.
> 
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] [v8] pinctrl: qcom: disable GPIO groups with no pins
Date: Wed, 13 Dec 2017 14:37:38 -0800	[thread overview]
Message-ID: <20171213223738.GR7997@codeaurora.org> (raw)
In-Reply-To: <1513189818-7384-3-git-send-email-timur@codeaurora.org>

On 12/13, Timur Tabi wrote:
> pinctrl-msm only accepts an array of GPIOs from 0 to n-1, and it expects
> each group to support have only one pin (npins == 1).
> 
> We can support "sparse" GPIO maps if we allow for some groups to have zero
> pins (npins == 0).  These pins are "hidden" from the rest of the driver
> and gpiolib.
> 
> Access to unavailable GPIOs is blocked via a request callback.  If the
> requested GPIO is unavailable, -EACCES is returned, which prevents
> further access to that GPIO.
> 
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2017-12-13 22:37 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 18:30 [PATCH 0/3] [v10] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-12-13 18:30 ` Timur Tabi
2017-12-13 18:30 ` [PATCH 1/3] [v2] Revert "gpio: set up initial state from .get_direction()" Timur Tabi
2017-12-13 18:30   ` Timur Tabi
2017-12-13 22:37   ` Stephen Boyd
2017-12-13 22:37     ` Stephen Boyd
2017-12-13 18:30 ` [PATCH 2/3] [v8] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-12-13 18:30   ` Timur Tabi
2017-12-13 22:37   ` Stephen Boyd [this message]
2017-12-13 22:37     ` Stephen Boyd
2017-12-13 18:30 ` [PATCH 3/3] [v6] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002 Timur Tabi
2017-12-13 18:30   ` Timur Tabi
2017-12-13 23:01   ` Stephen Boyd
2017-12-13 23:01     ` Stephen Boyd
2017-12-13 23:09     ` Timur Tabi
2017-12-13 23:09       ` Timur Tabi
2017-12-19  1:18       ` Timur Tabi
2017-12-19  1:18         ` Timur Tabi
2017-12-19  2:39         ` Stephen Boyd
2017-12-19  2:39           ` Stephen Boyd
2017-12-19  4:47           ` Timur Tabi
2017-12-19  4:47             ` Timur Tabi
2017-12-19 19:10             ` Stephen Boyd
2017-12-19 19:10               ` Stephen Boyd
2017-12-19 19:27           ` Timur Tabi
2017-12-19 19:27             ` Timur Tabi
2017-12-19 20:30             ` Stephen Boyd
2017-12-19 20:30               ` Stephen Boyd
2017-12-19 20:32               ` Timur Tabi
2017-12-19 20:32                 ` Timur Tabi
2017-12-19 22:56           ` Timur Tabi
2017-12-19 22:56             ` Timur Tabi
2017-12-20  2:26             ` Stephen Boyd
2017-12-20  2:26               ` Stephen Boyd
2017-12-20  4:05               ` Timur Tabi
2017-12-20  4:05                 ` Timur Tabi
2017-12-20  8:15                 ` Stephen Boyd
2017-12-20  8:15                   ` Stephen Boyd
2017-12-20 17:46                   ` Timur Tabi
2017-12-20 17:46                     ` Timur Tabi
2017-12-21  0:39                     ` Stephen Boyd
2017-12-21  0:39                       ` Stephen Boyd
2017-12-21  1:06                       ` Timur Tabi
2017-12-21  1:06                         ` Timur Tabi
2017-12-22  1:46                         ` Stephen Boyd
2017-12-22  1:46                           ` Stephen Boyd
2018-01-04 15:46                           ` Timur Tabi
2018-01-04 15:46                             ` Timur Tabi
2018-01-04 16:04                             ` Andy Shevchenko
2018-01-04 16:04                               ` Andy Shevchenko
2018-01-09 13:46                               ` Linus Walleij
2018-01-09 13:46                                 ` Linus Walleij
  -- strict thread matches above, loose matches on Subject: below --
2017-12-20 19:10 [PATCH 0/3] [v11] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-12-20 19:10 ` [PATCH 2/3] [v8] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-12-20 19:10   ` Timur Tabi
2017-12-12 20:50 [PATCH 0/3] [v9] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-12-12 20:50 ` [PATCH 2/3] [v8] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-12-12 20:50   ` Timur Tabi
2017-12-13 14:42   ` Andy Shevchenko
2017-12-13 14:42     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213223738.GR7997@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.gross@linaro.org \
    --cc=architt@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=thierry.reding@gmail.com \
    --cc=timur@codeaurora.org \
    --cc=varada@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.