All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	thierry.reding@gmail.com, david.brown@linaro.org,
	andy.gross@linaro.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Varadarajan Narayanan <varada@codeaurora.org>,
	Archit Taneja <architt@codeaurora.org>
Subject: Re: [PATCH 3/3] [v6] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
Date: Thu, 4 Jan 2018 09:46:18 -0600	[thread overview]
Message-ID: <8e985f68-5887-b0d5-8c45-e22b5d8f60cf@codeaurora.org> (raw)
In-Reply-To: <20171222014633.GD7997@codeaurora.org>

On 12/21/2017 07:46 PM, Stephen Boyd wrote:
> Ok. That's testable with acpi_match_device_ids() though. I can
> add that into pinctrl-msm.c so we don't have to pass info about
> available gpios from ACPI specific driver into the pinctrl-msm
> core driver. That's why I'm trying to avoid doing it in the ACPI
> specific driver. Do it close to where the gpiochip is created
> instead.

I guess we're just going to have to agree to disagree.  I see the DSDs 
as being SOC-specific, and therefore belong in the SOC driver.  I'm 
still going to need an SOC driver to define the TLMM register layout.

But as I said earlier, I've already spent way too much time working on a 
driver that, in all likelihood, never be used in any production system 
anyway.

I look forward to reviewing the next version of your patch.

> Maybe future HIDs could follow the DT design and then we can look
> for the same device property name in both firmwares. 

DSDs generally don't have the vendor prefix that DT properties do.

> Parsing
> ranges is simpler.

I'm not sure I agree with that.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] [v6] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
Date: Thu, 4 Jan 2018 09:46:18 -0600	[thread overview]
Message-ID: <8e985f68-5887-b0d5-8c45-e22b5d8f60cf@codeaurora.org> (raw)
In-Reply-To: <20171222014633.GD7997@codeaurora.org>

On 12/21/2017 07:46 PM, Stephen Boyd wrote:
> Ok. That's testable with acpi_match_device_ids() though. I can
> add that into pinctrl-msm.c so we don't have to pass info about
> available gpios from ACPI specific driver into the pinctrl-msm
> core driver. That's why I'm trying to avoid doing it in the ACPI
> specific driver. Do it close to where the gpiochip is created
> instead.

I guess we're just going to have to agree to disagree.  I see the DSDs 
as being SOC-specific, and therefore belong in the SOC driver.  I'm 
still going to need an SOC driver to define the TLMM register layout.

But as I said earlier, I've already spent way too much time working on a 
driver that, in all likelihood, never be used in any production system 
anyway.

I look forward to reviewing the next version of your patch.

> Maybe future HIDs could follow the DT design and then we can look
> for the same device property name in both firmwares. 

DSDs generally don't have the vendor prefix that DT properties do.

> Parsing
> ranges is simpler.

I'm not sure I agree with that.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2018-01-04 15:46 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 18:30 [PATCH 0/3] [v10] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-12-13 18:30 ` Timur Tabi
2017-12-13 18:30 ` [PATCH 1/3] [v2] Revert "gpio: set up initial state from .get_direction()" Timur Tabi
2017-12-13 18:30   ` Timur Tabi
2017-12-13 22:37   ` Stephen Boyd
2017-12-13 22:37     ` Stephen Boyd
2017-12-13 18:30 ` [PATCH 2/3] [v8] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-12-13 18:30   ` Timur Tabi
2017-12-13 22:37   ` Stephen Boyd
2017-12-13 22:37     ` Stephen Boyd
2017-12-13 18:30 ` [PATCH 3/3] [v6] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002 Timur Tabi
2017-12-13 18:30   ` Timur Tabi
2017-12-13 23:01   ` Stephen Boyd
2017-12-13 23:01     ` Stephen Boyd
2017-12-13 23:09     ` Timur Tabi
2017-12-13 23:09       ` Timur Tabi
2017-12-19  1:18       ` Timur Tabi
2017-12-19  1:18         ` Timur Tabi
2017-12-19  2:39         ` Stephen Boyd
2017-12-19  2:39           ` Stephen Boyd
2017-12-19  4:47           ` Timur Tabi
2017-12-19  4:47             ` Timur Tabi
2017-12-19 19:10             ` Stephen Boyd
2017-12-19 19:10               ` Stephen Boyd
2017-12-19 19:27           ` Timur Tabi
2017-12-19 19:27             ` Timur Tabi
2017-12-19 20:30             ` Stephen Boyd
2017-12-19 20:30               ` Stephen Boyd
2017-12-19 20:32               ` Timur Tabi
2017-12-19 20:32                 ` Timur Tabi
2017-12-19 22:56           ` Timur Tabi
2017-12-19 22:56             ` Timur Tabi
2017-12-20  2:26             ` Stephen Boyd
2017-12-20  2:26               ` Stephen Boyd
2017-12-20  4:05               ` Timur Tabi
2017-12-20  4:05                 ` Timur Tabi
2017-12-20  8:15                 ` Stephen Boyd
2017-12-20  8:15                   ` Stephen Boyd
2017-12-20 17:46                   ` Timur Tabi
2017-12-20 17:46                     ` Timur Tabi
2017-12-21  0:39                     ` Stephen Boyd
2017-12-21  0:39                       ` Stephen Boyd
2017-12-21  1:06                       ` Timur Tabi
2017-12-21  1:06                         ` Timur Tabi
2017-12-22  1:46                         ` Stephen Boyd
2017-12-22  1:46                           ` Stephen Boyd
2018-01-04 15:46                           ` Timur Tabi [this message]
2018-01-04 15:46                             ` Timur Tabi
2018-01-04 16:04                             ` Andy Shevchenko
2018-01-04 16:04                               ` Andy Shevchenko
2018-01-09 13:46                               ` Linus Walleij
2018-01-09 13:46                                 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e985f68-5887-b0d5-8c45-e22b5d8f60cf@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.gross@linaro.org \
    --cc=architt@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=sboyd@codeaurora.org \
    --cc=thierry.reding@gmail.com \
    --cc=varada@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.