* [renesas-drivers:topic/renesas-overlays 10/92] drivers/of/overlay.c:657:6: sparse: symbol 'overlay_changeset_release' was not declared. Should it be static?
@ 2017-12-14 19:40 kbuild test robot
2017-12-14 19:40 ` [RFC PATCH renesas-drivers] of: overlay: overlay_changeset_release() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-12-14 19:40 UTC (permalink / raw)
To: Pantelis Antoniou; +Cc: kbuild-all, linux-renesas-soc, Geert Uytterhoeven
tree: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git topic/renesas-overlays
head: 47d433a558bb60587eb9f86a4d010ef74e03fa0d
commit: 11de0d24be4742a41feceb95d9145b08843dc70a [10/92] of: overlay: kobjectify overlay objects
reproduce:
# apt-get install sparse
git checkout 11de0d24be4742a41feceb95d9145b08843dc70a
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC PATCH renesas-drivers] of: overlay: overlay_changeset_release() can be static
2017-12-14 19:40 [renesas-drivers:topic/renesas-overlays 10/92] drivers/of/overlay.c:657:6: sparse: symbol 'overlay_changeset_release' was not declared. Should it be static? kbuild test robot
@ 2017-12-14 19:40 ` kbuild test robot
2017-12-15 8:05 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-12-14 19:40 UTC (permalink / raw)
To: Pantelis Antoniou; +Cc: kbuild-all, linux-renesas-soc, Geert Uytterhoeven
Fixes: 11de0d24be47 ("of: overlay: kobjectify overlay objects")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index ef7e8a4..7f0255e 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -654,7 +654,7 @@ static inline struct overlay_changeset *kobj_to_ovcs(struct kobject *kobj)
return container_of(kobj, struct overlay_changeset, kobj);
}
-void overlay_changeset_release(struct kobject *kobj)
+static void overlay_changeset_release(struct kobject *kobj)
{
struct overlay_changeset *ovcs = kobj_to_ovcs(kobj);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH renesas-drivers] of: overlay: overlay_changeset_release() can be static
2017-12-14 19:40 ` [RFC PATCH renesas-drivers] of: overlay: overlay_changeset_release() can be static kbuild test robot
@ 2017-12-15 8:05 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2017-12-15 8:05 UTC (permalink / raw)
To: kbuild test robot
Cc: Pantelis Antoniou, kbuild-all, Linux-Renesas, Geert Uytterhoeven
On Thu, Dec 14, 2017 at 8:40 PM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> Fixes: 11de0d24be47 ("of: overlay: kobjectify overlay objects")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Thank you, will fold in the offending prototype commit.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-15 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-14 19:40 [renesas-drivers:topic/renesas-overlays 10/92] drivers/of/overlay.c:657:6: sparse: symbol 'overlay_changeset_release' was not declared. Should it be static? kbuild test robot
2017-12-14 19:40 ` [RFC PATCH renesas-drivers] of: overlay: overlay_changeset_release() can be static kbuild test robot
2017-12-15 8:05 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.