[renesas-drivers:topic/renesas-overlays 10/92] drivers/of/overlay.c:657:6: sparse: symbol 'overlay_changeset_release' was not declared. Should it be static?

[renesas-drivers:topic/renesas-overlays 10/92] drivers/of/overlay.c:657:6: sparse: symbol 'overlay_changeset_release' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git topic/renesas-overlays
head:   47d433a558bb60587eb9f86a4d010ef74e03fa0d
commit: 11de0d24be4742a41feceb95d9145b08843dc70a [10/92] of: overlay: kobjectify overlay objects
reproduce:
        # apt-get install sparse
        git checkout 11de0d24be4742a41feceb95d9145b08843dc70a
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)


Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH renesas-drivers] of: overlay: overlay_changeset_release() can be static

[kbuild test robot]

Fixes: 11de0d24be47 ("of: overlay: kobjectify overlay objects")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 overlay.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index ef7e8a4..7f0255e 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -654,7 +654,7 @@ static inline struct overlay_changeset *kobj_to_ovcs(struct kobject *kobj)
 	return container_of(kobj, struct overlay_changeset, kobj);
 }
 
-void overlay_changeset_release(struct kobject *kobj)
+static void overlay_changeset_release(struct kobject *kobj)
 {
 	struct overlay_changeset *ovcs = kobj_to_ovcs(kobj);
 

Re: [RFC PATCH renesas-drivers] of: overlay: overlay_changeset_release() can be static

[Geert Uytterhoeven]

On Thu, Dec 14, 2017 at 8:40 PM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> Fixes: 11de0d24be47 ("of: overlay: kobjectify overlay objects")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Thank you, will fold in the offending prototype commit.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds