* [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL
@ 2017-12-14 15:43 Marta Lofstedt
2017-12-14 16:13 ` ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Marta Lofstedt @ 2017-12-14 15:43 UTC (permalink / raw)
To: intel-gfx
The discussion on how to fix the issues has been stagnant for a
long time, see the Bugzilla below and:
https://patchwork.freedesktop.org/patch/170429/
After only changing display cable the result of my machine went
from always failing to hit a WARN. This is also illustrated on
CI-shards, where the shard-apl flip-flop between pass and WARN
and the shard-kbl always fail. This made me realize that the
THRESHOLD_PER_CONNECTOR also needed to be updated, while previous
discussion only touched the THRESHOLD_TOTAL. As discussed in
provided links the motivation for this test is to discover big
anomalies in edid timings, but with the current tight thresholds
we are hitting the issues too often.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100047
Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
tests/kms_sysfs_edid_timing.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
index 12013881..7dbd3fe6 100644
--- a/tests/kms_sysfs_edid_timing.c
+++ b/tests/kms_sysfs_edid_timing.c
@@ -26,8 +26,8 @@
#include <fcntl.h>
#include <sys/stat.h>
-#define THRESHOLD_PER_CONNECTOR 10
-#define THRESHOLD_TOTAL 50
+#define THRESHOLD_PER_CONNECTOR 15
+#define THRESHOLD_TOTAL 95
#define CHECK_TIMES 15
IGT_TEST_DESCRIPTION("This check the time we take to read the content of all "
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL
2017-12-14 15:43 [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL Marta Lofstedt
@ 2017-12-14 16:13 ` Patchwork
2017-12-14 18:07 ` ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-12-14 16:13 UTC (permalink / raw)
To: Marta Lofstedt; +Cc: intel-gfx
== Series Details ==
Series: test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL
URL : https://patchwork.freedesktop.org/series/35365/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
103af7286e2d1014e3d7126691fe046ab2c9f73e lib: Ask the kernel to quiesce the GPU
with latest DRM-Tip kernel build CI_DRM_3518
b00330d88cf3 drm-tip: 2017y-12m-14d-14h-56m-59s UTC integration manifest
No testlist changes.
Test debugfs_test:
Subgroup read_all_entries:
incomplete -> PASS (fi-snb-2520m) fdo#103713 +1
Test gem_sync:
Subgroup basic-all:
fail -> DMESG-FAIL (fi-blb-e6850) fdo#104259
Test kms_chamelium:
Subgroup dp-crc-fast:
pass -> DMESG-FAIL (fi-kbl-7500u) fdo#103841
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
dmesg-warn -> PASS (fi-kbl-r) fdo#104172
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104259 https://bugs.freedesktop.org/show_bug.cgi?id=104259
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:439s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:445s
fi-blb-e6850 total:288 pass:222 dwarn:1 dfail:1 fail:0 skip:64 time:395s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:517s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:280s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:500s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:501s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:483s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:473s
fi-elk-e7500 total:224 pass:163 dwarn:15 dfail:0 fail:0 skip:45
fi-gdg-551 total:288 pass:178 dwarn:1 dfail:0 fail:1 skip:108 time:267s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:533s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:409s
fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:416s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:390s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:484s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:427s
fi-kbl-7500u total:288 pass:262 dwarn:1 dfail:1 fail:0 skip:24 time:488s
fi-kbl-7560u total:288 pass:268 dwarn:1 dfail:0 fail:0 skip:19 time:528s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:464s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:522s
fi-pnv-d510 total:288 pass:221 dwarn:1 dfail:0 fail:1 skip:65 time:596s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:447s
fi-skl-6600u total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:534s
fi-skl-6700hq total:288 pass:261 dwarn:1 dfail:0 fail:0 skip:26 time:561s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:493s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:451s
fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:416s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:597s
fi-cnl-y total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:619s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_670/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.IGT: failure for test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL
2017-12-14 15:43 [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL Marta Lofstedt
2017-12-14 16:13 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-12-14 18:07 ` Patchwork
2017-12-15 6:41 ` [PATCH i-g-t] " Lofstedt, Marta
2017-12-15 8:36 ` [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT Marta Lofstedt
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-12-14 18:07 UTC (permalink / raw)
To: Marta Lofstedt; +Cc: intel-gfx
== Series Details ==
Series: test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL
URL : https://patchwork.freedesktop.org/series/35365/
State : failure
== Summary ==
Test drv_suspend:
Subgroup fence-restore-tiled2untiled-hibernate:
skip -> FAIL (shard-hsw) fdo#103375
Test kms_cursor_crc:
Subgroup cursor-256x256-offscreen:
pass -> SKIP (shard-hsw)
Test kms_flip:
Subgroup wf_vblank-vs-dpms:
pass -> SKIP (shard-hsw) fdo#102614
Subgroup modeset-vs-vblank-race:
fail -> PASS (shard-hsw) fdo#103060
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
pass -> FAIL (shard-snb) fdo#101623 +1
Test kms_plane:
Subgroup plane-panning-bottom-right-suspend-pipe-b-planes:
pass -> SKIP (shard-snb)
Test gem_tiled_swapping:
Subgroup non-threaded:
dmesg-warn -> PASS (shard-hsw) fdo#104218 +1
Test perf_pmu:
Subgroup semaphore-wait-bcs0:
skip -> INCOMPLETE (shard-hsw)
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218
shard-hsw total:2644 pass:1502 dwarn:1 dfail:0 fail:9 skip:1131 time:9171s
shard-snb total:2712 pass:1306 dwarn:1 dfail:0 fail:13 skip:1392 time:8004s
Blacklisted hosts:
shard-apl total:2712 pass:1684 dwarn:1 dfail:0 fail:26 skip:1001 time:13788s
shard-kbl total:2635 pass:1746 dwarn:1 dfail:0 fail:31 skip:855 time:10583s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_670/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL
2017-12-14 15:43 [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL Marta Lofstedt
2017-12-14 16:13 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-14 18:07 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2017-12-15 6:41 ` Lofstedt, Marta
2017-12-15 8:36 ` [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT Marta Lofstedt
3 siblings, 0 replies; 6+ messages in thread
From: Lofstedt, Marta @ 2017-12-15 6:41 UTC (permalink / raw)
To: intel-gfx; +Cc: Sarvela, Tomi P
https://patchwork.freedesktop.org/series/35365/
Judging from PW results, THRESHOLD_TOTAL 95 is still not enough for KBL-shards. That is interesting.
/Marta
> -----Original Message-----
> From: Lofstedt, Marta
> Sent: Thursday, December 14, 2017 5:44 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Taylor, Clinton A
> <clinton.a.taylor@intel.com>; Lofstedt, Marta <marta.lofstedt@intel.com>
> Subject: [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase
> THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL
>
> The discussion on how to fix the issues has been stagnant for a long time, see
> the Bugzilla below and:
> https://patchwork.freedesktop.org/patch/170429/
>
> After only changing display cable the result of my machine went from always
> failing to hit a WARN. This is also illustrated on CI-shards, where the shard-apl
> flip-flop between pass and WARN and the shard-kbl always fail. This made
> me realize that the THRESHOLD_PER_CONNECTOR also needed to be
> updated, while previous discussion only touched the THRESHOLD_TOTAL. As
> discussed in provided links the motivation for this test is to discover big
> anomalies in edid timings, but with the current tight thresholds we are hitting
> the issues too often.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100047
> Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> ---
> tests/kms_sysfs_edid_timing.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 12013881..7dbd3fe6 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -26,8 +26,8 @@
> #include <fcntl.h>
> #include <sys/stat.h>
>
> -#define THRESHOLD_PER_CONNECTOR 10
> -#define THRESHOLD_TOTAL 50
> +#define THRESHOLD_PER_CONNECTOR 15
> +#define THRESHOLD_TOTAL 95
> #define CHECK_TIMES 15
>
> IGT_TEST_DESCRIPTION("This check the time we take to read the content of
> all "
> --
> 2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT
2017-12-14 15:43 [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL Marta Lofstedt
` (2 preceding siblings ...)
2017-12-15 6:41 ` [PATCH i-g-t] " Lofstedt, Marta
@ 2017-12-15 8:36 ` Marta Lofstedt
3 siblings, 0 replies; 6+ messages in thread
From: Marta Lofstedt @ 2017-12-15 8:36 UTC (permalink / raw)
To: intel-gfx
It is possoble to get very mysterious results from kms_sysfs_edid timing
Since there is no try-bot for IGT I am using IGT PW to get more data.
Marta Lofstedt (2):
test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and
THRESHOLD_TOTAL
HACK to get kms_sysfs_edid_timing run on more machines
tests/intel-ci/fast-feedback.testlist | 2 +-
tests/kms_sysfs_edid_timing.c | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT
@ 2017-12-15 13:04 Marta Lofstedt
0 siblings, 0 replies; 6+ messages in thread
From: Marta Lofstedt @ 2017-12-15 13:04 UTC (permalink / raw)
To: intel-gfx
It is possoble to get very mysterious results from kms_sysfs_edid timing
Since there is no try-bot for IGT I am using IGT PW to get more data.
Marta Lofstedt (2):
test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and
THRESHOLD_TOTAL
HACK to get kms_sysfs_edid_timing run on more machines
tests/intel-ci/fast-feedback.testlist | 2 +-
tests/kms_sysfs_edid_timing.c | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-15 13:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-14 15:43 [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL Marta Lofstedt
2017-12-14 16:13 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-14 18:07 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-12-15 6:41 ` [PATCH i-g-t] " Lofstedt, Marta
2017-12-15 8:36 ` [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT Marta Lofstedt
2017-12-15 13:04 Marta Lofstedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.