* [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT
@ 2017-12-15 13:04 Marta Lofstedt
2017-12-15 13:04 ` [PATCH i-g-t v2 1/2] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL Marta Lofstedt
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Marta Lofstedt @ 2017-12-15 13:04 UTC (permalink / raw)
To: intel-gfx
It is possoble to get very mysterious results from kms_sysfs_edid timing
Since there is no try-bot for IGT I am using IGT PW to get more data.
Marta Lofstedt (2):
test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and
THRESHOLD_TOTAL
HACK to get kms_sysfs_edid_timing run on more machines
tests/intel-ci/fast-feedback.testlist | 2 +-
tests/kms_sysfs_edid_timing.c | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH i-g-t v2 1/2] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL 2017-12-15 13:04 [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT Marta Lofstedt @ 2017-12-15 13:04 ` Marta Lofstedt 2017-12-15 13:04 ` [PATCH i-g-t v2 2/2] HACK to get kms_sysfs_edid_timing run on more machines Marta Lofstedt ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Marta Lofstedt @ 2017-12-15 13:04 UTC (permalink / raw) To: intel-gfx The discussion on how to fix the issues has been stagnant for a long time, see the Bugzilla below and: https://patchwork.freedesktop.org/patch/170429/ After only changing display cable the result of my machine went from always failing to hit a WARN. This is also illustrated on CI-shards, where the shard-apl flip-flop between pass and WARN and the shard-kbl always fail. This made me realize that the THRESHOLD_PER_CONNECTOR also needed to be updated, while previous discussion only touched the THRESHOLD_TOTAL. As discussed in provided links the motivation for this test is to discover big anomalies in edid timings, but with the current tight thresholds we are hitting the issues too often. V2: increased thresholds further after patchwork results. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100047 Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com> --- tests/kms_sysfs_edid_timing.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c index 12013881..53d96c1c 100644 --- a/tests/kms_sysfs_edid_timing.c +++ b/tests/kms_sysfs_edid_timing.c @@ -26,8 +26,8 @@ #include <fcntl.h> #include <sys/stat.h> -#define THRESHOLD_PER_CONNECTOR 10 -#define THRESHOLD_TOTAL 50 +#define THRESHOLD_PER_CONNECTOR 20 +#define THRESHOLD_TOTAL 150 #define CHECK_TIMES 15 IGT_TEST_DESCRIPTION("This check the time we take to read the content of all " @@ -75,21 +75,21 @@ igt_simple_main close(fd); } - igt_debug("%s: mean.max %.2fns, %.2fus, %.2fms, " + igt_info("%s: mean.max %.2fns, %.2fus, %.2fms, " "mean.avg %.2fns, %.2fus, %.2fms\n", de->d_name, mean.max, mean.max / 1e3, mean.max / 1e6, mean.mean, mean.mean / 1e3, mean.mean / 1e6); if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) { - igt_warn("%s: probe time exceed 10ms, " + igt_warn("%s: probe time exceed %ims, " "max=%.2fms, avg=%.2fms\n", de->d_name, - mean.max / 1e6, mean.mean / 1e6); + THRESHOLD_PER_CONNECTOR, mean.max / 1e6, mean.mean / 1e6); } igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6), - "%s: average probe time exceeded 50ms, " + "%s: average probe time exceeded %ims, " "max=%.2fms, avg=%.2fms\n", de->d_name, - mean.max / 1e6, mean.mean / 1e6); + THRESHOLD_TOTAL, mean.max / 1e6, mean.mean / 1e6); } closedir(dirp); -- 2.11.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH i-g-t v2 2/2] HACK to get kms_sysfs_edid_timing run on more machines 2017-12-15 13:04 [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT Marta Lofstedt 2017-12-15 13:04 ` [PATCH i-g-t v2 1/2] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL Marta Lofstedt @ 2017-12-15 13:04 ` Marta Lofstedt 2017-12-15 13:36 ` ✓ Fi.CI.BAT: success for kms_sysfs_edid timing and hack to run for BAT Patchwork 2017-12-15 15:23 ` ✓ Fi.CI.IGT: " Patchwork 3 siblings, 0 replies; 6+ messages in thread From: Marta Lofstedt @ 2017-12-15 13:04 UTC (permalink / raw) To: intel-gfx Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com> --- tests/intel-ci/fast-feedback.testlist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index f71a16bc..a6c3f614 100644 --- a/tests/intel-ci/fast-feedback.testlist +++ b/tests/intel-ci/fast-feedback.testlist @@ -1,5 +1,5 @@ # Keep alphabetically sorted by default - +igt@kms_sysfs_edid_timing igt@core_auth@basic-auth igt@core_prop_blob@basic igt@debugfs_test@read_all_entries -- 2.11.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for kms_sysfs_edid timing and hack to run for BAT 2017-12-15 13:04 [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT Marta Lofstedt 2017-12-15 13:04 ` [PATCH i-g-t v2 1/2] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL Marta Lofstedt 2017-12-15 13:04 ` [PATCH i-g-t v2 2/2] HACK to get kms_sysfs_edid_timing run on more machines Marta Lofstedt @ 2017-12-15 13:36 ` Patchwork 2017-12-15 15:23 ` ✓ Fi.CI.IGT: " Patchwork 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2017-12-15 13:36 UTC (permalink / raw) To: Marta Lofstedt; +Cc: intel-gfx == Series Details == Series: kms_sysfs_edid timing and hack to run for BAT URL : https://patchwork.freedesktop.org/series/35404/ State : success == Summary == IGT patchset tested on top of latest successful build c0be3310715e2f744b892c51f09e62273bcc8e57 tests/kms_frontbuffer_tracking: Correctly handle debugfs errors with latest DRM-Tip kernel build CI_DRM_3521 ad43db157c69 drm-tip: 2017y-12m-14d-20h-09m-53s UTC integration manifest No testlist changes. Test debugfs_test: Subgroup read_all_entries: dmesg-fail -> DMESG-WARN (fi-elk-e7500) fdo#103989 +1 incomplete -> PASS (fi-snb-2520m) fdo#103713 Test gem_sync: Subgroup basic-all: dmesg-fail -> FAIL (fi-blb-e6850) fdo#104259 Subgroup basic-each: skip -> PASS (fi-blb-e6850) Subgroup basic-many-each: skip -> PASS (fi-blb-e6850) Subgroup basic-store-all: skip -> PASS (fi-blb-e6850) Subgroup basic-store-each: skip -> PASS (fi-blb-e6850) Test gem_tiled_blits: Subgroup basic: skip -> PASS (fi-blb-e6850) Test gem_tiled_fence_blits: Subgroup basic: skip -> PASS (fi-blb-e6850) Test gem_wait: Subgroup basic-busy-all: skip -> PASS (fi-blb-e6850) Subgroup basic-wait-all: skip -> PASS (fi-blb-e6850) Subgroup basic-await-all: skip -> PASS (fi-blb-e6850) Test kms_busy: Subgroup basic-flip-a: skip -> PASS (fi-blb-e6850) Subgroup basic-flip-b: skip -> PASS (fi-blb-e6850) Test kms_cursor_legacy: Subgroup basic-busy-flip-before-cursor-legacy: skip -> PASS (fi-blb-e6850) Test kms_psr_sink_crc: Subgroup psr_basic: dmesg-warn -> PASS (fi-skl-6700hq) fdo#101144 fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989 fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713 fdo#104259 https://bugs.freedesktop.org/show_bug.cgi?id=104259 fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144 fi-bdw-5557u total:289 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:437s fi-bdw-gvtdvm total:289 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:440s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:1 skip:64 time:391s fi-bsw-n3050 total:289 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:511s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:282s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:501s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:510s fi-byt-j1900 total:289 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:490s fi-byt-n2820 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:479s fi-elk-e7500 total:225 pass:164 dwarn:15 dfail:0 fail:0 skip:45 fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:108 time:274s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:527s fi-hsw-4770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:410s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:421s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:392s fi-ivb-3520m total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:482s fi-ivb-3770 total:289 pass:256 dwarn:0 dfail:0 fail:0 skip:33 time:432s fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:483s fi-kbl-7560u total:289 pass:269 dwarn:1 dfail:0 fail:0 skip:19 time:522s fi-kbl-7567u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:472s fi-kbl-r total:289 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:530s fi-pnv-d510 total:289 pass:221 dwarn:1 dfail:0 fail:1 skip:65 time:594s fi-skl-6260u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:448s fi-skl-6600u total:289 pass:261 dwarn:1 dfail:0 fail:0 skip:27 time:537s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:561s fi-skl-6770hq total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:491s fi-skl-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:445s fi-snb-2520m total:289 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:555s fi-snb-2600 total:289 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:420s Blacklisted hosts: fi-cfl-s2 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:603s fi-cnl-y total:253 pass:226 dwarn:0 dfail:0 fail:0 skip:25 fi-glk-dsi total:184 pass:99 dwarn:0 dfail:1 fail:0 skip:83 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_679/issues.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for kms_sysfs_edid timing and hack to run for BAT 2017-12-15 13:04 [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT Marta Lofstedt ` (2 preceding siblings ...) 2017-12-15 13:36 ` ✓ Fi.CI.BAT: success for kms_sysfs_edid timing and hack to run for BAT Patchwork @ 2017-12-15 15:23 ` Patchwork 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2017-12-15 15:23 UTC (permalink / raw) To: Marta Lofstedt; +Cc: intel-gfx == Series Details == Series: kms_sysfs_edid timing and hack to run for BAT URL : https://patchwork.freedesktop.org/series/35404/ State : success == Summary == Test gem_tiled_swapping: Subgroup non-threaded: dmesg-warn -> PASS (shard-hsw) fdo#104218 +1 Test kms_flip: Subgroup vblank-vs-suspend: incomplete -> PASS (shard-hsw) fdo#103375 Subgroup vblank-vs-modeset-suspend-interruptible: pass -> INCOMPLETE (shard-hsw) fdo#103540 Test drv_selftest: Subgroup live_hangcheck: pass -> INCOMPLETE (shard-snb) fdo#103880 fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218 fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375 fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540 fdo#103880 https://bugs.freedesktop.org/show_bug.cgi?id=103880 shard-hsw total:2672 pass:1511 dwarn:1 dfail:0 fail:10 skip:1149 time:9039s shard-snb total:2694 pass:1289 dwarn:1 dfail:0 fail:12 skip:1391 time:7948s Blacklisted hosts: shard-apl total:2712 pass:1684 dwarn:1 dfail:0 fail:26 skip:1001 time:14005s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_679/shards.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL @ 2017-12-14 15:43 Marta Lofstedt 2017-12-15 8:36 ` [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT Marta Lofstedt 0 siblings, 1 reply; 6+ messages in thread From: Marta Lofstedt @ 2017-12-14 15:43 UTC (permalink / raw) To: intel-gfx The discussion on how to fix the issues has been stagnant for a long time, see the Bugzilla below and: https://patchwork.freedesktop.org/patch/170429/ After only changing display cable the result of my machine went from always failing to hit a WARN. This is also illustrated on CI-shards, where the shard-apl flip-flop between pass and WARN and the shard-kbl always fail. This made me realize that the THRESHOLD_PER_CONNECTOR also needed to be updated, while previous discussion only touched the THRESHOLD_TOTAL. As discussed in provided links the motivation for this test is to discover big anomalies in edid timings, but with the current tight thresholds we are hitting the issues too often. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100047 Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com> --- tests/kms_sysfs_edid_timing.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c index 12013881..7dbd3fe6 100644 --- a/tests/kms_sysfs_edid_timing.c +++ b/tests/kms_sysfs_edid_timing.c @@ -26,8 +26,8 @@ #include <fcntl.h> #include <sys/stat.h> -#define THRESHOLD_PER_CONNECTOR 10 -#define THRESHOLD_TOTAL 50 +#define THRESHOLD_PER_CONNECTOR 15 +#define THRESHOLD_TOTAL 95 #define CHECK_TIMES 15 IGT_TEST_DESCRIPTION("This check the time we take to read the content of all " -- 2.11.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT 2017-12-14 15:43 [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL Marta Lofstedt @ 2017-12-15 8:36 ` Marta Lofstedt 0 siblings, 0 replies; 6+ messages in thread From: Marta Lofstedt @ 2017-12-15 8:36 UTC (permalink / raw) To: intel-gfx It is possoble to get very mysterious results from kms_sysfs_edid timing Since there is no try-bot for IGT I am using IGT PW to get more data. Marta Lofstedt (2): test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL HACK to get kms_sysfs_edid_timing run on more machines tests/intel-ci/fast-feedback.testlist | 2 +- tests/kms_sysfs_edid_timing.c | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) -- 2.11.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-15 15:23 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-15 13:04 [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT Marta Lofstedt 2017-12-15 13:04 ` [PATCH i-g-t v2 1/2] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL Marta Lofstedt 2017-12-15 13:04 ` [PATCH i-g-t v2 2/2] HACK to get kms_sysfs_edid_timing run on more machines Marta Lofstedt 2017-12-15 13:36 ` ✓ Fi.CI.BAT: success for kms_sysfs_edid timing and hack to run for BAT Patchwork 2017-12-15 15:23 ` ✓ Fi.CI.IGT: " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2017-12-14 15:43 [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL Marta Lofstedt 2017-12-15 8:36 ` [PATCH i-g-t v2 0/2] kms_sysfs_edid timing and hack to run for BAT Marta Lofstedt
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.