From: Matthew Wilcox <willy@infradead.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: yang.zhang.wz@gmail.com, kvm@vger.kernel.org, mst@redhat.com,
liliang.opensource@gmail.com, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
aarcange@redhat.com, virtio-dev@lists.oasis-open.org,
mawilcox@microsoft.com, nilal@redhat.com, riel@redhat.com,
cornelia.huck@de.ibm.com, mhocko@kernel.org, quan.xu0@gmail.com,
linux-kernel@vger.kernel.org, amit.shah@redhat.com,
pbonzini@redhat.com, akpm@linux-foundation.org,
mgorman@techsingularity.net
Subject: Re: [PATCH v20 0/7] Virtio-balloon Enhancement
Date: Tue, 19 Dec 2017 06:40:20 -0800 [thread overview]
Message-ID: <20171219144020.GA30842__10561.5718327046$1513694348$gmane$org@bombadil.infradead.org> (raw)
In-Reply-To: <201712192305.AAE21882.MtQHJOFFSFVOLO@I-love.SAKURA.ne.jp>
On Tue, Dec 19, 2017 at 11:05:11PM +0900, Tetsuo Handa wrote:
> Removing exceptional path made this patch easier to read.
> But what I meant is
>
> Can you eliminate exception path and fold all xbitmap patches into one, and
> post only one xbitmap patch without virtio-balloon changes?
>
> .
>
> I still think we don't need xb_preload()/xb_preload_end().
> I think xb_find_set() has a bug in !node path.
Don't think. Write a test-case. Please. If it shows a bug, then great,
Wei has an example of what the bug is to fix. If it doesn't show a bug,
then we can add it to the test suite anyway, to ensure that case continues
to work in the future.
> Also, please avoid unconditionally adding to builtin modules.
> There are users who want to save even few KB.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-19 14:40 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 12:17 [PATCH v20 0/7] Virtio-balloon Enhancement Wei Wang
2017-12-19 12:17 ` [virtio-dev] " Wei Wang
2017-12-19 12:17 ` [Qemu-devel] " Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` [PATCH v20 1/7] xbitmap: Introduce xbitmap Wei Wang
2017-12-19 12:17 ` [virtio-dev] " Wei Wang
2017-12-19 12:17 ` [Qemu-devel] " Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 15:58 ` Philippe Ombredanne
2017-12-19 15:58 ` [Qemu-devel] " Philippe Ombredanne
2017-12-19 15:58 ` Philippe Ombredanne
2017-12-19 15:58 ` Philippe Ombredanne
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` [PATCH v20 2/7] xbitmap: potential improvement Wei Wang
2017-12-19 12:17 ` [virtio-dev] " Wei Wang
2017-12-19 12:17 ` [Qemu-devel] " Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` [PATCH v20 3/7] xbitmap: add more operations Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` [virtio-dev] " Wei Wang
2017-12-19 12:17 ` [Qemu-devel] " Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG Wei Wang
2017-12-19 12:17 ` [virtio-dev] " Wei Wang
2017-12-19 12:17 ` [Qemu-devel] " Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-24 3:21 ` Matthew Wilcox
2017-12-24 3:21 ` [Qemu-devel] " Matthew Wilcox
2017-12-24 3:21 ` Matthew Wilcox
2017-12-24 3:21 ` Matthew Wilcox
2017-12-24 4:45 ` Tetsuo Handa
2017-12-24 4:45 ` [Qemu-devel] " Tetsuo Handa
2017-12-24 4:45 ` Tetsuo Handa
2017-12-24 7:42 ` Wei Wang
2017-12-24 7:42 ` Wei Wang
2017-12-24 7:42 ` [virtio-dev] " Wei Wang
2017-12-24 7:42 ` [Qemu-devel] " Wei Wang
2017-12-24 7:42 ` Wei Wang
2017-12-24 8:16 ` [virtio-dev] " Wei Wang
2017-12-24 8:16 ` Wei Wang
2017-12-24 8:16 ` Wei Wang
2017-12-24 8:16 ` [Qemu-devel] " Wei Wang
2017-12-24 8:16 ` Wei Wang
2017-12-25 14:51 ` Tetsuo Handa
2017-12-25 14:51 ` [Qemu-devel] " Tetsuo Handa
2017-12-25 14:51 ` Tetsuo Handa
2017-12-26 3:06 ` Wei Wang
2017-12-26 3:06 ` [virtio-dev] " Wei Wang
2017-12-26 3:06 ` [Qemu-devel] " Wei Wang
2017-12-26 3:06 ` Wei Wang
2017-12-26 10:38 ` Tetsuo Handa
2017-12-26 10:38 ` [Qemu-devel] " Tetsuo Handa
2017-12-26 10:38 ` Tetsuo Handa
2017-12-26 11:36 ` Wei Wang
2017-12-26 11:36 ` Wei Wang
2017-12-26 11:36 ` [virtio-dev] " Wei Wang
2017-12-26 11:36 ` [Qemu-devel] " Wei Wang
2017-12-26 11:36 ` Wei Wang
2017-12-26 13:40 ` Tetsuo Handa
2017-12-26 13:40 ` [Qemu-devel] " Tetsuo Handa
2017-12-26 13:40 ` Tetsuo Handa
2017-12-26 3:06 ` Wei Wang
2018-01-02 13:24 ` Matthew Wilcox
2018-01-02 13:24 ` [Qemu-devel] " Matthew Wilcox
2018-01-02 13:24 ` Matthew Wilcox
2018-01-03 2:29 ` Tetsuo Handa
2018-01-03 2:29 ` [Qemu-devel] " Tetsuo Handa
2018-01-03 2:29 ` Tetsuo Handa
2018-01-03 9:00 ` Wei Wang
2018-01-03 9:00 ` [virtio-dev] " Wei Wang
2018-01-03 9:00 ` [Qemu-devel] " Wei Wang
2018-01-03 9:00 ` Wei Wang
2018-01-03 10:19 ` Tetsuo Handa
2018-01-03 10:19 ` [Qemu-devel] " Tetsuo Handa
2018-01-03 10:19 ` Tetsuo Handa
2018-01-03 9:00 ` Wei Wang
2018-01-02 13:24 ` Matthew Wilcox
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` [PATCH v20 5/7] mm: support reporting free page blocks Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` [virtio-dev] " Wei Wang
2017-12-19 12:17 ` [Qemu-devel] " Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` [PATCH v20 6/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ Wei Wang
2017-12-19 12:17 ` [virtio-dev] " Wei Wang
2017-12-19 12:17 ` [Qemu-devel] " Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` [PATCH v20 7/7] virtio-balloon: don't report free pages when page poisoning is enabled Wei Wang
2017-12-19 12:17 ` [virtio-dev] " Wei Wang
2017-12-19 12:17 ` [Qemu-devel] " Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 12:17 ` Wei Wang
2017-12-19 14:05 ` [PATCH v20 0/7] Virtio-balloon Enhancement Tetsuo Handa
2017-12-19 14:05 ` [Qemu-devel] " Tetsuo Handa
2017-12-19 14:05 ` Tetsuo Handa
2017-12-19 14:40 ` Matthew Wilcox [this message]
2017-12-19 14:40 ` Matthew Wilcox
2017-12-19 14:40 ` [Qemu-devel] " Matthew Wilcox
2017-12-19 14:40 ` Matthew Wilcox
2017-12-20 2:33 ` Tetsuo Handa
2017-12-20 2:33 ` [Qemu-devel] " Tetsuo Handa
2017-12-20 2:33 ` Tetsuo Handa
2017-12-19 18:08 ` Michael S. Tsirkin
2017-12-19 18:08 ` [virtio-dev] " Michael S. Tsirkin
2017-12-19 18:08 ` [Qemu-devel] " Michael S. Tsirkin
2017-12-19 18:08 ` Michael S. Tsirkin
2017-12-19 18:08 ` Michael S. Tsirkin
2017-12-20 10:34 ` Wei Wang
2017-12-20 10:34 ` [virtio-dev] " Wei Wang
2017-12-20 10:34 ` [Qemu-devel] " Wei Wang
2017-12-20 10:34 ` Wei Wang
2017-12-20 12:25 ` Matthew Wilcox
2017-12-20 12:25 ` Matthew Wilcox
2017-12-20 12:25 ` [Qemu-devel] " Matthew Wilcox
2017-12-20 12:25 ` Matthew Wilcox
2017-12-20 16:13 ` Wang, Wei W
2017-12-20 16:13 ` Wang, Wei W
2017-12-20 16:13 ` [virtio-dev] " Wang, Wei W
2017-12-20 16:13 ` [Qemu-devel] " Wang, Wei W
2017-12-20 16:13 ` Wang, Wei W
2017-12-20 16:13 ` Wang, Wei W
2017-12-20 17:10 ` Matthew Wilcox
2017-12-20 17:10 ` Matthew Wilcox
2017-12-20 17:10 ` [Qemu-devel] " Matthew Wilcox
2017-12-20 17:10 ` Matthew Wilcox
2017-12-20 17:10 ` Matthew Wilcox
2017-12-21 2:49 ` Wei Wang
2017-12-21 2:49 ` Wei Wang
2017-12-21 2:49 ` [virtio-dev] " Wei Wang
2017-12-21 2:49 ` [Qemu-devel] " Wei Wang
2017-12-21 2:49 ` Wei Wang
2017-12-21 2:49 ` Wei Wang
2017-12-21 12:14 ` Matthew Wilcox
2017-12-21 12:14 ` Matthew Wilcox
2017-12-21 12:14 ` [Qemu-devel] " Matthew Wilcox
2017-12-21 12:14 ` Matthew Wilcox
2017-12-21 12:14 ` Matthew Wilcox
2017-12-21 12:56 ` Tetsuo Handa
2017-12-21 12:56 ` [Qemu-devel] " Tetsuo Handa
2017-12-21 12:56 ` Tetsuo Handa
2017-12-20 10:34 ` Wei Wang
2017-12-19 12:17 Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20171219144020.GA30842__10561.5718327046$1513694348$gmane$org@bombadil.infradead.org' \
--to=willy@infradead.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amit.shah@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=liliang.opensource@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=qemu-devel@nongnu.org \
--cc=quan.xu0@gmail.com \
--cc=riel@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.