* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-19 21:05 ` kevans91-OYTqUY/oFF8 0 siblings, 0 replies; 50+ messages in thread From: kevans91 @ 2017-12-19 21:05 UTC (permalink / raw) To: Srinivas Kandagatla, Rob Herring, Mark Rutland, Maxime Ripard, Chen-Yu Tsai, Russell King Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi, Kyle Evans Allwinner a83t has a 1 KB sid block with efuse for security rootkey and thermal calibration data, add node to describe it. a83t-sid is not currently supported by nvmem/sunxi-sid, but it is supported in an external driver for FreeBSD. Signed-off-by: Kyle Evans <kevans91@ksu.edu> --- Changes in v2: - remove bogus "From:" line in commit text; no functional change Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 + arch/arm/boot/dts/sun8i-a83t.dtsi | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt index d69543701..e319fe5e2 100644 --- a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt +++ b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt @@ -4,6 +4,7 @@ Required properties: - compatible: Should be one of the following: "allwinner,sun4i-a10-sid" "allwinner,sun7i-a20-sid" + "allwinner,sun8i-a83t-sid" "allwinner,sun8i-h3-sid" "allwinner,sun50i-a64-sid" diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index de5119a2a..cced6e5fb 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -238,6 +238,11 @@ #size-cells = <0>; }; + sid: eeprom@1c14000 { + compatible = "allwinner,sun8i-a83t-sid"; + reg = <0x1c14000 0x400>; + }; + usb_otg: usb@1c19000 { compatible = "allwinner,sun8i-a83t-musb", "allwinner,sun8i-a33-musb"; -- 2.15.1 ^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-19 21:05 ` kevans91-OYTqUY/oFF8 0 siblings, 0 replies; 50+ messages in thread From: kevans91 at ksu.edu @ 2017-12-19 21:05 UTC (permalink / raw) To: linux-arm-kernel Allwinner a83t has a 1 KB sid block with efuse for security rootkey and thermal calibration data, add node to describe it. a83t-sid is not currently supported by nvmem/sunxi-sid, but it is supported in an external driver for FreeBSD. Signed-off-by: Kyle Evans <kevans91@ksu.edu> --- Changes in v2: - remove bogus "From:" line in commit text; no functional change Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 + arch/arm/boot/dts/sun8i-a83t.dtsi | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt index d69543701..e319fe5e2 100644 --- a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt +++ b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt @@ -4,6 +4,7 @@ Required properties: - compatible: Should be one of the following: "allwinner,sun4i-a10-sid" "allwinner,sun7i-a20-sid" + "allwinner,sun8i-a83t-sid" "allwinner,sun8i-h3-sid" "allwinner,sun50i-a64-sid" diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index de5119a2a..cced6e5fb 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -238,6 +238,11 @@ #size-cells = <0>; }; + sid: eeprom at 1c14000 { + compatible = "allwinner,sun8i-a83t-sid"; + reg = <0x1c14000 0x400>; + }; + usb_otg: usb at 1c19000 { compatible = "allwinner,sun8i-a83t-musb", "allwinner,sun8i-a33-musb"; -- 2.15.1 ^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-19 21:05 ` kevans91-OYTqUY/oFF8 0 siblings, 0 replies; 50+ messages in thread From: kevans91-OYTqUY/oFF8 @ 2017-12-19 21:05 UTC (permalink / raw) To: Srinivas Kandagatla, Rob Herring, Mark Rutland, Maxime Ripard, Chen-Yu Tsai, Russell King Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Kyle Evans Allwinner a83t has a 1 KB sid block with efuse for security rootkey and thermal calibration data, add node to describe it. a83t-sid is not currently supported by nvmem/sunxi-sid, but it is supported in an external driver for FreeBSD. Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> --- Changes in v2: - remove bogus "From:" line in commit text; no functional change Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 + arch/arm/boot/dts/sun8i-a83t.dtsi | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt index d69543701..e319fe5e2 100644 --- a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt +++ b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt @@ -4,6 +4,7 @@ Required properties: - compatible: Should be one of the following: "allwinner,sun4i-a10-sid" "allwinner,sun7i-a20-sid" + "allwinner,sun8i-a83t-sid" "allwinner,sun8i-h3-sid" "allwinner,sun50i-a64-sid" diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index de5119a2a..cced6e5fb 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -238,6 +238,11 @@ #size-cells = <0>; }; + sid: eeprom@1c14000 { + compatible = "allwinner,sun8i-a83t-sid"; + reg = <0x1c14000 0x400>; + }; + usb_otg: usb@1c19000 { compatible = "allwinner,sun8i-a83t-musb", "allwinner,sun8i-a33-musb"; -- 2.15.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-20 21:45 ` Rob Herring 0 siblings, 0 replies; 50+ messages in thread From: Rob Herring @ 2017-12-20 21:45 UTC (permalink / raw) To: kevans91 Cc: Srinivas Kandagatla, Mark Rutland, Maxime Ripard, Chen-Yu Tsai, Russell King, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > thermal calibration data, add node to describe it. > > a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > supported in an external driver for FreeBSD. > > Signed-off-by: Kyle Evans <kevans91@ksu.edu> > --- > > Changes in v2: > - remove bogus "From:" line in commit text; no functional change > > Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 + > arch/arm/boot/dts/sun8i-a83t.dtsi | 5 +++++ > 2 files changed, 6 insertions(+) Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-20 21:45 ` Rob Herring 0 siblings, 0 replies; 50+ messages in thread From: Rob Herring @ 2017-12-20 21:45 UTC (permalink / raw) To: linux-arm-kernel On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: > Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > thermal calibration data, add node to describe it. > > a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > supported in an external driver for FreeBSD. > > Signed-off-by: Kyle Evans <kevans91@ksu.edu> > --- > > Changes in v2: > - remove bogus "From:" line in commit text; no functional change > > Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 + > arch/arm/boot/dts/sun8i-a83t.dtsi | 5 +++++ > 2 files changed, 6 insertions(+) Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-20 21:45 ` Rob Herring 0 siblings, 0 replies; 50+ messages in thread From: Rob Herring @ 2017-12-20 21:45 UTC (permalink / raw) To: kevans91-OYTqUY/oFF8 Cc: Srinivas Kandagatla, Mark Rutland, Maxime Ripard, Chen-Yu Tsai, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: > Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > thermal calibration data, add node to describe it. > > a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > supported in an external driver for FreeBSD. > > Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> > --- > > Changes in v2: > - remove bogus "From:" line in commit text; no functional change > > Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 + > arch/arm/boot/dts/sun8i-a83t.dtsi | 5 +++++ > 2 files changed, 6 insertions(+) Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 14:55 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2017-12-21 14:55 UTC (permalink / raw) To: kevans91 Cc: Srinivas Kandagatla, Rob Herring, Mark Rutland, Chen-Yu Tsai, Russell King, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 691 bytes --] Hi Kyle, On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > thermal calibration data, add node to describe it. > > a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > supported in an external driver for FreeBSD. > > Signed-off-by: Kyle Evans <kevans91@ksu.edu> The patch looks fine in itself, but we've had a number of issues with the register layout (and access patterns) in the past, so I'd rather have something that works in Linux too if possible. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 14:55 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2017-12-21 14:55 UTC (permalink / raw) To: linux-arm-kernel Hi Kyle, On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: > Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > thermal calibration data, add node to describe it. > > a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > supported in an external driver for FreeBSD. > > Signed-off-by: Kyle Evans <kevans91@ksu.edu> The patch looks fine in itself, but we've had a number of issues with the register layout (and access patterns) in the past, so I'd rather have something that works in Linux too if possible. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171221/cf6e2c93/attachment.sig> ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 14:55 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2017-12-21 14:55 UTC (permalink / raw) To: kevans91-OYTqUY/oFF8 Cc: Srinivas Kandagatla, Rob Herring, Mark Rutland, Chen-Yu Tsai, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 733 bytes --] Hi Kyle, On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: > Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > thermal calibration data, add node to describe it. > > a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > supported in an external driver for FreeBSD. > > Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> The patch looks fine in itself, but we've had a number of issues with the register layout (and access patterns) in the past, so I'd rather have something that works in Linux too if possible. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t 2017-12-21 14:55 ` Maxime Ripard (?) (?) @ 2017-12-21 15:07 ` Icenowy Zheng -1 siblings, 0 replies; 50+ messages in thread From: Icenowy Zheng @ 2017-12-21 15:07 UTC (permalink / raw) To: linux-arm-kernel ? 2017?12?21???? CST ??10:55:12?Maxime Ripard ??? > Hi Kyle, > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: > > Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > thermal calibration data, add node to describe it. > > > > a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > supported in an external driver for FreeBSD. > > > > Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > The patch looks fine in itself, but we've had a number of issues with > the register layout (and access patterns) in the past, so I'd rather > have something that works in Linux too if possible. I think for A83T it can just refer H3. > > Maxime ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 15:19 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2017-12-21 15:19 UTC (permalink / raw) To: Maxime Ripard Cc: Srinivas Kandagatla, Rob Herring, Mark Rutland, Chen-Yu Tsai, Russell King, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi Kyle, > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> thermal calibration data, add node to describe it. >> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> supported in an external driver for FreeBSD. >> >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > The patch looks fine in itself, but we've had a number of issues with > the register layout (and access patterns) in the past, so I'd rather > have something that works in Linux too if possible. Hello! I have a patch that I think should make it work fine on Linux [1], but I'm afraid I have little to no capability to test it myself and so I did not add it as well. I do know that the rootkey is offset 0x200 into the given space [2], as is the case with the H3, and that the readout quirk is not needed. I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the H3, but I do know that thermal data can be found at 0x34 and 0x38 in this space. [1] https://people.freebsd.org/~kevans/sunxi-sid.diff [2] https://svnweb.freebsd.org/base/head/sys/arm/allwinner/aw_sid.c?view=markup#l56 ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 15:19 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2017-12-21 15:19 UTC (permalink / raw) To: linux-arm-kernel On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi Kyle, > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> thermal calibration data, add node to describe it. >> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> supported in an external driver for FreeBSD. >> >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > The patch looks fine in itself, but we've had a number of issues with > the register layout (and access patterns) in the past, so I'd rather > have something that works in Linux too if possible. Hello! I have a patch that I think should make it work fine on Linux [1], but I'm afraid I have little to no capability to test it myself and so I did not add it as well. I do know that the rootkey is offset 0x200 into the given space [2], as is the case with the H3, and that the readout quirk is not needed. I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the H3, but I do know that thermal data can be found at 0x34 and 0x38 in this space. [1] https://people.freebsd.org/~kevans/sunxi-sid.diff [2] https://svnweb.freebsd.org/base/head/sys/arm/allwinner/aw_sid.c?view=markup#l56 ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 15:19 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2017-12-21 15:19 UTC (permalink / raw) To: Maxime Ripard Cc: Srinivas Kandagatla, Rob Herring, Mark Rutland, Chen-Yu Tsai, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > Hi Kyle, > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> thermal calibration data, add node to describe it. >> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> supported in an external driver for FreeBSD. >> >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> > > The patch looks fine in itself, but we've had a number of issues with > the register layout (and access patterns) in the past, so I'd rather > have something that works in Linux too if possible. Hello! I have a patch that I think should make it work fine on Linux [1], but I'm afraid I have little to no capability to test it myself and so I did not add it as well. I do know that the rootkey is offset 0x200 into the given space [2], as is the case with the H3, and that the readout quirk is not needed. I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the H3, but I do know that thermal data can be found at 0x34 and 0x38 in this space. [1] https://people.freebsd.org/~kevans/sunxi-sid.diff [2] https://svnweb.freebsd.org/base/head/sys/arm/allwinner/aw_sid.c?view=markup#l56 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 15:26 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2017-12-21 15:26 UTC (permalink / raw) To: Kyle Evans Cc: Srinivas Kandagatla, Rob Herring, Mark Rutland, Chen-Yu Tsai, Russell King, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 1657 bytes --] Hi, On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > Hi Kyle, > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> thermal calibration data, add node to describe it. > >> > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> supported in an external driver for FreeBSD. > >> > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > The patch looks fine in itself, but we've had a number of issues with > > the register layout (and access patterns) in the past, so I'd rather > > have something that works in Linux too if possible. > > I have a patch that I think should make it work fine on Linux [1], but > I'm afraid I have little to no capability to test it myself and so I > did not add it as well. > > I do know that the rootkey is offset 0x200 into the given space [2], > as is the case with the H3, and that the readout quirk is not needed. > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > this space. Then maybe we should leave it aside until someone takes some time on the A83t. The good news is that the binding itself looks fine, so as far as FreeBSD goes, there shouldn't be anything preventing you from using it I guess. Chen-Yu, what do you think? Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 15:26 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2017-12-21 15:26 UTC (permalink / raw) To: linux-arm-kernel Hi, On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > Hi Kyle, > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> thermal calibration data, add node to describe it. > >> > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> supported in an external driver for FreeBSD. > >> > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > The patch looks fine in itself, but we've had a number of issues with > > the register layout (and access patterns) in the past, so I'd rather > > have something that works in Linux too if possible. > > I have a patch that I think should make it work fine on Linux [1], but > I'm afraid I have little to no capability to test it myself and so I > did not add it as well. > > I do know that the rootkey is offset 0x200 into the given space [2], > as is the case with the H3, and that the readout quirk is not needed. > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > this space. Then maybe we should leave it aside until someone takes some time on the A83t. The good news is that the binding itself looks fine, so as far as FreeBSD goes, there shouldn't be anything preventing you from using it I guess. Chen-Yu, what do you think? Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171221/7c003c1c/attachment.sig> ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 15:26 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2017-12-21 15:26 UTC (permalink / raw) To: Kyle Evans Cc: Srinivas Kandagatla, Rob Herring, Mark Rutland, Chen-Yu Tsai, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 1685 bytes --] Hi, On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > Hi Kyle, > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> thermal calibration data, add node to describe it. > >> > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> supported in an external driver for FreeBSD. > >> > >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> > > > > The patch looks fine in itself, but we've had a number of issues with > > the register layout (and access patterns) in the past, so I'd rather > > have something that works in Linux too if possible. > > I have a patch that I think should make it work fine on Linux [1], but > I'm afraid I have little to no capability to test it myself and so I > did not add it as well. > > I do know that the rootkey is offset 0x200 into the given space [2], > as is the case with the H3, and that the readout quirk is not needed. > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > this space. Then maybe we should leave it aside until someone takes some time on the A83t. The good news is that the binding itself looks fine, so as far as FreeBSD goes, there shouldn't be anything preventing you from using it I guess. Chen-Yu, what do you think? Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 15:30 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2017-12-21 15:30 UTC (permalink / raw) To: Maxime Ripard Cc: Srinivas Kandagatla, Rob Herring, Mark Rutland, Chen-Yu Tsai, Russell King, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Thu, Dec 21, 2017 at 9:26 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > Hi Kyle, >> > >> > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> thermal calibration data, add node to describe it. >> >> >> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> supported in an external driver for FreeBSD. >> >> >> >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> > >> > The patch looks fine in itself, but we've had a number of issues with >> > the register layout (and access patterns) in the past, so I'd rather >> > have something that works in Linux too if possible. >> >> I have a patch that I think should make it work fine on Linux [1], but >> I'm afraid I have little to no capability to test it myself and so I >> did not add it as well. >> >> I do know that the rootkey is offset 0x200 into the given space [2], >> as is the case with the H3, and that the readout quirk is not needed. >> I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. Yeah, we've had this exact binding in our own copy of DTS up until a recent point when we flipped the switch to pulling DT from Mainline Linux and trying to upstream changes instead of having a bunch of local modifications in our tree. > Chen-Yu, what do you think? > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 15:30 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2017-12-21 15:30 UTC (permalink / raw) To: linux-arm-kernel On Thu, Dec 21, 2017 at 9:26 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > Hi Kyle, >> > >> > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: >> >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> thermal calibration data, add node to describe it. >> >> >> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> supported in an external driver for FreeBSD. >> >> >> >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> > >> > The patch looks fine in itself, but we've had a number of issues with >> > the register layout (and access patterns) in the past, so I'd rather >> > have something that works in Linux too if possible. >> >> I have a patch that I think should make it work fine on Linux [1], but >> I'm afraid I have little to no capability to test it myself and so I >> did not add it as well. >> >> I do know that the rootkey is offset 0x200 into the given space [2], >> as is the case with the H3, and that the readout quirk is not needed. >> I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. Yeah, we've had this exact binding in our own copy of DTS up until a recent point when we flipped the switch to pulling DT from Mainline Linux and trying to upstream changes instead of having a bunch of local modifications in our tree. > Chen-Yu, what do you think? > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 15:30 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2017-12-21 15:30 UTC (permalink / raw) To: Maxime Ripard Cc: Srinivas Kandagatla, Rob Herring, Mark Rutland, Chen-Yu Tsai, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw On Thu, Dec 21, 2017 at 9:26 AM, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: >> > Hi Kyle, >> > >> > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: >> >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> thermal calibration data, add node to describe it. >> >> >> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> supported in an external driver for FreeBSD. >> >> >> >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> >> > >> > The patch looks fine in itself, but we've had a number of issues with >> > the register layout (and access patterns) in the past, so I'd rather >> > have something that works in Linux too if possible. >> >> I have a patch that I think should make it work fine on Linux [1], but >> I'm afraid I have little to no capability to test it myself and so I >> did not add it as well. >> >> I do know that the rootkey is offset 0x200 into the given space [2], >> as is the case with the H3, and that the readout quirk is not needed. >> I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. Yeah, we've had this exact binding in our own copy of DTS up until a recent point when we flipped the switch to pulling DT from Mainline Linux and trying to upstream changes instead of having a bunch of local modifications in our tree. > Chen-Yu, what do you think? > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 15:39 ` Chen-Yu Tsai 0 siblings, 0 replies; 50+ messages in thread From: Chen-Yu Tsai @ 2017-12-21 15:39 UTC (permalink / raw) To: Maxime Ripard Cc: Kyle Evans, Srinivas Kandagatla, Rob Herring, Mark Rutland, Chen-Yu Tsai, Russell King, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Thu, Dec 21, 2017 at 11:26 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > Hi Kyle, >> > >> > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> thermal calibration data, add node to describe it. >> >> >> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> supported in an external driver for FreeBSD. >> >> >> >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> > >> > The patch looks fine in itself, but we've had a number of issues with >> > the register layout (and access patterns) in the past, so I'd rather >> > have something that works in Linux too if possible. >> >> I have a patch that I think should make it work fine on Linux [1], but >> I'm afraid I have little to no capability to test it myself and so I >> did not add it as well. >> >> I do know that the rootkey is offset 0x200 into the given space [2], >> as is the case with the H3, and that the readout quirk is not needed. >> I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. > > Chen-Yu, what do you think? Looks good to me. ChenYu ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 15:39 ` Chen-Yu Tsai 0 siblings, 0 replies; 50+ messages in thread From: Chen-Yu Tsai @ 2017-12-21 15:39 UTC (permalink / raw) To: Maxime Ripard Cc: Kyle Evans, Srinivas Kandagatla, Rob Herring, Mark Rutland, Chen-Yu Tsai, Russell King, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Thu, Dec 21, 2017 at 11:26 PM, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: >> > Hi Kyle, >> > >> > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: >> >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> thermal calibration data, add node to describe it. >> >> >> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> supported in an external driver for FreeBSD. >> >> >> >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> >> > >> > The patch looks fine in itself, but we've had a number of issues with >> > the register layout (and access patterns) in the past, so I'd rather >> > have something that works in Linux too if possible. >> >> I have a patch that I think should make it work fine on Linux [1], but >> I'm afraid I have little to no capability to test it myself and so I >> did not add it as well. >> >> I do know that the rootkey is offset 0x200 into the given space [2], >> as is the case with the H3, and that the readout quirk is not needed. >> I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. > > Chen-Yu, what do you think? Looks good to me. ChenYu ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t 2017-12-21 15:26 ` Maxime Ripard (?) @ 2017-12-21 18:09 ` Emmanuel Vadot -1 siblings, 0 replies; 50+ messages in thread From: Emmanuel Vadot @ 2017-12-21 18:09 UTC (permalink / raw) To: Maxime Ripard Cc: Kyle Evans, Mark Rutland, devicetree, linux-sunxi, Russell King, linux-kernel, Chen-Yu Tsai, Rob Herring, Srinivas Kandagatla, linux-arm-kernel Hi Maxime, On Thu, 21 Dec 2017 16:26:30 +0100 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > <maxime.ripard@free-electrons.com> wrote: > > > Hi Kyle, > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > >> thermal calibration data, add node to describe it. > > >> > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > >> supported in an external driver for FreeBSD. > > >> > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > the register layout (and access patterns) in the past, so I'd rather > > > have something that works in Linux too if possible. > > > > I have a patch that I think should make it work fine on Linux [1], but > > I'm afraid I have little to no capability to test it myself and so I > > did not add it as well. > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > as is the case with the H3, and that the readout quirk is not needed. > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. Take some time on the Linux driver and do not apply this patch for now you mean ? Cheers, > The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. > > Chen-Yu, what do you think? > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- Emmanuel Vadot <manu@bidouilliste.com> ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 18:09 ` Emmanuel Vadot 0 siblings, 0 replies; 50+ messages in thread From: Emmanuel Vadot @ 2017-12-21 18:09 UTC (permalink / raw) To: linux-arm-kernel Hi Maxime, On Thu, 21 Dec 2017 16:26:30 +0100 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > <maxime.ripard@free-electrons.com> wrote: > > > Hi Kyle, > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > >> thermal calibration data, add node to describe it. > > >> > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > >> supported in an external driver for FreeBSD. > > >> > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > the register layout (and access patterns) in the past, so I'd rather > > > have something that works in Linux too if possible. > > > > I have a patch that I think should make it work fine on Linux [1], but > > I'm afraid I have little to no capability to test it myself and so I > > did not add it as well. > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > as is the case with the H3, and that the readout quirk is not needed. > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. Take some time on the Linux driver and do not apply this patch for now you mean ? Cheers, > The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. > > Chen-Yu, what do you think? > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- Emmanuel Vadot <manu@bidouilliste.com> ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-21 18:09 ` Emmanuel Vadot 0 siblings, 0 replies; 50+ messages in thread From: Emmanuel Vadot @ 2017-12-21 18:09 UTC (permalink / raw) To: Maxime Ripard Cc: Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, Kyle Evans, Chen-Yu Tsai, linux-arm-kernel Hi Maxime, On Thu, 21 Dec 2017 16:26:30 +0100 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > <maxime.ripard@free-electrons.com> wrote: > > > Hi Kyle, > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > >> thermal calibration data, add node to describe it. > > >> > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > >> supported in an external driver for FreeBSD. > > >> > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > the register layout (and access patterns) in the past, so I'd rather > > > have something that works in Linux too if possible. > > > > I have a patch that I think should make it work fine on Linux [1], but > > I'm afraid I have little to no capability to test it myself and so I > > did not add it as well. > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > as is the case with the H3, and that the readout quirk is not needed. > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. Take some time on the Linux driver and do not apply this patch for now you mean ? Cheers, > The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. > > Chen-Yu, what do you think? > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- Emmanuel Vadot <manu@bidouilliste.com> ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-22 8:35 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2017-12-22 8:35 UTC (permalink / raw) To: Emmanuel Vadot Cc: Kyle Evans, Mark Rutland, devicetree, linux-sunxi, Russell King, linux-kernel, Chen-Yu Tsai, Rob Herring, Srinivas Kandagatla, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 1888 bytes --] On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > > Hi Maxime, > > On Thu, 21 Dec 2017 16:26:30 +0100 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > Hi, > > > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > > <maxime.ripard@free-electrons.com> wrote: > > > > Hi Kyle, > > > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > > >> thermal calibration data, add node to describe it. > > > >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > > >> supported in an external driver for FreeBSD. > > > >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > > the register layout (and access patterns) in the past, so I'd rather > > > > have something that works in Linux too if possible. > > > > > > I have a patch that I think should make it work fine on Linux [1], but > > > I'm afraid I have little to no capability to test it myself and so I > > > did not add it as well. > > > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > > as is the case with the H3, and that the readout quirk is not needed. > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > > this space. > > > > Then maybe we should leave it aside until someone takes some time on > > the A83t. > > Take some time on the Linux driver and do not apply this patch for > now you mean ? Yep. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-22 8:35 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2017-12-22 8:35 UTC (permalink / raw) To: linux-arm-kernel On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > > Hi Maxime, > > On Thu, 21 Dec 2017 16:26:30 +0100 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > Hi, > > > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > > <maxime.ripard@free-electrons.com> wrote: > > > > Hi Kyle, > > > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > > >> thermal calibration data, add node to describe it. > > > >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > > >> supported in an external driver for FreeBSD. > > > >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > > the register layout (and access patterns) in the past, so I'd rather > > > > have something that works in Linux too if possible. > > > > > > I have a patch that I think should make it work fine on Linux [1], but > > > I'm afraid I have little to no capability to test it myself and so I > > > did not add it as well. > > > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > > as is the case with the H3, and that the readout quirk is not needed. > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > > this space. > > > > Then maybe we should leave it aside until someone takes some time on > > the A83t. > > Take some time on the Linux driver and do not apply this patch for > now you mean ? Yep. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171222/f9c1e545/attachment.sig> ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-22 8:35 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2017-12-22 8:35 UTC (permalink / raw) To: Emmanuel Vadot Cc: Kyle Evans, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Russell King, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Chen-Yu Tsai, Rob Herring, Srinivas Kandagatla, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r [-- Attachment #1: Type: text/plain, Size: 1940 bytes --] On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > > Hi Maxime, > > On Thu, 21 Dec 2017 16:26:30 +0100 > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > > Hi, > > > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > > > Hi Kyle, > > > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > > >> thermal calibration data, add node to describe it. > > > >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > > >> supported in an external driver for FreeBSD. > > > >> > > > >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> > > > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > > the register layout (and access patterns) in the past, so I'd rather > > > > have something that works in Linux too if possible. > > > > > > I have a patch that I think should make it work fine on Linux [1], but > > > I'm afraid I have little to no capability to test it myself and so I > > > did not add it as well. > > > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > > as is the case with the H3, and that the readout quirk is not needed. > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > > this space. > > > > Then maybe we should leave it aside until someone takes some time on > > the A83t. > > Take some time on the Linux driver and do not apply this patch for > now you mean ? Yep. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-22 10:07 ` Emmanuel Vadot 0 siblings, 0 replies; 50+ messages in thread From: Emmanuel Vadot @ 2017-12-22 10:07 UTC (permalink / raw) To: Maxime Ripard Cc: Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, Kyle Evans, Chen-Yu Tsai, linux-arm-kernel On Fri, 22 Dec 2017 09:35:08 +0100 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > > > > Hi Maxime, > > > > On Thu, 21 Dec 2017 16:26:30 +0100 > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > > > Hi, > > > > > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > > > <maxime.ripard@free-electrons.com> wrote: > > > > > Hi Kyle, > > > > > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > > > >> thermal calibration data, add node to describe it. > > > > >> > > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > > > >> supported in an external driver for FreeBSD. > > > > >> > > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > > > the register layout (and access patterns) in the past, so I'd rather > > > > > have something that works in Linux too if possible. > > > > > > > > I have a patch that I think should make it work fine on Linux [1], but > > > > I'm afraid I have little to no capability to test it myself and so I > > > > did not add it as well. > > > > > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > > > as is the case with the H3, and that the readout quirk is not needed. > > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > > > this space. > > > > > > Then maybe we should leave it aside until someone takes some time on > > > the A83t. > > > > Take some time on the Linux driver and do not apply this patch for > > now you mean ? > > Yep. > > Maxime Since linux doesn't have the compatible in it's driver what would be the harm to add the node in the DTS ? If a quirks is needed because some region is weird this would go in the driver right ? I don't see a technical problem for adding this node right now. If Kyle confirm the lenght of the region and that no quirk is needed will it be enough ? Cheers, -- Emmanuel Vadot <manu@bidouilliste.com> ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-22 10:07 ` Emmanuel Vadot 0 siblings, 0 replies; 50+ messages in thread From: Emmanuel Vadot @ 2017-12-22 10:07 UTC (permalink / raw) To: linux-arm-kernel On Fri, 22 Dec 2017 09:35:08 +0100 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > > > > Hi Maxime, > > > > On Thu, 21 Dec 2017 16:26:30 +0100 > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > > > Hi, > > > > > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > > > <maxime.ripard@free-electrons.com> wrote: > > > > > Hi Kyle, > > > > > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: > > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > > > >> thermal calibration data, add node to describe it. > > > > >> > > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > > > >> supported in an external driver for FreeBSD. > > > > >> > > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > > > the register layout (and access patterns) in the past, so I'd rather > > > > > have something that works in Linux too if possible. > > > > > > > > I have a patch that I think should make it work fine on Linux [1], but > > > > I'm afraid I have little to no capability to test it myself and so I > > > > did not add it as well. > > > > > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > > > as is the case with the H3, and that the readout quirk is not needed. > > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > > > this space. > > > > > > Then maybe we should leave it aside until someone takes some time on > > > the A83t. > > > > Take some time on the Linux driver and do not apply this patch for > > now you mean ? > > Yep. > > Maxime Since linux doesn't have the compatible in it's driver what would be the harm to add the node in the DTS ? If a quirks is needed because some region is weird this would go in the driver right ? I don't see a technical problem for adding this node right now. If Kyle confirm the lenght of the region and that no quirk is needed will it be enough ? Cheers, -- Emmanuel Vadot <manu@bidouilliste.com> ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-22 10:07 ` Emmanuel Vadot 0 siblings, 0 replies; 50+ messages in thread From: Emmanuel Vadot @ 2017-12-22 10:07 UTC (permalink / raw) To: Maxime Ripard Cc: Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Russell King, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Rob Herring, Srinivas Kandagatla, Kyle Evans, Chen-Yu Tsai, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Fri, 22 Dec 2017 09:35:08 +0100 Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > > > > Hi Maxime, > > > > On Thu, 21 Dec 2017 16:26:30 +0100 > > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > > > > Hi, > > > > > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > > > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > > > > Hi Kyle, > > > > > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: > > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > > > >> thermal calibration data, add node to describe it. > > > > >> > > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > > > >> supported in an external driver for FreeBSD. > > > > >> > > > > >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> > > > > > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > > > the register layout (and access patterns) in the past, so I'd rather > > > > > have something that works in Linux too if possible. > > > > > > > > I have a patch that I think should make it work fine on Linux [1], but > > > > I'm afraid I have little to no capability to test it myself and so I > > > > did not add it as well. > > > > > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > > > as is the case with the H3, and that the readout quirk is not needed. > > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > > > this space. > > > > > > Then maybe we should leave it aside until someone takes some time on > > > the A83t. > > > > Take some time on the Linux driver and do not apply this patch for > > now you mean ? > > Yep. > > Maxime Since linux doesn't have the compatible in it's driver what would be the harm to add the node in the DTS ? If a quirks is needed because some region is weird this would go in the driver right ? I don't see a technical problem for adding this node right now. If Kyle confirm the lenght of the region and that no quirk is needed will it be enough ? Cheers, -- Emmanuel Vadot <manu-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-22 10:11 ` Chen-Yu Tsai 0 siblings, 0 replies; 50+ messages in thread From: Chen-Yu Tsai @ 2017-12-22 10:11 UTC (permalink / raw) To: Emmanuel Vadot Cc: Maxime Ripard, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, Kyle Evans, Chen-Yu Tsai, linux-arm-kernel On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > On Fri, 22 Dec 2017 09:35:08 +0100 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> > >> > Hi Maxime, >> > >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> > >> > > Hi, >> > > >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> > > > <maxime.ripard@free-electrons.com> wrote: >> > > > > Hi Kyle, >> > > > > >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> > > > >> thermal calibration data, add node to describe it. >> > > > >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> > > > >> supported in an external driver for FreeBSD. >> > > > >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> > > > > >> > > > > The patch looks fine in itself, but we've had a number of issues with >> > > > > the register layout (and access patterns) in the past, so I'd rather >> > > > > have something that works in Linux too if possible. >> > > > >> > > > I have a patch that I think should make it work fine on Linux [1], but >> > > > I'm afraid I have little to no capability to test it myself and so I >> > > > did not add it as well. >> > > > >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> > > > as is the case with the H3, and that the readout quirk is not needed. >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> > > > this space. >> > > >> > > Then maybe we should leave it aside until someone takes some time on >> > > the A83t. >> > >> > Take some time on the Linux driver and do not apply this patch for >> > now you mean ? >> >> Yep. >> >> Maxime > > Since linux doesn't have the compatible in it's driver what would > be the harm to add the node in the DTS ? If a quirks is needed because > some region is weird this would go in the driver right ? I don't see a > technical problem for adding this node right now. > If Kyle confirm the lenght of the region and that no quirk is needed > will it be enough ? I guess I wasn't very clear. I'm OK with the patch going in. The device node currently says nothing about how much efuse space there is. The memory region covers that and the control section, and the size matches what the memory map says. The size and offset of the efuse space would be dealt with in the driver. ChenYu ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2017-12-22 10:11 ` Chen-Yu Tsai 0 siblings, 0 replies; 50+ messages in thread From: Chen-Yu Tsai @ 2017-12-22 10:11 UTC (permalink / raw) To: Emmanuel Vadot Cc: Maxime Ripard, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, Kyle Evans, Chen-Yu Tsai, linux-arm-kernel On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org> wrote: > On Fri, 22 Dec 2017 09:35:08 +0100 > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> > >> > Hi Maxime, >> > >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: >> > >> > > Hi, >> > > >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> > > > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: >> > > > > Hi Kyle, >> > > > > >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> > > > >> thermal calibration data, add node to describe it. >> > > > >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> > > > >> supported in an external driver for FreeBSD. >> > > > >> >> > > > >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> >> > > > > >> > > > > The patch looks fine in itself, but we've had a number of issues with >> > > > > the register layout (and access patterns) in the past, so I'd rather >> > > > > have something that works in Linux too if possible. >> > > > >> > > > I have a patch that I think should make it work fine on Linux [1], but >> > > > I'm afraid I have little to no capability to test it myself and so I >> > > > did not add it as well. >> > > > >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> > > > as is the case with the H3, and that the readout quirk is not needed. >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> > > > this space. >> > > >> > > Then maybe we should leave it aside until someone takes some time on >> > > the A83t. >> > >> > Take some time on the Linux driver and do not apply this patch for >> > now you mean ? >> >> Yep. >> >> Maxime > > Since linux doesn't have the compatible in it's driver what would > be the harm to add the node in the DTS ? If a quirks is needed because > some region is weird this would go in the driver right ? I don't see a > technical problem for adding this node right now. > If Kyle confirm the lenght of the region and that no quirk is needed > will it be enough ? I guess I wasn't very clear. I'm OK with the patch going in. The device node currently says nothing about how much efuse space there is. The memory region covers that and the control section, and the size matches what the memory map says. The size and offset of the efuse space would be dealt with in the driver. ChenYu ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-01-04 14:01 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2018-01-04 14:01 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, Kyle Evans, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 3174 bytes --] On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > > On Fri, 22 Dec 2017 09:35:08 +0100 > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> > > >> > Hi Maxime, > >> > > >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> > > >> > > Hi, > >> > > > >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> > > > <maxime.ripard@free-electrons.com> wrote: > >> > > > > Hi Kyle, > >> > > > > > >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> > > > >> thermal calibration data, add node to describe it. > >> > > > >> > >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> > > > >> supported in an external driver for FreeBSD. > >> > > > >> > >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > >> > > > > > >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> > > > > have something that works in Linux too if possible. > >> > > > > >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> > > > I'm afraid I have little to no capability to test it myself and so I > >> > > > did not add it as well. > >> > > > > >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> > > > this space. > >> > > > >> > > Then maybe we should leave it aside until someone takes some time on > >> > > the A83t. > >> > > >> > Take some time on the Linux driver and do not apply this patch for > >> > now you mean ? > >> > >> Yep. > >> > >> Maxime > > > > Since linux doesn't have the compatible in it's driver what would > > be the harm to add the node in the DTS ? If a quirks is needed because > > some region is weird this would go in the driver right ? I don't see a > > technical problem for adding this node right now. > > If Kyle confirm the lenght of the region and that no quirk is needed > > will it be enough ? > > I guess I wasn't very clear. I'm OK with the patch going in. The device > node currently says nothing about how much efuse space there is. The > memory region covers that and the control section, and the size matches > what the memory map says. > > The size and offset of the efuse space would be dealt with in the driver. Let's merge it then. Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-01-04 14:01 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2018-01-04 14:01 UTC (permalink / raw) To: linux-arm-kernel On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > > On Fri, 22 Dec 2017 09:35:08 +0100 > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> > > >> > Hi Maxime, > >> > > >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> > > >> > > Hi, > >> > > > >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> > > > <maxime.ripard@free-electrons.com> wrote: > >> > > > > Hi Kyle, > >> > > > > > >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: > >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> > > > >> thermal calibration data, add node to describe it. > >> > > > >> > >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> > > > >> supported in an external driver for FreeBSD. > >> > > > >> > >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > >> > > > > > >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> > > > > have something that works in Linux too if possible. > >> > > > > >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> > > > I'm afraid I have little to no capability to test it myself and so I > >> > > > did not add it as well. > >> > > > > >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> > > > this space. > >> > > > >> > > Then maybe we should leave it aside until someone takes some time on > >> > > the A83t. > >> > > >> > Take some time on the Linux driver and do not apply this patch for > >> > now you mean ? > >> > >> Yep. > >> > >> Maxime > > > > Since linux doesn't have the compatible in it's driver what would > > be the harm to add the node in the DTS ? If a quirks is needed because > > some region is weird this would go in the driver right ? I don't see a > > technical problem for adding this node right now. > > If Kyle confirm the lenght of the region and that no quirk is needed > > will it be enough ? > > I guess I wasn't very clear. I'm OK with the patch going in. The device > node currently says nothing about how much efuse space there is. The > memory region covers that and the control section, and the size matches > what the memory map says. > > The size and offset of the efuse space would be dealt with in the driver. Let's merge it then. Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180104/d04730a1/attachment.sig> ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-01-04 14:01 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2018-01-04 14:01 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, Kyle Evans, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 3363 bytes --] On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org> wrote: > > On Fri, 22 Dec 2017 09:35:08 +0100 > > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > > >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> > > >> > Hi Maxime, > >> > > >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > >> > > >> > > Hi, > >> > > > >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> > > > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > >> > > > > Hi Kyle, > >> > > > > > >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: > >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> > > > >> thermal calibration data, add node to describe it. > >> > > > >> > >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> > > > >> supported in an external driver for FreeBSD. > >> > > > >> > >> > > > >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> > >> > > > > > >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> > > > > have something that works in Linux too if possible. > >> > > > > >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> > > > I'm afraid I have little to no capability to test it myself and so I > >> > > > did not add it as well. > >> > > > > >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> > > > this space. > >> > > > >> > > Then maybe we should leave it aside until someone takes some time on > >> > > the A83t. > >> > > >> > Take some time on the Linux driver and do not apply this patch for > >> > now you mean ? > >> > >> Yep. > >> > >> Maxime > > > > Since linux doesn't have the compatible in it's driver what would > > be the harm to add the node in the DTS ? If a quirks is needed because > > some region is weird this would go in the driver right ? I don't see a > > technical problem for adding this node right now. > > If Kyle confirm the lenght of the region and that no quirk is needed > > will it be enough ? > > I guess I wasn't very clear. I'm OK with the patch going in. The device > node currently says nothing about how much efuse space there is. The > memory region covers that and the control section, and the size matches > what the memory map says. > > The size and offset of the efuse space would be dealt with in the driver. Let's merge it then. Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-01-08 15:30 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2018-01-08 15:30 UTC (permalink / raw) To: Maxime Ripard, Chen-Yu Tsai Cc: Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, linux-arm-kernel On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> > >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> > >> >> > Hi Maxime, >> >> > >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> > >> >> > > Hi, >> >> > > >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> > > > <maxime.ripard@free-electrons.com> wrote: >> >> > > > > Hi Kyle, >> >> > > > > >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> > > > >> thermal calibration data, add node to describe it. >> >> > > > >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> > > > >> supported in an external driver for FreeBSD. >> >> > > > >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> >> > > > > >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> > > > > have something that works in Linux too if possible. >> >> > > > >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> > > > did not add it as well. >> >> > > > >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> > > > this space. >> >> > > >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> > > the A83t. >> >> > >> >> > Take some time on the Linux driver and do not apply this patch for >> >> > now you mean ? >> >> >> >> Yep. >> >> >> >> Maxime >> > >> > Since linux doesn't have the compatible in it's driver what would >> > be the harm to add the node in the DTS ? If a quirks is needed because >> > some region is weird this would go in the driver right ? I don't see a >> > technical problem for adding this node right now. >> > If Kyle confirm the lenght of the region and that no quirk is needed >> > will it be enough ? >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> node currently says nothing about how much efuse space there is. The >> memory region covers that and the control section, and the size matches >> what the memory map says. >> >> The size and offset of the efuse space would be dealt with in the driver. > > Let's merge it then. > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > Maxime Hi, What does the timeline for these things normally look like? I'm new to these parts. =) Thanks, Kyle Evans ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-01-08 15:30 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2018-01-08 15:30 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> > >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> > >> >> > Hi Maxime, >> >> > >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> > >> >> > > Hi, >> >> > > >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> > > > <maxime.ripard@free-electrons.com> wrote: >> >> > > > > Hi Kyle, >> >> > > > > >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> > > > >> thermal calibration data, add node to describe it. >> >> > > > >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> > > > >> supported in an external driver for FreeBSD. >> >> > > > >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> >> > > > > >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> > > > > have something that works in Linux too if possible. >> >> > > > >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> > > > did not add it as well. >> >> > > > >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> > > > this space. >> >> > > >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> > > the A83t. >> >> > >> >> > Take some time on the Linux driver and do not apply this patch for >> >> > now you mean ? >> >> >> >> Yep. >> >> >> >> Maxime >> > >> > Since linux doesn't have the compatible in it's driver what would >> > be the harm to add the node in the DTS ? If a quirks is needed because >> > some region is weird this would go in the driver right ? I don't see a >> > technical problem for adding this node right now. >> > If Kyle confirm the lenght of the region and that no quirk is needed >> > will it be enough ? >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> node currently says nothing about how much efuse space there is. The >> memory region covers that and the control section, and the size matches >> what the memory map says. >> >> The size and offset of the efuse space would be dealt with in the driver. > > Let's merge it then. > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > Maxime Hi, What does the timeline for these things normally look like? I'm new to these parts. =) Thanks, Kyle Evans ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-01-08 15:30 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2018-01-08 15:30 UTC (permalink / raw) To: Maxime Ripard, Chen-Yu Tsai Cc: Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, linux-arm-kernel On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org> wrote: >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: >> > >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> > >> >> > Hi Maxime, >> >> > >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: >> >> > >> >> > > Hi, >> >> > > >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> > > > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: >> >> > > > > Hi Kyle, >> >> > > > > >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> > > > >> thermal calibration data, add node to describe it. >> >> > > > >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> > > > >> supported in an external driver for FreeBSD. >> >> > > > >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> >> >> > > > > >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> > > > > have something that works in Linux too if possible. >> >> > > > >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> > > > did not add it as well. >> >> > > > >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> > > > this space. >> >> > > >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> > > the A83t. >> >> > >> >> > Take some time on the Linux driver and do not apply this patch for >> >> > now you mean ? >> >> >> >> Yep. >> >> >> >> Maxime >> > >> > Since linux doesn't have the compatible in it's driver what would >> > be the harm to add the node in the DTS ? If a quirks is needed because >> > some region is weird this would go in the driver right ? I don't see a >> > technical problem for adding this node right now. >> > If Kyle confirm the lenght of the region and that no quirk is needed >> > will it be enough ? >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> node currently says nothing about how much efuse space there is. The >> memory region covers that and the control section, and the size matches >> what the memory map says. >> >> The size and offset of the efuse space would be dealt with in the driver. > > Let's merge it then. > > Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > > Maxime Hi, What does the timeline for these things normally look like? I'm new to these parts. =) Thanks, Kyle Evans ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-01-09 13:34 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2018-01-09 13:34 UTC (permalink / raw) To: Kyle Evans Cc: Chen-Yu Tsai, Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 3751 bytes --] On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: > On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > >> > On Fri, 22 Dec 2017 09:35:08 +0100 > >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> > > >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> >> > > >> >> > Hi Maxime, > >> >> > > >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> >> > > >> >> > > Hi, > >> >> > > > >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> >> > > > <maxime.ripard@free-electrons.com> wrote: > >> >> > > > > Hi Kyle, > >> >> > > > > > >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> >> > > > >> thermal calibration data, add node to describe it. > >> >> > > > >> > >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> >> > > > >> supported in an external driver for FreeBSD. > >> >> > > > >> > >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > >> >> > > > > > >> >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> >> > > > > have something that works in Linux too if possible. > >> >> > > > > >> >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> >> > > > I'm afraid I have little to no capability to test it myself and so I > >> >> > > > did not add it as well. > >> >> > > > > >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> >> > > > this space. > >> >> > > > >> >> > > Then maybe we should leave it aside until someone takes some time on > >> >> > > the A83t. > >> >> > > >> >> > Take some time on the Linux driver and do not apply this patch for > >> >> > now you mean ? > >> >> > >> >> Yep. > >> >> > >> >> Maxime > >> > > >> > Since linux doesn't have the compatible in it's driver what would > >> > be the harm to add the node in the DTS ? If a quirks is needed because > >> > some region is weird this would go in the driver right ? I don't see a > >> > technical problem for adding this node right now. > >> > If Kyle confirm the lenght of the region and that no quirk is needed > >> > will it be enough ? > >> > >> I guess I wasn't very clear. I'm OK with the patch going in. The device > >> node currently says nothing about how much efuse space there is. The > >> memory region covers that and the control section, and the size matches > >> what the memory map says. > >> > >> The size and offset of the efuse space would be dealt with in the driver. > > > > Let's merge it then. > > > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > What does the timeline for these things normally look like? I'm new to > these parts. =) We're one week away from the merge window, so it's a bit late for it to be merged in 4.16, but it'll be in 4.17. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-01-09 13:34 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2018-01-09 13:34 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: > On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > >> > On Fri, 22 Dec 2017 09:35:08 +0100 > >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> > > >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> >> > > >> >> > Hi Maxime, > >> >> > > >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> >> > > >> >> > > Hi, > >> >> > > > >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> >> > > > <maxime.ripard@free-electrons.com> wrote: > >> >> > > > > Hi Kyle, > >> >> > > > > > >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: > >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> >> > > > >> thermal calibration data, add node to describe it. > >> >> > > > >> > >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> >> > > > >> supported in an external driver for FreeBSD. > >> >> > > > >> > >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > >> >> > > > > > >> >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> >> > > > > have something that works in Linux too if possible. > >> >> > > > > >> >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> >> > > > I'm afraid I have little to no capability to test it myself and so I > >> >> > > > did not add it as well. > >> >> > > > > >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> >> > > > this space. > >> >> > > > >> >> > > Then maybe we should leave it aside until someone takes some time on > >> >> > > the A83t. > >> >> > > >> >> > Take some time on the Linux driver and do not apply this patch for > >> >> > now you mean ? > >> >> > >> >> Yep. > >> >> > >> >> Maxime > >> > > >> > Since linux doesn't have the compatible in it's driver what would > >> > be the harm to add the node in the DTS ? If a quirks is needed because > >> > some region is weird this would go in the driver right ? I don't see a > >> > technical problem for adding this node right now. > >> > If Kyle confirm the lenght of the region and that no quirk is needed > >> > will it be enough ? > >> > >> I guess I wasn't very clear. I'm OK with the patch going in. The device > >> node currently says nothing about how much efuse space there is. The > >> memory region covers that and the control section, and the size matches > >> what the memory map says. > >> > >> The size and offset of the efuse space would be dealt with in the driver. > > > > Let's merge it then. > > > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > What does the timeline for these things normally look like? I'm new to > these parts. =) We're one week away from the merge window, so it's a bit late for it to be merged in 4.16, but it'll be in 4.17. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180109/bd79f4be/attachment-0001.sig> ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-01-09 13:34 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2018-01-09 13:34 UTC (permalink / raw) To: Kyle Evans Cc: Chen-Yu Tsai, Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 3971 bytes --] On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: > On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org> wrote: > >> > On Fri, 22 Dec 2017 09:35:08 +0100 > >> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > >> > > >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> >> > > >> >> > Hi Maxime, > >> >> > > >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> >> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > >> >> > > >> >> > > Hi, > >> >> > > > >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> >> > > > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > >> >> > > > > Hi Kyle, > >> >> > > > > > >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: > >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> >> > > > >> thermal calibration data, add node to describe it. > >> >> > > > >> > >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> >> > > > >> supported in an external driver for FreeBSD. > >> >> > > > >> > >> >> > > > >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> > >> >> > > > > > >> >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> >> > > > > have something that works in Linux too if possible. > >> >> > > > > >> >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> >> > > > I'm afraid I have little to no capability to test it myself and so I > >> >> > > > did not add it as well. > >> >> > > > > >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> >> > > > this space. > >> >> > > > >> >> > > Then maybe we should leave it aside until someone takes some time on > >> >> > > the A83t. > >> >> > > >> >> > Take some time on the Linux driver and do not apply this patch for > >> >> > now you mean ? > >> >> > >> >> Yep. > >> >> > >> >> Maxime > >> > > >> > Since linux doesn't have the compatible in it's driver what would > >> > be the harm to add the node in the DTS ? If a quirks is needed because > >> > some region is weird this would go in the driver right ? I don't see a > >> > technical problem for adding this node right now. > >> > If Kyle confirm the lenght of the region and that no quirk is needed > >> > will it be enough ? > >> > >> I guess I wasn't very clear. I'm OK with the patch going in. The device > >> node currently says nothing about how much efuse space there is. The > >> memory region covers that and the control section, and the size matches > >> what the memory map says. > >> > >> The size and offset of the efuse space would be dealt with in the driver. > > > > Let's merge it then. > > > > Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > > What does the timeline for these things normally look like? I'm new to > these parts. =) We're one week away from the merge window, so it's a bit late for it to be merged in 4.16, but it'll be in 4.17. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t 2018-01-09 13:34 ` Maxime Ripard (?) @ 2018-01-09 13:55 ` Kyle Evans -1 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2018-01-09 13:55 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, linux-arm-kernel On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> >> > >> >> >> > Hi Maxime, >> >> >> > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> >> > >> >> >> > > Hi, >> >> >> > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> >> > > > <maxime.ripard@free-electrons.com> wrote: >> >> >> > > > > Hi Kyle, >> >> >> > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> >> > > > >> thermal calibration data, add node to describe it. >> >> >> > > > >> >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> >> > > > >> supported in an external driver for FreeBSD. >> >> >> > > > >> >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> >> >> > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> >> > > > > have something that works in Linux too if possible. >> >> >> > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> >> > > > did not add it as well. >> >> >> > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> >> > > > this space. >> >> >> > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> >> > > the A83t. >> >> >> > >> >> >> > Take some time on the Linux driver and do not apply this patch for >> >> >> > now you mean ? >> >> >> >> >> >> Yep. >> >> >> >> >> >> Maxime >> >> > >> >> > Since linux doesn't have the compatible in it's driver what would >> >> > be the harm to add the node in the DTS ? If a quirks is needed because >> >> > some region is weird this would go in the driver right ? I don't see a >> >> > technical problem for adding this node right now. >> >> > If Kyle confirm the lenght of the region and that no quirk is needed >> >> > will it be enough ? >> >> >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> >> node currently says nothing about how much efuse space there is. The >> >> memory region covers that and the control section, and the size matches >> >> what the memory map says. >> >> >> >> The size and offset of the efuse space would be dealt with in the driver. >> > >> > Let's merge it then. >> > >> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> >> >> What does the timeline for these things normally look like? I'm new to >> these parts. =) > > We're one week away from the merge window, so it's a bit late for it > to be merged in 4.16, but it'll be in 4.17. Ok, cool, that makes sense. Thanks! ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-01-09 13:55 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2018-01-09 13:55 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> >> > >> >> >> > Hi Maxime, >> >> >> > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> >> > >> >> >> > > Hi, >> >> >> > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> >> > > > <maxime.ripard@free-electrons.com> wrote: >> >> >> > > > > Hi Kyle, >> >> >> > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> >> > > > >> thermal calibration data, add node to describe it. >> >> >> > > > >> >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> >> > > > >> supported in an external driver for FreeBSD. >> >> >> > > > >> >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> >> >> > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> >> > > > > have something that works in Linux too if possible. >> >> >> > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> >> > > > did not add it as well. >> >> >> > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> >> > > > this space. >> >> >> > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> >> > > the A83t. >> >> >> > >> >> >> > Take some time on the Linux driver and do not apply this patch for >> >> >> > now you mean ? >> >> >> >> >> >> Yep. >> >> >> >> >> >> Maxime >> >> > >> >> > Since linux doesn't have the compatible in it's driver what would >> >> > be the harm to add the node in the DTS ? If a quirks is needed because >> >> > some region is weird this would go in the driver right ? I don't see a >> >> > technical problem for adding this node right now. >> >> > If Kyle confirm the lenght of the region and that no quirk is needed >> >> > will it be enough ? >> >> >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> >> node currently says nothing about how much efuse space there is. The >> >> memory region covers that and the control section, and the size matches >> >> what the memory map says. >> >> >> >> The size and offset of the efuse space would be dealt with in the driver. >> > >> > Let's merge it then. >> > >> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> >> >> What does the timeline for these things normally look like? I'm new to >> these parts. =) > > We're one week away from the merge window, so it's a bit late for it > to be merged in 4.16, but it'll be in 4.17. Ok, cool, that makes sense. Thanks! ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-01-09 13:55 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2018-01-09 13:55 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, linux-arm-kernel On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard >> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org> wrote: >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> >> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: >> >> > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> >> > >> >> >> > Hi Maxime, >> >> >> > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> >> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: >> >> >> > >> >> >> > > Hi, >> >> >> > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> >> > > > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: >> >> >> > > > > Hi Kyle, >> >> >> > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> >> > > > >> thermal calibration data, add node to describe it. >> >> >> > > > >> >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> >> > > > >> supported in an external driver for FreeBSD. >> >> >> > > > >> >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> >> >> >> > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> >> > > > > have something that works in Linux too if possible. >> >> >> > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> >> > > > did not add it as well. >> >> >> > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> >> > > > this space. >> >> >> > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> >> > > the A83t. >> >> >> > >> >> >> > Take some time on the Linux driver and do not apply this patch for >> >> >> > now you mean ? >> >> >> >> >> >> Yep. >> >> >> >> >> >> Maxime >> >> > >> >> > Since linux doesn't have the compatible in it's driver what would >> >> > be the harm to add the node in the DTS ? If a quirks is needed because >> >> > some region is weird this would go in the driver right ? I don't see a >> >> > technical problem for adding this node right now. >> >> > If Kyle confirm the lenght of the region and that no quirk is needed >> >> > will it be enough ? >> >> >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> >> node currently says nothing about how much efuse space there is. The >> >> memory region covers that and the control section, and the size matches >> >> what the memory map says. >> >> >> >> The size and offset of the efuse space would be dealt with in the driver. >> > >> > Let's merge it then. >> > >> > Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> >> >> What does the timeline for these things normally look like? I'm new to >> these parts. =) > > We're one week away from the merge window, so it's a bit late for it > to be merged in 4.16, but it'll be in 4.17. Ok, cool, that makes sense. Thanks! ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t 2018-01-09 13:34 ` Maxime Ripard (?) @ 2018-04-18 14:05 ` Kyle Evans -1 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2018-04-18 14:05 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, linux-arm-kernel On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> >> > >> >> >> > Hi Maxime, >> >> >> > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> >> > >> >> >> > > Hi, >> >> >> > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> >> > > > <maxime.ripard@free-electrons.com> wrote: >> >> >> > > > > Hi Kyle, >> >> >> > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> >> > > > >> thermal calibration data, add node to describe it. >> >> >> > > > >> >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> >> > > > >> supported in an external driver for FreeBSD. >> >> >> > > > >> >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> >> >> > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> >> > > > > have something that works in Linux too if possible. >> >> >> > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> >> > > > did not add it as well. >> >> >> > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> >> > > > this space. >> >> >> > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> >> > > the A83t. >> >> >> > >> >> >> > Take some time on the Linux driver and do not apply this patch for >> >> >> > now you mean ? >> >> >> >> >> >> Yep. >> >> >> >> >> >> Maxime >> >> > >> >> > Since linux doesn't have the compatible in it's driver what would >> >> > be the harm to add the node in the DTS ? If a quirks is needed because >> >> > some region is weird this would go in the driver right ? I don't see a >> >> > technical problem for adding this node right now. >> >> > If Kyle confirm the lenght of the region and that no quirk is needed >> >> > will it be enough ? >> >> >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> >> node currently says nothing about how much efuse space there is. The >> >> memory region covers that and the control section, and the size matches >> >> what the memory map says. >> >> >> >> The size and offset of the efuse space would be dealt with in the driver. >> > >> > Let's merge it then. >> > >> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> >> >> What does the timeline for these things normally look like? I'm new to >> these parts. =) > > We're one week away from the merge window, so it's a bit late for it > to be merged in 4.16, but it'll be in 4.17. > > Maxime > Hi, It's been two months and this still hasn't quite landed in sunxi/for-next. =( May I ask the status on this? Thanks, Kyle Evans ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-04-18 14:05 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2018-04-18 14:05 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> >> > >> >> >> > Hi Maxime, >> >> >> > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> >> > >> >> >> > > Hi, >> >> >> > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> >> > > > <maxime.ripard@free-electrons.com> wrote: >> >> >> > > > > Hi Kyle, >> >> >> > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> >> > > > >> thermal calibration data, add node to describe it. >> >> >> > > > >> >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> >> > > > >> supported in an external driver for FreeBSD. >> >> >> > > > >> >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> >> >> > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> >> > > > > have something that works in Linux too if possible. >> >> >> > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> >> > > > did not add it as well. >> >> >> > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> >> > > > this space. >> >> >> > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> >> > > the A83t. >> >> >> > >> >> >> > Take some time on the Linux driver and do not apply this patch for >> >> >> > now you mean ? >> >> >> >> >> >> Yep. >> >> >> >> >> >> Maxime >> >> > >> >> > Since linux doesn't have the compatible in it's driver what would >> >> > be the harm to add the node in the DTS ? If a quirks is needed because >> >> > some region is weird this would go in the driver right ? I don't see a >> >> > technical problem for adding this node right now. >> >> > If Kyle confirm the lenght of the region and that no quirk is needed >> >> > will it be enough ? >> >> >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> >> node currently says nothing about how much efuse space there is. The >> >> memory region covers that and the control section, and the size matches >> >> what the memory map says. >> >> >> >> The size and offset of the efuse space would be dealt with in the driver. >> > >> > Let's merge it then. >> > >> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> >> >> What does the timeline for these things normally look like? I'm new to >> these parts. =) > > We're one week away from the merge window, so it's a bit late for it > to be merged in 4.16, but it'll be in 4.17. > > Maxime > Hi, It's been two months and this still hasn't quite landed in sunxi/for-next. =( May I ask the status on this? Thanks, Kyle Evans ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-04-18 14:05 ` Kyle Evans 0 siblings, 0 replies; 50+ messages in thread From: Kyle Evans @ 2018-04-18 14:05 UTC (permalink / raw) To: Maxime Ripard Cc: Mark Rutland, devicetree, Emmanuel Vadot, linux-sunxi, linux-kernel, Russell King, Chen-Yu Tsai, Rob Herring, Srinivas Kandagatla, linux-arm-kernel On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> >> > >> >> >> > Hi Maxime, >> >> >> > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> >> > >> >> >> > > Hi, >> >> >> > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> >> > > > <maxime.ripard@free-electrons.com> wrote: >> >> >> > > > > Hi Kyle, >> >> >> > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> >> > > > >> thermal calibration data, add node to describe it. >> >> >> > > > >> >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> >> > > > >> supported in an external driver for FreeBSD. >> >> >> > > > >> >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> >> >> > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> >> > > > > have something that works in Linux too if possible. >> >> >> > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> >> > > > did not add it as well. >> >> >> > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> >> > > > this space. >> >> >> > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> >> > > the A83t. >> >> >> > >> >> >> > Take some time on the Linux driver and do not apply this patch for >> >> >> > now you mean ? >> >> >> >> >> >> Yep. >> >> >> >> >> >> Maxime >> >> > >> >> > Since linux doesn't have the compatible in it's driver what would >> >> > be the harm to add the node in the DTS ? If a quirks is needed because >> >> > some region is weird this would go in the driver right ? I don't see a >> >> > technical problem for adding this node right now. >> >> > If Kyle confirm the lenght of the region and that no quirk is needed >> >> > will it be enough ? >> >> >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> >> node currently says nothing about how much efuse space there is. The >> >> memory region covers that and the control section, and the size matches >> >> what the memory map says. >> >> >> >> The size and offset of the efuse space would be dealt with in the driver. >> > >> > Let's merge it then. >> > >> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> >> >> What does the timeline for these things normally look like? I'm new to >> these parts. =) > > We're one week away from the merge window, so it's a bit late for it > to be merged in 4.16, but it'll be in 4.17. > > Maxime > Hi, It's been two months and this still hasn't quite landed in sunxi/for-next. =( May I ask the status on this? Thanks, Kyle Evans ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-04-19 13:38 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2018-04-19 13:38 UTC (permalink / raw) To: Kyle Evans Cc: Chen-Yu Tsai, Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 4372 bytes --] On Wed, Apr 18, 2018 at 09:05:19AM -0500, Kyle Evans wrote: > On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: > >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard > >> <maxime.ripard@free-electrons.com> wrote: > >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 > >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> >> > > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> >> >> > > >> >> >> > Hi Maxime, > >> >> >> > > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> >> >> > > >> >> >> > > Hi, > >> >> >> > > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> >> >> > > > <maxime.ripard@free-electrons.com> wrote: > >> >> >> > > > > Hi Kyle, > >> >> >> > > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> >> >> > > > >> thermal calibration data, add node to describe it. > >> >> >> > > > >> > >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> >> >> > > > >> supported in an external driver for FreeBSD. > >> >> >> > > > >> > >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > >> >> >> > > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> >> >> > > > > have something that works in Linux too if possible. > >> >> >> > > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I > >> >> >> > > > did not add it as well. > >> >> >> > > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> >> >> > > > this space. > >> >> >> > > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on > >> >> >> > > the A83t. > >> >> >> > > >> >> >> > Take some time on the Linux driver and do not apply this patch for > >> >> >> > now you mean ? > >> >> >> > >> >> >> Yep. > >> >> >> > >> >> >> Maxime > >> >> > > >> >> > Since linux doesn't have the compatible in it's driver what would > >> >> > be the harm to add the node in the DTS ? If a quirks is needed because > >> >> > some region is weird this would go in the driver right ? I don't see a > >> >> > technical problem for adding this node right now. > >> >> > If Kyle confirm the lenght of the region and that no quirk is needed > >> >> > will it be enough ? > >> >> > >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device > >> >> node currently says nothing about how much efuse space there is. The > >> >> memory region covers that and the control section, and the size matches > >> >> what the memory map says. > >> >> > >> >> The size and offset of the efuse space would be dealt with in the driver. > >> > > >> > Let's merge it then. > >> > > >> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > >> > >> What does the timeline for these things normally look like? I'm new to > >> these parts. =) > > > > We're one week away from the merge window, so it's a bit late for it > > to be merged in 4.16, but it'll be in 4.17. > It's been two months and this still hasn't quite landed in > sunxi/for-next. =( May I ask the status on this? It seems to have fallen through the cracks, sorry :/ Can you resend it based on 4.17? Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-04-19 13:38 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2018-04-19 13:38 UTC (permalink / raw) To: linux-arm-kernel On Wed, Apr 18, 2018 at 09:05:19AM -0500, Kyle Evans wrote: > On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: > >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard > >> <maxime.ripard@free-electrons.com> wrote: > >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 > >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> >> > > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> >> >> > > >> >> >> > Hi Maxime, > >> >> >> > > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> >> >> > > >> >> >> > > Hi, > >> >> >> > > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> >> >> > > > <maxime.ripard@free-electrons.com> wrote: > >> >> >> > > > > Hi Kyle, > >> >> >> > > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote: > >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> >> >> > > > >> thermal calibration data, add node to describe it. > >> >> >> > > > >> > >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> >> >> > > > >> supported in an external driver for FreeBSD. > >> >> >> > > > >> > >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > >> >> >> > > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> >> >> > > > > have something that works in Linux too if possible. > >> >> >> > > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I > >> >> >> > > > did not add it as well. > >> >> >> > > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> >> >> > > > this space. > >> >> >> > > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on > >> >> >> > > the A83t. > >> >> >> > > >> >> >> > Take some time on the Linux driver and do not apply this patch for > >> >> >> > now you mean ? > >> >> >> > >> >> >> Yep. > >> >> >> > >> >> >> Maxime > >> >> > > >> >> > Since linux doesn't have the compatible in it's driver what would > >> >> > be the harm to add the node in the DTS ? If a quirks is needed because > >> >> > some region is weird this would go in the driver right ? I don't see a > >> >> > technical problem for adding this node right now. > >> >> > If Kyle confirm the lenght of the region and that no quirk is needed > >> >> > will it be enough ? > >> >> > >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device > >> >> node currently says nothing about how much efuse space there is. The > >> >> memory region covers that and the control section, and the size matches > >> >> what the memory map says. > >> >> > >> >> The size and offset of the efuse space would be dealt with in the driver. > >> > > >> > Let's merge it then. > >> > > >> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > >> > >> What does the timeline for these things normally look like? I'm new to > >> these parts. =) > > > > We're one week away from the merge window, so it's a bit late for it > > to be merged in 4.16, but it'll be in 4.17. > It's been two months and this still hasn't quite landed in > sunxi/for-next. =( May I ask the status on this? It seems to have fallen through the cracks, sorry :/ Can you resend it based on 4.17? Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180419/b1663c4f/attachment-0001.sig> ^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t @ 2018-04-19 13:38 ` Maxime Ripard 0 siblings, 0 replies; 50+ messages in thread From: Maxime Ripard @ 2018-04-19 13:38 UTC (permalink / raw) To: Kyle Evans Cc: Chen-Yu Tsai, Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel, Russell King, linux-sunxi, Rob Herring, Srinivas Kandagatla, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 4526 bytes --] On Wed, Apr 18, 2018 at 09:05:19AM -0500, Kyle Evans wrote: > On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: > >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard > >> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org> wrote: > >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 > >> >> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > >> >> > > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> >> >> > > >> >> >> > Hi Maxime, > >> >> >> > > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> >> >> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > >> >> >> > > >> >> >> > > Hi, > >> >> >> > > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> >> >> > > > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > >> >> >> > > > > Hi Kyle, > >> >> >> > > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote: > >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> >> >> > > > >> thermal calibration data, add node to describe it. > >> >> >> > > > >> > >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> >> >> > > > >> supported in an external driver for FreeBSD. > >> >> >> > > > >> > >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org> > >> >> >> > > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> >> >> > > > > have something that works in Linux too if possible. > >> >> >> > > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I > >> >> >> > > > did not add it as well. > >> >> >> > > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> >> >> > > > this space. > >> >> >> > > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on > >> >> >> > > the A83t. > >> >> >> > > >> >> >> > Take some time on the Linux driver and do not apply this patch for > >> >> >> > now you mean ? > >> >> >> > >> >> >> Yep. > >> >> >> > >> >> >> Maxime > >> >> > > >> >> > Since linux doesn't have the compatible in it's driver what would > >> >> > be the harm to add the node in the DTS ? If a quirks is needed because > >> >> > some region is weird this would go in the driver right ? I don't see a > >> >> > technical problem for adding this node right now. > >> >> > If Kyle confirm the lenght of the region and that no quirk is needed > >> >> > will it be enough ? > >> >> > >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device > >> >> node currently says nothing about how much efuse space there is. The > >> >> memory region covers that and the control section, and the size matches > >> >> what the memory map says. > >> >> > >> >> The size and offset of the efuse space would be dealt with in the driver. > >> > > >> > Let's merge it then. > >> > > >> > Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > >> > >> What does the timeline for these things normally look like? I'm new to > >> these parts. =) > > > > We're one week away from the merge window, so it's a bit late for it > > to be merged in 4.16, but it'll be in 4.17. > It's been two months and this still hasn't quite landed in > sunxi/for-next. =( May I ask the status on this? It seems to have fallen through the cracks, sorry :/ Can you resend it based on 4.17? Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 50+ messages in thread
end of thread, other threads:[~2018-04-19 13:38 UTC | newest] Thread overview: 50+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-19 21:05 [PATCH v2] ARM: dts: sunxi: Add sid for a83t kevans91 2017-12-19 21:05 ` kevans91 at ksu.edu 2017-12-19 21:05 ` kevans91-OYTqUY/oFF8 2017-12-20 21:45 ` Rob Herring 2017-12-20 21:45 ` Rob Herring 2017-12-20 21:45 ` Rob Herring 2017-12-21 14:55 ` Maxime Ripard 2017-12-21 14:55 ` Maxime Ripard 2017-12-21 14:55 ` Maxime Ripard 2017-12-21 15:07 ` Icenowy Zheng 2017-12-21 15:19 ` Kyle Evans 2017-12-21 15:19 ` Kyle Evans 2017-12-21 15:19 ` Kyle Evans 2017-12-21 15:26 ` Maxime Ripard 2017-12-21 15:26 ` Maxime Ripard 2017-12-21 15:26 ` Maxime Ripard 2017-12-21 15:30 ` Kyle Evans 2017-12-21 15:30 ` Kyle Evans 2017-12-21 15:30 ` Kyle Evans 2017-12-21 15:39 ` Chen-Yu Tsai 2017-12-21 15:39 ` Chen-Yu Tsai 2017-12-21 18:09 ` Emmanuel Vadot 2017-12-21 18:09 ` Emmanuel Vadot 2017-12-21 18:09 ` Emmanuel Vadot 2017-12-22 8:35 ` Maxime Ripard 2017-12-22 8:35 ` Maxime Ripard 2017-12-22 8:35 ` Maxime Ripard 2017-12-22 10:07 ` Emmanuel Vadot 2017-12-22 10:07 ` Emmanuel Vadot 2017-12-22 10:07 ` Emmanuel Vadot 2017-12-22 10:11 ` Chen-Yu Tsai 2017-12-22 10:11 ` Chen-Yu Tsai 2018-01-04 14:01 ` Maxime Ripard 2018-01-04 14:01 ` Maxime Ripard 2018-01-04 14:01 ` Maxime Ripard 2018-01-08 15:30 ` Kyle Evans 2018-01-08 15:30 ` Kyle Evans 2018-01-08 15:30 ` Kyle Evans 2018-01-09 13:34 ` Maxime Ripard 2018-01-09 13:34 ` Maxime Ripard 2018-01-09 13:34 ` Maxime Ripard 2018-01-09 13:55 ` Kyle Evans 2018-01-09 13:55 ` Kyle Evans 2018-01-09 13:55 ` Kyle Evans 2018-04-18 14:05 ` Kyle Evans 2018-04-18 14:05 ` Kyle Evans 2018-04-18 14:05 ` Kyle Evans 2018-04-19 13:38 ` Maxime Ripard 2018-04-19 13:38 ` Maxime Ripard 2018-04-19 13:38 ` Maxime Ripard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.