All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Lee Jones <lee.jones@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] backlight: tdo24m: add the reset line gpio
Date: Wed, 3 Jan 2018 09:49:53 +0000	[thread overview]
Message-ID: <20180103094953.dhlzmyz6c2mymv7v@oak.lan> (raw)
In-Reply-To: <874logbar8.fsf@belgarion.home>

On Sun, Dec 24, 2017 at 12:55:55PM +0100, Robert Jarzmik wrote:
> Robert Jarzmik <robert.jarzmik@free.fr> writes:
> 
> > Daniel Thompson <daniel.thompson@linaro.org> writes:
> >
> >> On Fri, Oct 13, 2017 at 09:42:48PM +0200, Robert Jarzmik wrote:
> >> Also, this adds a new optional property, doesn't the devicetree binding 
> >> docs need to be update to match this?
> > Ah yes, that too. I'll add it for v3.
> Actually I won't ... because there is no description for tdo24m I could find.
> 
> If that's a problem for you, I'll drop that patch as well.

I think I'm ok to drop this, if only because based on current upstream 
state I think this code will never be given a reset line anyway (or is
there a partner patch for mach-pxa that hasn't been posted yet).


Daniel.

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Lee Jones <lee.jones@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] backlight: tdo24m: add the reset line gpio
Date: Wed, 03 Jan 2018 09:49:53 +0000	[thread overview]
Message-ID: <20180103094953.dhlzmyz6c2mymv7v@oak.lan> (raw)
In-Reply-To: <874logbar8.fsf@belgarion.home>

On Sun, Dec 24, 2017 at 12:55:55PM +0100, Robert Jarzmik wrote:
> Robert Jarzmik <robert.jarzmik@free.fr> writes:
> 
> > Daniel Thompson <daniel.thompson@linaro.org> writes:
> >
> >> On Fri, Oct 13, 2017 at 09:42:48PM +0200, Robert Jarzmik wrote:
> >> Also, this adds a new optional property, doesn't the devicetree binding 
> >> docs need to be update to match this?
> > Ah yes, that too. I'll add it for v3.
> Actually I won't ... because there is no description for tdo24m I could find.
> 
> If that's a problem for you, I'll drop that patch as well.

I think I'm ok to drop this, if only because based on current upstream 
state I think this code will never be given a reset line anyway (or is
there a partner patch for mach-pxa that hasn't been posted yet).


Daniel.

  reply	other threads:[~2018-01-03  9:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13 19:42 [PATCH v2 1/3] backlight: tdo24m: fix the spi cs between transfers Robert Jarzmik
2017-10-13 19:42 ` Robert Jarzmik
2017-10-13 19:42 ` [PATCH v2 2/3] backlight: tdo24m: add the reset line gpio Robert Jarzmik
2017-10-13 19:42   ` Robert Jarzmik
2017-12-15 11:53   ` Daniel Thompson
2017-12-15 11:53     ` Daniel Thompson
2017-12-16 11:39     ` Robert Jarzmik
2017-12-16 11:39       ` Robert Jarzmik
2017-12-17 20:57       ` Daniel Thompson
2017-12-24 11:55       ` Robert Jarzmik
2017-12-24 11:55         ` Robert Jarzmik
2018-01-03  9:49         ` Daniel Thompson [this message]
2018-01-03  9:49           ` Daniel Thompson
2017-10-13 19:42 ` [PATCH v2 3/3] backlight: tdo24m: add model and status sysfs entries Robert Jarzmik
2017-10-13 19:42   ` Robert Jarzmik
2017-12-15 14:32   ` Daniel Thompson
2017-12-15 14:32     ` Daniel Thompson
2017-12-16 11:40     ` Robert Jarzmik
2017-12-16 11:40       ` Robert Jarzmik
2017-12-14 20:03 ` [PATCH v2 1/3] backlight: tdo24m: fix the spi cs between transfers Robert Jarzmik
2017-12-14 20:03   ` Robert Jarzmik
2017-12-15 11:56   ` Daniel Thompson
2017-12-15 11:40 ` Daniel Thompson
2017-12-16 11:45   ` Robert Jarzmik
2017-12-16 11:45     ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180103094953.dhlzmyz6c2mymv7v@oak.lan \
    --to=daniel.thompson@linaro.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.