From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] backlight: tdo24m: add model and status sysfs entries
Date: Sat, 16 Dec 2017 12:40:55 +0100 [thread overview]
Message-ID: <87o9myew8o.fsf@belgarion.home> (raw)
In-Reply-To: <20171215143200.sm22mkifqlskjddf@oak.lan> (Daniel Thompson's message of "Fri, 15 Dec 2017 14:32:00 +0000")
Daniel Thompson <daniel.thompson@linaro.org> writes:
> On Fri, Oct 13, 2017 at 09:42:49PM +0200, Robert Jarzmik wrote:
>> Add entries to query the panel ASIC to acquire the model number and the
>> status field. This comes in handy to check that the SPI connection is
>> functional and that the panel's firmware is alive.
>>
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> This feels to me somewhat like debug information being pushed into sysfs.
> There are very few backlight drivers that add additional sysfs attributes
> meaning the extra info here is not commonly pushed into the ABI for a
> backlight and knowing the info in these properties does not really
> help userspace to *use* the hardware.
>
> Does this kind of thing really belong in sysfs?
Ok, as you wish. Let's drop this patch from the serie for now.
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] backlight: tdo24m: add model and status sysfs entries
Date: Sat, 16 Dec 2017 11:40:55 +0000 [thread overview]
Message-ID: <87o9myew8o.fsf@belgarion.home> (raw)
In-Reply-To: <20171215143200.sm22mkifqlskjddf@oak.lan> (Daniel Thompson's message of "Fri, 15 Dec 2017 14:32:00 +0000")
Daniel Thompson <daniel.thompson@linaro.org> writes:
> On Fri, Oct 13, 2017 at 09:42:49PM +0200, Robert Jarzmik wrote:
>> Add entries to query the panel ASIC to acquire the model number and the
>> status field. This comes in handy to check that the SPI connection is
>> functional and that the panel's firmware is alive.
>>
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> This feels to me somewhat like debug information being pushed into sysfs.
> There are very few backlight drivers that add additional sysfs attributes
> meaning the extra info here is not commonly pushed into the ABI for a
> backlight and knowing the info in these properties does not really
> help userspace to *use* the hardware.
>
> Does this kind of thing really belong in sysfs?
Ok, as you wish. Let's drop this patch from the serie for now.
Cheers.
--
Robert
next prev parent reply other threads:[~2017-12-16 11:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 19:42 [PATCH v2 1/3] backlight: tdo24m: fix the spi cs between transfers Robert Jarzmik
2017-10-13 19:42 ` Robert Jarzmik
2017-10-13 19:42 ` [PATCH v2 2/3] backlight: tdo24m: add the reset line gpio Robert Jarzmik
2017-10-13 19:42 ` Robert Jarzmik
2017-12-15 11:53 ` Daniel Thompson
2017-12-15 11:53 ` Daniel Thompson
2017-12-16 11:39 ` Robert Jarzmik
2017-12-16 11:39 ` Robert Jarzmik
2017-12-17 20:57 ` Daniel Thompson
2017-12-24 11:55 ` Robert Jarzmik
2017-12-24 11:55 ` Robert Jarzmik
2018-01-03 9:49 ` Daniel Thompson
2018-01-03 9:49 ` Daniel Thompson
2017-10-13 19:42 ` [PATCH v2 3/3] backlight: tdo24m: add model and status sysfs entries Robert Jarzmik
2017-10-13 19:42 ` Robert Jarzmik
2017-12-15 14:32 ` Daniel Thompson
2017-12-15 14:32 ` Daniel Thompson
2017-12-16 11:40 ` Robert Jarzmik [this message]
2017-12-16 11:40 ` Robert Jarzmik
2017-12-14 20:03 ` [PATCH v2 1/3] backlight: tdo24m: fix the spi cs between transfers Robert Jarzmik
2017-12-14 20:03 ` Robert Jarzmik
2017-12-15 11:56 ` Daniel Thompson
2017-12-15 11:40 ` Daniel Thompson
2017-12-16 11:45 ` Robert Jarzmik
2017-12-16 11:45 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9myew8o.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.