* Build failure in -next due to 'xdp: generic XDP handling of xdp_rxq_info'
@ 2018-01-09 19:01 Guenter Roeck
2018-01-09 22:37 ` Jesper Dangaard Brouer
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2018-01-09 19:01 UTC (permalink / raw)
To: Jesper Dangaard Brouer
Cc: Alexei Starovoitov, David S. Miller, netdev, linux-kernel
Hi,
commit e817f85652c ("xdp: generic XDP handling of xdp_rxq_info") results in
the following error when building m68k:m5208evb_defconfig in -next.
net/core/dev.c: In function 'netif_get_rxqueue':
net/core/dev.c:3926:15: error: 'struct net_device' has no member named '_rx'
net/core/dev.c:3931:28: error:
'struct net_device' has no member named 'real_num_rx_queues'
net/core/dev.c: In function 'netif_alloc_rx_queues':
net/core/dev.c:7633:29: error:
'struct net_device' has no member named 'num_rx_queues'
[ and so on ]
Reverting the commit fixes the problem. Bisect log is attached.
Guenter
---
# bad: [06d41862286aa7bc634a1dd9e6e7e96f925ef30a] Add linux-next specific files for 20180109
# good: [b2cd1df66037e7c4697c7e40496bf7e4a5e16a2d] Linux 4.15-rc7
git bisect start 'HEAD' 'v4.15-rc7'
# bad: [9da4bdd3a63316ea34855132136f33c5b028a345] Merge remote-tracking branch 'crypto/master'
git bisect bad 9da4bdd3a63316ea34855132136f33c5b028a345
# good: [4367c00fe4237e51bbd365d89afca092de188906] Merge remote-tracking branch 'i2c/i2c/for-next'
git bisect good 4367c00fe4237e51bbd365d89afca092de188906
# bad: [f998b6b10144cd9809da6af02758615f789e8aa1] netfilter: ipset: Missing nfnl_lock()/nfnl_unlock() is added to ip_set_net_exit()
git bisect bad f998b6b10144cd9809da6af02758615f789e8aa1
# good: [918341e063028080bcd73d33540f77d9c1d20602] cxgb4: Report tid start range correctly for T6
git bisect good 918341e063028080bcd73d33540f77d9c1d20602
# good: [4f83435ad777358d9cdc138868feebbe2a23f577] nfp: bpf: allocate vNIC priv for keeping track of the offloaded program
git bisect good 4f83435ad777358d9cdc138868feebbe2a23f577
# good: [8a4816cad00bf14642f0ed6043b32d29a05006ce] tg3: Add Macronix NVRAM support
git bisect good 8a4816cad00bf14642f0ed6043b32d29a05006ce
# bad: [7f0b800048b562d716372466ea8d9de648c422dd] Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
git bisect bad 7f0b800048b562d716372466ea8d9de648c422dd
# good: [c90ecbfaf50d2d7db25c531d9169be7e47435f3f] rds: Use atomic flag to track connections being destroyed
git bisect good c90ecbfaf50d2d7db25c531d9169be7e47435f3f
# good: [0ddf543226acacfb9f521dafc6c817d5b04c7b1f] xdp/mlx5: setup xdp_rxq_info
git bisect good 0ddf543226acacfb9f521dafc6c817d5b04c7b1f
# bad: [e817f85652c14d78f170b18797e4c477c78949e0] xdp: generic XDP handling of xdp_rxq_info
git bisect bad e817f85652c14d78f170b18797e4c477c78949e0
# good: [96a8604f95fa216b9ddfd15c687eed42a2f56901] bnxt_en: setup xdp_rxq_info
git bisect good 96a8604f95fa216b9ddfd15c687eed42a2f56901
# good: [27e95e3648910c81a0840aa10dde77323795519e] thunderx: setup xdp_rxq_info
git bisect good 27e95e3648910c81a0840aa10dde77323795519e
# good: [754b8a21a96d5f11712245aef907149606b323ae] virtio_net: setup xdp_rxq_info
git bisect good 754b8a21a96d5f11712245aef907149606b323ae
# first bad commit: [e817f85652c14d78f170b18797e4c477c78949e0] xdp: generic XDP handling of xdp_rxq_info
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Build failure in -next due to 'xdp: generic XDP handling of xdp_rxq_info'
2018-01-09 19:01 Build failure in -next due to 'xdp: generic XDP handling of xdp_rxq_info' Guenter Roeck
@ 2018-01-09 22:37 ` Jesper Dangaard Brouer
2018-01-09 22:42 ` [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set Jesper Dangaard Brouer
0 siblings, 1 reply; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2018-01-09 22:37 UTC (permalink / raw)
To: Guenter Roeck
Cc: Alexei Starovoitov, David S. Miller, netdev, linux-kernel, brouer
On Tue, 9 Jan 2018 11:01:47 -0800
Guenter Roeck <linux@roeck-us.net> wrote:
> Hi,
>
> commit e817f85652c ("xdp: generic XDP handling of xdp_rxq_info") results in
> the following error when building m68k:m5208evb_defconfig in -next.
>
> net/core/dev.c: In function 'netif_get_rxqueue':
> net/core/dev.c:3926:15: error: 'struct net_device' has no member named '_rx'
> net/core/dev.c:3931:28: error:
> 'struct net_device' has no member named 'real_num_rx_queues'
>
> net/core/dev.c: In function 'netif_alloc_rx_queues':
> net/core/dev.c:7633:29: error:
> 'struct net_device' has no member named 'num_rx_queues'
>
> [ and so on ]
Hi Guenter,
This is caused by CONFIG_SYSFS is not set in your config. I'm
preparing a patch... can I ask you to test it, as I have a hard time
disabling on my X86_64 system.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 5+ messages in thread
* [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set
2018-01-09 22:37 ` Jesper Dangaard Brouer
@ 2018-01-09 22:42 ` Jesper Dangaard Brouer
2018-01-09 22:57 ` Guenter Roeck
2018-01-10 20:41 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2018-01-09 22:42 UTC (permalink / raw)
To: netdev, Jesper Dangaard Brouer
Cc: Daniel Borkmann, linux-kernel, linux, Alexei Starovoitov
The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to
remove the corresponding ifdef's in include/linux/netdevice.h.
Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
include/linux/netdevice.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 440b000f07f4..b308793c64ce 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1805,12 +1805,9 @@ struct net_device {
/* Interface address info used in eth_type_trans() */
unsigned char *dev_addr;
-#ifdef CONFIG_SYSFS
struct netdev_rx_queue *_rx;
-
unsigned int num_rx_queues;
unsigned int real_num_rx_queues;
-#endif
struct bpf_prog __rcu *xdp_prog;
unsigned long gro_flush_timeout;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set
2018-01-09 22:42 ` [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set Jesper Dangaard Brouer
@ 2018-01-09 22:57 ` Guenter Roeck
2018-01-10 20:41 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2018-01-09 22:57 UTC (permalink / raw)
To: Jesper Dangaard Brouer
Cc: netdev, Daniel Borkmann, linux-kernel, Alexei Starovoitov
On Tue, Jan 09, 2018 at 11:42:34PM +0100, Jesper Dangaard Brouer wrote:
> The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to
> remove the corresponding ifdef's in include/linux/netdevice.h.
>
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> include/linux/netdevice.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 440b000f07f4..b308793c64ce 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1805,12 +1805,9 @@ struct net_device {
> /* Interface address info used in eth_type_trans() */
> unsigned char *dev_addr;
>
> -#ifdef CONFIG_SYSFS
> struct netdev_rx_queue *_rx;
> -
> unsigned int num_rx_queues;
> unsigned int real_num_rx_queues;
> -#endif
>
> struct bpf_prog __rcu *xdp_prog;
> unsigned long gro_flush_timeout;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set
2018-01-09 22:42 ` [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set Jesper Dangaard Brouer
2018-01-09 22:57 ` Guenter Roeck
@ 2018-01-10 20:41 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2018-01-10 20:41 UTC (permalink / raw)
To: brouer; +Cc: netdev, borkmann, linux-kernel, linux, alexei.starovoitov
From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Tue, 09 Jan 2018 23:42:34 +0100
> The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to
> remove the corresponding ifdef's in include/linux/netdevice.h.
>
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-10 20:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-09 19:01 Build failure in -next due to 'xdp: generic XDP handling of xdp_rxq_info' Guenter Roeck
2018-01-09 22:37 ` Jesper Dangaard Brouer
2018-01-09 22:42 ` [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set Jesper Dangaard Brouer
2018-01-09 22:57 ` Guenter Roeck
2018-01-10 20:41 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.