From: Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> To: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org> Cc: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>, Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>, Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v5 00/16] OMAP2+ OneNAND driver update Date: Thu, 11 Jan 2018 20:38:56 +0100 [thread overview] Message-ID: <20180111193856.GA32512@lenoch> (raw) In-Reply-To: <20180111192931.vwnpvj2wtgrvkhbe-4/PLUo9XfK9owWHViPbQSXlKr5M7+etX9Sl0XMgJPXI@public.gmane.org> On Thu, Jan 11, 2018 at 09:29:31PM +0200, Aaro Koskinen wrote: > Hi, > > On Wed, Jan 10, 2018 at 10:13:25PM +0100, Ladislav Michl wrote: > > On Wed, Jan 10, 2018 at 07:35:19PM +0200, Aaro Koskinen wrote: > > > On Wed, Jan 10, 2018 at 10:20:58AM +0100, Ladislav Michl wrote: > > > > On Tue, Jan 09, 2018 at 11:01:14PM +0200, Aaro Koskinen wrote: > > > > > On Tue, Jan 09, 2018 at 02:08:12PM +0100, Ladislav Michl wrote: > > > > > > Merge window is really close now and patches seems still to be untested on > > > > > > n8x0. So unless someone is going to test it soon, I'll pick used N800 on > > > > > > ebay :-/ > > > > > > > > > > Today I tried to test them on Nokia N810, and I get: > > > > > > > > > > [ 0.174804] omap-gpmc 6800a000.gpmc: GPMC revision 2.0 > > > > > [ 0.174865] gpmc_mem_init: disabling cs 0 mapped at 0x0-0x1000000 > > > > > [ 0.177459] omap-gpmc 6800a000.gpmc: /ocp/gpmc@6800a000/onenand@0,0 has no 'bank-width' property > > > > > [ 0.177612] omap-gpmc 6800a000.gpmc: failed to probe DT child 'onenand': -22 > > > > > > > > > > With plain v4.15-rc7+ it probes fine. > > > > > > > > Thank you for testing. As stated in cover letter, you need also > > > > https://patchwork.kernel.org/patch/10043259/ > > > > which can be also found in Roger's branch > > > > https://github.com/rogerq/linux/commits/for-v4.16/gpmc-omap-immutable > > > > (see previous replies in this thread and also discussion about OneNAND > > > > DT node) > > > > > > I applied it, and now get: > > > > > > [ 0.174987] omap-gpmc 6800a000.gpmc: GPMC revision 2.0 > > > [ 0.175048] gpmc_mem_init: disabling cs 0 mapped at 0x0-0x1000000 > > > [ 0.177703] omap-gpmc 6800a000.gpmc: Incompatible OneNAND node: missing compatible > > > [ 0.177764] omap-gpmc 6800a000.gpmc: failed to probe DT child 'onenand': -22 > > > > As expected without reading discussion about OneNAND DT node :) > > > > In short, this version expects "ti,omap2-onenand" compatible. > > Right. I didn't realize by bootloader was passing the DTB from an old > kernel. > > So after fixing my boot I got the patches working N800 and N810: I was > able to read and write on old JFFS2 file systems without any issues. So > you can add for the series: > > Tested-by: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org> Thank you! > > In earlier version of this patchset there was fixup present, so driver > > worked even without compatible. Later on (17 Oct 2017 11:46:51 +0300) > > Roger objected (https://www.spinics.net/lists/linux-omap/msg139576.html): > > "I don't want to fixup broken DTs like this as they will go silently without > > being fixed. Let's instead just error out after the dev_warn(). This will > > force us to fix all DT nodes." > > So fixup was removed. I know N900 support is under heavy development > > in mainline, but if n8x0 is considered finished and stable, we should > > reintroduce fixup. Thoughts? > > N8x0 support is also "under development", and we are fine with updating > and always using latest in-tree DTs. That makes things simpler :) I'll post v6 based on -next with patches 13 and 14 squashed. Thanks to everyone involved for cooperation, ladis -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ladislav Michl <ladis@linux-mips.org> To: Aaro Koskinen <aaro.koskinen@iki.fi> Cc: Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, Peter Ujfalusi <peter.ujfalusi@ti.com>, Kyungmin Park <kyungmin.park@samsung.com>, Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org Subject: Re: [PATCH v5 00/16] OMAP2+ OneNAND driver update Date: Thu, 11 Jan 2018 20:38:56 +0100 [thread overview] Message-ID: <20180111193856.GA32512@lenoch> (raw) In-Reply-To: <20180111192931.vwnpvj2wtgrvkhbe@darkstar.musicnaut.iki.fi> On Thu, Jan 11, 2018 at 09:29:31PM +0200, Aaro Koskinen wrote: > Hi, > > On Wed, Jan 10, 2018 at 10:13:25PM +0100, Ladislav Michl wrote: > > On Wed, Jan 10, 2018 at 07:35:19PM +0200, Aaro Koskinen wrote: > > > On Wed, Jan 10, 2018 at 10:20:58AM +0100, Ladislav Michl wrote: > > > > On Tue, Jan 09, 2018 at 11:01:14PM +0200, Aaro Koskinen wrote: > > > > > On Tue, Jan 09, 2018 at 02:08:12PM +0100, Ladislav Michl wrote: > > > > > > Merge window is really close now and patches seems still to be untested on > > > > > > n8x0. So unless someone is going to test it soon, I'll pick used N800 on > > > > > > ebay :-/ > > > > > > > > > > Today I tried to test them on Nokia N810, and I get: > > > > > > > > > > [ 0.174804] omap-gpmc 6800a000.gpmc: GPMC revision 2.0 > > > > > [ 0.174865] gpmc_mem_init: disabling cs 0 mapped at 0x0-0x1000000 > > > > > [ 0.177459] omap-gpmc 6800a000.gpmc: /ocp/gpmc@6800a000/onenand@0,0 has no 'bank-width' property > > > > > [ 0.177612] omap-gpmc 6800a000.gpmc: failed to probe DT child 'onenand': -22 > > > > > > > > > > With plain v4.15-rc7+ it probes fine. > > > > > > > > Thank you for testing. As stated in cover letter, you need also > > > > https://patchwork.kernel.org/patch/10043259/ > > > > which can be also found in Roger's branch > > > > https://github.com/rogerq/linux/commits/for-v4.16/gpmc-omap-immutable > > > > (see previous replies in this thread and also discussion about OneNAND > > > > DT node) > > > > > > I applied it, and now get: > > > > > > [ 0.174987] omap-gpmc 6800a000.gpmc: GPMC revision 2.0 > > > [ 0.175048] gpmc_mem_init: disabling cs 0 mapped at 0x0-0x1000000 > > > [ 0.177703] omap-gpmc 6800a000.gpmc: Incompatible OneNAND node: missing compatible > > > [ 0.177764] omap-gpmc 6800a000.gpmc: failed to probe DT child 'onenand': -22 > > > > As expected without reading discussion about OneNAND DT node :) > > > > In short, this version expects "ti,omap2-onenand" compatible. > > Right. I didn't realize by bootloader was passing the DTB from an old > kernel. > > So after fixing my boot I got the patches working N800 and N810: I was > able to read and write on old JFFS2 file systems without any issues. So > you can add for the series: > > Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi> Thank you! > > In earlier version of this patchset there was fixup present, so driver > > worked even without compatible. Later on (17 Oct 2017 11:46:51 +0300) > > Roger objected (https://www.spinics.net/lists/linux-omap/msg139576.html): > > "I don't want to fixup broken DTs like this as they will go silently without > > being fixed. Let's instead just error out after the dev_warn(). This will > > force us to fix all DT nodes." > > So fixup was removed. I know N900 support is under heavy development > > in mainline, but if n8x0 is considered finished and stable, we should > > reintroduce fixup. Thoughts? > > N8x0 support is also "under development", and we are fine with updating > and always using latest in-tree DTs. That makes things simpler :) I'll post v6 based on -next with patches 13 and 14 squashed. Thanks to everyone involved for cooperation, ladis
next prev parent reply other threads:[~2018-01-11 19:38 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-15 16:23 [PATCH v5 00/16] OMAP2+ OneNAND driver update Ladislav Michl 2017-11-15 16:23 ` Ladislav Michl 2017-11-15 16:24 ` [PATCH v5 01/16] dt-bindings: mtd: gpmc-onenand: Update properties description Ladislav Michl 2017-11-15 16:24 ` Ladislav Michl 2017-11-30 10:25 ` Boris Brezillon 2017-11-30 10:25 ` Boris Brezillon 2017-11-30 13:09 ` Ladislav Michl 2017-11-30 13:09 ` Ladislav Michl 2017-12-15 10:18 ` Roger Quadros 2017-12-15 10:18 ` Roger Quadros [not found] ` <23d7ad3c-e6cd-3ba6-269a-1788371d13c3-l0cyMroinI0@public.gmane.org> 2017-12-15 12:24 ` Ladislav Michl 2017-12-15 12:24 ` Ladislav Michl 2017-11-15 16:26 ` [PATCH v5 02/16] ARM: dts: OMAP2+: Add compatible property to onenand node Ladislav Michl 2017-11-15 16:26 ` Ladislav Michl 2017-11-15 16:26 ` [PATCH v5 03/16] ARM: dts: omap3-igep: Update onenand node timings Ladislav Michl 2017-11-15 16:26 ` Ladislav Michl 2017-11-15 16:27 ` [PATCH v5 04/16] mtd: onenand: omap2: Remove regulator support Ladislav Michl 2017-11-15 16:27 ` Ladislav Michl 2017-11-15 16:28 ` [PATCH v5 05/16] mtd: onenand: omap2: Remove skip initial unlocking support Ladislav Michl 2017-11-15 16:28 ` Ladislav Michl 2017-11-15 16:29 ` [PATCH v5 06/16] mtd: onenand: omap2: Remove partitioning support from platform data Ladislav Michl 2017-11-15 16:29 ` Ladislav Michl 2017-11-15 16:30 ` [PATCH v5 07/16] mtd: onenand: omap2: Account waiting time as waiting on IO Ladislav Michl 2017-11-15 16:30 ` Ladislav Michl 2017-11-15 16:31 ` [PATCH v5 08/16] mtd: onenand: omap2: Simplify the DMA setup for various paths Ladislav Michl 2017-11-15 16:31 ` Ladislav Michl 2017-11-15 16:32 ` [PATCH v5 09/16] mtd: onenand: omap2: Unify OMAP2 and OMAP3 DMA implementation Ladislav Michl 2017-11-15 16:32 ` Ladislav Michl 2017-11-15 16:33 ` [PATCH v5 10/16] mtd: onenand: omap2: Convert to use dmaengine for memcpy Ladislav Michl 2017-11-15 16:33 ` Ladislav Michl 2017-11-15 16:34 ` [PATCH v5 11/16] mtd: onenand: omap2: Do not make delay for GPIO OMAP3 specific Ladislav Michl 2017-11-15 16:34 ` Ladislav Michl 2017-11-15 16:35 ` [PATCH v5 12/16] mtd: onenand: omap2: Decouple DMA enabling from INT pin availability Ladislav Michl 2017-11-15 16:35 ` Ladislav Michl 2017-11-15 16:36 ` [PATCH v5 13/16] memory: omap-gpmc: Refactor OneNAND support Ladislav Michl 2017-11-15 16:36 ` Ladislav Michl 2017-11-15 16:37 ` [PATCH v5 14/16] mtd: onenand: omap2: Configure driver from DT Ladislav Michl 2017-11-15 16:37 ` Ladislav Michl 2017-11-15 16:38 ` [PATCH v5 15/16] ARM: OMAP2+: Remove gpmc-onenand Ladislav Michl 2017-11-15 16:38 ` Ladislav Michl 2017-11-15 16:38 ` [PATCH v5 16/16] ARM: dts: Nokia: Use OneNAND INT pin Ladislav Michl 2017-11-15 16:38 ` Ladislav Michl 2017-11-30 10:18 ` [PATCH v5 00/16] OMAP2+ OneNAND driver update Boris Brezillon 2017-11-30 10:18 ` Boris Brezillon 2017-11-30 13:13 ` Ladislav Michl 2017-11-30 13:13 ` Ladislav Michl 2017-11-30 16:09 ` Tony Lindgren 2017-11-30 16:09 ` Tony Lindgren 2017-12-01 13:43 ` Roger Quadros 2017-12-01 13:43 ` Roger Quadros 2018-01-09 13:08 ` Ladislav Michl 2018-01-09 13:08 ` Ladislav Michl 2018-01-09 21:01 ` Aaro Koskinen 2018-01-09 21:01 ` Aaro Koskinen 2018-01-10 9:20 ` Ladislav Michl 2018-01-10 9:20 ` Ladislav Michl 2018-01-10 17:35 ` Aaro Koskinen 2018-01-10 17:35 ` Aaro Koskinen [not found] ` <20180110173519.xyug4egltni4f3qi-4/PLUo9XfK9owWHViPbQSXlKr5M7+etX9Sl0XMgJPXI@public.gmane.org> 2018-01-10 21:13 ` Ladislav Michl 2018-01-10 21:13 ` Ladislav Michl 2018-01-11 19:29 ` Aaro Koskinen 2018-01-11 19:29 ` Aaro Koskinen [not found] ` <20180111192931.vwnpvj2wtgrvkhbe-4/PLUo9XfK9owWHViPbQSXlKr5M7+etX9Sl0XMgJPXI@public.gmane.org> 2018-01-11 19:38 ` Ladislav Michl [this message] 2018-01-11 19:38 ` Ladislav Michl 2018-01-10 21:27 ` Aaro Koskinen 2018-01-10 21:27 ` Aaro Koskinen 2018-01-11 8:08 ` Roger Quadros 2018-01-11 8:08 ` Roger Quadros
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180111193856.GA32512@lenoch \ --to=ladis-6z/3iimg2c8g8few9mqtra@public.gmane.org \ --cc=aaro.koskinen-X3B1VOXEql0@public.gmane.org \ --cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \ --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=peter.ujfalusi-l0cyMroinI0@public.gmane.org \ --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=rogerq-l0cyMroinI0@public.gmane.org \ --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.