All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fabian Huegel <fabian_huegel@web.de>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	James Simmons <jsimmons@infradead.org>,
	Lai Siyao <lai.siyao@intel.com>,
	"John L . Hammond" <john.hammond@intel.com>,
	devel@driverdev.osuosl.org, Ben Evans <bevans@cray.com>,
	NeilBrown <neilb@suse.com>,
	Christoph Volkert <linux@christoph-volkert.de>,
	linux-kernel@i4.cs.fau.de, linux-kernel@vger.kernel.org,
	lustre-devel@lists.lustre.org
Subject: Re: [PATCH 1/8] staging: lustre: Enclose complex macros in parentheses
Date: Mon, 15 Jan 2018 16:00:28 +0100	[thread overview]
Message-ID: <20180115150028.GA10946@kroah.com> (raw)
In-Reply-To: <1515691022-22729-2-git-send-email-fabian_huegel@web.de>

On Thu, Jan 11, 2018 at 06:16:55PM +0100, Fabian Huegel wrote:
> Checkpatch wants complex macros to be enclosed in parentheses, so we
> put parentheses around these four macros.
> 
> Signed-off-by: Fabian Huegel <fabian_huegel@web.de>
> Signed-off-by: Christoph Volkert <linux@christoph-volkert.de>
> ---
>  drivers/staging/lustre/lustre/include/obd_class.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h
> index 67c535c..5c8cf30 100644
> --- a/drivers/staging/lustre/lustre/include/obd_class.h
> +++ b/drivers/staging/lustre/lustre/include/obd_class.h
> @@ -294,10 +294,10 @@ struct obdo;
>  
>  void obdo_to_ioobj(const struct obdo *oa, struct obd_ioobj *ioobj);
>  
> -#define OBT(dev)	(dev)->obd_type
> -#define OBP(dev, op)    (dev)->obd_type->typ_dt_ops->op
> -#define MDP(dev, op)    (dev)->obd_type->typ_md_ops->op
> -#define CTXTP(ctxt, op) (ctxt)->loc_logops->lop_##op
> +#define OBT(dev)	((dev)->obd_type)
> +#define OBP(dev, op)    ((dev)->obd_type->typ_dt_ops->op)
> +#define MDP(dev, op)    ((dev)->obd_type->typ_md_ops->op)
> +#define CTXTP(ctxt, op) ((ctxt)->loc_logops->lop_##op)

That really doesn't make any sense, as this can only be a variable in
here, not any "complex expression".  Sometimes checkpatch.pl isn't very
smart.

Also, these macros are horridly named, odds are they are not even
needed...

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fabian Huegel <fabian_huegel@web.de>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	James Simmons <jsimmons@infradead.org>,
	Lai Siyao <lai.siyao@intel.com>,
	"John L . Hammond" <john.hammond@intel.com>,
	devel@driverdev.osuosl.org, Ben Evans <bevans@cray.com>,
	NeilBrown <neilb@suse.com>,
	Christoph Volkert <linux@christoph-volkert.de>,
	linux-kernel@i4.cs.fau.de, linux-kernel@vger.kernel.org,
	lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 1/8] staging: lustre: Enclose complex macros in parentheses
Date: Mon, 15 Jan 2018 16:00:28 +0100	[thread overview]
Message-ID: <20180115150028.GA10946@kroah.com> (raw)
In-Reply-To: <1515691022-22729-2-git-send-email-fabian_huegel@web.de>

On Thu, Jan 11, 2018 at 06:16:55PM +0100, Fabian Huegel wrote:
> Checkpatch wants complex macros to be enclosed in parentheses, so we
> put parentheses around these four macros.
> 
> Signed-off-by: Fabian Huegel <fabian_huegel@web.de>
> Signed-off-by: Christoph Volkert <linux@christoph-volkert.de>
> ---
>  drivers/staging/lustre/lustre/include/obd_class.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h
> index 67c535c..5c8cf30 100644
> --- a/drivers/staging/lustre/lustre/include/obd_class.h
> +++ b/drivers/staging/lustre/lustre/include/obd_class.h
> @@ -294,10 +294,10 @@ struct obdo;
>  
>  void obdo_to_ioobj(const struct obdo *oa, struct obd_ioobj *ioobj);
>  
> -#define OBT(dev)	(dev)->obd_type
> -#define OBP(dev, op)    (dev)->obd_type->typ_dt_ops->op
> -#define MDP(dev, op)    (dev)->obd_type->typ_md_ops->op
> -#define CTXTP(ctxt, op) (ctxt)->loc_logops->lop_##op
> +#define OBT(dev)	((dev)->obd_type)
> +#define OBP(dev, op)    ((dev)->obd_type->typ_dt_ops->op)
> +#define MDP(dev, op)    ((dev)->obd_type->typ_md_ops->op)
> +#define CTXTP(ctxt, op) ((ctxt)->loc_logops->lop_##op)

That really doesn't make any sense, as this can only be a variable in
here, not any "complex expression".  Sometimes checkpatch.pl isn't very
smart.

Also, these macros are horridly named, odds are they are not even
needed...

thanks,

greg k-h

  reply	other threads:[~2018-01-15 15:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11 17:16 Fabian Huegel
2018-01-11 17:16 ` [PATCH 1/8] staging: lustre: Enclose complex macros in parentheses Fabian Huegel
2018-01-15 15:00   ` Greg Kroah-Hartman [this message]
2018-01-15 15:00     ` [lustre-devel] " Greg Kroah-Hartman
2018-01-11 17:16 ` [PATCH 2/8] staging: lustre: Enclose complex macros in do-while loops Fabian Huegel
2018-01-11 17:16 ` [PATCH 3/8] staging: lustre: Remove DECLARE_LU_VARS macro Fabian Huegel
2018-01-11 17:16 ` [PATCH 4/8] staging: lustre: Fix comment style Fabian Huegel
2018-01-15 15:02   ` Greg Kroah-Hartman
2018-01-15 15:02     ` [lustre-devel] " Greg Kroah-Hartman
2018-01-18 15:51     ` staging: lustre: Cleanup of obd_class.h Fabian Huegel
2018-01-18 15:51       ` [PATCH 1/2] staging: lustre: Fix comment style Fabian Huegel
2018-01-20  1:53         ` Joe Perches
2018-01-20  1:53           ` [lustre-devel] " Joe Perches
2018-01-22 10:37           ` Greg Kroah-Hartman
2018-01-22 10:37             ` [lustre-devel] " Greg Kroah-Hartman
2018-01-18 15:51       ` [PATCH 2/2] staging: lustre: Align struct member identifiers Fabian Huegel
2018-01-11 17:16 ` [PATCH 5/8] staging: lustre: Add identifier names to function declarations Fabian Huegel
2018-01-11 17:17 ` [PATCH 6/8] staging: lustre: Fix overlong lines Fabian Huegel
2018-01-19  3:36   ` Dilger, Andreas
2018-01-19  3:36     ` [lustre-devel] " Dilger, Andreas
2018-01-11 17:17 ` [PATCH 7/8] staging: lustre: Align struct member identifiers Fabian Huegel
2018-01-11 17:17 ` [PATCH 8/8] staging: lustre: Align backslashes in multi-line macros Fabian Huegel
2018-01-11 17:25 ` Ben Evans
2018-01-11 17:25   ` [lustre-devel] (no subject) Ben Evans
  -- strict thread matches above, loose matches on Subject: below --
2017-12-21 15:25 staging: lustre: Cleanup of obd_class.h Fabian Huegel
2017-12-21 15:25 ` [PATCH 1/8] staging: lustre: Enclose complex macros in parentheses Fabian Huegel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180115150028.GA10946@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=bevans@cray.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fabian_huegel@web.de \
    --cc=john.hammond@intel.com \
    --cc=jsimmons@infradead.org \
    --cc=lai.siyao@intel.com \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@christoph-volkert.de \
    --cc=lustre-devel@lists.lustre.org \
    --cc=neilb@suse.com \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.