All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, Ben Evans <bevans@cray.com>,
	Fabian Huegel <fabian_huegel@web.de>,
	linux-kernel@i4.cs.fau.de, NeilBrown <neilb@suse.com>,
	linux-kernel@vger.kernel.org, Oleg Drokin <oleg.drokin@intel.com>,
	lustre-devel@lists.lustre.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	"John L . Hammond" <john.hammond@intel.com>,
	Lai Siyao <lai.siyao@intel.com>,
	Christoph Volkert <linux@christoph-volkert.de>
Subject: Re: [PATCH 1/2] staging: lustre: Fix comment style
Date: Mon, 22 Jan 2018 11:37:45 +0100	[thread overview]
Message-ID: <20180122103745.GA23996@kroah.com> (raw)
In-Reply-To: <1516413239.14739.0.camel@perches.com>

On Fri, Jan 19, 2018 at 05:53:59PM -0800, Joe Perches wrote:
> On Thu, 2018-01-18 at 16:51 +0100, Fabian Huegel wrote:
> > Most multi-line comments started on the first line, but the preferred
> > linux kernel style is to start multi-line comments on the second line.
> > Some comments became less readable after the change, so we changed them
> > to single-line comments.
> []
> > diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h
> > 
> > @@ -182,7 +179,8 @@ struct config_llog_data {
> >  	struct obd_export	  *cld_mgcexp;
> >  	struct mutex		    cld_lock;
> >  	int			 cld_type;
> > -	unsigned int		cld_stopping:1, /* we were told to stop
> > +	unsigned int		cld_stopping:1, /*
> > +						 * we were told to stop
> >  						 * watching
> >  						 */
> >  				cld_lostlock:1; /* lock not requeued */
> 
> probably better for both of these to be bool
> instead of bitfield.

That's a change best left for a separate patch :)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, Ben Evans <bevans@cray.com>,
	Fabian Huegel <fabian_huegel@web.de>,
	linux-kernel@i4.cs.fau.de, NeilBrown <neilb@suse.com>,
	linux-kernel@vger.kernel.org, Oleg Drokin <oleg.drokin@intel.com>,
	lustre-devel@lists.lustre.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	"John L . Hammond" <john.hammond@intel.com>,
	Lai Siyao <lai.siyao@intel.com>,
	Christoph Volkert <linux@christoph-volkert.de>
Subject: [lustre-devel] [PATCH 1/2] staging: lustre: Fix comment style
Date: Mon, 22 Jan 2018 11:37:45 +0100	[thread overview]
Message-ID: <20180122103745.GA23996@kroah.com> (raw)
In-Reply-To: <1516413239.14739.0.camel@perches.com>

On Fri, Jan 19, 2018 at 05:53:59PM -0800, Joe Perches wrote:
> On Thu, 2018-01-18 at 16:51 +0100, Fabian Huegel wrote:
> > Most multi-line comments started on the first line, but the preferred
> > linux kernel style is to start multi-line comments on the second line.
> > Some comments became less readable after the change, so we changed them
> > to single-line comments.
> []
> > diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h
> > 
> > @@ -182,7 +179,8 @@ struct config_llog_data {
> >  	struct obd_export	  *cld_mgcexp;
> >  	struct mutex		    cld_lock;
> >  	int			 cld_type;
> > -	unsigned int		cld_stopping:1, /* we were told to stop
> > +	unsigned int		cld_stopping:1, /*
> > +						 * we were told to stop
> >  						 * watching
> >  						 */
> >  				cld_lostlock:1; /* lock not requeued */
> 
> probably better for both of these to be bool
> instead of bitfield.

That's a change best left for a separate patch :)

thanks,

greg k-h

  reply	other threads:[~2018-01-22 10:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11 17:16 Fabian Huegel
2018-01-11 17:16 ` [PATCH 1/8] staging: lustre: Enclose complex macros in parentheses Fabian Huegel
2018-01-15 15:00   ` Greg Kroah-Hartman
2018-01-15 15:00     ` [lustre-devel] " Greg Kroah-Hartman
2018-01-11 17:16 ` [PATCH 2/8] staging: lustre: Enclose complex macros in do-while loops Fabian Huegel
2018-01-11 17:16 ` [PATCH 3/8] staging: lustre: Remove DECLARE_LU_VARS macro Fabian Huegel
2018-01-11 17:16 ` [PATCH 4/8] staging: lustre: Fix comment style Fabian Huegel
2018-01-15 15:02   ` Greg Kroah-Hartman
2018-01-15 15:02     ` [lustre-devel] " Greg Kroah-Hartman
2018-01-18 15:51     ` staging: lustre: Cleanup of obd_class.h Fabian Huegel
2018-01-18 15:51       ` [PATCH 1/2] staging: lustre: Fix comment style Fabian Huegel
2018-01-20  1:53         ` Joe Perches
2018-01-20  1:53           ` [lustre-devel] " Joe Perches
2018-01-22 10:37           ` Greg Kroah-Hartman [this message]
2018-01-22 10:37             ` Greg Kroah-Hartman
2018-01-18 15:51       ` [PATCH 2/2] staging: lustre: Align struct member identifiers Fabian Huegel
2018-01-11 17:16 ` [PATCH 5/8] staging: lustre: Add identifier names to function declarations Fabian Huegel
2018-01-11 17:17 ` [PATCH 6/8] staging: lustre: Fix overlong lines Fabian Huegel
2018-01-19  3:36   ` Dilger, Andreas
2018-01-19  3:36     ` [lustre-devel] " Dilger, Andreas
2018-01-11 17:17 ` [PATCH 7/8] staging: lustre: Align struct member identifiers Fabian Huegel
2018-01-11 17:17 ` [PATCH 8/8] staging: lustre: Align backslashes in multi-line macros Fabian Huegel
2018-01-11 17:25 ` Ben Evans
2018-01-11 17:25   ` [lustre-devel] (no subject) Ben Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180122103745.GA23996@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=bevans@cray.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fabian_huegel@web.de \
    --cc=joe@perches.com \
    --cc=john.hammond@intel.com \
    --cc=lai.siyao@intel.com \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@christoph-volkert.de \
    --cc=lustre-devel@lists.lustre.org \
    --cc=neilb@suse.com \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.