* [U-Boot] [PATCH] sunxi: Fix display timing flags
@ 2018-01-16 16:43 Giulio Benetti
2018-01-17 7:38 ` Maxime Ripard
0 siblings, 1 reply; 3+ messages in thread
From: Giulio Benetti @ 2018-01-16 16:43 UTC (permalink / raw)
To: u-boot
flags member of struct timing was not initialized,
this took to unpredictable behaviour of display flags,
such DISPLAY_FLAGS_HSYNC_HIGH instead of _LOW etc.
Init timing->flags = 0
Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
drivers/video/sunxi/sunxi_display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/sunxi/sunxi_display.c b/drivers/video/sunxi/sunxi_display.c
index 0630289..f191ef1 100644
--- a/drivers/video/sunxi/sunxi_display.c
+++ b/drivers/video/sunxi/sunxi_display.c
@@ -625,6 +625,8 @@ static void sunxi_ctfb_mode_to_display_timing(const struct ctfb_res_modes *mode,
timing->vback_porch.typ = mode->upper_margin;
timing->vsync_len.typ = mode->vsync_len;
+ timing->flags = 0;
+
if (mode->sync & FB_SYNC_HOR_HIGH_ACT)
timing->flags |= DISPLAY_FLAGS_HSYNC_HIGH;
else
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] sunxi: Fix display timing flags
2018-01-16 16:43 [U-Boot] [PATCH] sunxi: Fix display timing flags Giulio Benetti
@ 2018-01-17 7:38 ` Maxime Ripard
2018-01-22 8:22 ` Jagan Teki
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2018-01-17 7:38 UTC (permalink / raw)
To: u-boot
On Tue, Jan 16, 2018 at 05:43:48PM +0100, Giulio Benetti wrote:
> flags member of struct timing was not initialized,
> this took to unpredictable behaviour of display flags,
> such DISPLAY_FLAGS_HSYNC_HIGH instead of _LOW etc.
>
> Init timing->flags = 0
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180117/e624df72/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] sunxi: Fix display timing flags
2018-01-17 7:38 ` Maxime Ripard
@ 2018-01-22 8:22 ` Jagan Teki
0 siblings, 0 replies; 3+ messages in thread
From: Jagan Teki @ 2018-01-22 8:22 UTC (permalink / raw)
To: u-boot
On Wed, Jan 17, 2018 at 1:08 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Tue, Jan 16, 2018 at 05:43:48PM +0100, Giulio Benetti wrote:
>> flags member of struct timing was not initialized,
>> this took to unpredictable behaviour of display flags,
>> such DISPLAY_FLAGS_HSYNC_HIGH instead of _LOW etc.
>>
>> Init timing->flags = 0
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Applied to u-boot-sunxi/master
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-22 8:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-16 16:43 [U-Boot] [PATCH] sunxi: Fix display timing flags Giulio Benetti
2018-01-17 7:38 ` Maxime Ripard
2018-01-22 8:22 ` Jagan Teki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.