[U-Boot] [PATCH] sunxi: Fix display timing flags

[U-Boot] [PATCH] sunxi: Fix display timing flags

[Giulio Benetti]

flags member of struct timing was not initialized,
this took to unpredictable behaviour of display flags,
such DISPLAY_FLAGS_HSYNC_HIGH instead of _LOW etc.

Init timing->flags = 0

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 drivers/video/sunxi/sunxi_display.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/sunxi/sunxi_display.c b/drivers/video/sunxi/sunxi_display.c
index 0630289..f191ef1 100644
--- a/drivers/video/sunxi/sunxi_display.c
+++ b/drivers/video/sunxi/sunxi_display.c
@@ -625,6 +625,8 @@ static void sunxi_ctfb_mode_to_display_timing(const struct ctfb_res_modes *mode,
 	timing->vback_porch.typ = mode->upper_margin;
 	timing->vsync_len.typ = mode->vsync_len;
 
+	timing->flags = 0;
+
 	if (mode->sync & FB_SYNC_HOR_HIGH_ACT)
 		timing->flags |= DISPLAY_FLAGS_HSYNC_HIGH;
 	else
-- 
2.7.4

[U-Boot] [PATCH] sunxi: Fix display timing flags

[Maxime Ripard]

On Tue, Jan 16, 2018 at 05:43:48PM +0100, Giulio Benetti wrote:
> flags member of struct timing was not initialized,
> this took to unpredictable behaviour of display flags,
> such DISPLAY_FLAGS_HSYNC_HIGH instead of _LOW etc.
> 
> Init timing->flags = 0
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180117/e624df72/attachment.sig>

[U-Boot] [PATCH] sunxi: Fix display timing flags

[Jagan Teki]

On Wed, Jan 17, 2018 at 1:08 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Tue, Jan 16, 2018 at 05:43:48PM +0100, Giulio Benetti wrote:
>> flags member of struct timing was not initialized,
>> this took to unpredictable behaviour of display flags,
>> such DISPLAY_FLAGS_HSYNC_HIGH instead of _LOW etc.
>>
>> Init timing->flags = 0
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Applied to u-boot-sunxi/master