All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	namhyung@kernel.org, Adrian Hunter <adrian.hunter@intel.com>,
	Mike Leach <mike.leach@arm.com>,
	suzuki.poulosi@arm.com, Kim Phillips <kim.phillips@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 01/10] perf tools: Integrating the CoreSight decoding library
Date: Thu, 18 Jan 2018 11:14:23 -0300	[thread overview]
Message-ID: <20180118141423.GE18383@kernel.org> (raw)
In-Reply-To: <20180118135948.GA2940@krava>

Em Thu, Jan 18, 2018 at 02:59:48PM +0100, Jiri Olsa escreveu:
> On Thu, Jan 18, 2018 at 10:41:39AM -0300, Arnaldo Carvalho de Melo wrote:
> > 	Shouldn't libopencsd be treated like libbabeltrace was before
> > the required version was widely available in distros?

> > 	I.e. these csets should have the rationale for that:

> > Enabling it once it became widely available:

> >    24787afbcd01 ("perf tools: Enable LIBBABELTRACE by default")

> > Disabling it because we would need to get things from tarballs/git
> > repos, build it in our machines, as requested by Ingo:

> >   6ab2b762befd ("perf build: Disable libbabeltrace check by default")
> 
> I think at that time we did not have a way to hide the check,
> now we have FEATURE_DISPLAY seprated so we can still check
> for it, but users won't be bothered with [ FAIL ] output

Ok, users won't be bothered with the fail output, but we tried hard to
get the build fast by having it only test for things that are widely
available, right? I.e. if we know something is not widely available then
we better not try to build with it and get faster builds, wasn't that
part of the rationale in the babeltrace case?

If one has to build from sources some library, then its not a problem to
have in the make command line a LIBOPENCSD=1 switch?

- Arnaldo

WARNING: multiple messages have this Message-ID (diff)
From: acme@kernel.org (Arnaldo Carvalho de Melo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 01/10] perf tools: Integrating the CoreSight decoding library
Date: Thu, 18 Jan 2018 11:14:23 -0300	[thread overview]
Message-ID: <20180118141423.GE18383@kernel.org> (raw)
In-Reply-To: <20180118135948.GA2940@krava>

Em Thu, Jan 18, 2018 at 02:59:48PM +0100, Jiri Olsa escreveu:
> On Thu, Jan 18, 2018 at 10:41:39AM -0300, Arnaldo Carvalho de Melo wrote:
> > 	Shouldn't libopencsd be treated like libbabeltrace was before
> > the required version was widely available in distros?

> > 	I.e. these csets should have the rationale for that:

> > Enabling it once it became widely available:

> >    24787afbcd01 ("perf tools: Enable LIBBABELTRACE by default")

> > Disabling it because we would need to get things from tarballs/git
> > repos, build it in our machines, as requested by Ingo:

> >   6ab2b762befd ("perf build: Disable libbabeltrace check by default")
> 
> I think at that time we did not have a way to hide the check,
> now we have FEATURE_DISPLAY seprated so we can still check
> for it, but users won't be bothered with [ FAIL ] output

Ok, users won't be bothered with the fail output, but we tried hard to
get the build fast by having it only test for things that are widely
available, right? I.e. if we know something is not widely available then
we better not try to build with it and get faster builds, wasn't that
part of the rationale in the babeltrace case?

If one has to build from sources some library, then its not a problem to
have in the make command line a LIBOPENCSD=1 switch?

- Arnaldo

  reply	other threads:[~2018-01-18 14:14 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 18:13 [PATCH v2 00/10] perf tools: Add support for CoreSight trace decoding Mathieu Poirier
2018-01-15 18:13 ` Mathieu Poirier
2018-01-15 18:13 ` [PATCH v2 01/10] perf tools: Integrating the CoreSight decoding library Mathieu Poirier
2018-01-15 18:13   ` Mathieu Poirier
2018-01-16 12:14   ` Jiri Olsa
2018-01-16 12:15   ` Jiri Olsa
2018-01-16 18:04     ` Mathieu Poirier
2018-01-16 20:30     ` Mathieu Poirier
2018-01-17  8:06       ` Jiri Olsa
2018-01-17  8:06         ` Jiri Olsa
2018-01-18 13:41         ` Arnaldo Carvalho de Melo
2018-01-18 13:41           ` Arnaldo Carvalho de Melo
2018-01-18 13:59           ` Jiri Olsa
2018-01-18 13:59             ` Jiri Olsa
2018-01-18 14:14             ` Arnaldo Carvalho de Melo [this message]
2018-01-18 14:14               ` Arnaldo Carvalho de Melo
2018-01-18 14:27               ` Jiri Olsa
2018-01-18 14:27                 ` Jiri Olsa
2018-01-19 14:58                 ` Arnaldo Carvalho de Melo
2018-01-19 14:58                   ` Arnaldo Carvalho de Melo
2018-01-19 15:12                   ` Jiri Olsa
2018-01-19 15:12                     ` Jiri Olsa
2018-01-19 15:24                     ` Mathieu Poirier
2018-01-19 15:24                       ` Mathieu Poirier
2018-01-19 15:55                       ` Arnaldo Carvalho de Melo
2018-01-19 15:55                         ` Arnaldo Carvalho de Melo
2018-01-19 17:28                         ` Mathieu Poirier
2018-01-19 17:28                           ` Mathieu Poirier
2018-01-19 18:46                           ` Jiri Olsa
2018-01-19 18:46                             ` Jiri Olsa
2018-01-15 18:13 ` [PATCH v2 02/10] perf tools: Add initial entry point for decoder CoreSight traces Mathieu Poirier
2018-01-15 18:13   ` Mathieu Poirier
2018-01-15 18:13 ` [PATCH v2 03/10] perf tools: Add processing of coresight metadata Mathieu Poirier
2018-01-15 18:13   ` Mathieu Poirier
2018-01-15 18:13 ` [PATCH v2 04/10] perf tools: Add decoder mechanic to support dumping trace data Mathieu Poirier
2018-01-15 18:13   ` Mathieu Poirier
2018-01-15 18:13 ` [PATCH v2 05/10] perf tools: Add support for decoding CoreSight " Mathieu Poirier
2018-01-15 18:13   ` Mathieu Poirier
2018-01-15 18:13 ` [PATCH v2 06/10] perf tools: Add functionality to communicate with the openCSD decoder Mathieu Poirier
2018-01-15 18:13   ` Mathieu Poirier
2018-01-15 18:13 ` [PATCH v2 07/10] pert tools: Add queue management functionality Mathieu Poirier
2018-01-15 18:13   ` Mathieu Poirier
2018-01-15 18:13 ` [PATCH v2 08/10] perf tools: Add full support for CoreSight trace decoding Mathieu Poirier
2018-01-15 18:13   ` Mathieu Poirier
2018-01-15 18:13 ` [PATCH v2 09/10] perf tools: Add mechanic to synthesise CoreSight trace packets Mathieu Poirier
2018-01-15 18:13   ` Mathieu Poirier
2018-01-15 18:13 ` [PATCH v2 10/10] MAINTAINERS: Adding entry for CoreSight trace decoding Mathieu Poirier
2018-01-15 18:13   ` Mathieu Poirier
2018-01-16 12:17 ` [PATCH v2 00/10] perf tools: Add support " Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180118141423.GE18383@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=kim.phillips@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@arm.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=suzuki.poulosi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.