From: Guenter Roeck <linux@roeck-us.net>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "shufan_lee(?????|)" <shufan_lee@richtek.com>,
'Jun Li' <jun.li@nxp.com>, ShuFanLee <leechu729@gmail.com>,
"cy_huang(??????)" <cy_huang@richtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver
Date: Fri, 19 Jan 2018 08:02:35 -0800 [thread overview]
Message-ID: <20180119160235.GA21066@roeck-us.net> (raw)
In-Reply-To: <20180119092413.GB22976@kuha.fi.intel.com>
On Fri, Jan 19, 2018 at 11:24:13AM +0200, Heikki Krogerus wrote:
> Hi,
>
> On Fri, Jan 19, 2018 at 09:01:24AM +0000, shufan_lee(?????|) wrote:
> > Hi Heikki,
> >
> > For example, the flow of tcpci_init is a little bit different.
> > In tcpci_init, there are more parameters need to be set for RT1711H.
>
> Different init parameters is really not a reason for a fork of the
> driver. The configuration of the TCPC will depend on the platform and
> TCPC vendor most cases.
>
Agreed. dwc3 usb support is an excellent example on how to handle this
kind of variation.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "shufan_lee\(?????|\)" <shufan_lee@richtek.com>,
'Jun Li' <jun.li@nxp.com>, ShuFanLee <leechu729@gmail.com>,
"cy_huang\(??????\)" <cy_huang@richtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: USB TYPEC: RT1711H Type-C Chip Driver
Date: Fri, 19 Jan 2018 08:02:35 -0800 [thread overview]
Message-ID: <20180119160235.GA21066@roeck-us.net> (raw)
On Fri, Jan 19, 2018 at 11:24:13AM +0200, Heikki Krogerus wrote:
> Hi,
>
> On Fri, Jan 19, 2018 at 09:01:24AM +0000, shufan_lee(?????|) wrote:
> > Hi Heikki,
> >
> > For example, the flow of tcpci_init is a little bit different.
> > In tcpci_init, there are more parameters need to be set for RT1711H.
>
> Different init parameters is really not a reason for a fork of the
> driver. The configuration of the TCPC will depend on the platform and
> TCPC vendor most cases.
>
Agreed. dwc3 usb support is an excellent example on how to handle this
kind of variation.
Guenter
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-19 16:02 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 6:59 [PATCH] USB TYPEC: RT1711H Type-C Chip Driver ShuFanLee
2018-01-10 6:59 ` ShuFanLee
2018-01-17 9:30 ` [PATCH] " shufan_lee(李書帆)
2018-01-17 9:30 ` shufan_lee(李書帆)
2018-01-17 11:08 ` [PATCH] " Heikki Krogerus
2018-01-17 11:08 ` Heikki Krogerus
2018-01-17 11:14 ` [PATCH] " Greg KH
2018-01-17 11:14 ` Greg Kroah-Hartman
2018-01-17 12:00 ` [PATCH] " Heikki Krogerus
2018-01-17 12:00 ` Heikki Krogerus
2018-01-17 13:31 ` [PATCH] " Greg KH
2018-01-17 13:31 ` Greg Kroah-Hartman
2018-01-17 13:33 ` [PATCH] " Greg KH
2018-01-17 13:33 ` Greg KH
2018-01-17 13:33 ` [PATCH] " Greg KH
2018-01-17 13:33 ` Greg KH
2018-01-17 13:42 ` [PATCH] " Greg KH
2018-01-17 13:42 ` Greg KH
2018-01-18 13:13 ` [PATCH] " shufan_lee(李書帆)
2018-01-18 13:13 ` shufan_lee(李書帆)
2018-01-19 8:03 ` [PATCH] " 'Greg KH'
2018-01-19 8:03 ` Greg KH
2018-01-19 3:09 ` [PATCH] " Jun Li
2018-01-19 3:09 ` Jun Li
2018-01-19 5:48 ` [PATCH] " shufan_lee(李書帆)
2018-01-19 5:48 ` shufan_lee(李書帆)
2018-01-19 8:22 ` [PATCH] " Heikki Krogerus
2018-01-19 8:22 ` Heikki Krogerus
2018-01-19 9:01 ` [PATCH] " shufan_lee(李書帆)
2018-01-19 9:01 ` shufan_lee(李書帆)
2018-01-19 9:24 ` [PATCH] " Heikki Krogerus
2018-01-19 9:24 ` Heikki Krogerus
2018-01-19 16:02 ` Guenter Roeck [this message]
2018-01-19 16:02 ` Guenter Roeck
2018-01-22 2:01 ` [PATCH] " shufan_lee(李書帆)
2018-01-22 2:01 ` shufan_lee(李書帆)
2018-01-22 18:50 ` [PATCH] " Guenter Roeck
2018-01-22 18:50 ` Guenter Roeck
2018-01-29 7:19 ` [PATCH] " shufan_lee(李書帆)
2018-01-29 7:19 ` shufan_lee(李書帆)
2018-01-29 19:57 ` [PATCH] " Guenter Roeck
2018-01-29 19:57 ` Guenter Roeck
2018-01-30 13:21 ` [PATCH] " shufan_lee(李書帆)
2018-01-30 13:21 ` shufan_lee(李書帆)
2018-01-30 23:25 ` [PATCH] " Guenter Roeck
2018-01-30 23:25 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2018-01-09 3:13 [PATCH] " shufan_lee(李書帆)
2018-01-09 6:18 ` Randy Dunlap
2018-01-09 8:45 ` shufan_lee(李書帆)
2018-01-09 17:26 ` Randy Dunlap
2018-01-10 2:49 ` shufan_lee(李書帆)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119160235.GA21066@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cy_huang@richtek.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=leechu729@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.