From: Brijesh Singh <brijesh.singh@amd.com> To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>, Tom Lendacky <Thomas.Lendacky@amd.com>, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Eric Blake <eblake@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Daniel P . Berrange" <berrange@redhat.com>, Brijesh Singh <brijesh.singh@amd.com> Subject: [PATCH v6 23/23] sev: add migration blocker Date: Mon, 29 Jan 2018 11:41:32 -0600 [thread overview] Message-ID: <20180129174132.108925-24-brijesh.singh@amd.com> (raw) In-Reply-To: <20180129174132.108925-1-brijesh.singh@amd.com> SEV guest migration is not implemented yet. Signed-off-by: Brijesh Singh <brijesh.singh@amd.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> --- accel/kvm/sev.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/accel/kvm/sev.c b/accel/kvm/sev.c index 65d34c531ee5..6800e059f57c 100644 --- a/accel/kvm/sev.c +++ b/accel/kvm/sev.c @@ -20,6 +20,7 @@ #include "sysemu/sysemu.h" #include "trace.h" #include "qapi-event.h" +#include "migration/blocker.h" #define DEFAULT_GUEST_POLICY 0x1 /* disable debug */ #define DEFAULT_SEV_DEVICE "/dev/sev" @@ -28,6 +29,7 @@ static int sev_fd; static SEVState *sev_state; static MemoryRegionRAMReadWriteOps sev_ops; +static Error *sev_mig_blocker; #define SEV_FW_MAX_ERROR 0x17 @@ -479,6 +481,7 @@ static void sev_launch_finish(SEVState *s) { int ret, error; + Error *local_err = NULL; trace_kvm_sev_launch_finish(); ret = sev_ioctl(KVM_SEV_LAUNCH_FINISH, 0, &error); @@ -489,6 +492,16 @@ sev_launch_finish(SEVState *s) } sev_set_guest_state(SEV_STATE_RUNNING); + + /* add migration blocker */ + error_setg(&sev_mig_blocker, + "SEV: Migration is not implemented"); + ret = migrate_add_blocker(sev_mig_blocker, &local_err); + if (local_err) { + error_report_err(local_err); + error_free(sev_mig_blocker); + exit(1); + } } static void -- 2.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Brijesh Singh <brijesh.singh@amd.com> To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>, Tom Lendacky <Thomas.Lendacky@amd.com>, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Eric Blake <eblake@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Daniel P . Berrange" <berrange@redhat.com>, Brijesh Singh <brijesh.singh@amd.com> Subject: [Qemu-devel] [PATCH v6 23/23] sev: add migration blocker Date: Mon, 29 Jan 2018 11:41:32 -0600 [thread overview] Message-ID: <20180129174132.108925-24-brijesh.singh@amd.com> (raw) In-Reply-To: <20180129174132.108925-1-brijesh.singh@amd.com> SEV guest migration is not implemented yet. Signed-off-by: Brijesh Singh <brijesh.singh@amd.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> --- accel/kvm/sev.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/accel/kvm/sev.c b/accel/kvm/sev.c index 65d34c531ee5..6800e059f57c 100644 --- a/accel/kvm/sev.c +++ b/accel/kvm/sev.c @@ -20,6 +20,7 @@ #include "sysemu/sysemu.h" #include "trace.h" #include "qapi-event.h" +#include "migration/blocker.h" #define DEFAULT_GUEST_POLICY 0x1 /* disable debug */ #define DEFAULT_SEV_DEVICE "/dev/sev" @@ -28,6 +29,7 @@ static int sev_fd; static SEVState *sev_state; static MemoryRegionRAMReadWriteOps sev_ops; +static Error *sev_mig_blocker; #define SEV_FW_MAX_ERROR 0x17 @@ -479,6 +481,7 @@ static void sev_launch_finish(SEVState *s) { int ret, error; + Error *local_err = NULL; trace_kvm_sev_launch_finish(); ret = sev_ioctl(KVM_SEV_LAUNCH_FINISH, 0, &error); @@ -489,6 +492,16 @@ sev_launch_finish(SEVState *s) } sev_set_guest_state(SEV_STATE_RUNNING); + + /* add migration blocker */ + error_setg(&sev_mig_blocker, + "SEV: Migration is not implemented"); + ret = migrate_add_blocker(sev_mig_blocker, &local_err); + if (local_err) { + error_report_err(local_err); + error_free(sev_mig_blocker); + exit(1); + } } static void -- 2.9.5
next prev parent reply other threads:[~2018-01-29 17:42 UTC|newest] Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-29 17:41 [PATCH v6 00/23] x86: Secure Encrypted Virtualization (AMD) Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 01/23] memattrs: add debug attribute Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-30 21:59 ` Edgar E. Iglesias 2018-01-30 21:59 ` [Qemu-devel] " Edgar E. Iglesias 2018-01-29 17:41 ` [PATCH v6 02/23] exec: add ram_debug_ops support Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-30 21:59 ` Edgar E. Iglesias 2018-01-30 21:59 ` [Qemu-devel] " Edgar E. Iglesias 2018-01-30 22:34 ` Brijesh Singh 2018-01-30 22:34 ` [Qemu-devel] " Brijesh Singh 2018-01-30 22:37 ` Edgar E. Iglesias 2018-01-30 22:37 ` [Qemu-devel] " Edgar E. Iglesias 2018-01-30 23:26 ` Brijesh Singh 2018-01-30 23:26 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 03/23] exec: add debug version of physical memory read and write API Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 04/23] monitor/i386: use debug APIs when accessing guest memory Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-30 17:49 ` Dr. David Alan Gilbert 2018-01-30 17:49 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-01-30 21:46 ` Brijesh Singh 2018-01-30 21:46 ` [Qemu-devel] " Brijesh Singh 2018-01-30 22:15 ` Brijesh Singh 2018-01-30 22:15 ` [Qemu-devel] " Brijesh Singh 2018-01-31 9:57 ` Dr. David Alan Gilbert 2018-01-31 9:57 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-01-31 13:41 ` Eduardo Habkost 2018-01-31 13:41 ` [Qemu-devel] " Eduardo Habkost 2018-01-31 16:05 ` Brijesh Singh 2018-01-31 16:05 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 06/23] machine: add -memory-encryption property Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 07/23] kvm: update kvm.h to include memory encryption ioctls Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 08/23] docs: add AMD Secure Encrypted Virtualization (SEV) Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 09/23] accel: add Secure Encrypted Virtulization (SEV) object Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 10/23] sev: add command to initialize the memory encryption context Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-02-01 12:13 ` Dr. David Alan Gilbert 2018-02-01 12:13 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-02-01 15:33 ` Brijesh Singh 2018-02-01 15:33 ` [Qemu-devel] " Brijesh Singh 2018-02-01 15:46 ` Dr. David Alan Gilbert 2018-02-01 15:46 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-01-29 17:41 ` [PATCH v6 11/23] sev: register the guest memory range which may contain encrypted data Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 12/23] kvm: introduce memory encryption APIs Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 13/23] hmp: display memory encryption support in 'info kvm' Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-31 17:43 ` Markus Armbruster 2018-02-01 15:21 ` Brijesh Singh 2018-02-01 17:58 ` Dr. David Alan Gilbert 2018-02-01 17:58 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-02-01 19:55 ` Brijesh Singh 2018-02-01 19:55 ` [Qemu-devel] " Brijesh Singh 2018-02-01 20:04 ` Dr. David Alan Gilbert 2018-02-01 20:04 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-02-02 13:08 ` Daniel P. Berrangé 2018-02-02 13:08 ` [Qemu-devel] " Daniel P. Berrangé 2018-02-02 13:46 ` Brijesh Singh 2018-02-02 13:46 ` [Qemu-devel] " Brijesh Singh 2018-02-02 15:24 ` Dr. David Alan Gilbert 2018-02-02 15:24 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-01-29 17:41 ` [PATCH v6 14/23] sev: add command to create launch memory encryption context Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 15/23] sev: add command to encrypt guest memory region Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 16/23] target/i386: encrypt bios rom Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 17/23] qapi: add SEV_MEASUREMENT event Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-31 17:45 ` Markus Armbruster 2018-02-01 15:25 ` Brijesh Singh 2018-02-01 15:28 ` Eric Blake 2018-02-01 15:28 ` Eric Blake 2018-01-29 17:41 ` [PATCH v6 18/23] sev: emit the " Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-30 20:08 ` Dr. David Alan Gilbert 2018-01-30 20:08 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-01-30 22:13 ` Brijesh Singh 2018-01-30 22:13 ` [Qemu-devel] " Brijesh Singh 2018-02-01 17:27 ` Dr. David Alan Gilbert 2018-02-01 17:27 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-02-02 15:11 ` Brijesh Singh 2018-02-02 15:11 ` [Qemu-devel] " Brijesh Singh 2018-02-02 15:16 ` Daniel P. Berrangé 2018-02-02 15:16 ` [Qemu-devel] " Daniel P. Berrangé 2018-02-08 16:17 ` Brijesh Singh 2018-02-08 16:17 ` [Qemu-devel] " Brijesh Singh 2018-02-08 16:22 ` Daniel P. Berrangé 2018-01-29 17:41 ` [PATCH v6 19/23] sev: Finalize the SEV guest launch flow Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 20/23] hw: i386: set ram_debug_ops when memory encryption is enabled Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 21/23] sev: add debug encrypt and decrypt commands Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` [PATCH v6 22/23] target/i386: clear C-bit when walking SEV guest page table Brijesh Singh 2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh 2018-01-29 17:41 ` Brijesh Singh [this message] 2018-01-29 17:41 ` [Qemu-devel] [PATCH v6 23/23] sev: add migration blocker Brijesh Singh 2018-01-29 18:13 ` [Qemu-devel] [PATCH v6 00/23] x86: Secure Encrypted Virtualization (AMD) no-reply 2018-01-29 18:13 ` no-reply 2018-01-29 18:17 ` no-reply 2018-01-29 18:17 ` [Qemu-devel] " no-reply 2018-01-29 18:19 ` no-reply 2018-01-29 18:19 ` no-reply 2018-01-29 18:31 ` no-reply 2018-01-29 18:31 ` [Qemu-devel] " no-reply 2018-02-06 15:51 ` Bruce Rogers 2018-02-06 15:51 ` Bruce Rogers 2018-02-07 1:07 ` Brijesh Singh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180129174132.108925-24-brijesh.singh@amd.com \ --to=brijesh.singh@amd.com \ --cc=Thomas.Lendacky@amd.com \ --cc=berrange@redhat.com \ --cc=dgilbert@redhat.com \ --cc=eblake@redhat.com \ --cc=edgar.iglesias@xilinx.com \ --cc=ehabkost@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=stefanha@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.