From: Eric Blake <eblake@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>,
Markus Armbruster <armbru@redhat.com>
Cc: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>,
Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, Tom Lendacky <Thomas.Lendacky@amd.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 17/23] qapi: add SEV_MEASUREMENT event
Date: Thu, 1 Feb 2018 09:28:50 -0600 [thread overview]
Message-ID: <b35e4ea1-92f8-78c6-ea07-fde07667427f@redhat.com> (raw)
In-Reply-To: <315572b0-2893-2247-c20b-717becd9661c@amd.com>
[-- Attachment #1.1: Type: text/plain, Size: 871 bytes --]
On 02/01/2018 09:25 AM, Brijesh Singh wrote:
>>> +{ 'event' : 'SEV_MEASUREMENT',
>>> + 'data' : { 'value' : 'str' } }
>>
>> New event -> automatic question: do we need a way to poll for this
>> information? Say when an event could get lost during a libvirt restart.
>>
>
>
> In our initial SEV patches for libvirt we ran into similar cases where
> the event was dropped on restart, and now leaning towards dropping this
> event patch and add a new QMP command which can be used by libvirt to
> retrieve the measurement.
An event may still be useful to minimize the amount of polling required
when the connection is not broken. It's just that any setup that ONLY
permits events (and not also polling) is fragile.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>,
Markus Armbruster <armbru@redhat.com>
Cc: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>,
Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, Tom Lendacky <Thomas.Lendacky@amd.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 17/23] qapi: add SEV_MEASUREMENT event
Date: Thu, 1 Feb 2018 09:28:50 -0600 [thread overview]
Message-ID: <b35e4ea1-92f8-78c6-ea07-fde07667427f@redhat.com> (raw)
In-Reply-To: <315572b0-2893-2247-c20b-717becd9661c@amd.com>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On 02/01/2018 09:25 AM, Brijesh Singh wrote:
>>> +{ 'event' : 'SEV_MEASUREMENT',
>>> + 'data' : { 'value' : 'str' } }
>>
>> New event -> automatic question: do we need a way to poll for this
>> information? Say when an event could get lost during a libvirt restart.
>>
>
>
> In our initial SEV patches for libvirt we ran into similar cases where
> the event was dropped on restart, and now leaning towards dropping this
> event patch and add a new QMP command which can be used by libvirt to
> retrieve the measurement.
An event may still be useful to minimize the amount of polling required
when the connection is not broken. It's just that any setup that ONLY
permits events (and not also polling) is fragile.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-02-01 15:29 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 17:41 [PATCH v6 00/23] x86: Secure Encrypted Virtualization (AMD) Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 01/23] memattrs: add debug attribute Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-30 21:59 ` Edgar E. Iglesias
2018-01-30 21:59 ` [Qemu-devel] " Edgar E. Iglesias
2018-01-29 17:41 ` [PATCH v6 02/23] exec: add ram_debug_ops support Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-30 21:59 ` Edgar E. Iglesias
2018-01-30 21:59 ` [Qemu-devel] " Edgar E. Iglesias
2018-01-30 22:34 ` Brijesh Singh
2018-01-30 22:34 ` [Qemu-devel] " Brijesh Singh
2018-01-30 22:37 ` Edgar E. Iglesias
2018-01-30 22:37 ` [Qemu-devel] " Edgar E. Iglesias
2018-01-30 23:26 ` Brijesh Singh
2018-01-30 23:26 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 03/23] exec: add debug version of physical memory read and write API Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 04/23] monitor/i386: use debug APIs when accessing guest memory Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-30 17:49 ` Dr. David Alan Gilbert
2018-01-30 17:49 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-01-30 21:46 ` Brijesh Singh
2018-01-30 21:46 ` [Qemu-devel] " Brijesh Singh
2018-01-30 22:15 ` Brijesh Singh
2018-01-30 22:15 ` [Qemu-devel] " Brijesh Singh
2018-01-31 9:57 ` Dr. David Alan Gilbert
2018-01-31 9:57 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-01-31 13:41 ` Eduardo Habkost
2018-01-31 13:41 ` [Qemu-devel] " Eduardo Habkost
2018-01-31 16:05 ` Brijesh Singh
2018-01-31 16:05 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 06/23] machine: add -memory-encryption property Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 07/23] kvm: update kvm.h to include memory encryption ioctls Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 08/23] docs: add AMD Secure Encrypted Virtualization (SEV) Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 09/23] accel: add Secure Encrypted Virtulization (SEV) object Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 10/23] sev: add command to initialize the memory encryption context Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-02-01 12:13 ` Dr. David Alan Gilbert
2018-02-01 12:13 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-02-01 15:33 ` Brijesh Singh
2018-02-01 15:33 ` [Qemu-devel] " Brijesh Singh
2018-02-01 15:46 ` Dr. David Alan Gilbert
2018-02-01 15:46 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-01-29 17:41 ` [PATCH v6 11/23] sev: register the guest memory range which may contain encrypted data Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 12/23] kvm: introduce memory encryption APIs Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 13/23] hmp: display memory encryption support in 'info kvm' Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-31 17:43 ` Markus Armbruster
2018-02-01 15:21 ` Brijesh Singh
2018-02-01 17:58 ` Dr. David Alan Gilbert
2018-02-01 17:58 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-02-01 19:55 ` Brijesh Singh
2018-02-01 19:55 ` [Qemu-devel] " Brijesh Singh
2018-02-01 20:04 ` Dr. David Alan Gilbert
2018-02-01 20:04 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-02-02 13:08 ` Daniel P. Berrangé
2018-02-02 13:08 ` [Qemu-devel] " Daniel P. Berrangé
2018-02-02 13:46 ` Brijesh Singh
2018-02-02 13:46 ` [Qemu-devel] " Brijesh Singh
2018-02-02 15:24 ` Dr. David Alan Gilbert
2018-02-02 15:24 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-01-29 17:41 ` [PATCH v6 14/23] sev: add command to create launch memory encryption context Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 15/23] sev: add command to encrypt guest memory region Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 16/23] target/i386: encrypt bios rom Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 17/23] qapi: add SEV_MEASUREMENT event Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-31 17:45 ` Markus Armbruster
2018-02-01 15:25 ` Brijesh Singh
2018-02-01 15:28 ` Eric Blake [this message]
2018-02-01 15:28 ` Eric Blake
2018-01-29 17:41 ` [PATCH v6 18/23] sev: emit the " Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-30 20:08 ` Dr. David Alan Gilbert
2018-01-30 20:08 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-01-30 22:13 ` Brijesh Singh
2018-01-30 22:13 ` [Qemu-devel] " Brijesh Singh
2018-02-01 17:27 ` Dr. David Alan Gilbert
2018-02-01 17:27 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-02-02 15:11 ` Brijesh Singh
2018-02-02 15:11 ` [Qemu-devel] " Brijesh Singh
2018-02-02 15:16 ` Daniel P. Berrangé
2018-02-02 15:16 ` [Qemu-devel] " Daniel P. Berrangé
2018-02-08 16:17 ` Brijesh Singh
2018-02-08 16:17 ` [Qemu-devel] " Brijesh Singh
2018-02-08 16:22 ` Daniel P. Berrangé
2018-01-29 17:41 ` [PATCH v6 19/23] sev: Finalize the SEV guest launch flow Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 20/23] hw: i386: set ram_debug_ops when memory encryption is enabled Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 21/23] sev: add debug encrypt and decrypt commands Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 22/23] target/i386: clear C-bit when walking SEV guest page table Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 17:41 ` [PATCH v6 23/23] sev: add migration blocker Brijesh Singh
2018-01-29 17:41 ` [Qemu-devel] " Brijesh Singh
2018-01-29 18:13 ` [Qemu-devel] [PATCH v6 00/23] x86: Secure Encrypted Virtualization (AMD) no-reply
2018-01-29 18:13 ` no-reply
2018-01-29 18:17 ` no-reply
2018-01-29 18:17 ` [Qemu-devel] " no-reply
2018-01-29 18:19 ` no-reply
2018-01-29 18:19 ` no-reply
2018-01-29 18:31 ` no-reply
2018-01-29 18:31 ` [Qemu-devel] " no-reply
2018-02-06 15:51 ` Bruce Rogers
2018-02-06 15:51 ` Bruce Rogers
2018-02-07 1:07 ` Brijesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b35e4ea1-92f8-78c6-ea07-fde07667427f@redhat.com \
--to=eblake@redhat.com \
--cc=Thomas.Lendacky@amd.com \
--cc=armbru@redhat.com \
--cc=brijesh.singh@amd.com \
--cc=dgilbert@redhat.com \
--cc=edgar.iglesias@xilinx.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.