From: Sebastian Reichel <sebastian.reichel@collabora.co.uk> To: Philippe Ombredanne <pombredanne@nexb.com> Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Tony Lindgren <tony@atomide.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, ALSA <alsa-devel@alsa-project.org>, linux-omap@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec Date: Fri, 16 Feb 2018 14:31:14 +0100 [thread overview] Message-ID: <20180216133114.6ynx36b5cpfvkebd@earth.universe> (raw) In-Reply-To: <CAOFm3uFJC2Xb0PuNECJ-Tvg2gQS==tMSc77p_keQoCexNqOkDg@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 2439 bytes --] Hi Philippe, On Thu, Feb 15, 2018 at 10:50:22AM +0100, Philippe Ombredanne wrote: > Dear Sebastian, > > On Wed, Feb 14, 2018 at 11:07 PM, Sebastian Reichel > <sebastian.reichel@collabora.co.uk> wrote: > > Motorola CPCAP is a PMIC with audio functionality, that can be > > found on Motorola Droid 4 and probably a few other phones from > > Motorola's Droid series. > > > > The driver has been written from scratch using Motorola's Android > > driver, register dumps from running Android and datasheet for NXP > > MC13783UG (which is similar to Motorola CPCAP, but not the same). > > > > The chip provides two audio interfaces, that can be muxed to two > > different audio codecs. One provides support for stereo output > > (named StDAC or HiFi), while the other only provides mono output > > (named Voice). Only the Voice codec provides a Capture interface. > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> > > <snip> > > > --- /dev/null > > +++ b/sound/soc/codecs/cpcap.c > > @@ -0,0 +1,1588 @@ > > +/* > > + * ALSA SoC CPCAP codec driver > > + * > > + * Copyright (C) 2017 - 2018 Sebastian Reichel <sre@kernel.org> > > + * > > + * Very loosely based on original driver from Motorola: > > + * Copyright (C) 2007 - 2009 Motorola, Inc. > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + */ > > Could you consider using the new SPDX tags instead of this fine but > long legalese? [1] Sure. Thanks for the hint. > <snip> > > > +MODULE_ALIAS("platform:cpcap-codec"); > > +MODULE_DESCRIPTION("ASoC CPCAP codec driver"); > > +MODULE_AUTHOR("Sebastian Reichel"); > > +MODULE_LICENSE("GPL"); > > This does not match your license: per module.h, GPL means GPL-2.0 or > later. You notice above is GPL-2.0, not "or later" Indeed. I will fix this in the next revision. > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Sebastian [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sebastian.reichel@collabora.co.uk> To: Philippe Ombredanne <pombredanne@nexb.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, ALSA <alsa-devel@alsa-project.org>, linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>, LKML <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org> Subject: Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec Date: Fri, 16 Feb 2018 14:31:14 +0100 [thread overview] Message-ID: <20180216133114.6ynx36b5cpfvkebd@earth.universe> (raw) In-Reply-To: <CAOFm3uFJC2Xb0PuNECJ-Tvg2gQS==tMSc77p_keQoCexNqOkDg@mail.gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 2439 bytes --] Hi Philippe, On Thu, Feb 15, 2018 at 10:50:22AM +0100, Philippe Ombredanne wrote: > Dear Sebastian, > > On Wed, Feb 14, 2018 at 11:07 PM, Sebastian Reichel > <sebastian.reichel@collabora.co.uk> wrote: > > Motorola CPCAP is a PMIC with audio functionality, that can be > > found on Motorola Droid 4 and probably a few other phones from > > Motorola's Droid series. > > > > The driver has been written from scratch using Motorola's Android > > driver, register dumps from running Android and datasheet for NXP > > MC13783UG (which is similar to Motorola CPCAP, but not the same). > > > > The chip provides two audio interfaces, that can be muxed to two > > different audio codecs. One provides support for stereo output > > (named StDAC or HiFi), while the other only provides mono output > > (named Voice). Only the Voice codec provides a Capture interface. > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> > > <snip> > > > --- /dev/null > > +++ b/sound/soc/codecs/cpcap.c > > @@ -0,0 +1,1588 @@ > > +/* > > + * ALSA SoC CPCAP codec driver > > + * > > + * Copyright (C) 2017 - 2018 Sebastian Reichel <sre@kernel.org> > > + * > > + * Very loosely based on original driver from Motorola: > > + * Copyright (C) 2007 - 2009 Motorola, Inc. > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + */ > > Could you consider using the new SPDX tags instead of this fine but > long legalese? [1] Sure. Thanks for the hint. > <snip> > > > +MODULE_ALIAS("platform:cpcap-codec"); > > +MODULE_DESCRIPTION("ASoC CPCAP codec driver"); > > +MODULE_AUTHOR("Sebastian Reichel"); > > +MODULE_LICENSE("GPL"); > > This does not match your license: per module.h, GPL means GPL-2.0 or > later. You notice above is GPL-2.0, not "or later" Indeed. I will fix this in the next revision. > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Sebastian [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-02-16 13:31 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-14 22:07 [PATCHv4 0/4] Motorola Droid 4 Audio Support Sebastian Reichel 2018-02-14 22:07 ` Sebastian Reichel 2018-02-14 22:07 ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel 2018-02-14 22:07 ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Sebastian Reichel 2018-02-16 11:30 ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Mark Brown 2018-02-16 13:25 ` Sebastian Reichel 2018-02-16 13:25 ` Sebastian Reichel 2018-02-16 13:44 ` Mark Brown 2018-02-16 14:12 ` Sebastian Reichel 2018-02-16 15:16 ` Mark Brown 2018-02-16 15:57 ` Tony Lindgren 2018-02-16 15:57 ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Tony Lindgren 2018-02-19 13:05 ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Mark Brown 2018-02-19 13:05 ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Mark Brown 2018-02-22 19:54 ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Tony Lindgren 2018-02-22 19:54 ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Tony Lindgren 2018-02-23 12:47 ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel 2018-02-23 12:47 ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Sebastian Reichel 2018-02-16 15:58 ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel 2018-02-19 13:25 ` Mark Brown 2018-02-19 13:25 ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Mark Brown 2018-02-14 22:07 ` [PATCHv4 2/4] ASoC: codec: cpcap: new codec Sebastian Reichel 2018-02-14 22:07 ` Sebastian Reichel 2018-02-15 9:50 ` Philippe Ombredanne 2018-02-15 9:50 ` Philippe Ombredanne 2018-02-16 13:31 ` Sebastian Reichel [this message] 2018-02-16 13:31 ` Sebastian Reichel 2018-02-16 11:39 ` Mark Brown 2018-02-16 11:39 ` Mark Brown 2018-02-16 13:51 ` Sebastian Reichel 2018-02-16 14:27 ` Mark Brown 2018-02-16 14:27 ` Mark Brown 2018-02-23 8:07 ` Pavel Machek 2018-02-23 8:07 ` Pavel Machek 2018-02-23 12:44 ` Sebastian Reichel 2018-02-23 12:44 ` Sebastian Reichel 2018-02-14 22:07 ` [PATCHv4 3/4] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel 2018-02-14 22:07 ` [PATCHv4 4/4] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel 2018-02-14 22:07 ` Sebastian Reichel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180216133114.6ynx36b5cpfvkebd@earth.universe \ --to=sebastian.reichel@collabora.co.uk \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=perex@perex.cz \ --cc=pombredanne@nexb.com \ --cc=robh+dt@kernel.org \ --cc=tiwai@suse.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.