All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@kernel.org>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec
Date: Thu, 22 Feb 2018 11:54:19 -0800	[thread overview]
Message-ID: <20180222195418.GC5184@atomide.com> (raw)
In-Reply-To: <20180219130514.GC32761@sirena.org.uk>

* Mark Brown <broonie@kernel.org> [180219 12:05]:
> On Fri, Feb 16, 2018 at 07:57:07AM -0800, Tony Lindgren wrote:
> > One advantage of using a compatible property for the pmic subdevices
> > though is that it leaves out a dependency between various device
> > drivers things happen automagically. The mfd core driver can be
> > minimal and just implement interrupt handling and regmap. So no need
> > to to parse the child nodes in the pmic mfd driver :)
> 
> There's no need to do that anyway - with a MFD the child devices can
> assume that they're part of the MFD and reference their parent.
> 
> > So personally I'd prefer the option that requires least amount
> > of custom code if compatible vs no compatible property is the
> > only issue here.
> 
> It's a few lines of code to register the child devices from code rather
> than the DT, and keeps it out of the ABI.

OK yeah that's a good point with avoiding the ABI. Seems
we still want the dts child node(s) though. That way audio
device can be disabled for devices where audio is not wired
up at all on this PMIC.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Subject: Re: [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec
Date: Thu, 22 Feb 2018 11:54:19 -0800	[thread overview]
Message-ID: <20180222195418.GC5184@atomide.com> (raw)
In-Reply-To: <20180219130514.GC32761@sirena.org.uk>

* Mark Brown <broonie@kernel.org> [180219 12:05]:
> On Fri, Feb 16, 2018 at 07:57:07AM -0800, Tony Lindgren wrote:
> > One advantage of using a compatible property for the pmic subdevices
> > though is that it leaves out a dependency between various device
> > drivers things happen automagically. The mfd core driver can be
> > minimal and just implement interrupt handling and regmap. So no need
> > to to parse the child nodes in the pmic mfd driver :)
> 
> There's no need to do that anyway - with a MFD the child devices can
> assume that they're part of the MFD and reference their parent.
> 
> > So personally I'd prefer the option that requires least amount
> > of custom code if compatible vs no compatible property is the
> > only issue here.
> 
> It's a few lines of code to register the child devices from code rather
> than the DT, and keeps it out of the ABI.

OK yeah that's a good point with avoiding the ABI. Seems
we still want the dts child node(s) though. That way audio
device can be disabled for devices where audio is not wired
up at all on this PMIC.

Regards,

Tony

  reply	other threads:[~2018-02-22 19:54 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 22:07 [PATCHv4 0/4] Motorola Droid 4 Audio Support Sebastian Reichel
2018-02-14 22:07 ` Sebastian Reichel
2018-02-14 22:07 ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel
2018-02-14 22:07   ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Sebastian Reichel
2018-02-16 11:30   ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Mark Brown
2018-02-16 13:25     ` Sebastian Reichel
2018-02-16 13:25       ` Sebastian Reichel
2018-02-16 13:44       ` Mark Brown
2018-02-16 14:12         ` Sebastian Reichel
2018-02-16 15:16           ` Mark Brown
2018-02-16 15:57             ` Tony Lindgren
2018-02-16 15:57               ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Tony Lindgren
2018-02-19 13:05               ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Mark Brown
2018-02-19 13:05                 ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Mark Brown
2018-02-22 19:54                 ` Tony Lindgren [this message]
2018-02-22 19:54                   ` Tony Lindgren
2018-02-23 12:47                   ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel
2018-02-23 12:47                     ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Sebastian Reichel
2018-02-16 15:58             ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel
2018-02-19 13:25               ` Mark Brown
2018-02-19 13:25                 ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Mark Brown
2018-02-14 22:07 ` [PATCHv4 2/4] ASoC: codec: cpcap: new codec Sebastian Reichel
2018-02-14 22:07   ` Sebastian Reichel
2018-02-15  9:50   ` Philippe Ombredanne
2018-02-15  9:50     ` Philippe Ombredanne
2018-02-16 13:31     ` Sebastian Reichel
2018-02-16 13:31       ` Sebastian Reichel
2018-02-16 11:39   ` Mark Brown
2018-02-16 11:39     ` Mark Brown
2018-02-16 13:51     ` Sebastian Reichel
2018-02-16 14:27       ` Mark Brown
2018-02-16 14:27         ` Mark Brown
2018-02-23  8:07         ` Pavel Machek
2018-02-23  8:07           ` Pavel Machek
2018-02-23 12:44           ` Sebastian Reichel
2018-02-23 12:44             ` Sebastian Reichel
2018-02-14 22:07 ` [PATCHv4 3/4] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel
2018-02-14 22:07 ` [PATCHv4 4/4] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel
2018-02-14 22:07   ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222195418.GC5184@atomide.com \
    --to=tony@atomide.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.reichel@collabora.co.uk \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.