From: Rob Herring <robh@kernel.org>
To: Li Jun <jun.li@nxp.com>
Cc: gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
linux@roeck-us.net, a.hajda@samsung.com, mark.rutland@arm.com,
yueyao@google.com, peter.chen@nxp.com, garsilva@embeddedor.com,
o_leveque@orange.fr, shufan_lee@richtek.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-imx@nxp.com
Subject: Re: [PATCH v2 11/12] dt-bindings: usb: add documentation for typec port controller(TCPCI)
Date: Fri, 2 Mar 2018 16:56:07 -0600 [thread overview]
Message-ID: <20180302225607.75fj3n7qzdhevkeg@rob-hp-laptop> (raw)
In-Reply-To: <1519645759-12701-12-git-send-email-jun.li@nxp.com>
On Mon, Feb 26, 2018 at 07:49:18PM +0800, Li Jun wrote:
> TCPCI stands for typec port controller interface, its implementation
> has full typec port control with power delivery support, it's a
> standard i2c slave with GPIO input as irq interface, detail see spec
> "Universal Serial Bus Type-C Port Controller Interface Specification
> Revision 1.0, Version 1.1"
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
> Change for v2:
> - Use usb connector sub-node accordingly to specify typec properties.
>
> .../devicetree/bindings/usb/typec-tcpci.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/typec-tcpci.txt b/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> new file mode 100644
> index 0000000..318bf01
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> @@ -0,0 +1,35 @@
> +TCPCI(Typec port cotroller interface) binding
> +---------------------------------------------
> +
> +Required properties:
> +- compatible: should be "usb,tcpci".
usb is not a vendor. I'd do "usb-tcpci".
This will need chip specific compatible strings too.
> +- reg: the i2c slave address of typec port controller device.
> +- interrupt-parent: the phandle to the interrupt controller which provides
> + the interrupt.
> +- interrupts: interrupt specification for tcpci alert.
> +
> +Required sub-node:
> +- connector: The "usb-c-connector" attached to the tcpci chip, the bindings
> + of connector node are specified in
> + Documentation/devicetree/bindings/connector/usb-connector.txt
> +
> +Example:
> +
> +ptn5110@50 {
> + compatible = "usb,tcpci";
> + reg = <0x50>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> +
> + usb_con: connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + port-type = "dual";
> + default-role = "sink";
> + src-pdos = <0x380190c8>;
> + snk-pdos = <0x380190c8 0x3802d0c8>;
> + max-snk-mv = <9000>;
> + max-snk-ma = <1000>;
> + op-snk-mw = <9000>;
> + };
> +};
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Li Jun <jun.li@nxp.com>
Cc: gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
linux@roeck-us.net, a.hajda@samsung.com, mark.rutland@arm.com,
yueyao@google.com, peter.chen@nxp.com, garsilva@embeddedor.com,
o_leveque@orange.fr, shufan_lee@richtek.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-imx@nxp.com
Subject: [v2,11/12] dt-bindings: usb: add documentation for typec port controller(TCPCI)
Date: Fri, 2 Mar 2018 16:56:07 -0600 [thread overview]
Message-ID: <20180302225607.75fj3n7qzdhevkeg@rob-hp-laptop> (raw)
On Mon, Feb 26, 2018 at 07:49:18PM +0800, Li Jun wrote:
> TCPCI stands for typec port controller interface, its implementation
> has full typec port control with power delivery support, it's a
> standard i2c slave with GPIO input as irq interface, detail see spec
> "Universal Serial Bus Type-C Port Controller Interface Specification
> Revision 1.0, Version 1.1"
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
> Change for v2:
> - Use usb connector sub-node accordingly to specify typec properties.
>
> .../devicetree/bindings/usb/typec-tcpci.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/typec-tcpci.txt b/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> new file mode 100644
> index 0000000..318bf01
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> @@ -0,0 +1,35 @@
> +TCPCI(Typec port cotroller interface) binding
> +---------------------------------------------
> +
> +Required properties:
> +- compatible: should be "usb,tcpci".
usb is not a vendor. I'd do "usb-tcpci".
This will need chip specific compatible strings too.
> +- reg: the i2c slave address of typec port controller device.
> +- interrupt-parent: the phandle to the interrupt controller which provides
> + the interrupt.
> +- interrupts: interrupt specification for tcpci alert.
> +
> +Required sub-node:
> +- connector: The "usb-c-connector" attached to the tcpci chip, the bindings
> + of connector node are specified in
> + Documentation/devicetree/bindings/connector/usb-connector.txt
> +
> +Example:
> +
> +ptn5110@50 {
> + compatible = "usb,tcpci";
> + reg = <0x50>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> +
> + usb_con: connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + port-type = "dual";
> + default-role = "sink";
> + src-pdos = <0x380190c8>;
> + snk-pdos = <0x380190c8 0x3802d0c8>;
> + max-snk-mv = <9000>;
> + max-snk-ma = <1000>;
> + op-snk-mw = <9000>;
> + };
> +};
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-02 22:56 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 11:49 [PATCH v2 00/12] staging: typec: tcpci: move out of staging Li Jun
2018-02-26 11:49 ` [PATCH v2 01/12] usb: typec: add API to get port type and preferred role Li Jun
2018-02-26 11:49 ` [v2,01/12] " Jun Li
2018-02-26 13:19 ` [PATCH v2 01/12] " Heikki Krogerus
2018-02-26 13:19 ` [v2,01/12] " Heikki Krogerus
2018-03-05 7:54 ` [PATCH v2 01/12] " Jun Li
2018-03-05 7:54 ` [v2,01/12] " Jun Li
2018-02-26 11:49 ` [PATCH v2 02/12] usb: typec: add API to get sink and source config Li Jun
2018-02-26 11:49 ` [v2,02/12] " Jun Li
2018-02-26 13:32 ` [PATCH v2 02/12] " Heikki Krogerus
2018-02-26 13:32 ` [v2,02/12] " Heikki Krogerus
2018-03-05 8:40 ` [PATCH v2 02/12] " Jun Li
2018-03-05 8:40 ` [v2,02/12] " Jun Li
2018-02-26 11:49 ` [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt Li Jun
2018-02-26 11:49 ` [v2,03/12] " Jun Li
2018-02-26 14:06 ` [PATCH v2 03/12] " Heikki Krogerus
2018-02-26 14:06 ` [v2,03/12] " Heikki Krogerus
2018-02-26 14:30 ` [PATCH v2 03/12] " Jun Li
2018-02-26 14:30 ` [v2,03/12] " Jun Li
2018-02-27 11:03 ` [PATCH v2 03/12] " Heikki Krogerus
2018-02-27 11:03 ` [v2,03/12] " Heikki Krogerus
2018-03-05 8:53 ` [PATCH v2 03/12] " Jun Li
2018-03-05 8:53 ` [v2,03/12] " Jun Li
2018-03-05 9:53 ` [PATCH v2 03/12] " Heikki Krogerus
2018-03-05 9:53 ` [v2,03/12] " Heikki Krogerus
2018-03-05 10:35 ` [PATCH v2 03/12] " Jun Li
2018-03-05 10:35 ` [v2,03/12] " Jun Li
2018-03-05 11:30 ` [PATCH v2 03/12] " Heikki Krogerus
2018-03-05 11:30 ` [v2,03/12] " Heikki Krogerus
2018-03-05 12:38 ` [PATCH v2 03/12] " Jun Li
2018-03-05 12:38 ` [v2,03/12] " Jun Li
2018-02-26 11:49 ` [PATCH v2 04/12] staging: typec: tcpci: register port before request irq Li Jun
2018-02-26 11:49 ` [v2,04/12] " Jun Li
2018-02-26 11:49 ` [PATCH v2 05/12] staging: typec: tcpci: enable vbus detection Li Jun
2018-02-26 11:49 ` [v2,05/12] " Jun Li
2018-02-26 11:49 ` [PATCH v2 06/12] typec: tcpm: add starting value for drp toggling Li Jun
2018-02-26 11:49 ` [v2,06/12] " Jun Li
2018-02-26 11:49 ` [PATCH v2 07/12] staging: typec: tcpci: correct " Li Jun
2018-02-26 11:49 ` [v2,07/12] " Jun Li
2018-02-26 11:49 ` [PATCH v2 08/12] staging: typec: tcpci: keep the uncontact cc line open Li Jun
2018-02-26 11:49 ` [v2,08/12] " Jun Li
2018-02-26 11:49 ` [PATCH v2 09/12] staging: typec: tcpci: Only touch target bit when enable vconn Li Jun
2018-02-26 11:49 ` [v2,09/12] " Jun Li
2018-02-26 11:49 ` [PATCH v2 10/12] dt-bindings: connector: add properties for typec power delivery Li Jun
2018-02-26 11:49 ` [v2,10/12] " Jun Li
2018-02-27 8:41 ` [PATCH v2 10/12] " Andrzej Hajda
2018-02-27 8:41 ` [v2,10/12] " Andrzej Hajda
2018-03-02 22:38 ` [PATCH v2 10/12] " Rob Herring
2018-03-02 22:38 ` [v2,10/12] " Rob Herring
2018-03-05 7:52 ` [PATCH v2 10/12] " Jun Li
2018-03-05 7:52 ` [v2,10/12] " Jun Li
2018-03-05 12:25 ` [PATCH v2 10/12] " Jun Li
2018-03-05 12:25 ` [v2,10/12] " Jun Li
2018-03-05 7:00 ` [PATCH v2 10/12] " Jun Li
2018-03-05 7:00 ` [v2,10/12] " Jun Li
2018-03-05 9:59 ` [PATCH v2 10/12] " Andrzej Hajda
2018-03-05 9:59 ` [v2,10/12] " Andrzej Hajda
2018-03-06 9:38 ` [PATCH v2 10/12] " Jun Li
2018-03-06 9:38 ` [v2,10/12] " Jun Li
2018-03-06 11:54 ` [PATCH v2 10/12] " Andrzej Hajda
2018-03-06 11:54 ` [v2,10/12] " Andrzej Hajda
2018-03-06 12:02 ` [PATCH v2 10/12] " Heikki Krogerus
2018-03-06 12:02 ` [v2,10/12] " Heikki Krogerus
2018-03-08 1:41 ` [PATCH v2 10/12] " Jun Li
2018-03-08 1:41 ` [v2,10/12] " Jun Li
2018-03-09 7:34 ` [PATCH v2 10/12] " Heikki Krogerus
2018-03-09 7:34 ` [v2,10/12] " Heikki Krogerus
2018-03-02 22:29 ` [PATCH v2 10/12] " Rob Herring
2018-03-02 22:29 ` [v2,10/12] " Rob Herring
2018-03-05 7:07 ` [PATCH v2 10/12] " Jun Li
2018-03-05 7:07 ` [v2,10/12] " Jun Li
2018-02-26 11:49 ` [PATCH v2 11/12] dt-bindings: usb: add documentation for typec port controller(TCPCI) Li Jun
2018-02-26 11:49 ` [v2,11/12] " Jun Li
2018-03-02 22:56 ` Rob Herring [this message]
2018-03-02 22:56 ` Rob Herring
2018-02-26 11:49 ` [PATCH v2 12/12] staging: typec: tcpci: move tcpci driver out of staging Li Jun
2018-02-26 11:49 ` [v2,12/12] " Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302225607.75fj3n7qzdhevkeg@rob-hp-laptop \
--to=robh@kernel.org \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=o_leveque@orange.fr \
--cc=peter.chen@nxp.com \
--cc=shufan_lee@richtek.com \
--cc=yueyao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.