From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tomas Winkler <tomas.winkler@intel.com>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Alexander Usyskin <alexander.usyskin@intel.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] tpm_crb: use __le64 annotated variable for response buffer address
Date: Tue, 6 Mar 2018 10:28:21 +0200 [thread overview]
Message-ID: <20180306082821.GB5705@linux.intel.com> (raw)
In-Reply-To: <20180305130320.GC3425@linux.intel.com>
On Mon, Mar 05, 2018 at 03:03:20PM +0200, Jarkko Sakkinen wrote:
> On Sun, Mar 04, 2018 at 02:12:05PM +0200, Tomas Winkler wrote:
> > This suppresses sparse warning
> > drivers/char/tpm/tpm_crb.c:558:18: warning: cast to restricted __le64
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > ---
> > drivers/char/tpm/tpm_crb.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> The guideline is that you should describe what is wrong rather than
> copy-paste the sparse message.
Jason, didn't yo give the feedback to some patch 1-2 years ago that
instead of copy-pasting parse error one should write a clear commit
msg or is this OK?
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 3/3] tpm_crb: use __le64 annotated variable for response buffer address
Date: Tue, 6 Mar 2018 10:28:21 +0200 [thread overview]
Message-ID: <20180306082821.GB5705@linux.intel.com> (raw)
In-Reply-To: <20180305130320.GC3425@linux.intel.com>
On Mon, Mar 05, 2018 at 03:03:20PM +0200, Jarkko Sakkinen wrote:
> On Sun, Mar 04, 2018 at 02:12:05PM +0200, Tomas Winkler wrote:
> > This suppresses sparse warning
> > drivers/char/tpm/tpm_crb.c:558:18: warning: cast to restricted __le64
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > ---
> > drivers/char/tpm/tpm_crb.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> The guideline is that you should describe what is wrong rather than
> copy-paste the sparse message.
Jason, didn't yo give the feedback to some patch 1-2 years ago that
instead of copy-pasting parse error one should write a clear commit
msg or is this OK?
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-06 8:28 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 12:12 [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands Tomas Winkler
2018-03-04 12:12 ` Tomas Winkler
2018-03-04 12:12 ` [PATCH 2/3] tpm: add new tpm2 commands according to TCG 1.36 Tomas Winkler
2018-03-04 12:12 ` Tomas Winkler
2018-03-05 13:02 ` Jarkko Sakkinen
2018-03-05 13:02 ` Jarkko Sakkinen
2018-03-04 12:12 ` [PATCH 3/3] tpm_crb: use __le64 annotated variable for response buffer address Tomas Winkler
2018-03-04 12:12 ` Tomas Winkler
2018-03-05 13:03 ` Jarkko Sakkinen
2018-03-05 13:03 ` Jarkko Sakkinen
2018-03-06 8:28 ` Jarkko Sakkinen [this message]
2018-03-06 8:28 ` Jarkko Sakkinen
2018-03-06 8:34 ` Winkler, Tomas
2018-03-06 8:34 ` Winkler, Tomas
2018-03-06 15:39 ` Jason Gunthorpe
2018-03-06 15:39 ` Jason Gunthorpe
2018-03-05 12:56 ` [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands Jarkko Sakkinen
2018-03-05 12:56 ` Jarkko Sakkinen
2018-03-05 13:09 ` Winkler, Tomas
2018-03-05 13:09 ` Winkler, Tomas
2018-03-05 17:59 ` Jarkko Sakkinen
2018-03-05 17:59 ` Jarkko Sakkinen
2018-03-05 18:04 ` Winkler, Tomas
2018-03-05 18:04 ` Winkler, Tomas
2018-03-06 8:02 ` Jarkko Sakkinen
2018-03-06 8:02 ` Jarkko Sakkinen
2018-03-06 8:09 ` Winkler, Tomas
2018-03-06 8:09 ` Winkler, Tomas
2018-03-06 7:49 ` Jarkko Sakkinen
2018-03-06 7:49 ` Jarkko Sakkinen
2018-03-06 8:06 ` Winkler, Tomas
2018-03-06 8:06 ` Winkler, Tomas
2018-03-06 16:32 ` James Bottomley
2018-03-06 16:32 ` James Bottomley
2018-03-06 16:32 ` James Bottomley
2018-03-06 16:45 ` Winkler, Tomas
2018-03-06 16:45 ` Winkler, Tomas
2018-03-06 16:45 ` Winkler, Tomas
2018-03-06 18:36 ` Mimi Zohar
2018-03-06 18:36 ` Mimi Zohar
2018-03-06 18:36 ` Mimi Zohar
2018-03-06 21:59 ` Jason Gunthorpe
2018-03-06 21:59 ` Jason Gunthorpe
2018-03-06 21:59 ` Jason Gunthorpe
2018-03-07 15:22 ` Mimi Zohar
2018-03-07 15:22 ` Mimi Zohar
2018-03-07 15:22 ` Mimi Zohar
2018-03-07 15:41 ` Winkler, Tomas
2018-03-07 15:41 ` Winkler, Tomas
2018-03-07 15:41 ` Winkler, Tomas
2018-03-07 15:54 ` Jonathan Corbet
2018-03-07 15:54 ` Jonathan Corbet
2018-03-07 16:04 ` Winkler, Tomas
2018-03-07 16:35 ` Mimi Zohar
2018-03-07 16:35 ` Mimi Zohar
2018-03-07 18:24 ` Jonathan Corbet
2018-03-07 18:24 ` Jonathan Corbet
2018-03-10 12:46 ` Jarkko Sakkinen
2018-03-10 12:46 ` Jarkko Sakkinen
2018-03-10 12:44 ` Jarkko Sakkinen
2018-03-10 12:44 ` Jarkko Sakkinen
2018-03-10 12:37 ` Jarkko Sakkinen
2018-03-10 12:37 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306082821.GB5705@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=alexander.usyskin@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.