From: "Winkler, Tomas" <tomas.winkler@intel.com> To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Cc: Jason Gunthorpe <jgg@ziepe.ca>, "Usyskin, Alexander" <alexander.usyskin@intel.com>, "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>, "linux-security-module@vger.kernel.org" <linux-security-module@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands. Date: Mon, 5 Mar 2018 18:04:56 +0000 [thread overview] Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9422E568@hasmsx108.ger.corp.intel.com> (raw) In-Reply-To: <20180305175912.GD5791@linux.intel.com> > > On Mon, Mar 05, 2018 at 01:09:09PM +0000, Winkler, Tomas wrote: > > > enum tpm_duration { > > > TPM_DURATION_DEFAULT = 2000, > > > TPM_DURATION_LONG = 300000, > > > }; > > > > > How is this aligned with the spec PTP spec? > > For TPM 2.0 that spec only partially defines durations for CCs and thus our > look up table is already kind "flakky". In a sense that the default duration is > upper limit for spec defined durations. The timeouts for LONG and MEDIUM is defined by the PTP spec, we need to maintain those as those effect the system. The UNDEFINED and LONG LONG is the implementation choice we driver from empirical data we have so far. > > > > These would be both for TPM 1.2 and TPM 2.0. Instead of having table > > > for every ordinal there should be a small tables describing commands > > > that require long timeout. > > > > Yeah I didn't cover the 1.2. > > I could probably help with TPM 1.2 changes if required. In middle of it, will send for review in few. Thanks Tomas
WARNING: multiple messages have this Message-ID (diff)
From: tomas.winkler@intel.com (Winkler, Tomas) To: linux-security-module@vger.kernel.org Subject: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands. Date: Mon, 5 Mar 2018 18:04:56 +0000 [thread overview] Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9422E568@hasmsx108.ger.corp.intel.com> (raw) In-Reply-To: <20180305175912.GD5791@linux.intel.com> > > On Mon, Mar 05, 2018 at 01:09:09PM +0000, Winkler, Tomas wrote: > > > enum tpm_duration { > > > TPM_DURATION_DEFAULT = 2000, > > > TPM_DURATION_LONG = 300000, > > > }; > > > > > How is this aligned with the spec PTP spec? > > For TPM 2.0 that spec only partially defines durations for CCs and thus our > look up table is already kind "flakky". In a sense that the default duration is > upper limit for spec defined durations. The timeouts for LONG and MEDIUM is defined by the PTP spec, we need to maintain those as those effect the system. The UNDEFINED and LONG LONG is the implementation choice we driver from empirical data we have so far. > > > > These would be both for TPM 1.2 and TPM 2.0. Instead of having table > > > for every ordinal there should be a small tables describing commands > > > that require long timeout. > > > > Yeah I didn't cover the 1.2. > > I could probably help with TPM 1.2 changes if required. In middle of it, will send for review in few. Thanks Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-05 18:05 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-04 12:12 [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands Tomas Winkler 2018-03-04 12:12 ` Tomas Winkler 2018-03-04 12:12 ` [PATCH 2/3] tpm: add new tpm2 commands according to TCG 1.36 Tomas Winkler 2018-03-04 12:12 ` Tomas Winkler 2018-03-05 13:02 ` Jarkko Sakkinen 2018-03-05 13:02 ` Jarkko Sakkinen 2018-03-04 12:12 ` [PATCH 3/3] tpm_crb: use __le64 annotated variable for response buffer address Tomas Winkler 2018-03-04 12:12 ` Tomas Winkler 2018-03-05 13:03 ` Jarkko Sakkinen 2018-03-05 13:03 ` Jarkko Sakkinen 2018-03-06 8:28 ` Jarkko Sakkinen 2018-03-06 8:28 ` Jarkko Sakkinen 2018-03-06 8:34 ` Winkler, Tomas 2018-03-06 8:34 ` Winkler, Tomas 2018-03-06 15:39 ` Jason Gunthorpe 2018-03-06 15:39 ` Jason Gunthorpe 2018-03-05 12:56 ` [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands Jarkko Sakkinen 2018-03-05 12:56 ` Jarkko Sakkinen 2018-03-05 13:09 ` Winkler, Tomas 2018-03-05 13:09 ` Winkler, Tomas 2018-03-05 17:59 ` Jarkko Sakkinen 2018-03-05 17:59 ` Jarkko Sakkinen 2018-03-05 18:04 ` Winkler, Tomas [this message] 2018-03-05 18:04 ` Winkler, Tomas 2018-03-06 8:02 ` Jarkko Sakkinen 2018-03-06 8:02 ` Jarkko Sakkinen 2018-03-06 8:09 ` Winkler, Tomas 2018-03-06 8:09 ` Winkler, Tomas 2018-03-06 7:49 ` Jarkko Sakkinen 2018-03-06 7:49 ` Jarkko Sakkinen 2018-03-06 8:06 ` Winkler, Tomas 2018-03-06 8:06 ` Winkler, Tomas 2018-03-06 16:32 ` James Bottomley 2018-03-06 16:32 ` James Bottomley 2018-03-06 16:32 ` James Bottomley 2018-03-06 16:45 ` Winkler, Tomas 2018-03-06 16:45 ` Winkler, Tomas 2018-03-06 16:45 ` Winkler, Tomas 2018-03-06 18:36 ` Mimi Zohar 2018-03-06 18:36 ` Mimi Zohar 2018-03-06 18:36 ` Mimi Zohar 2018-03-06 21:59 ` Jason Gunthorpe 2018-03-06 21:59 ` Jason Gunthorpe 2018-03-06 21:59 ` Jason Gunthorpe 2018-03-07 15:22 ` Mimi Zohar 2018-03-07 15:22 ` Mimi Zohar 2018-03-07 15:22 ` Mimi Zohar 2018-03-07 15:41 ` Winkler, Tomas 2018-03-07 15:41 ` Winkler, Tomas 2018-03-07 15:41 ` Winkler, Tomas 2018-03-07 15:54 ` Jonathan Corbet 2018-03-07 15:54 ` Jonathan Corbet 2018-03-07 16:04 ` Winkler, Tomas 2018-03-07 16:35 ` Mimi Zohar 2018-03-07 16:35 ` Mimi Zohar 2018-03-07 18:24 ` Jonathan Corbet 2018-03-07 18:24 ` Jonathan Corbet 2018-03-10 12:46 ` Jarkko Sakkinen 2018-03-10 12:46 ` Jarkko Sakkinen 2018-03-10 12:44 ` Jarkko Sakkinen 2018-03-10 12:44 ` Jarkko Sakkinen 2018-03-10 12:37 ` Jarkko Sakkinen 2018-03-10 12:37 ` Jarkko Sakkinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5B8DA87D05A7694D9FA63FD143655C1B9422E568@hasmsx108.ger.corp.intel.com \ --to=tomas.winkler@intel.com \ --cc=alexander.usyskin@intel.com \ --cc=jarkko.sakkinen@linux.intel.com \ --cc=jgg@ziepe.ca \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.