* [PATCH] fstests: btrfs/004: increase the buffer size of logical-resolve to the maximum value 64K
@ 2018-03-06 7:02 Lu Fengqi
2018-03-07 7:07 ` Eryu Guan
0 siblings, 1 reply; 3+ messages in thread
From: Lu Fengqi @ 2018-03-06 7:02 UTC (permalink / raw)
To: linux-btrfs, fstests
Because of commit e76e13ce8c0b ("fsstress: implement the
clonerange/deduperange ioctls"), dedupe makes the number of references to
the same extent item increase so much that the default 4K buffer of
logical-resolve is no longer sufficient.
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
---
tests/btrfs/004 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/btrfs/004 b/tests/btrfs/004
index de583cc355d4..0d2efb91dba7 100755
--- a/tests/btrfs/004
+++ b/tests/btrfs/004
@@ -103,7 +103,7 @@ _btrfs_inspect_addr()
expect_addr=$3
expect_inum=$4
file=$5
- cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -P $addr $mp"
+ cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -s 65536 -P $addr $mp"
echo "# $cmd" >> $seqres.full
out=`$cmd`
echo "$out" >> $seqres.full
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fstests: btrfs/004: increase the buffer size of logical-resolve to the maximum value 64K
2018-03-06 7:02 [PATCH] fstests: btrfs/004: increase the buffer size of logical-resolve to the maximum value 64K Lu Fengqi
@ 2018-03-07 7:07 ` Eryu Guan
2018-03-07 13:07 ` Filipe Manana
0 siblings, 1 reply; 3+ messages in thread
From: Eryu Guan @ 2018-03-07 7:07 UTC (permalink / raw)
To: Lu Fengqi; +Cc: linux-btrfs, fstests
On Tue, Mar 06, 2018 at 03:02:31PM +0800, Lu Fengqi wrote:
> Because of commit e76e13ce8c0b ("fsstress: implement the
> clonerange/deduperange ioctls"), dedupe makes the number of references to
> the same extent item increase so much that the default 4K buffer of
> logical-resolve is no longer sufficient.
>
> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
This looks fine to me. But I'd like an explicit ack from btrfs
developers.
Thanks,
Eryu
> ---
> tests/btrfs/004 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/004 b/tests/btrfs/004
> index de583cc355d4..0d2efb91dba7 100755
> --- a/tests/btrfs/004
> +++ b/tests/btrfs/004
> @@ -103,7 +103,7 @@ _btrfs_inspect_addr()
> expect_addr=$3
> expect_inum=$4
> file=$5
> - cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -P $addr $mp"
> + cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -s 65536 -P $addr $mp"
> echo "# $cmd" >> $seqres.full
> out=`$cmd`
> echo "$out" >> $seqres.full
> --
> 2.16.2
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fstests: btrfs/004: increase the buffer size of logical-resolve to the maximum value 64K
2018-03-07 7:07 ` Eryu Guan
@ 2018-03-07 13:07 ` Filipe Manana
0 siblings, 0 replies; 3+ messages in thread
From: Filipe Manana @ 2018-03-07 13:07 UTC (permalink / raw)
To: Eryu Guan; +Cc: Lu Fengqi, linux-btrfs, fstests
On Wed, Mar 7, 2018 at 7:07 AM, Eryu Guan <guaneryu@gmail.com> wrote:
> On Tue, Mar 06, 2018 at 03:02:31PM +0800, Lu Fengqi wrote:
>> Because of commit e76e13ce8c0b ("fsstress: implement the
>> clonerange/deduperange ioctls"), dedupe makes the number of references to
>> the same extent item increase so much that the default 4K buffer of
>> logical-resolve is no longer sufficient.
>>
>> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
>
> This looks fine to me. But I'd like an explicit ack from btrfs
> developers.
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Looks good to me.
>
> Thanks,
> Eryu
>
>> ---
>> tests/btrfs/004 | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/btrfs/004 b/tests/btrfs/004
>> index de583cc355d4..0d2efb91dba7 100755
>> --- a/tests/btrfs/004
>> +++ b/tests/btrfs/004
>> @@ -103,7 +103,7 @@ _btrfs_inspect_addr()
>> expect_addr=$3
>> expect_inum=$4
>> file=$5
>> - cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -P $addr $mp"
>> + cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -s 65536 -P $addr $mp"
>> echo "# $cmd" >> $seqres.full
>> out=`$cmd`
>> echo "$out" >> $seqres.full
>> --
>> 2.16.2
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe fstests" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Filipe David Manana,
“Whether you think you can, or you think you can't — you're right.”
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-07 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-06 7:02 [PATCH] fstests: btrfs/004: increase the buffer size of logical-resolve to the maximum value 64K Lu Fengqi
2018-03-07 7:07 ` Eryu Guan
2018-03-07 13:07 ` Filipe Manana
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.