[PATCH] fstests: btrfs/004: increase the buffer size of logical-resolve to the maximum value 64K

[PATCH] fstests: btrfs/004: increase the buffer size of logical-resolve to the maximum value 64K

[Lu Fengqi]

Because of commit e76e13ce8c0b ("fsstress: implement the
clonerange/deduperange ioctls"), dedupe makes the number of references to
the same extent item increase so much that the default 4K buffer of
logical-resolve is no longer sufficient.

Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
---
 tests/btrfs/004 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/btrfs/004 b/tests/btrfs/004
index de583cc355d4..0d2efb91dba7 100755
--- a/tests/btrfs/004
+++ b/tests/btrfs/004
@@ -103,7 +103,7 @@ _btrfs_inspect_addr()
 	expect_addr=$3
 	expect_inum=$4
 	file=$5
-	cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -P $addr $mp"
+	cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -s 65536 -P $addr $mp"
 	echo "# $cmd" >> $seqres.full
 	out=`$cmd`
 	echo "$out" >> $seqres.full
-- 
2.16.2

Re: [PATCH] fstests: btrfs/004: increase the buffer size of logical-resolve to the maximum value 64K

[Eryu Guan]

On Tue, Mar 06, 2018 at 03:02:31PM +0800, Lu Fengqi wrote:
> Because of commit e76e13ce8c0b ("fsstress: implement the
> clonerange/deduperange ioctls"), dedupe makes the number of references to
> the same extent item increase so much that the default 4K buffer of
> logical-resolve is no longer sufficient.
> 
> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>

This looks fine to me. But I'd like an explicit ack from btrfs
developers.

Thanks,
Eryu

> ---
>  tests/btrfs/004 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/btrfs/004 b/tests/btrfs/004
> index de583cc355d4..0d2efb91dba7 100755
> --- a/tests/btrfs/004
> +++ b/tests/btrfs/004
> @@ -103,7 +103,7 @@ _btrfs_inspect_addr()
>  	expect_addr=$3
>  	expect_inum=$4
>  	file=$5
> -	cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -P $addr $mp"
> +	cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -s 65536 -P $addr $mp"
>  	echo "# $cmd" >> $seqres.full
>  	out=`$cmd`
>  	echo "$out" >> $seqres.full
> -- 
> 2.16.2
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fstests: btrfs/004: increase the buffer size of logical-resolve to the maximum value 64K

[Filipe Manana]

On Wed, Mar 7, 2018 at 7:07 AM, Eryu Guan <guaneryu@gmail.com> wrote:
> On Tue, Mar 06, 2018 at 03:02:31PM +0800, Lu Fengqi wrote:
>> Because of commit e76e13ce8c0b ("fsstress: implement the
>> clonerange/deduperange ioctls"), dedupe makes the number of references to
>> the same extent item increase so much that the default 4K buffer of
>> logical-resolve is no longer sufficient.
>>
>> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
>
> This looks fine to me. But I'd like an explicit ack from btrfs
> developers.

Reviewed-by: Filipe Manana <fdmanana@suse.com>

Looks good to me.

>
> Thanks,
> Eryu
>
>> ---
>>  tests/btrfs/004 | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/btrfs/004 b/tests/btrfs/004
>> index de583cc355d4..0d2efb91dba7 100755
>> --- a/tests/btrfs/004
>> +++ b/tests/btrfs/004
>> @@ -103,7 +103,7 @@ _btrfs_inspect_addr()
>>       expect_addr=$3
>>       expect_inum=$4
>>       file=$5
>> -     cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -P $addr $mp"
>> +     cmd="$BTRFS_UTIL_PROG inspect-internal logical-resolve -s 65536 -P $addr $mp"
>>       echo "# $cmd" >> $seqres.full
>>       out=`$cmd`
>>       echo "$out" >> $seqres.full
>> --
>> 2.16.2
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe fstests" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”