From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Agustin Vega-Frias <agustinv@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
timur@codeaurora.org
Subject: Re: [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events
Date: Thu, 8 Mar 2018 10:03:58 -0300 [thread overview]
Message-ID: <20180308130358.GC3701@kernel.org> (raw)
In-Reply-To: <1520454947-16977-1-git-send-email-agustinv@codeaurora.org>
Em Wed, Mar 07, 2018 at 03:35:47PM -0500, Agustin Vega-Frias escreveu:
> +++ b/tools/perf/util/parse-events.y
> @@ -8,6 +8,7 @@
>
> #define YYDEBUG 1
>
> +#include <fnmatch.h>
> #include <linux/compiler.h>
> #include <linux/list.h>
> #include <linux/types.h>
> @@ -234,6 +235,10 @@ PE_NAME opt_event_config
> if (parse_events_add_pmu(_parse_state, list, $1, $2)) {
> struct perf_pmu *pmu = NULL;
> int ok = 0;
> + char *pattern;
> +
> + if (asprintf(&pattern, "%s*", $1) < 0)
> + YYABORT;
+ if (asprintf(&pattern, "?(uncore_)%s*", $1) < 0)
I completely overlook that you were using this and thus needed that
extension, duh, thanks for the patience 8-) and for the new patch.
- Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: acme@kernel.org (Arnaldo Carvalho de Melo)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events
Date: Thu, 8 Mar 2018 10:03:58 -0300 [thread overview]
Message-ID: <20180308130358.GC3701@kernel.org> (raw)
In-Reply-To: <1520454947-16977-1-git-send-email-agustinv@codeaurora.org>
Em Wed, Mar 07, 2018 at 03:35:47PM -0500, Agustin Vega-Frias escreveu:
> +++ b/tools/perf/util/parse-events.y
> @@ -8,6 +8,7 @@
>
> #define YYDEBUG 1
>
> +#include <fnmatch.h>
> #include <linux/compiler.h>
> #include <linux/list.h>
> #include <linux/types.h>
> @@ -234,6 +235,10 @@ PE_NAME opt_event_config
> if (parse_events_add_pmu(_parse_state, list, $1, $2)) {
> struct perf_pmu *pmu = NULL;
> int ok = 0;
> + char *pattern;
> +
> + if (asprintf(&pattern, "%s*", $1) < 0)
> + YYABORT;
+ if (asprintf(&pattern, "?(uncore_)%s*", $1) < 0)
I completely overlook that you were using this and thus needed that
extension, duh, thanks for the patience 8-) and for the new patch.
- Arnaldo
next prev parent reply other threads:[~2018-03-08 13:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 20:35 [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events Agustin Vega-Frias
2018-03-07 20:35 ` Agustin Vega-Frias
2018-03-08 13:03 ` Arnaldo Carvalho de Melo [this message]
2018-03-08 13:03 ` Arnaldo Carvalho de Melo
2018-03-08 13:28 ` Agustin Vega-Frias
2018-03-08 13:28 ` Agustin Vega-Frias
2018-03-08 13:39 ` Arnaldo Carvalho de Melo
2018-03-08 13:39 ` Arnaldo Carvalho de Melo
2018-03-09 8:42 ` [tip:perf/core] perf pmu: " tip-bot for Agustin Vega-Frias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308130358.GC3701@kernel.org \
--to=acme@kernel.org \
--cc=agustinv@codeaurora.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.