From: Arnaldo Carvalho de Melo <acme@kernel.org> To: Agustin Vega-Frias <agustinv@codeaurora.org> Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, timur@codeaurora.org Subject: Re: [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events Date: Thu, 8 Mar 2018 10:39:31 -0300 [thread overview] Message-ID: <20180308133931.GA7273@kernel.org> (raw) In-Reply-To: <ae102272a8186f0351363511f4ed07f8@codeaurora.org> Em Thu, Mar 08, 2018 at 08:28:13AM -0500, Agustin Vega-Frias escreveu: > On 2018-03-08 08:03, Arnaldo Carvalho de Melo wrote: > > Em Wed, Mar 07, 2018 at 03:35:47PM -0500, Agustin Vega-Frias escreveu: > > > +++ b/tools/perf/util/parse-events.y > > > @@ -8,6 +8,7 @@ > > > > > > #define YYDEBUG 1 > > > > > > +#include <fnmatch.h> > > > #include <linux/compiler.h> > > > #include <linux/list.h> > > > #include <linux/types.h> > > > @@ -234,6 +235,10 @@ PE_NAME opt_event_config > > > if (parse_events_add_pmu(_parse_state, list, $1, $2)) { > > > struct perf_pmu *pmu = NULL; > > > int ok = 0; > > > + char *pattern; > > > + > > > + if (asprintf(&pattern, "%s*", $1) < 0) > > > + YYABORT; > > + if (asprintf(&pattern, "?(uncore_)%s*", $1) < 0) > > I completely overlook that you were using this and thus needed that > > extension, duh, thanks for the patience 8-) and for the new patch. Further trying to remove my brown paper bag: I thought the '?(...)' type of thing would be something _users_ would pass on the perf tool command line, not something used by the tool itself, like on the original patch.... :-) > NP Arnaldo, thanks for the quick turnaround on these patches :o) > Just so I know, since these are my first patches on perf tools, > where are perf tools patches queued once acked? git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core If they are super urgent, then they will go to a different branch, perf/urgent, that is targetted for the current merge window, i.e. right now: perf/core -> 4.17 perf/urgent -> 4.16 Thanks, and keep the patches flowing! - Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: acme@kernel.org (Arnaldo Carvalho de Melo) To: linux-arm-kernel@lists.infradead.org Subject: [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events Date: Thu, 8 Mar 2018 10:39:31 -0300 [thread overview] Message-ID: <20180308133931.GA7273@kernel.org> (raw) In-Reply-To: <ae102272a8186f0351363511f4ed07f8@codeaurora.org> Em Thu, Mar 08, 2018 at 08:28:13AM -0500, Agustin Vega-Frias escreveu: > On 2018-03-08 08:03, Arnaldo Carvalho de Melo wrote: > > Em Wed, Mar 07, 2018 at 03:35:47PM -0500, Agustin Vega-Frias escreveu: > > > +++ b/tools/perf/util/parse-events.y > > > @@ -8,6 +8,7 @@ > > > > > > #define YYDEBUG 1 > > > > > > +#include <fnmatch.h> > > > #include <linux/compiler.h> > > > #include <linux/list.h> > > > #include <linux/types.h> > > > @@ -234,6 +235,10 @@ PE_NAME opt_event_config > > > if (parse_events_add_pmu(_parse_state, list, $1, $2)) { > > > struct perf_pmu *pmu = NULL; > > > int ok = 0; > > > + char *pattern; > > > + > > > + if (asprintf(&pattern, "%s*", $1) < 0) > > > + YYABORT; > > + if (asprintf(&pattern, "?(uncore_)%s*", $1) < 0) > > I completely overlook that you were using this and thus needed that > > extension, duh, thanks for the patience 8-) and for the new patch. Further trying to remove my brown paper bag: I thought the '?(...)' type of thing would be something _users_ would pass on the perf tool command line, not something used by the tool itself, like on the original patch.... :-) > NP Arnaldo, thanks for the quick turnaround on these patches :o) > Just so I know, since these are my first patches on perf tools, > where are perf tools patches queued once acked? git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core If they are super urgent, then they will go to a different branch, perf/urgent, that is targetted for the current merge window, i.e. right now: perf/core -> 4.17 perf/urgent -> 4.16 Thanks, and keep the patches flowing! - Arnaldo
next prev parent reply other threads:[~2018-03-08 13:39 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-07 20:35 [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events Agustin Vega-Frias 2018-03-07 20:35 ` Agustin Vega-Frias 2018-03-08 13:03 ` Arnaldo Carvalho de Melo 2018-03-08 13:03 ` Arnaldo Carvalho de Melo 2018-03-08 13:28 ` Agustin Vega-Frias 2018-03-08 13:28 ` Agustin Vega-Frias 2018-03-08 13:39 ` Arnaldo Carvalho de Melo [this message] 2018-03-08 13:39 ` Arnaldo Carvalho de Melo 2018-03-09 8:42 ` [tip:perf/core] perf pmu: " tip-bot for Agustin Vega-Frias
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180308133931.GA7273@kernel.org \ --to=acme@kernel.org \ --cc=agustinv@codeaurora.org \ --cc=ak@linux.intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=jolsa@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=timur@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.