From: Brad Mouring <brad.mouring@ni.com> To: Nicolas Ferre <nicolas.ferre@microchip.com>, Rob Herring <robh+dt@kernel.org>, "David S . Miller" <davem@davemloft.net>, "Michael Grzeschik" <m.grzeschik@pengutronix.de>, Andrew Lunn <andrew@lunn.ch> Cc: Mark Rutland <mark.rutland@arm.com>, <netdev@vger.kernel.org>, "Julia Cartwright" <julia@ni.com>, <devicetree@vger.kernel.org>, Brad Mouring <brad.mouring@ni.com> Subject: [PATCH v2 net-next 2/3] net: macb: Add phy-handle DT support Date: Fri, 9 Mar 2018 16:12:32 -0600 [thread overview] Message-ID: <20180309221233.71202-2-brad.mouring@ni.com> (raw) In-Reply-To: <20180309221233.71202-1-brad.mouring@ni.com> This optional binding (as described in the ethernet DT bindings doc) directs the netdev to the phydev to use. This is useful for a phy chip that has >1 phy in it, and two netdevs are using the same phy chip (i.e. the second mac's phy lives on the first mac's MDIO bus) The devicetree snippet would look something like this: ethernet@feedf00d { ... phy-handle = <&phy0> // the first netdev is physically wired to phy0 ... phy0: phy@0 { ... reg = <0x0> // MDIO address 0 ... } phy1: phy@1 { ... reg = <0x1> // MDIO address 1 ... } ... } ethernet@deadbeef { ... phy-handle = <&phy1> // tells the driver to use phy1 on the // first mac's mdio bus (it's wired thusly) ... } The work done to add the phy_node in the first place (dacdbb4dfc1a1: "net: macb: add fixed-link node support") will consume the device_node (if found). Signed-off-by: Brad Mouring <brad.mouring@ni.com> --- drivers/net/ethernet/cadence/macb_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 7b69a291ab7a..af458ab62601 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -485,6 +485,9 @@ static int macb_mii_probe(struct net_device *dev) } bp->phy_node = of_node_get(np); } else { + /* attempt to find a phy-handle */ + bp->phy_node = of_parse_phandle(np, "phy-handle", 0); + /* fallback to standard phy registration if no phy were * found during dt phy registration */ -- 2.16.2
WARNING: multiple messages have this Message-ID (diff)
From: Brad Mouring <brad.mouring@ni.com> To: Nicolas Ferre <nicolas.ferre@microchip.com>, Rob Herring <robh+dt@kernel.org>, "David S . Miller" <davem@davemloft.net>, "Michael Grzeschik <m.grzeschik@pengutronix.de>, Andrew Lunn" <andrew@lunn.ch> Cc: Mark Rutland <mark.rutland@arm.com>, netdev@vger.kernel.org, "Julia Cartwright <julia@ni.com>, <devicetree@vger.kernel.org>, Brad Mouring" <brad.mouring@ni.com> Subject: [PATCH v2 net-next 2/3] net: macb: Add phy-handle DT support Date: Fri, 9 Mar 2018 16:12:32 -0600 [thread overview] Message-ID: <20180309221233.71202-2-brad.mouring@ni.com> (raw) In-Reply-To: <20180309221233.71202-1-brad.mouring@ni.com> This optional binding (as described in the ethernet DT bindings doc) directs the netdev to the phydev to use. This is useful for a phy chip that has >1 phy in it, and two netdevs are using the same phy chip (i.e. the second mac's phy lives on the first mac's MDIO bus) The devicetree snippet would look something like this: ethernet@feedf00d { ... phy-handle = <&phy0> // the first netdev is physically wired to phy0 ... phy0: phy@0 { ... reg = <0x0> // MDIO address 0 ... } phy1: phy@1 { ... reg = <0x1> // MDIO address 1 ... } ... } ethernet@deadbeef { ... phy-handle = <&phy1> // tells the driver to use phy1 on the // first mac's mdio bus (it's wired thusly) ... } The work done to add the phy_node in the first place (dacdbb4dfc1a1: "net: macb: add fixed-link node support") will consume the device_node (if found). Signed-off-by: Brad Mouring <brad.mouring@ni.com> --- drivers/net/ethernet/cadence/macb_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 7b69a291ab7a..af458ab62601 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -485,6 +485,9 @@ static int macb_mii_probe(struct net_device *dev) } bp->phy_node = of_node_get(np); } else { + /* attempt to find a phy-handle */ + bp->phy_node = of_parse_phandle(np, "phy-handle", 0); + /* fallback to standard phy registration if no phy were * found during dt phy registration */ -- 2.16.2
next prev parent reply other threads:[~2018-03-09 22:14 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-07 22:42 [PATCH 1/2] net: macb: Add phy-handle DT support Brad Mouring 2018-03-07 22:42 ` Brad Mouring 2018-03-07 22:42 ` [PATCH 2/2] Documentation: macb: Document phy-handle optional binding Brad Mouring 2018-03-07 22:42 ` Brad Mouring 2018-03-08 17:32 ` [1/2] net: macb: Add phy-handle DT support Andrew Lunn 2018-03-08 22:00 ` Brad Mouring 2018-03-08 22:00 ` Brad Mouring 2018-03-09 22:12 ` [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup Brad Mouring 2018-03-09 22:12 ` Brad Mouring 2018-03-09 22:12 ` Brad Mouring [this message] 2018-03-09 22:12 ` [PATCH v2 net-next 2/3] net: macb: Add phy-handle DT support Brad Mouring 2018-03-09 22:12 ` [PATCH v2 net-next 3/3] Documentation: macb: Document phy-handle optional binding Brad Mouring 2018-03-09 22:12 ` Brad Mouring 2018-03-10 16:18 ` Andrew Lunn 2018-03-10 16:17 ` [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup Andrew Lunn 2018-03-10 22:19 ` Brad Mouring 2018-03-10 22:19 ` Brad Mouring 2018-03-12 17:09 ` [PATCH v3 net-next 0/4] macb: Introduce phy-handle DT functionality Brad Mouring 2018-03-12 17:09 ` [PATCH v3 net-next 1/4] net: macb: Reorganize macb_mii bringup Brad Mouring 2018-03-12 17:09 ` Brad Mouring 2018-03-12 17:17 ` Florian Fainelli 2018-03-13 4:25 ` kbuild test robot 2018-03-13 4:25 ` kbuild test robot 2018-03-12 17:09 ` [PATCH v3 net-next 2/4] net: macb: Remove redundant poll irq assignment Brad Mouring 2018-03-12 17:09 ` Brad Mouring 2018-03-12 17:17 ` Florian Fainelli 2018-03-12 17:10 ` [PATCH v3 net-next 3/4] net: macb: Add phy-handle DT support Brad Mouring 2018-03-12 17:10 ` Brad Mouring 2018-03-12 17:59 ` Andrew Lunn 2018-03-12 21:34 ` [PATCH v4 net-next 0/4] Brad Mouring 2018-03-12 21:34 ` [PATCH v4 net-next 1/4] net: macb: Reorganize macb_mii bringup Brad Mouring 2018-03-12 21:34 ` Brad Mouring 2018-03-12 21:34 ` [PATCH v4 net-next 2/4] net: macb: Remove redundant poll irq assignment Brad Mouring 2018-03-12 21:34 ` Brad Mouring 2018-03-12 21:34 ` [PATCH v4 net-next 3/4] net: macb: Add phy-handle DT support Brad Mouring 2018-03-12 21:34 ` Brad Mouring 2018-03-12 21:57 ` Andrew Lunn 2018-03-12 22:30 ` Florian Fainelli 2018-03-13 13:49 ` Brad Mouring 2018-03-13 13:49 ` Brad Mouring 2018-03-13 21:32 ` [PATCH v5 net-next 0/4] net: macb: Introduce phy-handle DT functionality Brad Mouring 2018-03-13 21:32 ` Brad Mouring 2018-03-13 21:32 ` [PATCH v5 net-next 1/4] net: macb: Reorganize macb_mii bringup Brad Mouring 2018-03-13 21:32 ` Brad Mouring 2018-03-13 21:32 ` [PATCH v5 net-next 2/4] net: macb: Remove redundant poll irq assignment Brad Mouring 2018-03-13 21:32 ` Brad Mouring 2018-03-13 21:32 ` [PATCH v5 net-next 3/4] net: macb: Add phy-handle DT support Brad Mouring 2018-03-13 21:32 ` Brad Mouring 2018-03-13 21:32 ` [PATCH v5 net-next 4/4] Documentation: macb: Document phy-handle binding Brad Mouring 2018-03-13 21:32 ` Brad Mouring 2018-03-16 15:15 ` [PATCH v5 net-next 0/4] net: macb: Introduce phy-handle DT functionality David Miller 2018-03-12 21:34 ` [PATCH v4 net-next 4/4] Documentation: macb: Document phy-handle binding Brad Mouring 2018-03-12 21:34 ` Brad Mouring 2018-03-12 17:10 ` [PATCH v3 " Brad Mouring 2018-03-12 17:10 ` Brad Mouring 2018-03-12 17:18 ` Florian Fainelli 2018-03-11 7:02 ` [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup kbuild test robot 2018-03-11 7:02 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180309221233.71202-2-brad.mouring@ni.com \ --to=brad.mouring@ni.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=julia@ni.com \ --cc=m.grzeschik@pengutronix.de \ --cc=mark.rutland@arm.com \ --cc=netdev@vger.kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.