From: Brad Mouring <brad.mouring@ni.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Mark Rutland <mark.rutland@arm.com>, <netdev@vger.kernel.org>,
Julia Cartwright <julia@ni.com>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup
Date: Sat, 10 Mar 2018 16:19:20 -0600 [thread overview]
Message-ID: <20180310221920.GA76538@artie.amer.corp.natinst.com> (raw)
In-Reply-To: <20180310161718.GC29174@lunn.ch>
Hi Andrew,
On Sat, Mar 10, 2018 at 05:17:18PM +0100, Andrew Lunn wrote:
> On Fri, Mar 09, 2018 at 04:12:31PM -0600, Brad Mouring wrote:
> > The macb mii setup (mii_probe() and mii_init()) previously was
> > somewhat interspersed, likely a result of organic growth and hacking.
>
> Hi Brad
>
> For netdev it is normal to include a cover note for patch series,
> which explains the big picture of the series. The cover note is then
> used as the merge commit message.
>
> >
> > This change moves mii bus registration into mii_init and probing the
> > bus for devices into mii_probe.
> >
> > Signed-off-by: Brad Mouring <brad.mouring@ni.com>
> > Suggested-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> > drivers/net/ethernet/cadence/macb_main.c | 89 ++++++++++++++++----------------
> > 1 file changed, 45 insertions(+), 44 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> > index e84afcf1ecb5..7b69a291ab7a 100644
> > --- a/drivers/net/ethernet/cadence/macb_main.c
> > +++ b/drivers/net/ethernet/cadence/macb_main.c
> > @@ -470,10 +470,48 @@ static void macb_handle_link_change(struct net_device *dev)
> > static int macb_mii_probe(struct net_device *dev)
> > {
> > struct macb *bp = netdev_priv(dev);
> > - struct macb_platform_data *pdata;
> > + struct macb_platform_data *pdata = dev_get_platdata(&bp->pdev->dev);
> > struct phy_device *phydev;
> > + struct device_node *np = bp->pdev->dev.of_node;
> > int phy_irq;
> > - int ret;
> > + int ret, i;
>
> These should be in 'Reverse Christmas Tree' order. i.e. longest
> first. That makes pdata tricky, so do the assignment in the body of
> the function.
>
> > +
> > + if (np) {
> > + if (of_phy_is_fixed_link(np)) {
> > + if (of_phy_register_fixed_link(np) < 0) {
> > + dev_err(&bp->pdev->dev,
> > + "broken fixed-link specification\n");
> > + return -ENODEV;
> > + }
> > + bp->phy_node = of_node_get(np);
> > + } else {
> > + /* fallback to standard phy registration if no phy were
> > + * found during dt phy registration
> > + */
> > + if (!phy_find_first(bp->mii_bus)) {
> > + for (i = 0; i < PHY_MAX_ADDR; i++) {
> > + struct phy_device *phydev;
> > +
> > + phydev = mdiobus_scan(bp->mii_bus, i);
> > + if (IS_ERR(phydev) &&
> > + PTR_ERR(phydev) != -ENODEV) {
> > + ret = PTR_ERR(phydev);
> > + break;
> > + }
> > + }
> > +
> > + if (ret)
> > + return -ENODEV;
> > + }
> > + }
> > + } else {
> > + for (i = 0; i < PHY_MAX_ADDR; i++)
> > + bp->mii_bus->irq[i] = PHY_POLL;
> > +
> > + if (pdata)
> > + bp->mii_bus->phy_mask = pdata->phy_mask;
>
> I would say these two are to do with the mdio bus setup. Setting irq
> to POLL is not required, the core will do that. So you could add one
> patch removing that.
>
> Andrew
Thank you for the excellent feedback and patience. I've prepped a set
of patches addressing your points, but I'd like to test the changes
on hardware first (both with a DT that calls out the phys and one
that depends on default discovery) prior to a v3 (with appropriate
cover letter).
Brad
WARNING: multiple messages have this Message-ID (diff)
From: Brad Mouring <brad.mouring@ni.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
netdev@vger.kernel.org, Julia Cartwright <julia@ni.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup
Date: Sat, 10 Mar 2018 16:19:20 -0600 [thread overview]
Message-ID: <20180310221920.GA76538@artie.amer.corp.natinst.com> (raw)
In-Reply-To: <20180310161718.GC29174@lunn.ch>
Hi Andrew,
On Sat, Mar 10, 2018 at 05:17:18PM +0100, Andrew Lunn wrote:
> On Fri, Mar 09, 2018 at 04:12:31PM -0600, Brad Mouring wrote:
> > The macb mii setup (mii_probe() and mii_init()) previously was
> > somewhat interspersed, likely a result of organic growth and hacking.
>
> Hi Brad
>
> For netdev it is normal to include a cover note for patch series,
> which explains the big picture of the series. The cover note is then
> used as the merge commit message.
>
> >
> > This change moves mii bus registration into mii_init and probing the
> > bus for devices into mii_probe.
> >
> > Signed-off-by: Brad Mouring <brad.mouring@ni.com>
> > Suggested-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> > drivers/net/ethernet/cadence/macb_main.c | 89 ++++++++++++++++----------------
> > 1 file changed, 45 insertions(+), 44 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> > index e84afcf1ecb5..7b69a291ab7a 100644
> > --- a/drivers/net/ethernet/cadence/macb_main.c
> > +++ b/drivers/net/ethernet/cadence/macb_main.c
> > @@ -470,10 +470,48 @@ static void macb_handle_link_change(struct net_device *dev)
> > static int macb_mii_probe(struct net_device *dev)
> > {
> > struct macb *bp = netdev_priv(dev);
> > - struct macb_platform_data *pdata;
> > + struct macb_platform_data *pdata = dev_get_platdata(&bp->pdev->dev);
> > struct phy_device *phydev;
> > + struct device_node *np = bp->pdev->dev.of_node;
> > int phy_irq;
> > - int ret;
> > + int ret, i;
>
> These should be in 'Reverse Christmas Tree' order. i.e. longest
> first. That makes pdata tricky, so do the assignment in the body of
> the function.
>
> > +
> > + if (np) {
> > + if (of_phy_is_fixed_link(np)) {
> > + if (of_phy_register_fixed_link(np) < 0) {
> > + dev_err(&bp->pdev->dev,
> > + "broken fixed-link specification\n");
> > + return -ENODEV;
> > + }
> > + bp->phy_node = of_node_get(np);
> > + } else {
> > + /* fallback to standard phy registration if no phy were
> > + * found during dt phy registration
> > + */
> > + if (!phy_find_first(bp->mii_bus)) {
> > + for (i = 0; i < PHY_MAX_ADDR; i++) {
> > + struct phy_device *phydev;
> > +
> > + phydev = mdiobus_scan(bp->mii_bus, i);
> > + if (IS_ERR(phydev) &&
> > + PTR_ERR(phydev) != -ENODEV) {
> > + ret = PTR_ERR(phydev);
> > + break;
> > + }
> > + }
> > +
> > + if (ret)
> > + return -ENODEV;
> > + }
> > + }
> > + } else {
> > + for (i = 0; i < PHY_MAX_ADDR; i++)
> > + bp->mii_bus->irq[i] = PHY_POLL;
> > +
> > + if (pdata)
> > + bp->mii_bus->phy_mask = pdata->phy_mask;
>
> I would say these two are to do with the mdio bus setup. Setting irq
> to POLL is not required, the core will do that. So you could add one
> patch removing that.
>
> Andrew
Thank you for the excellent feedback and patience. I've prepped a set
of patches addressing your points, but I'd like to test the changes
on hardware first (both with a DT that calls out the phys and one
that depends on default discovery) prior to a v3 (with appropriate
cover letter).
Brad
next prev parent reply other threads:[~2018-03-10 22:19 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 22:42 [PATCH 1/2] net: macb: Add phy-handle DT support Brad Mouring
2018-03-07 22:42 ` Brad Mouring
2018-03-07 22:42 ` [PATCH 2/2] Documentation: macb: Document phy-handle optional binding Brad Mouring
2018-03-07 22:42 ` Brad Mouring
2018-03-08 17:32 ` [1/2] net: macb: Add phy-handle DT support Andrew Lunn
2018-03-08 22:00 ` Brad Mouring
2018-03-08 22:00 ` Brad Mouring
2018-03-09 22:12 ` [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup Brad Mouring
2018-03-09 22:12 ` Brad Mouring
2018-03-09 22:12 ` [PATCH v2 net-next 2/3] net: macb: Add phy-handle DT support Brad Mouring
2018-03-09 22:12 ` Brad Mouring
2018-03-09 22:12 ` [PATCH v2 net-next 3/3] Documentation: macb: Document phy-handle optional binding Brad Mouring
2018-03-09 22:12 ` Brad Mouring
2018-03-10 16:18 ` Andrew Lunn
2018-03-10 16:17 ` [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup Andrew Lunn
2018-03-10 22:19 ` Brad Mouring [this message]
2018-03-10 22:19 ` Brad Mouring
2018-03-12 17:09 ` [PATCH v3 net-next 0/4] macb: Introduce phy-handle DT functionality Brad Mouring
2018-03-12 17:09 ` [PATCH v3 net-next 1/4] net: macb: Reorganize macb_mii bringup Brad Mouring
2018-03-12 17:09 ` Brad Mouring
2018-03-12 17:17 ` Florian Fainelli
2018-03-13 4:25 ` kbuild test robot
2018-03-13 4:25 ` kbuild test robot
2018-03-12 17:09 ` [PATCH v3 net-next 2/4] net: macb: Remove redundant poll irq assignment Brad Mouring
2018-03-12 17:09 ` Brad Mouring
2018-03-12 17:17 ` Florian Fainelli
2018-03-12 17:10 ` [PATCH v3 net-next 3/4] net: macb: Add phy-handle DT support Brad Mouring
2018-03-12 17:10 ` Brad Mouring
2018-03-12 17:59 ` Andrew Lunn
2018-03-12 21:34 ` [PATCH v4 net-next 0/4] Brad Mouring
2018-03-12 21:34 ` [PATCH v4 net-next 1/4] net: macb: Reorganize macb_mii bringup Brad Mouring
2018-03-12 21:34 ` Brad Mouring
2018-03-12 21:34 ` [PATCH v4 net-next 2/4] net: macb: Remove redundant poll irq assignment Brad Mouring
2018-03-12 21:34 ` Brad Mouring
2018-03-12 21:34 ` [PATCH v4 net-next 3/4] net: macb: Add phy-handle DT support Brad Mouring
2018-03-12 21:34 ` Brad Mouring
2018-03-12 21:57 ` Andrew Lunn
2018-03-12 22:30 ` Florian Fainelli
2018-03-13 13:49 ` Brad Mouring
2018-03-13 13:49 ` Brad Mouring
2018-03-13 21:32 ` [PATCH v5 net-next 0/4] net: macb: Introduce phy-handle DT functionality Brad Mouring
2018-03-13 21:32 ` Brad Mouring
2018-03-13 21:32 ` [PATCH v5 net-next 1/4] net: macb: Reorganize macb_mii bringup Brad Mouring
2018-03-13 21:32 ` Brad Mouring
2018-03-13 21:32 ` [PATCH v5 net-next 2/4] net: macb: Remove redundant poll irq assignment Brad Mouring
2018-03-13 21:32 ` Brad Mouring
2018-03-13 21:32 ` [PATCH v5 net-next 3/4] net: macb: Add phy-handle DT support Brad Mouring
2018-03-13 21:32 ` Brad Mouring
2018-03-13 21:32 ` [PATCH v5 net-next 4/4] Documentation: macb: Document phy-handle binding Brad Mouring
2018-03-13 21:32 ` Brad Mouring
2018-03-16 15:15 ` [PATCH v5 net-next 0/4] net: macb: Introduce phy-handle DT functionality David Miller
2018-03-12 21:34 ` [PATCH v4 net-next 4/4] Documentation: macb: Document phy-handle binding Brad Mouring
2018-03-12 21:34 ` Brad Mouring
2018-03-12 17:10 ` [PATCH v3 " Brad Mouring
2018-03-12 17:10 ` Brad Mouring
2018-03-12 17:18 ` Florian Fainelli
2018-03-11 7:02 ` [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup kbuild test robot
2018-03-11 7:02 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180310221920.GA76538@artie.amer.corp.natinst.com \
--to=brad.mouring@ni.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=julia@ni.com \
--cc=m.grzeschik@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.