From: "hch@lst.de" <hch@lst.de>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: Sinan Kaya <okaya@codeaurora.org>, "hch@lst.de" <hch@lst.de>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"jarkko.sakkinen@linux.intel.com"
<jarkko.sakkinen@linux.intel.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"johan@kernel.org" <johan@kernel.org>,
"msuchanek@suse.de" <msuchanek@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Bharat Bhushan <bharat.bhushan@nxp.com>,
Leo Li <leoyang.li@nxp.com>
Subject: Re: [PATCH] dma-mapping: move dma configuration to bus infrastructure
Date: Tue, 13 Mar 2018 08:27:28 +0100 [thread overview]
Message-ID: <20180313072727.GA32191@lst.de> (raw)
In-Reply-To: <HE1PR0401MB24250A8631823FB3108EA62CE6D20@HE1PR0401MB2425.eurprd04.prod.outlook.com>
On Tue, Mar 13, 2018 at 04:22:53AM +0000, Nipun Gupta wrote:
> > Isn't this one or the other one but not both?
> >
> > Something like:
> >
> > if (dev->of_node)
> > of_dma_deconfigure(dev);
> > else
> > acpi_dma_deconfigure(dev);
> >
> > should work.
>
> I understand your point. Seems reasonable as we should not expect
> the 'of/acpi DMA deconfigure' API to not fail when they are not configured.
>
> But, here we would also need to get dma_device (just as we get in
> 'pci_dma_configure') and need a check on it as for PCI there 'of_node'
> is present in the dma_dev.
Both of_dma_deconfigure and acpi_dma_deconfigure just end up calling
arch_teardown_dma_ops. So my preference would be to just remove
of_dma_deconfigure and acpi_dma_deconfigure and call arch_teardown_dma_ops
as a prep patch before this one.
WARNING: multiple messages have this Message-ID (diff)
From: "hch-jcswGhMUV9g@public.gmane.org" <hch-jcswGhMUV9g@public.gmane.org>
To: Nipun Gupta <nipun.gupta-3arQi8VN3Tc@public.gmane.org>
Cc: "rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Leo Li <leoyang.li-3arQi8VN3Tc@public.gmane.org>,
"gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org"
<linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
"jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sinan Kaya <okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org"
<bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"msuchanek-l3A5Bk7waGM@public.gmane.org"
<msuchanek-l3A5Bk7waGM@public.gmane.org>,
"hch-jcswGhMUV9g@public.gmane.org"
<hch-jcswGhMUV9g@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] dma-mapping: move dma configuration to bus infrastructure
Date: Tue, 13 Mar 2018 08:27:28 +0100 [thread overview]
Message-ID: <20180313072727.GA32191@lst.de> (raw)
In-Reply-To: <HE1PR0401MB24250A8631823FB3108EA62CE6D20-B0v07Ae2taqTjcJO+iVGAo3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
On Tue, Mar 13, 2018 at 04:22:53AM +0000, Nipun Gupta wrote:
> > Isn't this one or the other one but not both?
> >
> > Something like:
> >
> > if (dev->of_node)
> > of_dma_deconfigure(dev);
> > else
> > acpi_dma_deconfigure(dev);
> >
> > should work.
>
> I understand your point. Seems reasonable as we should not expect
> the 'of/acpi DMA deconfigure' API to not fail when they are not configured.
>
> But, here we would also need to get dma_device (just as we get in
> 'pci_dma_configure') and need a check on it as for PCI there 'of_node'
> is present in the dma_dev.
Both of_dma_deconfigure and acpi_dma_deconfigure just end up calling
arch_teardown_dma_ops. So my preference would be to just remove
of_dma_deconfigure and acpi_dma_deconfigure and call arch_teardown_dma_ops
as a prep patch before this one.
next prev parent reply other threads:[~2018-03-13 7:27 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 15:24 [PATCH] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-12 15:24 ` Nipun Gupta
2018-03-12 16:44 ` Sinan Kaya
2018-03-12 16:44 ` Sinan Kaya
2018-03-13 4:22 ` Nipun Gupta
2018-03-13 4:22 ` Nipun Gupta
2018-03-13 4:22 ` Nipun Gupta
2018-03-13 7:27 ` hch [this message]
2018-03-13 7:27 ` hch-jcswGhMUV9g
2018-03-13 7:34 ` Christoph Hellwig
2018-03-13 7:34 ` Christoph Hellwig
2018-03-13 15:59 ` Nipun Gupta
2018-03-13 15:59 ` Nipun Gupta
2018-03-13 15:59 ` Nipun Gupta
2018-03-14 9:03 ` Christoph Hellwig
2018-03-14 9:03 ` Christoph Hellwig
2018-03-13 11:35 ` Robin Murphy
2018-03-13 11:35 ` Robin Murphy
2018-03-13 16:11 ` Nipun Gupta
2018-03-13 16:11 ` Nipun Gupta
2018-03-13 16:11 ` Nipun Gupta
2018-03-14 9:02 ` Christoph Hellwig
2018-03-14 9:02 ` Christoph Hellwig
2018-03-13 21:53 ` kbuild test robot
2018-03-13 21:53 ` kbuild test robot
2018-03-13 21:53 ` [RFC PATCH] dma-mapping: platform_dma_configure() can be static kbuild test robot
2018-03-13 21:53 ` kbuild test robot
2018-03-14 5:48 ` [dma] 9a019f4251: BUG:unable_to_handle_kernel kernel test robot
2018-03-14 5:48 ` kernel test robot
2018-03-14 5:48 ` kernel test robot
2018-03-30 7:15 ` [PATCH] dma-mapping: move dma configuration to bus infrastructure Christoph Hellwig
2018-03-30 7:17 ` Nipun Gupta
2018-03-30 7:17 ` Nipun Gupta
2018-03-30 7:17 ` Nipun Gupta
2018-03-30 9:05 ` Greg KH
2018-03-30 9:05 ` Greg KH
2018-03-21 6:55 [v2,1/2] " Nipun Gupta
2018-03-21 6:55 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-21 6:55 ` Nipun Gupta
2018-03-21 6:55 [v2,2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-03-21 6:55 ` [PATCH v2 2/2] " Nipun Gupta
2018-03-21 6:55 ` Nipun Gupta
2018-03-21 7:19 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Bharat Bhushan
2018-03-21 7:19 ` [PATCH v2 1/2] " Bharat Bhushan
2018-03-21 7:19 ` Bharat Bhushan
2018-03-21 7:19 ` Bharat Bhushan
2018-03-21 7:29 [v2,1/2] " Nipun Gupta
2018-03-21 7:29 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-21 7:29 ` Nipun Gupta
2018-03-21 7:29 ` Nipun Gupta
2018-03-21 9:29 [v2,1/2] " Greg Kroah-Hartman
2018-03-21 9:29 ` [PATCH v2 1/2] " Greg KH
2018-03-21 9:29 ` Greg KH
2018-03-21 9:35 [v2,2/2] drivers: remove force dma flag from buses Greg Kroah-Hartman
2018-03-21 9:35 ` [PATCH v2 2/2] " Greg KH
2018-03-21 9:35 ` Greg KH
2018-03-21 16:13 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-21 16:13 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-21 16:13 ` Nipun Gupta
2018-03-21 16:13 ` Nipun Gupta
2018-03-21 16:28 [v2,2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-03-21 16:28 ` [PATCH v2 2/2] " Nipun Gupta
2018-03-21 16:28 ` Nipun Gupta
2018-03-21 16:28 ` Nipun Gupta
2018-03-21 17:49 [v2,2/2] " Greg Kroah-Hartman
2018-03-21 17:49 ` [PATCH v2 2/2] " Greg KH
2018-03-21 17:49 ` Greg KH
2018-03-22 8:15 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Christoph Hellwig
2018-03-22 8:15 ` [PATCH v2 1/2] " Christoph Hellwig
2018-03-22 8:15 ` Christoph Hellwig
2018-03-22 8:17 [v2,1/2] " Christoph Hellwig
2018-03-22 8:17 ` [PATCH v2 1/2] " hch-jcswGhMUV9g
2018-03-22 8:17 ` hch
2018-03-22 8:19 [v2,2/2] drivers: remove force dma flag from buses Christoph Hellwig
2018-03-22 8:19 ` [PATCH v2 2/2] " Christoph Hellwig
2018-03-22 8:19 ` Christoph Hellwig
2018-03-22 15:05 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-22 15:05 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-22 15:05 ` Nipun Gupta
2018-03-22 15:05 ` Nipun Gupta
2018-03-22 15:13 [v2,2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-03-22 15:13 ` [PATCH v2 2/2] " Nipun Gupta
2018-03-22 15:13 ` Nipun Gupta
2018-03-22 15:13 ` Nipun Gupta
2018-03-23 16:09 [v2,2/2] " kbuild test robot
2018-03-23 16:09 ` [PATCH v2 2/2] " kbuild test robot
2018-03-23 16:09 ` kbuild test robot
2018-03-23 17:41 [v2,2/2] " kbuild test robot
2018-03-23 17:41 ` [PATCH v2 2/2] " kbuild test robot
2018-03-23 17:41 ` kbuild test robot
2018-03-24 9:25 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure kbuild test robot
2018-03-24 9:25 ` [PATCH v2 1/2] " kbuild test robot
2018-03-24 9:25 ` kbuild test robot
2018-03-30 7:54 [v3,1/2] " Nipun Gupta
2018-03-30 7:54 ` [PATCH v3 1/2] " Nipun Gupta
2018-03-30 7:54 ` Nipun Gupta
2018-03-30 7:54 ` Nipun Gupta
2018-03-30 7:54 [v3,2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-03-30 7:54 ` [PATCH v3 2/2] " Nipun Gupta
2018-03-30 7:54 ` Nipun Gupta
2018-03-30 7:54 ` Nipun Gupta
2018-04-09 20:27 [v3,2/2] " Rob Herring
2018-04-09 20:27 ` [PATCH v3 2/2] " Rob Herring
2018-04-09 20:27 ` Rob Herring
2018-04-10 19:20 [v3,1/2] dma-mapping: move dma configuration to bus infrastructure Bjorn Helgaas
2018-04-10 19:20 ` [PATCH v3 1/2] " Bjorn Helgaas
2018-04-10 19:20 ` Bjorn Helgaas
2018-04-10 19:21 [v3,2/2] drivers: remove force dma flag from buses Bjorn Helgaas
2018-04-10 19:21 ` [PATCH v3 2/2] " Bjorn Helgaas
2018-04-10 19:21 ` Bjorn Helgaas
2018-04-23 12:56 [v3,1/2] dma-mapping: move dma configuration to bus infrastructure Christoph Hellwig
2018-04-23 12:56 ` [PATCH v3 1/2] " Christoph Hellwig
2018-04-23 12:56 ` Christoph Hellwig
2018-04-23 12:56 [v3,1/2] " Christoph Hellwig
2018-04-23 12:56 ` [PATCH v3 1/2] " Christoph Hellwig
2018-04-23 12:56 ` Christoph Hellwig
2018-04-27 17:10 [v3,1/2] " Nipun Gupta
2018-04-27 17:10 ` [PATCH v3 1/2] " Nipun Gupta
2018-04-27 17:10 ` Nipun Gupta
2018-04-27 17:10 ` Nipun Gupta
2018-04-28 2:51 [v4,1/2] " Nipun Gupta
2018-04-28 2:51 ` [PATCH v4 1/2] " Nipun Gupta
2018-04-28 2:51 ` Nipun Gupta
2018-04-28 2:51 [v4,2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-04-28 2:51 ` [PATCH v4 2/2] " Nipun Gupta
2018-04-28 2:51 ` Nipun Gupta
2018-04-30 10:41 [v4,1/2] dma-mapping: move dma configuration to bus infrastructure Thierry Reding
2018-04-30 10:41 ` [PATCH v4 1/2] " Thierry Reding
2018-04-30 10:41 ` Thierry Reding
2018-05-01 12:34 [v4,2/2] drivers: remove force dma flag from buses Rob Herring
2018-05-01 12:34 ` [PATCH v4 2/2] " Rob Herring
2018-05-01 12:34 ` Rob Herring
2018-05-03 12:21 [v4,1/2] dma-mapping: move dma configuration to bus infrastructure Christoph Hellwig
2018-05-03 12:21 ` [PATCH v4 1/2] " Christoph Hellwig
2018-05-03 12:21 ` Christoph Hellwig
2018-05-03 12:21 [v4,1/2] " Christoph Hellwig
2018-05-03 12:21 ` [PATCH v4 1/2] " Christoph Hellwig
2018-05-03 12:21 ` Christoph Hellwig
2018-05-03 16:36 [v4,2/2] drivers: remove force dma flag from buses Vinod Koul
2018-05-03 16:36 ` [PATCH v4 2/2] " Vinod Koul
2018-05-03 16:36 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313072727.GA32191@lst.de \
--to=hch@lst.de \
--cc=bharat.bhushan@nxp.com \
--cc=bhelgaas@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=johan@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=msuchanek@suse.de \
--cc=nipun.gupta@nxp.com \
--cc=okaya@codeaurora.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.