All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: robin.murphy@arm.com, hch@lst.de, linux@armlinux.org.uk,
	gregkh@linuxfoundation.org, m.szyprowski@samsung.com,
	bhelgaas@google.com, zajec5@gmail.com, andy.gross@linaro.org,
	david.brown@linaro.org, dan.j.williams@intel.com,
	vinod.koul@intel.com, robh+dt@kernel.org, frowand.list@gmail.com,
	jarkko.sakkinen@linux.intel.com, rafael.j.wysocki@intel.com,
	dmitry.torokhov@gmail.com, johan@kernel.org, msuchanek@suse.de,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org, dmaengine@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
	bharat.bhushan@nxp.com, leoyang.li@nxp.com
Subject: [v4,1/2] dma-mapping: move dma configuration to bus infrastructure
Date: Mon, 30 Apr 2018 12:41:24 +0200	[thread overview]
Message-ID: <20180430104124.GE2476@ulmo> (raw)

On Sat, Apr 28, 2018 at 08:21:58AM +0530, Nipun Gupta wrote:
[...]
> diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c
> index 88a3558..a9ec99d 100644
> --- a/drivers/gpu/host1x/bus.c
> +++ b/drivers/gpu/host1x/bus.c
> @@ -314,6 +314,13 @@ static int host1x_device_match(struct device *dev, struct device_driver *drv)
>  	return strcmp(dev_name(dev), drv->name) == 0;
>  }
>  
> +static int host1x_dma_configure(struct device *dev)
> +{
> +	if (dev->of_node)
> +		return of_dma_configure(dev, dev->of_node);

The conditional here is somewhat pointless since the of_node should
always be set. If it weren't it should be considered a bug and this
function welcome to crash to make that very obvious.

Either way:

Acked-by: Thierry Reding <treding@nvidia.com>

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: robin.murphy@arm.com, hch@lst.de, linux@armlinux.org.uk,
	gregkh@linuxfoundation.org, m.szyprowski@samsung.com,
	bhelgaas@google.com, zajec5@gmail.com, andy.gross@linaro.org,
	david.brown@linaro.org, dan.j.williams@intel.com,
	vinod.koul@intel.com, robh+dt@kernel.org, frowand.list@gmail.com,
	jarkko.sakkinen@linux.intel.com, rafael.j.wysocki@intel.com,
	dmitry.torokhov@gmail.com, johan@kernel.org, msuchanek@suse.de,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org, dmaengine@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
	bharat.bhushan@nxp.com, leoyang.li@nxp.com
Subject: Re: [PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure
Date: Mon, 30 Apr 2018 12:41:24 +0200	[thread overview]
Message-ID: <20180430104124.GE2476@ulmo> (raw)
In-Reply-To: <1524883919-29484-1-git-send-email-nipun.gupta@nxp.com>

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

On Sat, Apr 28, 2018 at 08:21:58AM +0530, Nipun Gupta wrote:
[...]
> diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c
> index 88a3558..a9ec99d 100644
> --- a/drivers/gpu/host1x/bus.c
> +++ b/drivers/gpu/host1x/bus.c
> @@ -314,6 +314,13 @@ static int host1x_device_match(struct device *dev, struct device_driver *drv)
>  	return strcmp(dev_name(dev), drv->name) == 0;
>  }
>  
> +static int host1x_dma_configure(struct device *dev)
> +{
> +	if (dev->of_node)
> +		return of_dma_configure(dev, dev->of_node);

The conditional here is somewhat pointless since the of_node should
always be set. If it weren't it should be considered a bug and this
function welcome to crash to make that very obvious.

Either way:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Nipun Gupta <nipun.gupta-3arQi8VN3Tc@public.gmane.org>
Cc: zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	hch-jcswGhMUV9g@public.gmane.org,
	vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	msuchanek-l3A5Bk7waGM@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	leoyang.li-3arQi8VN3Tc@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure
Date: Mon, 30 Apr 2018 12:41:24 +0200	[thread overview]
Message-ID: <20180430104124.GE2476@ulmo> (raw)
In-Reply-To: <1524883919-29484-1-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 824 bytes --]

On Sat, Apr 28, 2018 at 08:21:58AM +0530, Nipun Gupta wrote:
[...]
> diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c
> index 88a3558..a9ec99d 100644
> --- a/drivers/gpu/host1x/bus.c
> +++ b/drivers/gpu/host1x/bus.c
> @@ -314,6 +314,13 @@ static int host1x_device_match(struct device *dev, struct device_driver *drv)
>  	return strcmp(dev_name(dev), drv->name) == 0;
>  }
>  
> +static int host1x_dma_configure(struct device *dev)
> +{
> +	if (dev->of_node)
> +		return of_dma_configure(dev, dev->of_node);

The conditional here is somewhat pointless since the of_node should
always be set. If it weren't it should be considered a bug and this
function welcome to crash to make that very obvious.

Either way:

Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2018-04-30 10:41 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 10:41 Thierry Reding [this message]
2018-04-30 10:41 ` [PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure Thierry Reding
2018-04-30 10:41 ` Thierry Reding
  -- strict thread matches above, loose matches on Subject: below --
2018-05-03 16:36 [v4,2/2] drivers: remove force dma flag from buses Vinod Koul
2018-05-03 16:36 ` [PATCH v4 2/2] " Vinod Koul
2018-05-03 16:36 ` Vinod Koul
2018-05-03 12:21 [v4,1/2] dma-mapping: move dma configuration to bus infrastructure Christoph Hellwig
2018-05-03 12:21 ` [PATCH v4 1/2] " Christoph Hellwig
2018-05-03 12:21 ` Christoph Hellwig
2018-05-03 12:21 [v4,1/2] " Christoph Hellwig
2018-05-03 12:21 ` [PATCH v4 1/2] " Christoph Hellwig
2018-05-03 12:21 ` Christoph Hellwig
2018-05-01 12:34 [v4,2/2] drivers: remove force dma flag from buses Rob Herring
2018-05-01 12:34 ` [PATCH v4 2/2] " Rob Herring
2018-05-01 12:34 ` Rob Herring
2018-04-28  2:51 [v4,2/2] " Nipun Gupta
2018-04-28  2:51 ` [PATCH v4 2/2] " Nipun Gupta
2018-04-28  2:51 ` Nipun Gupta
2018-04-28  2:51 [v4,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-04-28  2:51 ` [PATCH v4 1/2] " Nipun Gupta
2018-04-28  2:51 ` Nipun Gupta
2018-04-27 17:10 [v3,1/2] " Nipun Gupta
2018-04-27 17:10 ` [PATCH v3 1/2] " Nipun Gupta
2018-04-27 17:10 ` Nipun Gupta
2018-04-27 17:10 ` Nipun Gupta
2018-04-23 12:56 [v3,1/2] " Christoph Hellwig
2018-04-23 12:56 ` [PATCH v3 1/2] " Christoph Hellwig
2018-04-23 12:56 ` Christoph Hellwig
2018-04-23 12:56 [v3,1/2] " Christoph Hellwig
2018-04-23 12:56 ` [PATCH v3 1/2] " Christoph Hellwig
2018-04-23 12:56 ` Christoph Hellwig
2018-04-10 19:21 [v3,2/2] drivers: remove force dma flag from buses Bjorn Helgaas
2018-04-10 19:21 ` [PATCH v3 2/2] " Bjorn Helgaas
2018-04-10 19:21 ` Bjorn Helgaas
2018-04-10 19:20 [v3,1/2] dma-mapping: move dma configuration to bus infrastructure Bjorn Helgaas
2018-04-10 19:20 ` [PATCH v3 1/2] " Bjorn Helgaas
2018-04-10 19:20 ` Bjorn Helgaas
2018-04-09 20:27 [v3,2/2] drivers: remove force dma flag from buses Rob Herring
2018-04-09 20:27 ` [PATCH v3 2/2] " Rob Herring
2018-04-09 20:27 ` Rob Herring
2018-03-30  7:54 [v3,2/2] " Nipun Gupta
2018-03-30  7:54 ` [PATCH v3 2/2] " Nipun Gupta
2018-03-30  7:54 ` Nipun Gupta
2018-03-30  7:54 ` Nipun Gupta
2018-03-30  7:54 [v3,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-30  7:54 ` [PATCH v3 1/2] " Nipun Gupta
2018-03-30  7:54 ` Nipun Gupta
2018-03-30  7:54 ` Nipun Gupta
2018-03-24  9:25 [v2,1/2] " kbuild test robot
2018-03-24  9:25 ` [PATCH v2 1/2] " kbuild test robot
2018-03-24  9:25 ` kbuild test robot
2018-03-23 17:41 [v2,2/2] drivers: remove force dma flag from buses kbuild test robot
2018-03-23 17:41 ` [PATCH v2 2/2] " kbuild test robot
2018-03-23 17:41 ` kbuild test robot
2018-03-23 16:09 [v2,2/2] " kbuild test robot
2018-03-23 16:09 ` [PATCH v2 2/2] " kbuild test robot
2018-03-23 16:09 ` kbuild test robot
2018-03-22 15:13 [v2,2/2] " Nipun Gupta
2018-03-22 15:13 ` [PATCH v2 2/2] " Nipun Gupta
2018-03-22 15:13 ` Nipun Gupta
2018-03-22 15:13 ` Nipun Gupta
2018-03-22 15:05 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-22 15:05 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-22 15:05 ` Nipun Gupta
2018-03-22 15:05 ` Nipun Gupta
2018-03-22  8:19 [v2,2/2] drivers: remove force dma flag from buses Christoph Hellwig
2018-03-22  8:19 ` [PATCH v2 2/2] " Christoph Hellwig
2018-03-22  8:19 ` Christoph Hellwig
2018-03-22  8:17 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Christoph Hellwig
2018-03-22  8:17 ` [PATCH v2 1/2] " hch-jcswGhMUV9g
2018-03-22  8:17 ` hch
2018-03-22  8:15 [v2,1/2] " Christoph Hellwig
2018-03-22  8:15 ` [PATCH v2 1/2] " Christoph Hellwig
2018-03-22  8:15 ` Christoph Hellwig
2018-03-21 17:49 [v2,2/2] drivers: remove force dma flag from buses Greg Kroah-Hartman
2018-03-21 17:49 ` [PATCH v2 2/2] " Greg KH
2018-03-21 17:49 ` Greg KH
2018-03-21 16:28 [v2,2/2] " Nipun Gupta
2018-03-21 16:28 ` [PATCH v2 2/2] " Nipun Gupta
2018-03-21 16:28 ` Nipun Gupta
2018-03-21 16:28 ` Nipun Gupta
2018-03-21 16:13 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-21 16:13 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-21 16:13 ` Nipun Gupta
2018-03-21 16:13 ` Nipun Gupta
2018-03-21  9:35 [v2,2/2] drivers: remove force dma flag from buses Greg Kroah-Hartman
2018-03-21  9:35 ` [PATCH v2 2/2] " Greg KH
2018-03-21  9:35 ` Greg KH
2018-03-21  9:29 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Greg Kroah-Hartman
2018-03-21  9:29 ` [PATCH v2 1/2] " Greg KH
2018-03-21  9:29 ` Greg KH
2018-03-21  7:29 [v2,1/2] " Nipun Gupta
2018-03-21  7:29 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-21  7:29 ` Nipun Gupta
2018-03-21  7:29 ` Nipun Gupta
2018-03-21  7:19 [v2,1/2] " Bharat Bhushan
2018-03-21  7:19 ` [PATCH v2 1/2] " Bharat Bhushan
2018-03-21  7:19 ` Bharat Bhushan
2018-03-21  7:19 ` Bharat Bhushan
2018-03-21  6:55 [v2,2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-03-21  6:55 ` [PATCH v2 2/2] " Nipun Gupta
2018-03-21  6:55 ` Nipun Gupta
2018-03-21  6:55 [v2,1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-21  6:55 ` [PATCH v2 1/2] " Nipun Gupta
2018-03-21  6:55 ` Nipun Gupta
2018-03-12 15:24 [PATCH] " Nipun Gupta
2018-03-12 15:24 ` Nipun Gupta
2018-03-12 16:44 ` Sinan Kaya
2018-03-12 16:44   ` Sinan Kaya
2018-03-13  4:22   ` Nipun Gupta
2018-03-13  4:22     ` Nipun Gupta
2018-03-13  4:22     ` Nipun Gupta
2018-03-13  7:27     ` hch
2018-03-13  7:27       ` hch-jcswGhMUV9g
2018-03-13  7:34 ` Christoph Hellwig
2018-03-13  7:34   ` Christoph Hellwig
2018-03-13 15:59   ` Nipun Gupta
2018-03-13 15:59     ` Nipun Gupta
2018-03-13 15:59     ` Nipun Gupta
2018-03-14  9:03     ` Christoph Hellwig
2018-03-14  9:03       ` Christoph Hellwig
2018-03-13 11:35 ` Robin Murphy
2018-03-13 11:35   ` Robin Murphy
2018-03-13 16:11   ` Nipun Gupta
2018-03-13 16:11     ` Nipun Gupta
2018-03-13 16:11     ` Nipun Gupta
2018-03-14  9:02   ` Christoph Hellwig
2018-03-14  9:02     ` Christoph Hellwig
2018-03-13 21:53 ` kbuild test robot
2018-03-13 21:53   ` kbuild test robot
2018-03-13 21:53 ` [RFC PATCH] dma-mapping: platform_dma_configure() can be static kbuild test robot
2018-03-13 21:53   ` kbuild test robot
2018-03-14  5:48 ` [dma] 9a019f4251: BUG:unable_to_handle_kernel kernel test robot
2018-03-14  5:48   ` kernel test robot
2018-03-14  5:48   ` kernel test robot
2018-03-30  7:15 ` [PATCH] dma-mapping: move dma configuration to bus infrastructure Christoph Hellwig
2018-03-30  7:17   ` Nipun Gupta
2018-03-30  7:17     ` Nipun Gupta
2018-03-30  7:17     ` Nipun Gupta
2018-03-30  9:05   ` Greg KH
2018-03-30  9:05     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180430104124.GE2476@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=andy.gross@linaro.org \
    --cc=bharat.bhushan@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=dan.j.williams@intel.com \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=johan@kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=msuchanek@suse.de \
    --cc=nipun.gupta@nxp.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=vinod.koul@intel.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.