From: "Rafał Miłecki" <zajec5@gmail.com> To: Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Boris Brezillon <boris.brezillon@free-electrons.com>, Marek Vasut <marek.vasut@gmail.com>, Richard Weinberger <richard@nod.at>, Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>, Rob Herring <robh+dt@kernel.org> Cc: "Mark Rutland" <mark.rutland@arm.com>, devicetree@vger.kernel.org, "Florian Fainelli" <f.fainelli@gmail.com>, "Geert Uytterhoeven" <geert+renesas@glider.be>, "Linus Walleij" <linus.walleij@linaro.org>, "John Crispin" <john@phrozen.org>, linux-mtd@lists.infradead.org, "Jonas Gorski" <jonas.gorski@gmail.com>, "Rafał Miłecki" <rafal@milecki.pl>, "Frank Rowand" <frowand.list@gmail.com>, "Peter Rosin" <peda@axentia.se> Subject: [PATCH V10 2/3] mtd: rename "ofpart" parser to "fixed-partitions" as it fits it better Date: Wed, 14 Mar 2018 13:10:43 +0100 [thread overview] Message-ID: <20180314121044.12033-3-zajec5@gmail.com> (raw) In-Reply-To: <20180314121044.12033-1-zajec5@gmail.com> From: Rafał Miłecki <rafal@milecki.pl> Type "ofpart" means that OF should be used to get partitioning info and this driver supports "fixed-partitions" binding only. Renaming it should lead to less confusion especially when parsers for new compatibility strings start to appear. Signed-off-by: Rafał Miłecki <rafal@milecki.pl> --- drivers/mtd/mtdpart.c | 4 ++-- drivers/mtd/ofpart.c | 11 ++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c index 105fe2c7729c..cdb1f496ab95 100644 --- a/drivers/mtd/mtdpart.c +++ b/drivers/mtd/mtdpart.c @@ -907,7 +907,7 @@ static int mtd_part_of_parse(struct mtd_info *master, struct device_node *np; struct property *prop; const char *compat; - const char *fixed = "ofpart"; + const char *fixed = "fixed-partitions"; int ret, err = 0; np = of_get_child_by_name(mtd_get_of_node(master), "partitions"); @@ -927,7 +927,7 @@ static int mtd_part_of_parse(struct mtd_info *master, of_node_put(np); /* - * For backward compatibility we have to try the "ofpart" + * For backward compatibility we have to try the "fixed-partitions" * parser. It supports old DT format with partitions specified as a * direct subnodes of a flash device DT node without any compatibility * specified we could match. diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c index 6bdf4e525677..9f497315e65d 100644 --- a/drivers/mtd/ofpart.c +++ b/drivers/mtd/ofpart.c @@ -25,9 +25,9 @@ static bool node_has_compatible(struct device_node *pp) return of_get_property(pp, "compatible", NULL); } -static int parse_ofpart_partitions(struct mtd_info *master, - const struct mtd_partition **pparts, - struct mtd_part_parser_data *data) +static int parse_fixed_partitions(struct mtd_info *master, + const struct mtd_partition **pparts, + struct mtd_part_parser_data *data) { struct mtd_partition *parts; struct device_node *mtd_node; @@ -141,8 +141,8 @@ static int parse_ofpart_partitions(struct mtd_info *master, } static struct mtd_part_parser ofpart_parser = { - .parse_fn = parse_ofpart_partitions, - .name = "ofpart", + .parse_fn = parse_fixed_partitions, + .name = "fixed-partitions", }; static int parse_ofoldpart_partitions(struct mtd_info *master, @@ -229,4 +229,5 @@ MODULE_AUTHOR("Vitaly Wool, David Gibson"); * with the same name. Since we provide the ofoldpart parser, we should have * the corresponding alias. */ +MODULE_ALIAS("fixed-partitions"); MODULE_ALIAS("ofoldpart"); -- 2.11.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com> To: Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Boris Brezillon <boris.brezillon@free-electrons.com>, Marek Vasut <marek.vasut@gmail.com>, Richard Weinberger <richard@nod.at>, Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>, Rob Herring <robh+dt@kernel.org> Cc: "Mark Rutland" <mark.rutland@arm.com>, "Frank Rowand" <frowand.list@gmail.com>, "Linus Walleij" <linus.walleij@linaro.org>, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, "Geert Uytterhoeven" <geert+renesas@glider.be>, "Jonas Gorski" <jonas.gorski@gmail.com>, "Florian Fainelli" <f.fainelli@gmail.com>, "John Crispin" <john@phrozen.org>, "Peter Rosin" <peda@axentia.se>, "Rafał Miłecki" <rafal@milecki.pl> Subject: [PATCH V10 2/3] mtd: rename "ofpart" parser to "fixed-partitions" as it fits it better Date: Wed, 14 Mar 2018 13:10:43 +0100 [thread overview] Message-ID: <20180314121044.12033-3-zajec5@gmail.com> (raw) In-Reply-To: <20180314121044.12033-1-zajec5@gmail.com> From: Rafał Miłecki <rafal@milecki.pl> Type "ofpart" means that OF should be used to get partitioning info and this driver supports "fixed-partitions" binding only. Renaming it should lead to less confusion especially when parsers for new compatibility strings start to appear. Signed-off-by: Rafał Miłecki <rafal@milecki.pl> --- drivers/mtd/mtdpart.c | 4 ++-- drivers/mtd/ofpart.c | 11 ++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c index 105fe2c7729c..cdb1f496ab95 100644 --- a/drivers/mtd/mtdpart.c +++ b/drivers/mtd/mtdpart.c @@ -907,7 +907,7 @@ static int mtd_part_of_parse(struct mtd_info *master, struct device_node *np; struct property *prop; const char *compat; - const char *fixed = "ofpart"; + const char *fixed = "fixed-partitions"; int ret, err = 0; np = of_get_child_by_name(mtd_get_of_node(master), "partitions"); @@ -927,7 +927,7 @@ static int mtd_part_of_parse(struct mtd_info *master, of_node_put(np); /* - * For backward compatibility we have to try the "ofpart" + * For backward compatibility we have to try the "fixed-partitions" * parser. It supports old DT format with partitions specified as a * direct subnodes of a flash device DT node without any compatibility * specified we could match. diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c index 6bdf4e525677..9f497315e65d 100644 --- a/drivers/mtd/ofpart.c +++ b/drivers/mtd/ofpart.c @@ -25,9 +25,9 @@ static bool node_has_compatible(struct device_node *pp) return of_get_property(pp, "compatible", NULL); } -static int parse_ofpart_partitions(struct mtd_info *master, - const struct mtd_partition **pparts, - struct mtd_part_parser_data *data) +static int parse_fixed_partitions(struct mtd_info *master, + const struct mtd_partition **pparts, + struct mtd_part_parser_data *data) { struct mtd_partition *parts; struct device_node *mtd_node; @@ -141,8 +141,8 @@ static int parse_ofpart_partitions(struct mtd_info *master, } static struct mtd_part_parser ofpart_parser = { - .parse_fn = parse_ofpart_partitions, - .name = "ofpart", + .parse_fn = parse_fixed_partitions, + .name = "fixed-partitions", }; static int parse_ofoldpart_partitions(struct mtd_info *master, @@ -229,4 +229,5 @@ MODULE_AUTHOR("Vitaly Wool, David Gibson"); * with the same name. Since we provide the ofoldpart parser, we should have * the corresponding alias. */ +MODULE_ALIAS("fixed-partitions"); MODULE_ALIAS("ofoldpart"); -- 2.11.0
next prev parent reply other threads:[~2018-03-14 12:10 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-30 20:10 [PATCH V9 0/4] mtd: read partitions compatible prop for "ofpart" type Rafał Miłecki 2018-01-30 20:10 ` Rafał Miłecki [not found] ` <20180130201059.4424-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2018-01-30 20:10 ` [PATCH V9 1/4] mtd: partitions: add special treating for the "ofpart" parser type Rafał Miłecki 2018-01-30 20:10 ` Rafał Miłecki 2018-01-30 20:10 ` [PATCH V9 2/4] mtd: rename "ofpart" parser to "fixed-partitions" as it fits it better Rafał Miłecki 2018-01-30 20:10 ` Rafał Miłecki 2018-01-30 20:10 ` [PATCH V9 3/4] mtd: partitions: add of_match_table parser matching Rafał Miłecki 2018-01-30 20:10 ` Rafał Miłecki 2018-01-30 20:10 ` [PATCH V9 4/4] mtd: ofpart: add of_match_table with "fixed-partitions" Rafał Miłecki 2018-01-30 20:10 ` Rafał Miłecki 2018-02-01 14:32 ` [PATCH V9 0/4] mtd: read partitions compatible prop for "ofpart" type Peter Rosin 2018-02-01 14:32 ` Peter Rosin 2018-03-11 22:35 ` Richard Weinberger 2018-03-11 22:35 ` Richard Weinberger 2018-03-14 12:10 ` [PATCH V10 0/3] " Rafał Miłecki 2018-03-14 12:10 ` Rafał Miłecki 2018-03-14 12:10 ` [PATCH V10 1/3] mtd: partitions: add of_match_table parser matching for the " Rafał Miłecki 2018-03-14 12:10 ` Rafał Miłecki 2018-03-14 12:10 ` Rafał Miłecki [this message] 2018-03-14 12:10 ` [PATCH V10 2/3] mtd: rename "ofpart" parser to "fixed-partitions" as it fits it better Rafał Miłecki 2018-03-14 12:10 ` [PATCH V10 3/3] mtd: ofpart: add of_match_table with "fixed-partitions" Rafał Miłecki 2018-03-14 12:10 ` Rafał Miłecki 2018-03-26 11:30 ` [PATCH V10 0/3] mtd: read partitions compatible prop for "ofpart" type Richard Weinberger 2018-03-26 11:30 ` Richard Weinberger 2018-03-27 9:41 ` Boris Brezillon 2018-03-27 9:41 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180314121044.12033-3-zajec5@gmail.com \ --to=zajec5@gmail.com \ --cc=boris.brezillon@free-electrons.com \ --cc=computersforpeace@gmail.com \ --cc=cyrille.pitchen@wedev4u.fr \ --cc=devicetree@vger.kernel.org \ --cc=dwmw2@infradead.org \ --cc=f.fainelli@gmail.com \ --cc=frowand.list@gmail.com \ --cc=geert+renesas@glider.be \ --cc=john@phrozen.org \ --cc=jonas.gorski@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=mark.rutland@arm.com \ --cc=peda@axentia.se \ --cc=rafal@milecki.pl \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.