Re: [PATCH V9 0/4] mtd: read partitions compatible prop for "ofpart" type

From: Richard Weinberger <richard@nod.at>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Boris Brezillon" <boris.brezillon@free-electrons.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	devicetree@vger.kernel.org,
	"Frank Rowand" <frowand.list@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Marek Vasut" <marek.vasut@gmail.com>,
	"John Crispin" <john@phrozen.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-mtd@lists.infradead.org,
	"Cyrille Pitchen" <cyrille.pitchen@wedev4u.fr>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Brian Norris" <computersforpeace@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Peter Rosin" <peda@axentia.se>
Subject: Re: [PATCH V9 0/4] mtd: read partitions compatible prop for "ofpart" type
Date: Sun, 11 Mar 2018 23:35:06 +0100	[thread overview]
Message-ID: <1849709.LgWgpBxLnY@blindfold> (raw)
In-Reply-To: <20180130201059.4424-1-zajec5@gmail.com>

Rafał,

Am Dienstag, 30. Januar 2018, 21:10:55 CET schrieb Rafał Miłecki:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This patchset provides a proper support for flash device DT node with
> "partitions" subnode using "compatible" property. It's already
> documented in the: Documentation/devicetree/bindings/mtd/partition.txt
> 
> We believed a previous version 8 was ready to go, but soon after landing
> in the linux-next we got a regression report from Peter.
> 
> This version takes a safe path by:
> 1) Respecting parsers order as specified in the default/driver-provided
>    list.
> 2) Looking at "compatible" property only when "ofpart" type gets
>    speciied.
> 
> I double-checked the code and cannot think of any regression this could
> cause. I also hope this design (roughly discussed with Boris) can be
> acceptable for the mtd subsystem.
> 
> This is of course 4.17 material at best.
> 
> Brian Norris (1):
>   mtd: partitions: add of_match_table parser matching
> 
> Rafał Miłecki (3):
>   mtd: partitions: add special treating for the "ofpart" parser type
>   mtd: rename "ofpart" parser to "fixed-partitions" as it fits it better
>   mtd: ofpart: add of_match_table with "fixed-partitions"
> 
>  drivers/mtd/mtdpart.c          | 116
> +++++++++++++++++++++++++++++++++++++---- drivers/mtd/ofpart.c           | 
> 18 +++++--
>  include/linux/mtd/partitions.h |   1 +
>  3 files changed, 121 insertions(+), 14 deletions(-)

As discussed on IRC, 1/4 confused me. It should be squashed into 3/4 to make 
sense.
Other than that I think we can merge this patch series.
Not that I'm a super fan of it, but I can see the use-case but don't have an 
idea how to solve the problem in a less hacky way. ;-\

Just to be sure, DT guys are also happy with it, right?

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/