From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>
Subject: Re: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power
Date: Mon, 26 Mar 2018 11:06:25 +0200 [thread overview]
Message-ID: <20180326090625.espsuzblp7gy767t@verge.net.au> (raw)
In-Reply-To: <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com>
On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote:
> On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote:
>
> >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
> >>> need to be kept powered when backup mode is enabled. Reflect this in
> >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
> >>>
> >>> The accessory power switch (SW23) is a toggle switch, hense specify
> >>> "rohm,rstbmode-level".
> >>>
> >>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>> ---
> >>> v2:
> >>> - Add rohm,rstbmode-level.
> >>> ---
> >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644
> >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> >>> @@ -376,6 +376,8 @@
> >>> #interrupt-cells = <2>;
> >>> gpio-controller;
> >>> #gpio-cells = <2>;
> >>> + rohm,ddr-backup-power = <15>;
> >>
> >> Why not 0xf if those are all bit flags?
> >
> > Because it's a small number?
> > Does it matter?
>
> I think hex is preferable for the bit flags. Decimal makes one think it's something
> else -- some magnitude, etc...
Geert, it seems that Rob Herring is of the same opinion.
Would you care to respin this series?
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power
Date: Mon, 26 Mar 2018 11:06:25 +0200 [thread overview]
Message-ID: <20180326090625.espsuzblp7gy767t@verge.net.au> (raw)
In-Reply-To: <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com>
On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote:
> On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote:
>
> >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
> >>> need to be kept powered when backup mode is enabled. Reflect this in
> >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
> >>>
> >>> The accessory power switch (SW23) is a toggle switch, hense specify
> >>> "rohm,rstbmode-level".
> >>>
> >>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>> ---
> >>> v2:
> >>> - Add rohm,rstbmode-level.
> >>> ---
> >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644
> >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> >>> @@ -376,6 +376,8 @@
> >>> #interrupt-cells = <2>;
> >>> gpio-controller;
> >>> #gpio-cells = <2>;
> >>> + rohm,ddr-backup-power = <15>;
> >>
> >> Why not 0xf if those are all bit flags?
> >
> > Because it's a small number?
> > Does it matter?
>
> I think hex is preferable for the bit flags. Decimal makes one think it's something
> else -- some magnitude, etc...
Geert, it seems that Rob Herring is of the same opinion.
Would you care to respin this series?
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power
Date: Mon, 26 Mar 2018 11:06:25 +0200 [thread overview]
Message-ID: <20180326090625.espsuzblp7gy767t@verge.net.au> (raw)
In-Reply-To: <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com>
On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote:
> On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote:
>
> >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
> >>> need to be kept powered when backup mode is enabled. Reflect this in
> >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
> >>>
> >>> The accessory power switch (SW23) is a toggle switch, hense specify
> >>> "rohm,rstbmode-level".
> >>>
> >>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>> ---
> >>> v2:
> >>> - Add rohm,rstbmode-level.
> >>> ---
> >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644
> >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> >>> @@ -376,6 +376,8 @@
> >>> #interrupt-cells = <2>;
> >>> gpio-controller;
> >>> #gpio-cells = <2>;
> >>> + rohm,ddr-backup-power = <15>;
> >>
> >> Why not 0xf if those are all bit flags?
> >
> > Because it's a small number?
> > Does it matter?
>
> I think hex is preferable for the bit flags. Decimal makes one think it's something
> else -- some magnitude, etc...
Geert, it seems that Rob Herring is of the same opinion.
Would you care to respin this series?
next prev parent reply other threads:[~2018-03-26 9:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 12:09 [PATCH v2 0/3] arm64: dts: renesas: salvator-x(s)/ulcb: Configure PMIC for DDR Backup Power Geert Uytterhoeven
2018-03-14 12:09 ` Geert Uytterhoeven
2018-03-14 12:09 ` Geert Uytterhoeven
2018-03-14 12:09 ` [PATCH v2 1/3] arm64: dts: renesas: ulcb: Add BD9571 PMIC Geert Uytterhoeven
2018-03-14 12:09 ` Geert Uytterhoeven
2018-03-14 12:09 ` Geert Uytterhoeven
2018-03-14 12:09 ` [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power Geert Uytterhoeven
2018-03-14 12:09 ` Geert Uytterhoeven
2018-03-14 12:09 ` Geert Uytterhoeven
2018-03-14 15:17 ` Sergei Shtylyov
2018-03-14 15:17 ` Sergei Shtylyov
2018-03-14 15:17 ` Sergei Shtylyov
2018-03-16 11:49 ` Simon Horman
2018-03-16 11:49 ` Simon Horman
2018-03-16 11:49 ` Simon Horman
2018-03-16 12:00 ` Geert Uytterhoeven
2018-03-16 12:00 ` Geert Uytterhoeven
2018-03-16 12:00 ` Geert Uytterhoeven
2018-03-16 12:08 ` Sergei Shtylyov
2018-03-16 12:08 ` Sergei Shtylyov
2018-03-16 12:08 ` Sergei Shtylyov
2018-03-26 9:06 ` Simon Horman [this message]
2018-03-26 9:06 ` Simon Horman
2018-03-26 9:06 ` Simon Horman
2018-03-26 9:13 ` Geert Uytterhoeven
2018-03-26 9:13 ` Geert Uytterhoeven
2018-03-26 9:13 ` Geert Uytterhoeven
2018-03-27 8:17 ` Simon Horman
2018-03-27 8:17 ` Simon Horman
2018-03-27 8:17 ` Simon Horman
2018-03-14 12:09 ` [PATCH v2 3/3] arm64: dts: renesas: ulcb: " Geert Uytterhoeven
2018-03-14 12:09 ` Geert Uytterhoeven
2018-03-14 12:09 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326090625.espsuzblp7gy767t@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.