All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, Avi Kivity <avi@scylladb.com>,
	linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
	netdev@vger.kernel.org, linux-api@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/30] aio: add delayed cancel support
Date: Thu, 29 Mar 2018 20:08:31 +0200	[thread overview]
Message-ID: <20180329180831.GA15948@lst.de> (raw)
In-Reply-To: <20180329142506.GX30522@ZenIV.linux.org.uk>

On Thu, Mar 29, 2018 at 03:25:06PM +0100, Al Viro wrote:
> OK.  Let's leave that alone for now.  Re deferred cancels - AFAICS, we *must*
> remove the sucker from ctx->active_reqs before dropping ->ctx_lock.
> 
> As it is, you are creating a io_cancel()/io_cancel() race leading to double
> fput().  It's not that hard to fix; I can do that myself while applying your
> series (as described in previous posting - kiocb_cancel_locked() returning
> NULL or ERR_PTR() in non-deferred case and pointer to aio_kiocb removed from
> ->active_reqs in deferred one) or you could fix it in some other way and
> update your branch.

I think that is the right fix.  Let me resend so that I can test the
result first.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, Avi Kivity <avi@scylladb.com>,
	linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
	netdev@vger.kernel.org, linux-api@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/30] aio: add delayed cancel support
Date: Thu, 29 Mar 2018 20:08:31 +0200	[thread overview]
Message-ID: <20180329180831.GA15948@lst.de> (raw)
In-Reply-To: <20180329142506.GX30522@ZenIV.linux.org.uk>

On Thu, Mar 29, 2018 at 03:25:06PM +0100, Al Viro wrote:
> OK.  Let's leave that alone for now.  Re deferred cancels - AFAICS, we *must*
> remove the sucker from ctx->active_reqs before dropping ->ctx_lock.
> 
> As it is, you are creating a io_cancel()/io_cancel() race leading to double
> fput().  It's not that hard to fix; I can do that myself while applying your
> series (as described in previous posting - kiocb_cancel_locked() returning
> NULL or ERR_PTR() in non-deferred case and pointer to aio_kiocb removed from
> ->active_reqs in deferred one) or you could fix it in some other way and
> update your branch.

I think that is the right fix.  Let me resend so that I can test the
result first.

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>

  reply	other threads:[~2018-03-29 18:08 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28  7:28 aio poll and a new in-kernel poll API V7 Christoph Hellwig
2018-03-28  7:28 ` Christoph Hellwig
2018-03-28  7:28 ` [PATCH 01/30] fs: unexport poll_schedule_timeout Christoph Hellwig
2018-03-28  7:28   ` Christoph Hellwig
2018-03-28  7:28 ` [PATCH 02/30] fs: cleanup do_pollfd Christoph Hellwig
2018-03-28  7:28   ` Christoph Hellwig
2018-03-28  7:28 ` [PATCH 03/30] fs: update documentation to mention __poll_t and match the code Christoph Hellwig
2018-03-28  7:28   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 04/30] fs: add new vfs_poll and file_can_poll helpers Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 05/30] fs: introduce new ->get_poll_head and ->poll_mask methods Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 06/30] aio: simplify cancellation Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 07/30] aio: add delayed cancel support Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28 16:35   ` Al Viro
2018-03-28 21:34     ` Al Viro
2018-03-28 21:34       ` Al Viro
2018-03-29  8:53     ` Christoph Hellwig
2018-03-29  8:53       ` Christoph Hellwig
2018-03-29 14:25       ` Al Viro
2018-03-29 14:25         ` Al Viro
2018-03-29 18:08         ` Christoph Hellwig [this message]
2018-03-29 18:08           ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 08/30] aio: implement IOCB_CMD_POLL Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 09/30] net: refactor socket_poll Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 10/30] net: add support for ->poll_mask in proto_ops Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 11/30] net: remove sock_no_poll Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 12/30] net/tcp: convert to ->poll_mask Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 13/30] net/unix: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 14/30] net: convert datagram_poll users tp ->poll_mask Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 15/30] net/dccp: convert to ->poll_mask Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 16/30] net/atm: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 17/30] net/vmw_vsock: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 18/30] net/tipc: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 19/30] net/sctp: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 20/30] net/bluetooth: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 21/30] net/caif: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 22/30] net/nfc: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 23/30] net/phonet: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 24/30] net/iucv: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 25/30] net/rxrpc: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 26/30] crypto: af_alg: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 27/30] pipe: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 28/30] eventfd: switch " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 29/30] timerfd: convert " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-28  7:29 ` [PATCH 30/30] random: " Christoph Hellwig
2018-03-28  7:29   ` Christoph Hellwig
2018-03-29 20:32 aio poll and a new in-kernel poll API V8 Christoph Hellwig
2018-03-29 20:33 ` [PATCH 07/30] aio: add delayed cancel support Christoph Hellwig
2018-03-29 20:33   ` Christoph Hellwig
2018-03-29 22:35   ` Al Viro
2018-03-29 22:35     ` Al Viro
2018-03-30  7:14     ` Christoph Hellwig
2018-03-30  7:14       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180329180831.GA15948@lst.de \
    --to=hch@lst.de \
    --cc=avi@scylladb.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.