Build failure on RHEL 7.4

Build failure on RHEL 7.4

[Andrew Rybchenko]

Hello,

build fails on RHEL 7.4. I've not tried to dig it.


lib/librte_eal/linuxapp/eal/eal_memalloc.c: In function ‘resize_hugefile’:
librte_eal/linuxapp/eal/eal_memalloc.c:343:27: error: 
‘FALLOC_FL_PUNCH_HOLE’ undeclared (first use in this function)
     int flags = grow ? 0 : FALLOC_FL_PUNCH_HOLE |
                            ^
lib/librte_eal/linuxapp/eal/eal_memalloc.c:343:27: note: each undeclared 
identifier is reported only once for each function it appears in
lib/librte_eal/linuxapp/eal/eal_memalloc.c:344:6: error: 
‘FALLOC_FL_KEEP_SIZE’ undeclared (first use in this function)
       FALLOC_FL_KEEP_SIZE;
       ^
make[6]: *** [eal_memalloc.o] Error 1
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [eal] Error 2
make[4]: *** [linuxapp] Error 2
make[3]: *** [librte_eal] Error 2
make[2]: *** [lib] Error 2
make[1]: *** [all] Error 2
make: *** [all] Error 2

$ gcc --version
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ uname -r
3.10.0-693.el7.x86_64

Andrew.

Re: Build failure on RHEL 7.4

[Thomas Monjalon]

11/04/2018 21:09, Andrew Rybchenko:
> Hello,
> 
> build fails on RHEL 7.4. I've not tried to dig it.

Thanks for reporting.

[...]
> ‘FALLOC_FL_PUNCH_HOLE’ undeclared (first use in this function)
[...]
> ‘FALLOC_FL_KEEP_SIZE’ undeclared (first use in this function)

These constants were defined in Linux 2.6.23 and 2.6.38.

[...]
> $ uname -r
> 3.10.0-693.el7.x86_64

It should be OK.

I think we are just missing
	#include <linux/falloc.h>

Re: Build failure on RHEL 7.4

[Pavan Nikhilesh]

On Wed, Apr 11, 2018 at 09:40:30PM +0200, Thomas Monjalon wrote:
> 11/04/2018 21:09, Andrew Rybchenko:
> > Hello,
> >
> > build fails on RHEL 7.4. I've not tried to dig it.
>
> Thanks for reporting.
>
> [...]
> > ‘FALLOC_FL_PUNCH_HOLE’ undeclared (first use in this function)
> [...]
> > ‘FALLOC_FL_KEEP_SIZE’ undeclared (first use in this function)
>
> These constants were defined in Linux 2.6.23 and 2.6.38.
>
> [...]
> > $ uname -r
> > 3.10.0-693.el7.x86_64
>
> It should be OK.
>
> I think we are just missing
> 	#include <linux/falloc.h>

Currently there is a bug filed in glibc here for the exact same kernel version.
https://bugzilla.redhat.com/show_bug.cgi?id=1476120


>
>

Re: Build failure on RHEL 7.4

[Thomas Monjalon]

11/04/2018 21:46, Pavan Nikhilesh:
> On Wed, Apr 11, 2018 at 09:40:30PM +0200, Thomas Monjalon wrote:
> > 11/04/2018 21:09, Andrew Rybchenko:
> > > Hello,
> > >
> > > build fails on RHEL 7.4. I've not tried to dig it.
> >
> > Thanks for reporting.
> >
> > [...]
> > > ‘FALLOC_FL_PUNCH_HOLE’ undeclared (first use in this function)
> > [...]
> > > ‘FALLOC_FL_KEEP_SIZE’ undeclared (first use in this function)
> >
> > These constants were defined in Linux 2.6.23 and 2.6.38.
> >
> > [...]
> > > $ uname -r
> > > 3.10.0-693.el7.x86_64
> >
> > It should be OK.
> >
> > I think we are just missing
> > 	#include <linux/falloc.h>
> 
> Currently there is a bug filed in glibc here for the exact same kernel version.
> https://bugzilla.redhat.com/show_bug.cgi?id=1476120

The man page says: "The FALLOC_FL_* flags are defined in glibc headers
only since version 2.18."

I guess we can workaround with a direct include.

Re: Build failure on RHEL 7.4

[Thomas Monjalon]

11/04/2018 21:56, Thomas Monjalon:
> 11/04/2018 21:46, Pavan Nikhilesh:
> > On Wed, Apr 11, 2018 at 09:40:30PM +0200, Thomas Monjalon wrote:
> > > 11/04/2018 21:09, Andrew Rybchenko:
> > > > Hello,
> > > >
> > > > build fails on RHEL 7.4. I've not tried to dig it.
> > >
> > > Thanks for reporting.
> > >
> > > [...]
> > > > ‘FALLOC_FL_PUNCH_HOLE’ undeclared (first use in this function)
> > > [...]
> > > > ‘FALLOC_FL_KEEP_SIZE’ undeclared (first use in this function)
> > >
> > > These constants were defined in Linux 2.6.23 and 2.6.38.
> > >
> > > [...]
> > > > $ uname -r
> > > > 3.10.0-693.el7.x86_64
> > >
> > > It should be OK.
> > >
> > > I think we are just missing
> > > 	#include <linux/falloc.h>
> > 
> > Currently there is a bug filed in glibc here for the exact same kernel version.
> > https://bugzilla.redhat.com/show_bug.cgi?id=1476120
> 
> The man page says: "The FALLOC_FL_* flags are defined in glibc headers
> only since version 2.18."
> 
> I guess we can workaround with a direct include.

Fixed and rebased
Tested by David, thanks