All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kubakici@wp.pl>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Tal Gilboa <talgi@mellanox.com>,
	Tariq Toukan <tariqt@mellanox.com>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Ariel Elior <ariel.elior@cavium.com>,
	Ganesh Goudar <ganeshgr@chelsio.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	everest-linux-l2@cavium.com, intel-wired-lan@lists.osuosl.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited
Date: Thu, 12 Apr 2018 21:32:49 -0700	[thread overview]
Message-ID: <20180412213249.06661048@cakuba.netronome.com> (raw)
In-Reply-To: <152244391852.135666.14903825998610307052.stgit@bhelgaas-glaptop.roam.corp.google.com>

On Fri, 30 Mar 2018 16:05:18 -0500, Bjorn Helgaas wrote:
> +	if (bw_avail >= bw_cap)
> +		pci_info(dev, "%d Mb/s available bandwidth (%s x%d link)\n",
> +			 bw_cap, PCIE_SPEED2STR(speed_cap), width_cap);
> +	else
> +		pci_info(dev, "%d Mb/s available bandwidth, limited by %s x%d link at %s (capable of %d Mb/s with %s x%d link)\n",
> +			 bw_avail, PCIE_SPEED2STR(speed), width,
> +			 limiting_dev ? pci_name(limiting_dev) : "<unknown>",
> +			 bw_cap, PCIE_SPEED2STR(speed_cap), width_cap);

I was just looking at using this new function to print PCIe BW for a
NIC, but I'm slightly worried that there is nothing in the message that
says PCIe...  For a NIC some people may interpret the bandwidth as NIC
bandwidth:

[   39.839989] nfp 0000:04:00.0: Netronome Flow Processor NFP4000/NFP6000 PCIe Card Probe
[   39.848943] nfp 0000:04:00.0: 63.008 Gb/s available bandwidth (8 GT/s x8 link)
[   39.857146] nfp 0000:04:00.0: RESERVED BARs: 0.0: General/MSI-X SRAM, 0.1: PCIe XPB/MSI-X PBA, 0.4: Explicit0, 0.5: Explicit1, fre4

It's not a 63Gbps NIC...  I'm sorry if this was discussed before and I
didn't find it.  Would it make sense to add the "PCIe: " prefix to the
message like bnx2x used to do?  Like:

nfp 0000:04:00.0: PCIe: 63.008 Gb/s available bandwidth (8 GT/s x8 link)

Sorry for a very late comment.

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kubakici@wp.pl>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited
Date: Thu, 12 Apr 2018 21:32:49 -0700	[thread overview]
Message-ID: <20180412213249.06661048@cakuba.netronome.com> (raw)
In-Reply-To: <152244391852.135666.14903825998610307052.stgit@bhelgaas-glaptop.roam.corp.google.com>

On Fri, 30 Mar 2018 16:05:18 -0500, Bjorn Helgaas wrote:
> +	if (bw_avail >= bw_cap)
> +		pci_info(dev, "%d Mb/s available bandwidth (%s x%d link)\n",
> +			 bw_cap, PCIE_SPEED2STR(speed_cap), width_cap);
> +	else
> +		pci_info(dev, "%d Mb/s available bandwidth, limited by %s x%d link at %s (capable of %d Mb/s with %s x%d link)\n",
> +			 bw_avail, PCIE_SPEED2STR(speed), width,
> +			 limiting_dev ? pci_name(limiting_dev) : "<unknown>",
> +			 bw_cap, PCIE_SPEED2STR(speed_cap), width_cap);

I was just looking at using this new function to print PCIe BW for a
NIC, but I'm slightly worried that there is nothing in the message that
says PCIe...  For a NIC some people may interpret the bandwidth as NIC
bandwidth:

[   39.839989] nfp 0000:04:00.0: Netronome Flow Processor NFP4000/NFP6000 PCIe Card Probe
[   39.848943] nfp 0000:04:00.0: 63.008 Gb/s available bandwidth (8 GT/s x8 link)
[   39.857146] nfp 0000:04:00.0: RESERVED BARs: 0.0: General/MSI-X SRAM, 0.1: PCIe XPB/MSI-X PBA, 0.4: Explicit0, 0.5: Explicit1, fre4

It's not a 63Gbps NIC...  I'm sorry if this was discussed before and I
didn't find it.  Would it make sense to add the "PCIe: " prefix to the
message like bnx2x used to do?  Like:

nfp 0000:04:00.0: PCIe: 63.008 Gb/s available bandwidth (8 GT/s x8 link)

Sorry for a very late comment.

  parent reply	other threads:[~2018-04-13  4:33 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30 21:04 [PATCH v5 00/14] Report PCI device link status Bjorn Helgaas
2018-03-30 21:04 ` [Intel-wired-lan] " Bjorn Helgaas
2018-03-30 21:04 ` [PATCH v5 01/14] PCI: Add pcie_get_speed_cap() to find max supported link speed Bjorn Helgaas
2018-03-30 21:04   ` [Intel-wired-lan] " Bjorn Helgaas
2018-03-30 21:04 ` [PATCH v5 02/14] PCI: Add pcie_get_width_cap() to find max supported link width Bjorn Helgaas
2018-03-30 21:04   ` [Intel-wired-lan] " Bjorn Helgaas
2018-03-30 21:05 ` [PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth Bjorn Helgaas
2018-03-30 21:05   ` [Intel-wired-lan] " Bjorn Helgaas
2018-04-01 20:38   ` Tal Gilboa
2018-04-01 20:38     ` [Intel-wired-lan] " Tal Gilboa
2018-04-02  0:40     ` Bjorn Helgaas
2018-04-02  0:40       ` [Intel-wired-lan] " Bjorn Helgaas
2018-04-02  7:34       ` Tal Gilboa
2018-04-02  7:34         ` [Intel-wired-lan] " Tal Gilboa
2018-04-02 14:05         ` Bjorn Helgaas
2018-04-02 14:05           ` [Intel-wired-lan] " Bjorn Helgaas
2018-04-02 14:34           ` Tal Gilboa
2018-04-02 14:34             ` [Intel-wired-lan] " Tal Gilboa
2018-04-02 16:00             ` Keller, Jacob E
2018-04-02 16:00               ` [Intel-wired-lan] " Keller, Jacob E
2018-04-02 16:00               ` Keller, Jacob E
2018-04-02 19:37               ` Bjorn Helgaas
2018-04-02 19:37                 ` [Intel-wired-lan] " Bjorn Helgaas
2018-04-03  0:30           ` Jacob Keller
2018-04-03  0:30             ` [Intel-wired-lan] " Jacob Keller
2018-04-03 14:05             ` Bjorn Helgaas
2018-04-03 14:05               ` [Intel-wired-lan] " Bjorn Helgaas
2018-04-03 16:54               ` Keller, Jacob E
2018-04-03 16:54                 ` [Intel-wired-lan] " Keller, Jacob E
2018-04-03 16:54                 ` Keller, Jacob E
2018-03-30 21:05 ` [PATCH v5 04/14] PCI: Add pcie_bandwidth_available() to compute bandwidth available to device Bjorn Helgaas
2018-03-30 21:05   ` [Intel-wired-lan] " Bjorn Helgaas
2018-04-01 20:41   ` Tal Gilboa
2018-04-01 20:41     ` [Intel-wired-lan] " Tal Gilboa
2018-04-02  0:41     ` Bjorn Helgaas
2018-04-02  0:41       ` [Intel-wired-lan] " Bjorn Helgaas
2018-03-30 21:05 ` [PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited Bjorn Helgaas
2018-03-30 21:05   ` [Intel-wired-lan] " Bjorn Helgaas
2018-04-02 16:25   ` Keller, Jacob E
2018-04-02 16:25     ` [Intel-wired-lan] " Keller, Jacob E
2018-04-02 16:25     ` Keller, Jacob E
2018-04-02 19:58     ` Bjorn Helgaas
2018-04-02 19:58       ` [Intel-wired-lan] " Bjorn Helgaas
2018-04-02 20:25       ` Keller, Jacob E
2018-04-02 20:25         ` [Intel-wired-lan] " Keller, Jacob E
2018-04-02 20:25         ` Keller, Jacob E
2018-04-02 21:09         ` Tal Gilboa
2018-04-02 21:09           ` [Intel-wired-lan] " Tal Gilboa
2018-04-13  4:32   ` Jakub Kicinski [this message]
2018-04-13  4:32     ` Jakub Kicinski
2018-04-13 14:06     ` Bjorn Helgaas
2018-04-13 14:06       ` [Intel-wired-lan] " Bjorn Helgaas
2018-04-13 15:34       ` Keller, Jacob E
2018-04-13 15:34         ` [Intel-wired-lan] " Keller, Jacob E
2018-04-13 15:34         ` Keller, Jacob E
2018-03-30 21:05 ` [PATCH v5 06/14] net/mlx4_core: Report PCIe link properties with pcie_print_link_status() Bjorn Helgaas
2018-03-30 21:05   ` [Intel-wired-lan] " Bjorn Helgaas
2018-03-30 21:05 ` [PATCH v5 07/14] net/mlx5: " Bjorn Helgaas
2018-03-30 21:05   ` [Intel-wired-lan] " Bjorn Helgaas
2018-03-30 21:05 ` [PATCH v5 08/14] net/mlx5e: Use pcie_bandwidth_available() to compute bandwidth Bjorn Helgaas
2018-03-30 21:05   ` [Intel-wired-lan] " Bjorn Helgaas
2018-03-30 21:05 ` [PATCH v5 09/14] bnx2x: Report PCIe link properties with pcie_print_link_status() Bjorn Helgaas
2018-03-30 21:05   ` [Intel-wired-lan] " Bjorn Helgaas
2018-03-30 21:05 ` [PATCH v5 10/14] bnxt_en: " Bjorn Helgaas
2018-03-30 21:05   ` [Intel-wired-lan] " Bjorn Helgaas
2018-03-30 21:06 ` [PATCH v5 11/14] cxgb4: " Bjorn Helgaas
2018-03-30 21:06   ` [Intel-wired-lan] " Bjorn Helgaas
2018-03-30 21:06 ` [PATCH v5 12/14] fm10k: " Bjorn Helgaas
2018-03-30 21:06   ` [Intel-wired-lan] " Bjorn Helgaas
2018-04-02 15:56   ` Keller, Jacob E
2018-04-02 15:56     ` [Intel-wired-lan] " Keller, Jacob E
2018-04-02 15:56     ` Keller, Jacob E
2018-04-02 20:31     ` Bjorn Helgaas
2018-04-02 20:31       ` [Intel-wired-lan] " Bjorn Helgaas
2018-04-02 20:36       ` Keller, Jacob E
2018-04-02 20:36         ` [Intel-wired-lan] " Keller, Jacob E
2018-04-02 20:36         ` Keller, Jacob E
2018-03-30 21:06 ` [PATCH v5 13/14] ixgbe: " Bjorn Helgaas
2018-03-30 21:06   ` [Intel-wired-lan] " Bjorn Helgaas
2018-03-30 21:06 ` [PATCH v5 14/14] PCI: Remove unused pcie_get_minimum_link() Bjorn Helgaas
2018-03-30 21:06   ` [Intel-wired-lan] " Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180412213249.06661048@cakuba.netronome.com \
    --to=kubakici@wp.pl \
    --cc=ariel.elior@cavium.com \
    --cc=everest-linux-l2@cavium.com \
    --cc=ganeshgr@chelsio.com \
    --cc=helgaas@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=talgi@mellanox.com \
    --cc=tariqt@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.