From: "Michael S. Tsirkin" <mst@redhat.com> To: Stephen Hemminger <stephen@networkplumber.org> Cc: Sridhar Samudrala <sridhar.samudrala@intel.com>, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, jiri@resnulli.us Subject: Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework Date: Fri, 20 Apr 2018 18:43:54 +0300 [thread overview] Message-ID: <20180420183505-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <20180420082802.6ca37e4c@xeon-e3> On Fri, Apr 20, 2018 at 08:28:02AM -0700, Stephen Hemminger wrote: > On Thu, 19 Apr 2018 18:42:04 -0700 > Sridhar Samudrala <sridhar.samudrala@intel.com> wrote: > > > Use the registration/notification framework supported by the generic > > failover infrastructure. > > > > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com> > > Do what you want to other devices but leave netvsc alone. > Adding these failover ops does not reduce the code size, drivers/net/hyperv/Kconfig | 1 + drivers/net/hyperv/hyperv_net.h | 2 + drivers/net/hyperv/netvsc_drv.c | 208 ++++++++++------------------------------ 3 files changed, 55 insertions(+), 156 deletions(-) 100 lines gone. > and really is > no benefit. The netvsc device driver needs to be backported to several > other distributions and doing this makes that harder. > > I will NAK patches to change to common code for netvsc Wow. > especially the > three device model. AFAIK these patches do not change netvsc to a three device model. > MS worked hard with distro vendors to support transparent > mode, ans we really can't have a new model; That's why Sridhar worked hard to preserve a 2 device model for netvsc. > or do backport. > > Plus, DPDK is now dependent on existing model. DPDK does the kernel bypass thing, doesn't it? Why does the kernel care? -- MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Stephen Hemminger <stephen@networkplumber.org> Cc: Sridhar Samudrala <sridhar.samudrala@intel.com>, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, jiri@resnulli.us Subject: [virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework Date: Fri, 20 Apr 2018 18:43:54 +0300 [thread overview] Message-ID: <20180420183505-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <20180420082802.6ca37e4c@xeon-e3> On Fri, Apr 20, 2018 at 08:28:02AM -0700, Stephen Hemminger wrote: > On Thu, 19 Apr 2018 18:42:04 -0700 > Sridhar Samudrala <sridhar.samudrala@intel.com> wrote: > > > Use the registration/notification framework supported by the generic > > failover infrastructure. > > > > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com> > > Do what you want to other devices but leave netvsc alone. > Adding these failover ops does not reduce the code size, drivers/net/hyperv/Kconfig | 1 + drivers/net/hyperv/hyperv_net.h | 2 + drivers/net/hyperv/netvsc_drv.c | 208 ++++++++++------------------------------ 3 files changed, 55 insertions(+), 156 deletions(-) 100 lines gone. > and really is > no benefit. The netvsc device driver needs to be backported to several > other distributions and doing this makes that harder. > > I will NAK patches to change to common code for netvsc Wow. > especially the > three device model. AFAIK these patches do not change netvsc to a three device model. > MS worked hard with distro vendors to support transparent > mode, ans we really can't have a new model; That's why Sridhar worked hard to preserve a 2 device model for netvsc. > or do backport. > > Plus, DPDK is now dependent on existing model. DPDK does the kernel bypass thing, doesn't it? Why does the kernel care? -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-04-20 15:44 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-20 1:42 [PATCH net-next v7 0/4] Enable virtio_net to act as a standby for a passthru device Sridhar Samudrala 2018-04-20 1:42 ` [virtio-dev] " Sridhar Samudrala 2018-04-20 1:42 ` [PATCH v7 net-next 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit Sridhar Samudrala 2018-04-20 1:42 ` [virtio-dev] " Sridhar Samudrala 2018-04-20 1:42 ` Sridhar Samudrala 2018-04-20 1:42 ` [PATCH v7 net-next 2/4] net: Introduce generic failover module Sridhar Samudrala 2018-04-20 1:42 ` Sridhar Samudrala 2018-04-20 1:42 ` [virtio-dev] " Sridhar Samudrala 2018-04-20 2:44 ` Michael S. Tsirkin 2018-04-20 2:44 ` Michael S. Tsirkin 2018-04-20 2:44 ` [virtio-dev] " Michael S. Tsirkin 2018-04-20 15:21 ` Samudrala, Sridhar 2018-04-20 15:21 ` [virtio-dev] " Samudrala, Sridhar 2018-04-20 15:34 ` Michael S. Tsirkin 2018-04-20 15:34 ` Michael S. Tsirkin 2018-04-20 15:34 ` [virtio-dev] " Michael S. Tsirkin 2018-04-20 15:56 ` Alexander Duyck 2018-04-20 15:56 ` Alexander Duyck 2018-04-20 16:03 ` Michael S. Tsirkin 2018-04-20 16:03 ` Michael S. Tsirkin 2018-04-20 16:03 ` Michael S. Tsirkin 2018-04-20 15:56 ` Alexander Duyck 2018-04-20 15:21 ` Samudrala, Sridhar 2018-04-20 3:34 ` Michael S. Tsirkin 2018-04-20 3:34 ` [virtio-dev] " Michael S. Tsirkin 2018-04-20 3:34 ` Michael S. Tsirkin 2018-04-22 17:06 ` Michael S. Tsirkin 2018-04-22 17:06 ` Michael S. Tsirkin 2018-04-22 17:06 ` [virtio-dev] " Michael S. Tsirkin 2018-04-23 17:21 ` Samudrala, Sridhar 2018-04-23 17:21 ` [virtio-dev] " Samudrala, Sridhar 2018-04-22 18:29 ` kbuild test robot 2018-04-22 18:29 ` kbuild test robot 2018-04-20 1:42 ` [PATCH v7 net-next 3/4] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala 2018-04-20 1:42 ` [virtio-dev] " Sridhar Samudrala 2018-04-20 2:46 ` Michael S. Tsirkin 2018-04-20 2:46 ` [virtio-dev] " Michael S. Tsirkin 2018-04-20 2:46 ` Michael S. Tsirkin 2018-04-22 15:41 ` kbuild test robot 2018-04-22 15:41 ` kbuild test robot 2018-04-22 15:41 ` kbuild test robot 2018-04-22 15:41 ` kbuild test robot 2018-04-20 1:42 ` Sridhar Samudrala 2018-04-20 1:42 ` [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework Sridhar Samudrala 2018-04-20 1:42 ` Sridhar Samudrala 2018-04-20 1:42 ` [virtio-dev] " Sridhar Samudrala 2018-04-20 15:28 ` Stephen Hemminger 2018-04-20 15:43 ` Michael S. Tsirkin 2018-04-20 15:43 ` Michael S. Tsirkin [this message] 2018-04-20 15:43 ` [virtio-dev] " Michael S. Tsirkin 2018-04-20 15:47 ` David Miller 2018-04-20 15:47 ` David Miller 2018-04-20 15:46 ` David Miller 2018-04-20 15:46 ` David Miller 2018-04-20 15:46 ` Samudrala, Sridhar 2018-04-20 15:46 ` Samudrala, Sridhar 2018-04-20 15:46 ` [virtio-dev] " Samudrala, Sridhar 2018-04-20 16:00 ` Jiri Pirko 2018-04-20 16:00 ` Jiri Pirko 2018-04-23 17:04 ` Stephen Hemminger 2018-04-23 17:24 ` Michael S. Tsirkin 2018-04-23 17:24 ` Michael S. Tsirkin 2018-04-23 17:24 ` [virtio-dev] " Michael S. Tsirkin 2018-04-23 17:44 ` Stephen Hemminger 2018-04-23 17:56 ` Michael S. Tsirkin 2018-04-23 17:56 ` Michael S. Tsirkin 2018-04-23 17:56 ` [virtio-dev] " Michael S. Tsirkin 2018-04-23 19:44 ` Siwei Liu 2018-04-23 19:44 ` Siwei Liu 2018-04-23 19:44 ` [virtio-dev] " Siwei Liu 2018-04-23 20:06 ` Michael S. Tsirkin 2018-04-23 20:06 ` Michael S. Tsirkin 2018-04-23 20:06 ` [virtio-dev] " Michael S. Tsirkin 2018-04-24 1:28 ` Stephen Hemminger 2018-04-24 1:28 ` Stephen Hemminger 2018-04-25 21:38 ` Siwei Liu 2018-04-25 21:38 ` [virtio-dev] " Siwei Liu 2018-04-25 22:22 ` Michael S. Tsirkin 2018-04-25 22:22 ` Michael S. Tsirkin 2018-04-25 22:22 ` [virtio-dev] " Michael S. Tsirkin 2018-04-25 22:57 ` Siwei Liu 2018-04-25 22:57 ` [virtio-dev] " Siwei Liu 2018-04-26 0:18 ` Stephen Hemminger 2018-04-26 0:18 ` Stephen Hemminger 2018-04-26 2:43 ` Michael S. Tsirkin 2018-04-26 2:43 ` Michael S. Tsirkin 2018-04-26 2:43 ` [virtio-dev] " Michael S. Tsirkin 2018-04-26 2:28 ` Michael S. Tsirkin 2018-04-26 2:28 ` Michael S. Tsirkin 2018-04-26 2:28 ` [virtio-dev] " Michael S. Tsirkin 2018-04-26 22:14 ` Siwei Liu 2018-04-26 22:14 ` [virtio-dev] " Siwei Liu 2018-04-26 23:42 ` Michael S. Tsirkin 2018-04-26 23:42 ` [virtio-dev] " Michael S. Tsirkin 2018-04-28 0:43 ` Siwei Liu 2018-04-28 0:43 ` Siwei Liu 2018-04-28 0:43 ` [virtio-dev] " Siwei Liu 2018-04-26 23:42 ` Michael S. Tsirkin 2018-04-26 22:14 ` Siwei Liu 2018-04-25 22:57 ` Siwei Liu 2018-04-24 1:25 ` Stephen Hemminger 2018-04-24 1:25 ` Stephen Hemminger 2018-04-24 1:42 ` Michael S. Tsirkin 2018-04-24 1:42 ` Michael S. Tsirkin 2018-04-24 1:42 ` [virtio-dev] " Michael S. Tsirkin 2018-04-24 5:07 ` Stephen Hemminger 2018-04-24 5:07 ` Stephen Hemminger 2018-04-23 17:44 ` Stephen Hemminger 2018-04-23 17:25 ` Jiri Pirko 2018-04-23 17:25 ` Jiri Pirko 2018-04-23 17:04 ` Stephen Hemminger 2018-04-20 15:28 ` Stephen Hemminger 2018-04-22 15:41 ` kbuild test robot 2018-04-22 15:41 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180420183505-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=alexander.h.duyck@intel.com \ --cc=davem@davemloft.net \ --cc=jasowang@redhat.com \ --cc=jesse.brandeburg@intel.com \ --cc=jiri@resnulli.us \ --cc=kubakici@wp.pl \ --cc=loseweigh@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=sridhar.samudrala@intel.com \ --cc=stephen@networkplumber.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.