From: kbuild test robot <lkp@intel.com> To: Sridhar Samudrala <sridhar.samudrala@intel.com> Cc: alexander.h.duyck@intel.com, virtio-dev@lists.oasis-open.org, jiri@resnulli.us, mst@redhat.com, kubakici@wp.pl, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, loseweigh@gmail.com, kbuild-all@01.org, sridhar.samudrala@intel.com, davem@davemloft.net Subject: Re: [PATCH v7 net-next 3/4] virtio_net: Extend virtio to use VF datapath when available Date: Sun, 22 Apr 2018 23:41:42 +0800 [thread overview] Message-ID: <201804222244.LuAoYuup%fengguang.wu@intel.com> (raw) In-Reply-To: <1524188524-28411-4-git-send-email-sridhar.samudrala@intel.com> [-- Attachment #1: Type: text/plain, Size: 3204 bytes --] Hi Sridhar, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on v4.17-rc1] [cannot apply to net-next/master next-20180420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sridhar-Samudrala/Enable-virtio_net-to-act-as-a-standby-for-a-passthru-device/20180422-210557 config: i386-randconfig-a1-04221429 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from drivers//net/virtio_net.c:37:0: include/net/failover.h:67:1: error: expected identifier or '(' before '{' token { ^ >> include/net/failover.h:78:16: warning: 'struct pfailover' declared inside parameter list struct pfailover **pfailover); ^ >> include/net/failover.h:78:16: warning: its scope is only this definition or declaration, which is probably not what you want include/net/failover.h:79:1: error: expected identifier or '(' before '{' token { ^ include/net/failover.h:65:5: warning: 'failover_create' used but never defined int failover_create(struct net_device *standby_dev, ^ include/net/failover.h:77:5: warning: 'failover_register' declared 'static' but never defined [-Wunused-function] int failover_register(struct net_device *standby_dev, struct failover_ops *ops, ^ vim +78 include/net/failover.h 891cac68 Sridhar Samudrala 2018-04-19 63 891cac68 Sridhar Samudrala 2018-04-19 64 static inline 891cac68 Sridhar Samudrala 2018-04-19 65 int failover_create(struct net_device *standby_dev, 891cac68 Sridhar Samudrala 2018-04-19 66 struct failover **pfailover); 891cac68 Sridhar Samudrala 2018-04-19 @67 { 891cac68 Sridhar Samudrala 2018-04-19 68 return 0; 891cac68 Sridhar Samudrala 2018-04-19 69 } 891cac68 Sridhar Samudrala 2018-04-19 70 891cac68 Sridhar Samudrala 2018-04-19 71 static inline 891cac68 Sridhar Samudrala 2018-04-19 72 void failover_destroy(struct failover *failover) 891cac68 Sridhar Samudrala 2018-04-19 73 { 891cac68 Sridhar Samudrala 2018-04-19 74 } 891cac68 Sridhar Samudrala 2018-04-19 75 891cac68 Sridhar Samudrala 2018-04-19 76 static inline 891cac68 Sridhar Samudrala 2018-04-19 77 int failover_register(struct net_device *standby_dev, struct failover_ops *ops, 891cac68 Sridhar Samudrala 2018-04-19 @78 struct pfailover **pfailover); 891cac68 Sridhar Samudrala 2018-04-19 79 { 891cac68 Sridhar Samudrala 2018-04-19 80 return 0; 891cac68 Sridhar Samudrala 2018-04-19 81 } 891cac68 Sridhar Samudrala 2018-04-19 82 :::::: The code at line 78 was first introduced by commit :::::: 891cac68e9283c9561d0097af77e7189b9752719 net: Introduce generic failover module :::::: TO: Sridhar Samudrala <sridhar.samudrala@intel.com> :::::: CC: 0day robot <fengguang.wu@intel.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 29503 bytes --] [-- Attachment #3: Type: text/plain, Size: 183 bytes --] _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com> Cc: alexander.h.duyck@intel.com, virtio-dev@lists.oasis-open.org, jiri@resnulli.us, mst@redhat.com, kubakici@wp.pl, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, loseweigh@gmail.com, kbuild-all@01.org, sridhar.samudrala@intel.com, davem@davemloft.net Subject: Re: [PATCH v7 net-next 3/4] virtio_net: Extend virtio to use VF datapath when available Date: Sun, 22 Apr 2018 23:41:42 +0800 [thread overview] Message-ID: <201804222244.LuAoYuup%fengguang.wu@intel.com> (raw) In-Reply-To: <1524188524-28411-4-git-send-email-sridhar.samudrala@intel.com> [-- Attachment #1: Type: text/plain, Size: 3204 bytes --] Hi Sridhar, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on v4.17-rc1] [cannot apply to net-next/master next-20180420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sridhar-Samudrala/Enable-virtio_net-to-act-as-a-standby-for-a-passthru-device/20180422-210557 config: i386-randconfig-a1-04221429 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from drivers//net/virtio_net.c:37:0: include/net/failover.h:67:1: error: expected identifier or '(' before '{' token { ^ >> include/net/failover.h:78:16: warning: 'struct pfailover' declared inside parameter list struct pfailover **pfailover); ^ >> include/net/failover.h:78:16: warning: its scope is only this definition or declaration, which is probably not what you want include/net/failover.h:79:1: error: expected identifier or '(' before '{' token { ^ include/net/failover.h:65:5: warning: 'failover_create' used but never defined int failover_create(struct net_device *standby_dev, ^ include/net/failover.h:77:5: warning: 'failover_register' declared 'static' but never defined [-Wunused-function] int failover_register(struct net_device *standby_dev, struct failover_ops *ops, ^ vim +78 include/net/failover.h 891cac68 Sridhar Samudrala 2018-04-19 63 891cac68 Sridhar Samudrala 2018-04-19 64 static inline 891cac68 Sridhar Samudrala 2018-04-19 65 int failover_create(struct net_device *standby_dev, 891cac68 Sridhar Samudrala 2018-04-19 66 struct failover **pfailover); 891cac68 Sridhar Samudrala 2018-04-19 @67 { 891cac68 Sridhar Samudrala 2018-04-19 68 return 0; 891cac68 Sridhar Samudrala 2018-04-19 69 } 891cac68 Sridhar Samudrala 2018-04-19 70 891cac68 Sridhar Samudrala 2018-04-19 71 static inline 891cac68 Sridhar Samudrala 2018-04-19 72 void failover_destroy(struct failover *failover) 891cac68 Sridhar Samudrala 2018-04-19 73 { 891cac68 Sridhar Samudrala 2018-04-19 74 } 891cac68 Sridhar Samudrala 2018-04-19 75 891cac68 Sridhar Samudrala 2018-04-19 76 static inline 891cac68 Sridhar Samudrala 2018-04-19 77 int failover_register(struct net_device *standby_dev, struct failover_ops *ops, 891cac68 Sridhar Samudrala 2018-04-19 @78 struct pfailover **pfailover); 891cac68 Sridhar Samudrala 2018-04-19 79 { 891cac68 Sridhar Samudrala 2018-04-19 80 return 0; 891cac68 Sridhar Samudrala 2018-04-19 81 } 891cac68 Sridhar Samudrala 2018-04-19 82 :::::: The code at line 78 was first introduced by commit :::::: 891cac68e9283c9561d0097af77e7189b9752719 net: Introduce generic failover module :::::: TO: Sridhar Samudrala <sridhar.samudrala@intel.com> :::::: CC: 0day robot <fengguang.wu@intel.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 29503 bytes --] [-- Attachment #3: Type: text/plain, Size: 183 bytes --] _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2018-04-22 15:41 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-20 1:42 [PATCH net-next v7 0/4] Enable virtio_net to act as a standby for a passthru device Sridhar Samudrala 2018-04-20 1:42 ` [virtio-dev] " Sridhar Samudrala 2018-04-20 1:42 ` [PATCH v7 net-next 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit Sridhar Samudrala 2018-04-20 1:42 ` [virtio-dev] " Sridhar Samudrala 2018-04-20 1:42 ` Sridhar Samudrala 2018-04-20 1:42 ` [PATCH v7 net-next 2/4] net: Introduce generic failover module Sridhar Samudrala 2018-04-20 1:42 ` Sridhar Samudrala 2018-04-20 1:42 ` [virtio-dev] " Sridhar Samudrala 2018-04-20 2:44 ` Michael S. Tsirkin 2018-04-20 2:44 ` Michael S. Tsirkin 2018-04-20 2:44 ` [virtio-dev] " Michael S. Tsirkin 2018-04-20 15:21 ` Samudrala, Sridhar 2018-04-20 15:21 ` [virtio-dev] " Samudrala, Sridhar 2018-04-20 15:34 ` Michael S. Tsirkin 2018-04-20 15:34 ` Michael S. Tsirkin 2018-04-20 15:34 ` [virtio-dev] " Michael S. Tsirkin 2018-04-20 15:56 ` Alexander Duyck 2018-04-20 15:56 ` Alexander Duyck 2018-04-20 16:03 ` Michael S. Tsirkin 2018-04-20 16:03 ` Michael S. Tsirkin 2018-04-20 16:03 ` Michael S. Tsirkin 2018-04-20 15:56 ` Alexander Duyck 2018-04-20 15:21 ` Samudrala, Sridhar 2018-04-20 3:34 ` Michael S. Tsirkin 2018-04-20 3:34 ` [virtio-dev] " Michael S. Tsirkin 2018-04-20 3:34 ` Michael S. Tsirkin 2018-04-22 17:06 ` Michael S. Tsirkin 2018-04-22 17:06 ` Michael S. Tsirkin 2018-04-22 17:06 ` [virtio-dev] " Michael S. Tsirkin 2018-04-23 17:21 ` Samudrala, Sridhar 2018-04-23 17:21 ` [virtio-dev] " Samudrala, Sridhar 2018-04-22 18:29 ` kbuild test robot 2018-04-22 18:29 ` kbuild test robot 2018-04-20 1:42 ` [PATCH v7 net-next 3/4] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala 2018-04-20 1:42 ` [virtio-dev] " Sridhar Samudrala 2018-04-20 2:46 ` Michael S. Tsirkin 2018-04-20 2:46 ` [virtio-dev] " Michael S. Tsirkin 2018-04-20 2:46 ` Michael S. Tsirkin 2018-04-22 15:41 ` kbuild test robot 2018-04-22 15:41 ` kbuild test robot 2018-04-22 15:41 ` kbuild test robot [this message] 2018-04-22 15:41 ` kbuild test robot 2018-04-20 1:42 ` Sridhar Samudrala 2018-04-20 1:42 ` [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework Sridhar Samudrala 2018-04-20 1:42 ` Sridhar Samudrala 2018-04-20 1:42 ` [virtio-dev] " Sridhar Samudrala 2018-04-20 15:28 ` Stephen Hemminger 2018-04-20 15:43 ` Michael S. Tsirkin 2018-04-20 15:43 ` Michael S. Tsirkin 2018-04-20 15:43 ` [virtio-dev] " Michael S. Tsirkin 2018-04-20 15:47 ` David Miller 2018-04-20 15:47 ` David Miller 2018-04-20 15:46 ` David Miller 2018-04-20 15:46 ` David Miller 2018-04-20 15:46 ` Samudrala, Sridhar 2018-04-20 15:46 ` Samudrala, Sridhar 2018-04-20 15:46 ` [virtio-dev] " Samudrala, Sridhar 2018-04-20 16:00 ` Jiri Pirko 2018-04-20 16:00 ` Jiri Pirko 2018-04-23 17:04 ` Stephen Hemminger 2018-04-23 17:24 ` Michael S. Tsirkin 2018-04-23 17:24 ` Michael S. Tsirkin 2018-04-23 17:24 ` [virtio-dev] " Michael S. Tsirkin 2018-04-23 17:44 ` Stephen Hemminger 2018-04-23 17:56 ` Michael S. Tsirkin 2018-04-23 17:56 ` Michael S. Tsirkin 2018-04-23 17:56 ` [virtio-dev] " Michael S. Tsirkin 2018-04-23 19:44 ` Siwei Liu 2018-04-23 19:44 ` Siwei Liu 2018-04-23 19:44 ` [virtio-dev] " Siwei Liu 2018-04-23 20:06 ` Michael S. Tsirkin 2018-04-23 20:06 ` Michael S. Tsirkin 2018-04-23 20:06 ` [virtio-dev] " Michael S. Tsirkin 2018-04-24 1:28 ` Stephen Hemminger 2018-04-24 1:28 ` Stephen Hemminger 2018-04-25 21:38 ` Siwei Liu 2018-04-25 21:38 ` [virtio-dev] " Siwei Liu 2018-04-25 22:22 ` Michael S. Tsirkin 2018-04-25 22:22 ` Michael S. Tsirkin 2018-04-25 22:22 ` [virtio-dev] " Michael S. Tsirkin 2018-04-25 22:57 ` Siwei Liu 2018-04-25 22:57 ` [virtio-dev] " Siwei Liu 2018-04-26 0:18 ` Stephen Hemminger 2018-04-26 0:18 ` Stephen Hemminger 2018-04-26 2:43 ` Michael S. Tsirkin 2018-04-26 2:43 ` Michael S. Tsirkin 2018-04-26 2:43 ` [virtio-dev] " Michael S. Tsirkin 2018-04-26 2:28 ` Michael S. Tsirkin 2018-04-26 2:28 ` Michael S. Tsirkin 2018-04-26 2:28 ` [virtio-dev] " Michael S. Tsirkin 2018-04-26 22:14 ` Siwei Liu 2018-04-26 22:14 ` [virtio-dev] " Siwei Liu 2018-04-26 23:42 ` Michael S. Tsirkin 2018-04-26 23:42 ` [virtio-dev] " Michael S. Tsirkin 2018-04-28 0:43 ` Siwei Liu 2018-04-28 0:43 ` Siwei Liu 2018-04-28 0:43 ` [virtio-dev] " Siwei Liu 2018-04-26 23:42 ` Michael S. Tsirkin 2018-04-26 22:14 ` Siwei Liu 2018-04-25 22:57 ` Siwei Liu 2018-04-24 1:25 ` Stephen Hemminger 2018-04-24 1:25 ` Stephen Hemminger 2018-04-24 1:42 ` Michael S. Tsirkin 2018-04-24 1:42 ` Michael S. Tsirkin 2018-04-24 1:42 ` [virtio-dev] " Michael S. Tsirkin 2018-04-24 5:07 ` Stephen Hemminger 2018-04-24 5:07 ` Stephen Hemminger 2018-04-23 17:44 ` Stephen Hemminger 2018-04-23 17:25 ` Jiri Pirko 2018-04-23 17:25 ` Jiri Pirko 2018-04-23 17:04 ` Stephen Hemminger 2018-04-20 15:28 ` Stephen Hemminger 2018-04-22 15:41 ` kbuild test robot 2018-04-22 15:41 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201804222244.LuAoYuup%fengguang.wu@intel.com \ --to=lkp@intel.com \ --cc=alexander.h.duyck@intel.com \ --cc=davem@davemloft.net \ --cc=jiri@resnulli.us \ --cc=kbuild-all@01.org \ --cc=kubakici@wp.pl \ --cc=loseweigh@gmail.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=sridhar.samudrala@intel.com \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.