All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: [PATCH v3 4/5] eal: set affinity for control threads
Date: Tue, 24 Apr 2018 16:46:50 +0200	[thread overview]
Message-ID: <20180424144651.13145-5-olivier.matz@6wind.com> (raw)
In-Reply-To: <20180424144651.13145-1-olivier.matz@6wind.com>

The management threads must not bother the dataplane or service cores.
Set the affinity of these threads accordingly.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 lib/librte_eal/common/eal_common_thread.c | 22 +++++++++++++++++++++-
 lib/librte_eal/common/include/rte_lcore.h |  4 +++-
 2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
index 94d2a6e42..4e75cb81f 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -16,6 +16,7 @@
 #include <rte_memory.h>
 #include <rte_log.h>
 
+#include "eal_private.h"
 #include "eal_thread.h"
 
 RTE_DECLARE_PER_LCORE(unsigned , _socket_id);
@@ -169,7 +170,9 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
 		.start_routine = start_routine,
 		.arg = arg,
 	};
-	int ret;
+	unsigned int lcore_id;
+	rte_cpuset_t cpuset;
+	int cpu_found, ret;
 
 	pthread_barrier_init(&params.configured, NULL, 2);
 
@@ -183,6 +186,23 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
 			goto fail;
 	}
 
+	cpu_found = 0;
+	CPU_ZERO(&cpuset);
+	for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+		if (eal_cpu_detected(lcore_id) &&
+				rte_lcore_has_role(lcore_id, ROLE_OFF)) {
+			CPU_SET(lcore_id, &cpuset);
+			cpu_found = 1;
+		}
+	}
+	/* if no detected cpu is off, use master core */
+	if (!cpu_found)
+		CPU_SET(rte_get_master_lcore(), &cpuset);
+
+	ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset);
+	if (ret < 0)
+		goto fail;
+
 	pthread_barrier_wait(&params.configured);
 
 	return 0;
diff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h
index eb39c2a8b..334a0629e 100644
--- a/lib/librte_eal/common/include/rte_lcore.h
+++ b/lib/librte_eal/common/include/rte_lcore.h
@@ -279,7 +279,9 @@ int rte_thread_setname(pthread_t id, const char *name);
 /**
  * Create a control thread.
  *
- * Wrapper to pthread_create() and pthread_setname_np().
+ * Wrapper to pthread_create(), pthread_setname_np() and
+ * pthread_setaffinity_np(). The dataplane and service lcores are
+ * excluded from the affinity of the new thread.
  *
  * @param thread
  *   Filled with the thread id of the new created thread.
-- 
2.11.0

  parent reply	other threads:[~2018-04-24 14:47 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03 13:04 [PATCH v2 0/4] fix control thread affinities Olivier Matz
2018-04-03 13:04 ` [PATCH v2 1/4] eal: use sizeof to avoid a double use of a define Olivier Matz
2018-04-10 16:18   ` Burakov, Anatoly
2018-04-03 13:04 ` [PATCH v2 2/4] eal: new function to create control threads Olivier Matz
2018-04-10 16:18   ` Burakov, Anatoly
2018-04-03 13:04 ` [PATCH v2 3/4] eal: set name when creating a control thread Olivier Matz
2018-04-10 16:34   ` Burakov, Anatoly
2018-04-23 12:49     ` Olivier Matz
2018-04-17 22:32   ` Thomas Monjalon
2018-04-23 12:52     ` Olivier Matz
2018-04-03 13:04 ` [PATCH v2 4/4] eal: set affinity for control threads Olivier Matz
2018-04-10 16:18   ` Burakov, Anatoly
2018-04-03 13:13 ` [PATCH v2 0/4] fix control thread affinities Olivier Matz
2018-04-10 16:20 ` Burakov, Anatoly
2018-04-24 14:46 ` [PATCH v3 0/5] " Olivier Matz
2018-04-24 14:46   ` [PATCH v3 1/5] eal: use sizeof to avoid a double use of a define Olivier Matz
2018-04-24 14:46   ` [PATCH v3 2/5] eal: new function to create control threads Olivier Matz
2018-04-24 14:46   ` [PATCH v3 3/5] eal: set name when creating a control thread Olivier Matz
2018-04-24 16:08     ` Burakov, Anatoly
2018-04-27 15:46     ` Tan, Jianfeng
2018-04-27 16:17       ` Tan, Jianfeng
2018-04-27 16:46         ` Burakov, Anatoly
2018-04-24 14:46   ` Olivier Matz [this message]
2018-04-24 14:46   ` [PATCH v3 5/5] examples: use new API to create control threads Olivier Matz
2018-04-24 22:53   ` [PATCH v3 0/5] fix control thread affinities Thomas Monjalon
2018-04-30 15:45   ` pthread_barrier_deadlock in -rc1 (was: "Re: [PATCH v3 0/5] fix control thread affinities") Maxime Coquelin
2018-04-30 18:46     ` Olivier Matz
2018-05-01  8:59       ` Thomas Monjalon
2018-05-02  8:19       ` pthread_barrier_deadlock in -rc1 Tan, Jianfeng
2018-05-02  8:34         ` Maxime Coquelin
2018-05-02  8:50           ` Tan, Jianfeng
2018-05-02  9:05             ` Maxime Coquelin
2018-05-02  9:20               ` Olivier Matz
2018-05-02  9:32                 ` Tan, Jianfeng
2018-05-02  9:41                   ` Maxime Coquelin
2018-05-02  9:30             ` Burakov, Anatoly
2018-05-02  9:38               ` Tan, Jianfeng
2018-05-02  9:57               ` Olivier Matz
2018-05-02 10:01                 ` Tan, Jianfeng
2018-05-02 10:08                   ` Olivier Matz
2018-05-02 10:16                     ` Tan, Jianfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424144651.13145-5-olivier.matz@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.