Re: [PATCH v2 3/4] eal: set name when creating a control thread

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 03-Apr-18 2:04 PM, Olivier Matz wrote:
> To avoid code duplication, add a parameter to rte_ctrl_thread_create()
> to specify the name of the thread.
> 
> This requires to add a wrapper for the thread start routine in
> rte_thread_init(), which will first wait that the thread is configured.
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---

<...>

> +
> +	pthread_barrier_wait(&params.configured);
> +
> +	return 0;
> +
> +fail:
> +	pthread_kill(*thread, SIGTERM);

This may be wrong, but perhaps instead of killing the thread outright, a 
better approach would be pthread_cancel? I'm always uneasy about mixing 
signals and pthreads...

> +	pthread_join(*thread, NULL);
> +	return ret;
>   }

-- 
Thanks,
Anatoly