All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/10] ARM, arm64: dts: renesas: update register properties
@ 2018-04-26 10:29 ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Kuninori Morimoto, Simon Horman

Hi,

this series:

1. Drops unnecessary address properties from VIN port nodes
   on Renesas R-Car Gen2 SoC board DTSes. These are unnecessary
   as the nodes to not have bus addresses.

2. And adds address properties to R-Car Sound port nodes on
   Renesas R-Car Gen2 SoC DTSes. These are necessary as the nodes
   have unit names.

Simon Horman (10):
  ARM: dts: lager: Drop unnecessary address properties from port node
  ARM: dts: porter: Drop unnecessary address properties from vin port
    node
  ARM: dts: gose: Drop unnecessary address properties from port nodes
  ARM: dts: koelsch: Drop unnecessary address properties from port nodes
  ARM: dts: alt: Drop unnecessary address properties from vin port node
  ARM: dts: silk: Drop unnecessary address properties from vin port node
  ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys
    node
  arm64: dts: renesas: r8a7795: Add address properties to rcar_sound
    port nodes
  arm64: dts: renesas: r8a7796: Add address properties to rcar_sound
    port nodes
  arm64: dts: renesas: r8a77965: Add address properties to rcar_sound
    port nodes

 arch/arm/boot/dts/emev2-kzm9d.dts         |  3 ---
 arch/arm/boot/dts/r8a7790-lager.dts       |  3 ---
 arch/arm/boot/dts/r8a7791-koelsch.dts     |  6 ------
 arch/arm/boot/dts/r8a7791-porter.dts      |  3 ---
 arch/arm/boot/dts/r8a7793-gose.dts        |  6 ------
 arch/arm/boot/dts/r8a7794-alt.dts         |  3 ---
 arch/arm/boot/dts/r8a7794-silk.dts        |  3 ---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 14 ++++++++++++++
 arch/arm64/boot/dts/renesas/r8a7796.dtsi  | 11 +++++++++++
 arch/arm64/boot/dts/renesas/r8a77965.dtsi |  8 ++++++++
 10 files changed, 33 insertions(+), 27 deletions(-)

-- 
2.11.0

^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 00/10] ARM, arm64: dts: renesas: update register properties
@ 2018-04-26 10:29 ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

this series:

1. Drops unnecessary address properties from VIN port nodes
   on Renesas R-Car Gen2 SoC board DTSes. These are unnecessary
   as the nodes to not have bus addresses.

2. And adds address properties to R-Car Sound port nodes on
   Renesas R-Car Gen2 SoC DTSes. These are necessary as the nodes
   have unit names.

Simon Horman (10):
  ARM: dts: lager: Drop unnecessary address properties from port node
  ARM: dts: porter: Drop unnecessary address properties from vin port
    node
  ARM: dts: gose: Drop unnecessary address properties from port nodes
  ARM: dts: koelsch: Drop unnecessary address properties from port nodes
  ARM: dts: alt: Drop unnecessary address properties from vin port node
  ARM: dts: silk: Drop unnecessary address properties from vin port node
  ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys
    node
  arm64: dts: renesas: r8a7795: Add address properties to rcar_sound
    port nodes
  arm64: dts: renesas: r8a7796: Add address properties to rcar_sound
    port nodes
  arm64: dts: renesas: r8a77965: Add address properties to rcar_sound
    port nodes

 arch/arm/boot/dts/emev2-kzm9d.dts         |  3 ---
 arch/arm/boot/dts/r8a7790-lager.dts       |  3 ---
 arch/arm/boot/dts/r8a7791-koelsch.dts     |  6 ------
 arch/arm/boot/dts/r8a7791-porter.dts      |  3 ---
 arch/arm/boot/dts/r8a7793-gose.dts        |  6 ------
 arch/arm/boot/dts/r8a7794-alt.dts         |  3 ---
 arch/arm/boot/dts/r8a7794-silk.dts        |  3 ---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 14 ++++++++++++++
 arch/arm64/boot/dts/renesas/r8a7796.dtsi  | 11 +++++++++++
 arch/arm64/boot/dts/renesas/r8a77965.dtsi |  8 ++++++++
 10 files changed, 33 insertions(+), 27 deletions(-)

-- 
2.11.0

^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 01/10] ARM: dts: lager: Drop unnecessary address properties from port node
  2018-04-26 10:29 ` Simon Horman
@ 2018-04-26 10:29   ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Kuninori Morimoto, Simon Horman

The vin port node does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7790-lager.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef1000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7790-lager.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 7576f9f9bdba..092610e3f953 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -902,9 +902,6 @@
 	status = "okay";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin1ep0: endpoint {
 			remote-endpoint = <&adv7180>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 01/10] ARM: dts: lager: Drop unnecessary address properties from port node
@ 2018-04-26 10:29   ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

The vin port node does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7790-lager.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef1000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7790-lager.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 7576f9f9bdba..092610e3f953 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -902,9 +902,6 @@
 	status = "okay";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin1ep0: endpoint {
 			remote-endpoint = <&adv7180>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 02/10] ARM: dts: porter: Drop unnecessary address properties from vin port node
  2018-04-26 10:29 ` Simon Horman
@ 2018-04-26 10:29   ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Kuninori Morimoto, Simon Horman

The vin port node does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7791-porter.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef0000/port: unnecessary #address-cells/#size-cells without

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7791-porter.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts
index c336aa17b79e..a01101b49d99 100644
--- a/arch/arm/boot/dts/r8a7791-porter.dts
+++ b/arch/arm/boot/dts/r8a7791-porter.dts
@@ -386,9 +386,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin0ep: endpoint {
 			remote-endpoint = <&adv7180>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 02/10] ARM: dts: porter: Drop unnecessary address properties from vin port node
@ 2018-04-26 10:29   ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

The vin port node does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7791-porter.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef0000/port: unnecessary #address-cells/#size-cells without

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7791-porter.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts
index c336aa17b79e..a01101b49d99 100644
--- a/arch/arm/boot/dts/r8a7791-porter.dts
+++ b/arch/arm/boot/dts/r8a7791-porter.dts
@@ -386,9 +386,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin0ep: endpoint {
 			remote-endpoint = <&adv7180>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 03/10] ARM: dts: gose: Drop unnecessary address properties from port nodes
  2018-04-26 10:29 ` Simon Horman
@ 2018-04-26 10:29   ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Kuninori Morimoto, Simon Horman

The vin port nodes does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7793-gose.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
 arch/arm/boot/dts/r8a7793-gose.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef1000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7793-gose.dts | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
index 4c10285d769a..aa209f6e5d71 100644
--- a/arch/arm/boot/dts/r8a7793-gose.dts
+++ b/arch/arm/boot/dts/r8a7793-gose.dts
@@ -763,9 +763,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin0ep2: endpoint {
 			remote-endpoint = <&adv7612_out>;
 			bus-width = <24>;
@@ -785,9 +782,6 @@
 	status = "okay";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin1ep: endpoint {
 			remote-endpoint = <&adv7180_out>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 03/10] ARM: dts: gose: Drop unnecessary address properties from port nodes
@ 2018-04-26 10:29   ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

The vin port nodes does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7793-gose.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
 arch/arm/boot/dts/r8a7793-gose.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef1000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7793-gose.dts | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
index 4c10285d769a..aa209f6e5d71 100644
--- a/arch/arm/boot/dts/r8a7793-gose.dts
+++ b/arch/arm/boot/dts/r8a7793-gose.dts
@@ -763,9 +763,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin0ep2: endpoint {
 			remote-endpoint = <&adv7612_out>;
 			bus-width = <24>;
@@ -785,9 +782,6 @@
 	status = "okay";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin1ep: endpoint {
 			remote-endpoint = <&adv7180_out>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 04/10] ARM: dts: koelsch: Drop unnecessary address properties from port nodes
  2018-04-26 10:29 ` Simon Horman
@ 2018-04-26 10:29   ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Kuninori Morimoto, Simon Horman

The vin port nodes does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7791-koelsch.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
 arch/arm/boot/dts/r8a7791-koelsch.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef1000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index e394e0487416..8ab793d8b2fd 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -855,9 +855,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin0ep2: endpoint {
 			remote-endpoint = <&adv7612_out>;
 			bus-width = <24>;
@@ -876,9 +873,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin1ep: endpoint {
 			remote-endpoint = <&adv7180>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 04/10] ARM: dts: koelsch: Drop unnecessary address properties from port nodes
@ 2018-04-26 10:29   ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

The vin port nodes does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7791-koelsch.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
 arch/arm/boot/dts/r8a7791-koelsch.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef1000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index e394e0487416..8ab793d8b2fd 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -855,9 +855,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin0ep2: endpoint {
 			remote-endpoint = <&adv7612_out>;
 			bus-width = <24>;
@@ -876,9 +873,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin1ep: endpoint {
 			remote-endpoint = <&adv7180>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 05/10] ARM: dts: alt: Drop unnecessary address properties from vin port node
  2018-04-26 10:29 ` Simon Horman
@ 2018-04-26 10:29   ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Kuninori Morimoto, Simon Horman

The vin port node does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7794-alt.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7794-alt.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
index 1ecc5b9135f3..c210412f80ec 100644
--- a/arch/arm/boot/dts/r8a7794-alt.dts
+++ b/arch/arm/boot/dts/r8a7794-alt.dts
@@ -380,9 +380,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin0ep: endpoint {
 			remote-endpoint = <&adv7180>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 05/10] ARM: dts: alt: Drop unnecessary address properties from vin port node
@ 2018-04-26 10:29   ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

The vin port node does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7794-alt.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7794-alt.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
index 1ecc5b9135f3..c210412f80ec 100644
--- a/arch/arm/boot/dts/r8a7794-alt.dts
+++ b/arch/arm/boot/dts/r8a7794-alt.dts
@@ -380,9 +380,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin0ep: endpoint {
 			remote-endpoint = <&adv7180>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 06/10] ARM: dts: silk: Drop unnecessary address properties from vin port node
  2018-04-26 10:29 ` Simon Horman
@ 2018-04-26 10:29   ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Kuninori Morimoto, Simon Horman

The vin port node does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7794-silk.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7794-silk.dts b/arch/arm/boot/dts/r8a7794-silk.dts
index e2642d2c2eed..7808aaee6644 100644
--- a/arch/arm/boot/dts/r8a7794-silk.dts
+++ b/arch/arm/boot/dts/r8a7794-silk.dts
@@ -475,9 +475,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin0ep: endpoint {
 			remote-endpoint = <&adv7180>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 06/10] ARM: dts: silk: Drop unnecessary address properties from vin port node
@ 2018-04-26 10:29   ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

The vin port node does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7794-silk.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7794-silk.dts b/arch/arm/boot/dts/r8a7794-silk.dts
index e2642d2c2eed..7808aaee6644 100644
--- a/arch/arm/boot/dts/r8a7794-silk.dts
+++ b/arch/arm/boot/dts/r8a7794-silk.dts
@@ -475,9 +475,6 @@
 	pinctrl-names = "default";
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		vin0ep: endpoint {
 			remote-endpoint = <&adv7180>;
 			bus-width = <8>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node
  2018-04-26 10:29 ` Simon Horman
@ 2018-04-26 10:29   ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Kuninori Morimoto, Simon Horman

The gpio_keys node does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/emev2-kzm9d.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts
index c238407133bf..0af44b7eadb9 100644
--- a/arch/arm/boot/dts/emev2-kzm9d.dts
+++ b/arch/arm/boot/dts/emev2-kzm9d.dts
@@ -34,9 +34,6 @@
 
 	gpio_keys {
 		compatible = "gpio-keys";
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		one {
 			debounce-interval = <50>;
 			wakeup-source;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node
@ 2018-04-26 10:29   ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

The gpio_keys node does not have an address and thus does not need
address-cells or address size-properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/emev2-kzm9d.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts
index c238407133bf..0af44b7eadb9 100644
--- a/arch/arm/boot/dts/emev2-kzm9d.dts
+++ b/arch/arm/boot/dts/emev2-kzm9d.dts
@@ -34,9 +34,6 @@
 
 	gpio_keys {
 		compatible = "gpio-keys";
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		one {
 			debounce-interval = <50>;
 			wakeup-source;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 08/10] arm64: dts: renesas: r8a7795: Add address properties to rcar_sound port nodes
  2018-04-26 10:29 ` Simon Horman
@ 2018-04-26 10:29   ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Kuninori Morimoto, Simon Horman

The rcar_sound port nodes have unit names and thus should have register
properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 ...
 DTC     arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@1: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@2: node has a unit name, but no reg property
  ...
  DTC     arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@1: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@2: node has a unit name, but no reg property
  DTC     arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@1: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@2: node has a unit name, but no reg property

Prior to this patch the port nodes only defined in board DTS files.
As the register properties are common this patch defines the port nodes
and provides register properties in the SoC DTS file.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index b1c52dae4d49..9b080a864ea1 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1711,6 +1711,20 @@
 					dma-names = "rx", "tx", "rxu", "txu";
 				};
 			};
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				port@0 {
+					reg = <0>;
+				};
+				port@1 {
+					reg = <1>;
+				};
+				port@2 {
+					reg = <2>;
+				};
+			};
 		};
 
 		audma0: dma-controller@ec700000 {
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 08/10] arm64: dts: renesas: r8a7795: Add address properties to rcar_sound port nodes
@ 2018-04-26 10:29   ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

The rcar_sound port nodes have unit names and thus should have register
properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 ...
 DTC     arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 0: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 1: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 2: node has a unit name, but no reg property
  ...
  DTC     arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 0: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 1: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 2: node has a unit name, but no reg property
  DTC     arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 0: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 1: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 2: node has a unit name, but no reg property

Prior to this patch the port nodes only defined in board DTS files.
As the register properties are common this patch defines the port nodes
and provides register properties in the SoC DTS file.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index b1c52dae4d49..9b080a864ea1 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1711,6 +1711,20 @@
 					dma-names = "rx", "tx", "rxu", "txu";
 				};
 			};
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				port at 0 {
+					reg = <0>;
+				};
+				port at 1 {
+					reg = <1>;
+				};
+				port at 2 {
+					reg = <2>;
+				};
+			};
 		};
 
 		audma0: dma-controller at ec700000 {
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 09/10] arm64: dts: renesas: r8a7796: Add address properties to rcar_sound port nodes
  2018-04-26 10:29 ` Simon Horman
@ 2018-04-26 10:29   ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Kuninori Morimoto, Simon Horman

The rcar_sound port nodes have unit names and thus should have register
properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 ...
 DTC     arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dtb
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, but no reg property
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@1: node has a unit name, but no reg property
 ...
 DTC     arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dtb
 arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, but no reg property
 arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@1: node has a unit name, but no reg property

Prior to this patch the port nodes only defined in board DTS files.
As the register properties are common this patch defines the port nodes
and provides register properties in the SoC DTS file.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index f41bc25b3933..3fbd86590fb0 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1594,6 +1594,17 @@
 					dma-names = "rx", "tx", "rxu", "txu";
 				};
 			};
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				port@0 {
+					reg = <0>;
+				};
+				port@1 {
+					reg = <1>;
+				};
+			};
 		};
 
 		audma0: dma-controller@ec700000 {
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 09/10] arm64: dts: renesas: r8a7796: Add address properties to rcar_sound port nodes
@ 2018-04-26 10:29   ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

The rcar_sound port nodes have unit names and thus should have register
properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 ...
 DTC     arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dtb
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 0: node has a unit name, but no reg property
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 1: node has a unit name, but no reg property
 ...
 DTC     arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dtb
 arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 0: node has a unit name, but no reg property
 arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 1: node has a unit name, but no reg property

Prior to this patch the port nodes only defined in board DTS files.
As the register properties are common this patch defines the port nodes
and provides register properties in the SoC DTS file.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index f41bc25b3933..3fbd86590fb0 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1594,6 +1594,17 @@
 					dma-names = "rx", "tx", "rxu", "txu";
 				};
 			};
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				port at 0 {
+					reg = <0>;
+				};
+				port at 1 {
+					reg = <1>;
+				};
+			};
 		};
 
 		audma0: dma-controller at ec700000 {
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 10/10] arm64: dts: renesas: r8a77965: Add address properties to rcar_sound port nodes
  2018-04-26 10:29 ` Simon Horman
@ 2018-04-26 10:29   ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Kuninori Morimoto, Simon Horman

The rcar_sound port nodes have unit names and thus should have register
properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 ...
 DTC     arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, but no reg property
 DTC     arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, but no reg property

Prior to this patch the port nodes only defined in board DTS files.
As the register properties are common this patch defines the port nodes
and provides register properties in the SoC DTS file.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index b12f41755aea..88202eff6e12 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -856,6 +856,14 @@
 				ssi1: ssi-1 {
 				};
 			};
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				port@0 {
+					reg = <0>;
+				};
+			};
 		};
 
 		xhci0: usb@ee000000 {
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* [PATCH 10/10] arm64: dts: renesas: r8a77965: Add address properties to rcar_sound port nodes
@ 2018-04-26 10:29   ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-26 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

The rcar_sound port nodes have unit names and thus should have register
properties.

This is flagged by dtc as follows:
 # make dtbs W=1
 ...
 DTC     arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dtb
arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 0: node has a unit name, but no reg property
 DTC     arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dtb
arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dtb: Warning (unit_address_vs_reg): /soc/sound at ec500000/ports/port at 0: node has a unit name, but no reg property

Prior to this patch the port nodes only defined in board DTS files.
As the register properties are common this patch defines the port nodes
and provides register properties in the SoC DTS file.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index b12f41755aea..88202eff6e12 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -856,6 +856,14 @@
 				ssi1: ssi-1 {
 				};
 			};
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				port at 0 {
+					reg = <0>;
+				};
+			};
 		};
 
 		xhci0: usb at ee000000 {
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 32+ messages in thread

* Re: [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node
  2018-04-26 10:29   ` Simon Horman
@ 2018-04-26 14:52     ` Niklas Söderlund
  -1 siblings, 0 replies; 32+ messages in thread
From: Niklas Söderlund @ 2018-04-26 14:52 UTC (permalink / raw)
  To: Simon Horman
  Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm, Kuninori Morimoto

Hi Simon,

Thanks for your work.

On 2018-04-26 12:29:48 +0200, Simon Horman wrote:
> The gpio_keys node does not have an address and thus does not need
> address-cells or address size-properties.
> 
> This is flagged by dtc as follows:
>  # make dtbs W=1
>  arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

This warning don't seem to match with the change nor the rest of the 
commit message :-)

With that addressed and for the whole series:

Reviewed-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>

> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/boot/dts/emev2-kzm9d.dts | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts
> index c238407133bf..0af44b7eadb9 100644
> --- a/arch/arm/boot/dts/emev2-kzm9d.dts
> +++ b/arch/arm/boot/dts/emev2-kzm9d.dts
> @@ -34,9 +34,6 @@
>  
>  	gpio_keys {
>  		compatible = "gpio-keys";
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -
>  		one {
>  			debounce-interval = <50>;
>  			wakeup-source;
> -- 
> 2.11.0
> 

-- 
Regards,
Niklas S�derlund

^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node
@ 2018-04-26 14:52     ` Niklas Söderlund
  0 siblings, 0 replies; 32+ messages in thread
From: Niklas Söderlund @ 2018-04-26 14:52 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Simon,

Thanks for your work.

On 2018-04-26 12:29:48 +0200, Simon Horman wrote:
> The gpio_keys node does not have an address and thus does not need
> address-cells or address size-properties.
> 
> This is flagged by dtc as follows:
>  # make dtbs W=1
>  arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

This warning don't seem to match with the change nor the rest of the 
commit message :-)

With that addressed and for the whole series:

Reviewed-by: Niklas S?derlund <niklas.soderlund+renesas@ragnatech.se>

> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/boot/dts/emev2-kzm9d.dts | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts
> index c238407133bf..0af44b7eadb9 100644
> --- a/arch/arm/boot/dts/emev2-kzm9d.dts
> +++ b/arch/arm/boot/dts/emev2-kzm9d.dts
> @@ -34,9 +34,6 @@
>  
>  	gpio_keys {
>  		compatible = "gpio-keys";
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -
>  		one {
>  			debounce-interval = <50>;
>  			wakeup-source;
> -- 
> 2.11.0
> 

-- 
Regards,
Niklas S?derlund

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node
  2018-04-26 14:52     ` Niklas Söderlund
@ 2018-04-30  7:07       ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-30  7:07 UTC (permalink / raw)
  To: Niklas Söderlund
  Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm, Kuninori Morimoto

On Thu, Apr 26, 2018 at 04:52:13PM +0200, Niklas Söderlund wrote:
> Hi Simon,
> 
> Thanks for your work.
> 
> On 2018-04-26 12:29:48 +0200, Simon Horman wrote:
> > The gpio_keys node does not have an address and thus does not need
> > address-cells or address size-properties.
> > 
> > This is flagged by dtc as follows:
> >  # make dtbs W=1
> >  arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> This warning don't seem to match with the change nor the rest of the 
> commit message :-)
> 
> With that addressed and for the whole series:
> 
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks!

The fix is:

arch/arm/boot/dts/emev2-kzm9d.dtb: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm/boot/dts/emev2-kzm9d.dts | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts
> > index c238407133bf..0af44b7eadb9 100644
> > --- a/arch/arm/boot/dts/emev2-kzm9d.dts
> > +++ b/arch/arm/boot/dts/emev2-kzm9d.dts
> > @@ -34,9 +34,6 @@
> >  
> >  	gpio_keys {
> >  		compatible = "gpio-keys";
> > -		#address-cells = <1>;
> > -		#size-cells = <0>;
> > -
> >  		one {
> >  			debounce-interval = <50>;
> >  			wakeup-source;
> > -- 
> > 2.11.0
> > 
> 
> -- 
> Regards,
> Niklas Söderlund
> 

^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node
@ 2018-04-30  7:07       ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-04-30  7:07 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Apr 26, 2018 at 04:52:13PM +0200, Niklas S?derlund wrote:
> Hi Simon,
> 
> Thanks for your work.
> 
> On 2018-04-26 12:29:48 +0200, Simon Horman wrote:
> > The gpio_keys node does not have an address and thus does not need
> > address-cells or address size-properties.
> > 
> > This is flagged by dtc as follows:
> >  # make dtbs W=1
> >  arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> This warning don't seem to match with the change nor the rest of the 
> commit message :-)
> 
> With that addressed and for the whole series:
> 
> Reviewed-by: Niklas S?derlund <niklas.soderlund+renesas@ragnatech.se>

Thanks!

The fix is:

arch/arm/boot/dts/emev2-kzm9d.dtb: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm/boot/dts/emev2-kzm9d.dts | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts
> > index c238407133bf..0af44b7eadb9 100644
> > --- a/arch/arm/boot/dts/emev2-kzm9d.dts
> > +++ b/arch/arm/boot/dts/emev2-kzm9d.dts
> > @@ -34,9 +34,6 @@
> >  
> >  	gpio_keys {
> >  		compatible = "gpio-keys";
> > -		#address-cells = <1>;
> > -		#size-cells = <0>;
> > -
> >  		one {
> >  			debounce-interval = <50>;
> >  			wakeup-source;
> > -- 
> > 2.11.0
> > 
> 
> -- 
> Regards,
> Niklas S?derlund
> 

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node
  2018-04-30  7:07       ` Simon Horman
@ 2018-05-02  6:56         ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-05-02  6:56 UTC (permalink / raw)
  To: Niklas Söderlund
  Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm, Kuninori Morimoto

On Mon, Apr 30, 2018 at 09:07:48AM +0200, Simon Horman wrote:
> On Thu, Apr 26, 2018 at 04:52:13PM +0200, Niklas Söderlund wrote:
> > Hi Simon,
> > 
> > Thanks for your work.
> > 
> > On 2018-04-26 12:29:48 +0200, Simon Horman wrote:
> > > The gpio_keys node does not have an address and thus does not need
> > > address-cells or address size-properties.
> > > 
> > > This is flagged by dtc as follows:
> > >  # make dtbs W=1
> > >  arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> > 
> > This warning don't seem to match with the change nor the rest of the 
> > commit message :-)
> > 
> > With that addressed and for the whole series:
> > 
> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> 
> Thanks!
> 
> The fix is:
> 
> arch/arm/boot/dts/emev2-kzm9d.dtb: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Series applied.

^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node
@ 2018-05-02  6:56         ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-05-02  6:56 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Apr 30, 2018 at 09:07:48AM +0200, Simon Horman wrote:
> On Thu, Apr 26, 2018 at 04:52:13PM +0200, Niklas S?derlund wrote:
> > Hi Simon,
> > 
> > Thanks for your work.
> > 
> > On 2018-04-26 12:29:48 +0200, Simon Horman wrote:
> > > The gpio_keys node does not have an address and thus does not need
> > > address-cells or address size-properties.
> > > 
> > > This is flagged by dtc as follows:
> > >  # make dtbs W=1
> > >  arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> > 
> > This warning don't seem to match with the change nor the rest of the 
> > commit message :-)
> > 
> > With that addressed and for the whole series:
> > 
> > Reviewed-by: Niklas S?derlund <niklas.soderlund+renesas@ragnatech.se>
> 
> Thanks!
> 
> The fix is:
> 
> arch/arm/boot/dts/emev2-kzm9d.dtb: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Series applied.

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 00/10] ARM, arm64: dts: renesas: update register properties
  2018-04-26 10:29 ` Simon Horman
@ 2018-05-02 13:10   ` Geert Uytterhoeven
  -1 siblings, 0 replies; 32+ messages in thread
From: Geert Uytterhoeven @ 2018-05-02 13:10 UTC (permalink / raw)
  To: Simon Horman
  Cc: Linux-Renesas, Linux ARM, Magnus Damm, Kuninori Morimoto,
	Niklas Söderlund

Hi Simon,

On Thu, Apr 26, 2018 at 12:29 PM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> this series:
>
> 1. Drops unnecessary address properties from VIN port nodes
>    on Renesas R-Car Gen2 SoC board DTSes. These are unnecessary
>    as the nodes to not have bus addresses.

I guess the example in Documentation/devicetree/bindings/media/rcar_vin.txt
should be updated, too?

> 2. And adds address properties to R-Car Sound port nodes on
>    Renesas R-Car Gen2 SoC DTSes. These are necessary as the nodes
>    have unit names.

Documentation/devicetree/bindings/sound/renesas,rsnd.txt doesn't say
anything about the presence of ports?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 00/10] ARM, arm64: dts: renesas: update register properties
@ 2018-05-02 13:10   ` Geert Uytterhoeven
  0 siblings, 0 replies; 32+ messages in thread
From: Geert Uytterhoeven @ 2018-05-02 13:10 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Simon,

On Thu, Apr 26, 2018 at 12:29 PM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> this series:
>
> 1. Drops unnecessary address properties from VIN port nodes
>    on Renesas R-Car Gen2 SoC board DTSes. These are unnecessary
>    as the nodes to not have bus addresses.

I guess the example in Documentation/devicetree/bindings/media/rcar_vin.txt
should be updated, too?

> 2. And adds address properties to R-Car Sound port nodes on
>    Renesas R-Car Gen2 SoC DTSes. These are necessary as the nodes
>    have unit names.

Documentation/devicetree/bindings/sound/renesas,rsnd.txt doesn't say
anything about the presence of ports?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 00/10] ARM, arm64: dts: renesas: update register properties
  2018-05-02 13:10   ` Geert Uytterhoeven
@ 2018-05-09 18:48     ` Simon Horman
  -1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-05-09 18:48 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linux-Renesas, Linux ARM, Magnus Damm, Kuninori Morimoto,
	Niklas Söderlund

On Wed, May 02, 2018 at 03:10:18PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Apr 26, 2018 at 12:29 PM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > this series:
> >
> > 1. Drops unnecessary address properties from VIN port nodes
> >    on Renesas R-Car Gen2 SoC board DTSes. These are unnecessary
> >    as the nodes to not have bus addresses.
> 
> I guess the example in Documentation/devicetree/bindings/media/rcar_vin.txt
> should be updated, too?

I have sent a patch for this.

> > 2. And adds address properties to R-Car Sound port nodes on
> >    Renesas R-Car Gen2 SoC DTSes. These are necessary as the nodes
> >    have unit names.
> 
> Documentation/devicetree/bindings/sound/renesas,rsnd.txt doesn't say
> anything about the presence of ports?

^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 00/10] ARM, arm64: dts: renesas: update register properties
@ 2018-05-09 18:48     ` Simon Horman
  0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2018-05-09 18:48 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, May 02, 2018 at 03:10:18PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Apr 26, 2018 at 12:29 PM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > this series:
> >
> > 1. Drops unnecessary address properties from VIN port nodes
> >    on Renesas R-Car Gen2 SoC board DTSes. These are unnecessary
> >    as the nodes to not have bus addresses.
> 
> I guess the example in Documentation/devicetree/bindings/media/rcar_vin.txt
> should be updated, too?

I have sent a patch for this.

> > 2. And adds address properties to R-Car Sound port nodes on
> >    Renesas R-Car Gen2 SoC DTSes. These are necessary as the nodes
> >    have unit names.
> 
> Documentation/devicetree/bindings/sound/renesas,rsnd.txt doesn't say
> anything about the presence of ports?

^ permalink raw reply	[flat|nested] 32+ messages in thread

end of thread, other threads:[~2018-05-09 18:49 UTC | newest]

Thread overview: 32+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 10:29 [PATCH 00/10] ARM, arm64: dts: renesas: update register properties Simon Horman
2018-04-26 10:29 ` Simon Horman
2018-04-26 10:29 ` [PATCH 01/10] ARM: dts: lager: Drop unnecessary address properties from port node Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 02/10] ARM: dts: porter: Drop unnecessary address properties from vin " Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 03/10] ARM: dts: gose: Drop unnecessary address properties from port nodes Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 04/10] ARM: dts: koelsch: " Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 05/10] ARM: dts: alt: Drop unnecessary address properties from vin port node Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 06/10] ARM: dts: silk: " Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 14:52   ` Niklas Söderlund
2018-04-26 14:52     ` Niklas Söderlund
2018-04-30  7:07     ` Simon Horman
2018-04-30  7:07       ` Simon Horman
2018-05-02  6:56       ` Simon Horman
2018-05-02  6:56         ` Simon Horman
2018-04-26 10:29 ` [PATCH 08/10] arm64: dts: renesas: r8a7795: Add address properties to rcar_sound port nodes Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 09/10] arm64: dts: renesas: r8a7796: " Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 10/10] arm64: dts: renesas: r8a77965: " Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-05-02 13:10 ` [PATCH 00/10] ARM, arm64: dts: renesas: update register properties Geert Uytterhoeven
2018-05-02 13:10   ` Geert Uytterhoeven
2018-05-09 18:48   ` Simon Horman
2018-05-09 18:48     ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.