From: Heikki Krogerus <heikki.krogerus@linux.intel.com> To: Hans de Goede <hdegoede@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Guenter Roeck <linux@roeck-us.net>, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 4/4] usb: roles: intel_xhci: Always allow user control Date: Wed, 2 May 2018 09:52:48 +0300 [thread overview] Message-ID: <20180502065248.GC12870@kuha.fi.intel.com> (raw) In-Reply-To: <9a0b6af4-8d49-8193-2fcd-a956c3f852ed@redhat.com> On Tue, May 01, 2018 at 11:57:55AM +0200, Hans de Goede wrote: > Hi, > > On 30-04-18 14:41, Heikki Krogerus wrote: > > Trying to determine the USB port type with this mux is very > > difficult. To simplify the situation, always allowing user > > control, even if the port is USB Type-C port. > > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > > drivers/usb/roles/intel-xhci-usb-role-switch.c | 15 +-------------- > > 1 file changed, 1 insertion(+), 14 deletions(-) > > > > diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c b/drivers/usb/roles/intel-xhci-usb-role-switch.c > > index 28102127b9d5..6482eee6fd45 100644 > > --- a/drivers/usb/roles/intel-xhci-usb-role-switch.c > > +++ b/drivers/usb/roles/intel-xhci-usb-role-switch.c > > @@ -43,15 +43,6 @@ struct intel_xhci_acpi_match { > > int hrv; > > }; > > -/* > > - * ACPI IDs for PMICs which do not support separate data and power role > > - * detection (USB ACA detection for micro USB OTG), we allow userspace to > > - * change the role manually on these. > > - */ > > -static const struct intel_xhci_acpi_match allow_userspace_ctrl_ids[] = { > > - { "INT33F4", 3 }, /* X-Powers AXP288 PMIC */ > > -}; > > - > > static int intel_xhci_usb_set_role(struct device *dev, enum usb_role role) > > { > > struct intel_xhci_usb_data *data = dev_get_drvdata(dev); > > @@ -137,7 +128,6 @@ static int intel_xhci_usb_probe(struct platform_device *pdev) > > struct device *dev = &pdev->dev; > > struct intel_xhci_usb_data *data; > > struct resource *res; > > - int i; > > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > > if (!data) > > @@ -150,10 +140,7 @@ static int intel_xhci_usb_probe(struct platform_device *pdev) > > if (!data->base) > > return -ENOMEM; > > - for (i = 0; i < ARRAY_SIZE(allow_userspace_ctrl_ids); i++) > > - if (acpi_dev_present(allow_userspace_ctrl_ids[i].hid, "1", > > - allow_userspace_ctrl_ids[i].hrv)) > > - sw_desc.allow_userspace_control = true; > > + sw_desc.allow_userspace_control = true; > > It would be better to add: > > .allow_userspace_control = true, > > To the initialization of the struct and also make the struct const since > we are now no longer changing it and usb_role_switch_register() accepts > it being const. Makes sense. > With that changed: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> Thanks, -- heikki
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com> To: Hans de Goede <hdegoede@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Guenter Roeck <linux@roeck-us.net>, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [4/4] usb: roles: intel_xhci: Always allow user control Date: Wed, 2 May 2018 09:52:48 +0300 [thread overview] Message-ID: <20180502065248.GC12870@kuha.fi.intel.com> (raw) On Tue, May 01, 2018 at 11:57:55AM +0200, Hans de Goede wrote: > Hi, > > On 30-04-18 14:41, Heikki Krogerus wrote: > > Trying to determine the USB port type with this mux is very > > difficult. To simplify the situation, always allowing user > > control, even if the port is USB Type-C port. > > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > > drivers/usb/roles/intel-xhci-usb-role-switch.c | 15 +-------------- > > 1 file changed, 1 insertion(+), 14 deletions(-) > > > > diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c b/drivers/usb/roles/intel-xhci-usb-role-switch.c > > index 28102127b9d5..6482eee6fd45 100644 > > --- a/drivers/usb/roles/intel-xhci-usb-role-switch.c > > +++ b/drivers/usb/roles/intel-xhci-usb-role-switch.c > > @@ -43,15 +43,6 @@ struct intel_xhci_acpi_match { > > int hrv; > > }; > > -/* > > - * ACPI IDs for PMICs which do not support separate data and power role > > - * detection (USB ACA detection for micro USB OTG), we allow userspace to > > - * change the role manually on these. > > - */ > > -static const struct intel_xhci_acpi_match allow_userspace_ctrl_ids[] = { > > - { "INT33F4", 3 }, /* X-Powers AXP288 PMIC */ > > -}; > > - > > static int intel_xhci_usb_set_role(struct device *dev, enum usb_role role) > > { > > struct intel_xhci_usb_data *data = dev_get_drvdata(dev); > > @@ -137,7 +128,6 @@ static int intel_xhci_usb_probe(struct platform_device *pdev) > > struct device *dev = &pdev->dev; > > struct intel_xhci_usb_data *data; > > struct resource *res; > > - int i; > > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > > if (!data) > > @@ -150,10 +140,7 @@ static int intel_xhci_usb_probe(struct platform_device *pdev) > > if (!data->base) > > return -ENOMEM; > > - for (i = 0; i < ARRAY_SIZE(allow_userspace_ctrl_ids); i++) > > - if (acpi_dev_present(allow_userspace_ctrl_ids[i].hid, "1", > > - allow_userspace_ctrl_ids[i].hrv)) > > - sw_desc.allow_userspace_control = true; > > + sw_desc.allow_userspace_control = true; > > It would be better to add: > > .allow_userspace_control = true, > > To the initialization of the struct and also make the struct const since > we are now no longer changing it and usb_role_switch_register() accepts > it being const. Makes sense. > With that changed: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> Thanks,
next prev parent reply other threads:[~2018-05-02 6:52 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-30 12:41 [PATCH 0/4] usb: typec: fixes for Cherry Trails Heikki Krogerus 2018-04-30 12:41 ` [PATCH 1/4] platform: x86: intel_cht_int33fe: Fix dependencies Heikki Krogerus 2018-04-30 12:41 ` [1/4] " Heikki Krogerus 2018-05-01 9:53 ` [PATCH 1/4] " Hans de Goede 2018-05-01 9:53 ` [1/4] " Hans de Goede 2018-05-02 6:59 ` [PATCH 1/4] " Heikki Krogerus 2018-05-02 6:59 ` [1/4] " Heikki Krogerus 2018-04-30 12:41 ` [PATCH 2/4] usb: typec: tcpm: Release the role mux when exiting Heikki Krogerus 2018-04-30 12:41 ` [2/4] " Heikki Krogerus 2018-04-30 13:40 ` [PATCH 2/4] " Guenter Roeck 2018-04-30 13:40 ` [2/4] " Guenter Roeck 2018-05-01 9:54 ` [PATCH 2/4] " Hans de Goede 2018-05-01 9:54 ` [2/4] " Hans de Goede 2018-04-30 12:41 ` [PATCH 3/4] usb: typec: fusb302: Fix debugfs issue Heikki Krogerus 2018-04-30 12:41 ` [3/4] " Heikki Krogerus 2018-04-30 13:34 ` [PATCH 3/4] " Guenter Roeck 2018-04-30 13:34 ` [3/4] " Guenter Roeck 2018-05-02 6:52 ` [PATCH 3/4] " Heikki Krogerus 2018-05-02 6:52 ` [3/4] " Heikki Krogerus 2018-04-30 12:41 ` [PATCH 4/4] usb: roles: intel_xhci: Always allow user control Heikki Krogerus 2018-04-30 12:41 ` [4/4] " Heikki Krogerus 2018-05-01 9:57 ` [PATCH 4/4] " Hans de Goede 2018-05-01 9:57 ` [4/4] " Hans de Goede 2018-05-02 6:52 ` Heikki Krogerus [this message] 2018-05-02 6:52 ` Heikki Krogerus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180502065248.GC12870@kuha.fi.intel.com \ --to=heikki.krogerus@linux.intel.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=hdegoede@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=linux@roeck-us.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.