From: Hans de Goede <hdegoede@redhat.com> To: Heikki Krogerus <heikki.krogerus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Guenter Roeck <linux@roeck-us.net>, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 2/4] usb: typec: tcpm: Release the role mux when exiting Date: Tue, 1 May 2018 11:54:41 +0200 [thread overview] Message-ID: <26404d4d-af38-ecf7-ae21-80bb23a4749a@redhat.com> (raw) In-Reply-To: <20180430124158.45269-3-heikki.krogerus@linux.intel.com> Hi, On 30-04-18 14:41, Heikki Krogerus wrote: > The ref count for the USB role switch device must be > released after we are done using the switch. > > Fixes: c6962c29729c ("usb: typec: tcpm: Set USB role switch to device mode when configured as such") > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Makes sense: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/usb/typec/tcpm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > index 1ee259bc14a5..66dc0773b9bf 100644 > --- a/drivers/usb/typec/tcpm.c > +++ b/drivers/usb/typec/tcpm.c > @@ -4652,6 +4652,7 @@ void tcpm_unregister_port(struct tcpm_port *port) > for (i = 0; i < ARRAY_SIZE(port->port_altmode); i++) > typec_unregister_altmode(port->port_altmode[i]); > typec_unregister_port(port->typec_port); > + usb_role_switch_put(port->role_sw); > tcpm_debugfs_exit(port); > destroy_workqueue(port->wq); > } >
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com> To: Heikki Krogerus <heikki.krogerus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Guenter Roeck <linux@roeck-us.net>, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [2/4] usb: typec: tcpm: Release the role mux when exiting Date: Tue, 1 May 2018 11:54:41 +0200 [thread overview] Message-ID: <26404d4d-af38-ecf7-ae21-80bb23a4749a@redhat.com> (raw) Hi, On 30-04-18 14:41, Heikki Krogerus wrote: > The ref count for the USB role switch device must be > released after we are done using the switch. > > Fixes: c6962c29729c ("usb: typec: tcpm: Set USB role switch to device mode when configured as such") > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Makes sense: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/usb/typec/tcpm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > index 1ee259bc14a5..66dc0773b9bf 100644 > --- a/drivers/usb/typec/tcpm.c > +++ b/drivers/usb/typec/tcpm.c > @@ -4652,6 +4652,7 @@ void tcpm_unregister_port(struct tcpm_port *port) > for (i = 0; i < ARRAY_SIZE(port->port_altmode); i++) > typec_unregister_altmode(port->port_altmode[i]); > typec_unregister_port(port->typec_port); > + usb_role_switch_put(port->role_sw); > tcpm_debugfs_exit(port); > destroy_workqueue(port->wq); > } > --- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-01 9:54 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-30 12:41 [PATCH 0/4] usb: typec: fixes for Cherry Trails Heikki Krogerus 2018-04-30 12:41 ` [PATCH 1/4] platform: x86: intel_cht_int33fe: Fix dependencies Heikki Krogerus 2018-04-30 12:41 ` [1/4] " Heikki Krogerus 2018-05-01 9:53 ` [PATCH 1/4] " Hans de Goede 2018-05-01 9:53 ` [1/4] " Hans de Goede 2018-05-02 6:59 ` [PATCH 1/4] " Heikki Krogerus 2018-05-02 6:59 ` [1/4] " Heikki Krogerus 2018-04-30 12:41 ` [PATCH 2/4] usb: typec: tcpm: Release the role mux when exiting Heikki Krogerus 2018-04-30 12:41 ` [2/4] " Heikki Krogerus 2018-04-30 13:40 ` [PATCH 2/4] " Guenter Roeck 2018-04-30 13:40 ` [2/4] " Guenter Roeck 2018-05-01 9:54 ` Hans de Goede [this message] 2018-05-01 9:54 ` Hans de Goede 2018-04-30 12:41 ` [PATCH 3/4] usb: typec: fusb302: Fix debugfs issue Heikki Krogerus 2018-04-30 12:41 ` [3/4] " Heikki Krogerus 2018-04-30 13:34 ` [PATCH 3/4] " Guenter Roeck 2018-04-30 13:34 ` [3/4] " Guenter Roeck 2018-05-02 6:52 ` [PATCH 3/4] " Heikki Krogerus 2018-05-02 6:52 ` [3/4] " Heikki Krogerus 2018-04-30 12:41 ` [PATCH 4/4] usb: roles: intel_xhci: Always allow user control Heikki Krogerus 2018-04-30 12:41 ` [4/4] " Heikki Krogerus 2018-05-01 9:57 ` [PATCH 4/4] " Hans de Goede 2018-05-01 9:57 ` [4/4] " Hans de Goede 2018-05-02 6:52 ` [PATCH 4/4] " Heikki Krogerus 2018-05-02 6:52 ` [4/4] " Heikki Krogerus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=26404d4d-af38-ecf7-ae21-80bb23a4749a@redhat.com \ --to=hdegoede@redhat.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=heikki.krogerus@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=linux@roeck-us.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.