* [RFC] perf record: dead code perf_event__synthesize_id_index()
@ 2018-05-02 16:38 Stephane Eranian
2018-05-02 16:57 ` Jiri Olsa
0 siblings, 1 reply; 3+ messages in thread
From: Stephane Eranian @ 2018-05-02 16:38 UTC (permalink / raw)
To: LKML
Cc: Adrian Hunter, Arnaldo Carvalho de Melo, Jiri Olsa, mingo,
Peter Zijlstra
Hi,
It looks like perf_event__synthesize_id_index() is dead code in the current
tip
tree. I don't see any invocation of the function anywhere in perf.I
understand why
you'd want to keep the rest of the code related to PERF_RECORD_ID_INDEX
because some perf.data file may have this user-level record type. But the
synthesize code is not needed anymore, in my opinion.
Shouldn't we remove this code?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] perf record: dead code perf_event__synthesize_id_index()
2018-05-02 16:38 [RFC] perf record: dead code perf_event__synthesize_id_index() Stephane Eranian
@ 2018-05-02 16:57 ` Jiri Olsa
2018-05-03 6:15 ` Adrian Hunter
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Olsa @ 2018-05-02 16:57 UTC (permalink / raw)
To: Stephane Eranian
Cc: LKML, Adrian Hunter, Arnaldo Carvalho de Melo, mingo, Peter Zijlstra
On Wed, May 02, 2018 at 04:38:33PM +0000, Stephane Eranian wrote:
> Hi,
>
> It looks like perf_event__synthesize_id_index() is dead code in the current
> tip
> tree. I don't see any invocation of the function anywhere in perf.I
> understand why
> you'd want to keep the rest of the code related to PERF_RECORD_ID_INDEX
> because some perf.data file may have this user-level record type. But the
> synthesize code is not needed anymore, in my opinion.
>
> Shouldn't we remove this code?
looks like there never was any user of it, probably some
preparation for follow up that haven't happened yet.. Adrian?
jirka
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] perf record: dead code perf_event__synthesize_id_index()
2018-05-02 16:57 ` Jiri Olsa
@ 2018-05-03 6:15 ` Adrian Hunter
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2018-05-03 6:15 UTC (permalink / raw)
To: Jiri Olsa, Stephane Eranian
Cc: LKML, Arnaldo Carvalho de Melo, mingo, Peter Zijlstra, Shishkin,
Alexander
On 02/05/18 19:57, Jiri Olsa wrote:
> On Wed, May 02, 2018 at 04:38:33PM +0000, Stephane Eranian wrote:
>> Hi,
>>
>> It looks like perf_event__synthesize_id_index() is dead code in the current
>> tip
>> tree. I don't see any invocation of the function anywhere in perf.I
>> understand why
>> you'd want to keep the rest of the code related to PERF_RECORD_ID_INDEX
>> because some perf.data file may have this user-level record type. But the
>> synthesize code is not needed anymore, in my opinion.
>>
>> Shouldn't we remove this code?
>
> looks like there never was any user of it, probably some
> preparation for follow up that haven't happened yet.. Adrian?
Yes it is for AUX area sampling support, which we have patches for. Just
waiting on Alex to get the kernel side accepted.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-03 6:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 16:38 [RFC] perf record: dead code perf_event__synthesize_id_index() Stephane Eranian
2018-05-02 16:57 ` Jiri Olsa
2018-05-03 6:15 ` Adrian Hunter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.