From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Luwei Kang <luwei.kang@intel.com>
Cc: kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, pbonzini@redhat.com,
rkrcmar@redhat.com, linux-kernel@vger.kernel.org,
joro@8bytes.org, peterz@infradead.org,
chao.p.peng@linux.intel.com
Subject: Re: [PATCH v7 05/13] perf/x86/intel/pt: Introduce a new function to get capability of Intel PT
Date: Thu, 3 May 2018 13:50:32 +0300 [thread overview]
Message-ID: <20180503105032.h73n5lcrwkdbahgm@um.fi.intel.com> (raw)
In-Reply-To: <1525349323-9938-6-git-send-email-luwei.kang@intel.com>
On Thu, May 03, 2018 at 08:08:35PM +0800, Luwei Kang wrote:
> New function __pt_cap_get() will be invoked in KVM to check
> if a specific capability is availiable in KVM guest.
> Another function pt_cap_get() can only check the hardware
> capabilities but this may different with KVM guest because
> some features may not be exposed to guest.
Do we really need both in KVM?
> diff --git a/arch/x86/include/asm/intel_pt.h b/arch/x86/include/asm/intel_pt.h
> index 2de4db0..3a4f524 100644
> --- a/arch/x86/include/asm/intel_pt.h
> +++ b/arch/x86/include/asm/intel_pt.h
> @@ -27,9 +27,11 @@ enum pt_capabilities {
> #if defined(CONFIG_PERF_EVENTS) && defined(CONFIG_CPU_SUP_INTEL)
> void cpu_emergency_stop_pt(void);
> extern u32 pt_cap_get(enum pt_capabilities cap);
> +extern u32 __pt_cap_get(u32 *caps, enum pt_capabilities cap);
I'd call it something like pt_cap_decode().
next prev parent reply other threads:[~2018-05-03 10:50 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 12:08 [PATCH v7 00/13] Intel Processor Trace virtualization enabling Luwei Kang
2018-05-03 10:33 ` Alexander Shishkin
2018-05-03 12:08 ` [PATCH v7 01/13] perf/x86/intel/pt: Move Intel-PT MSRs bit definitions to a public header Luwei Kang
2018-05-03 12:08 ` [PATCH v7 02/13] perf/x86/intel/pt: Change pt_cap_get() to a public function Luwei Kang
2018-05-03 12:08 ` [PATCH v7 03/13] perf/x86/intel/pt: Add new bit definitions for Intel PT MSRs Luwei Kang
2018-05-03 12:08 ` [PATCH v7 04/13] perf/x86/intel/pt: add new capability for Intel PT Luwei Kang
2018-05-03 12:08 ` [PATCH v7 05/13] perf/x86/intel/pt: Introduce a new function to get capability of " Luwei Kang
2018-05-03 10:50 ` Alexander Shishkin [this message]
2018-05-03 11:04 ` Kang, Luwei
2018-05-03 12:13 ` Alexander Shishkin
2018-05-03 12:30 ` Paolo Bonzini
2018-05-03 12:30 ` Kang, Luwei
2018-05-03 12:32 ` Paolo Bonzini
2018-05-03 12:50 ` Kang, Luwei
2018-05-03 12:59 ` Alexander Shishkin
2018-05-03 12:08 ` [PATCH v7 06/13] KVM: x86: Add Intel Processor Trace virtualization mode Luwei Kang
2018-05-03 11:32 ` Alexander Shishkin
2018-05-03 11:50 ` Paolo Bonzini
2018-05-03 12:02 ` Alexander Shishkin
2018-05-03 12:30 ` Paolo Bonzini
2018-05-03 12:48 ` Alexander Shishkin
2018-05-03 12:50 ` Paolo Bonzini
2018-05-03 13:38 ` Alexander Shishkin
2018-05-03 13:48 ` Paolo Bonzini
2018-05-04 10:38 ` Alexander Shishkin
2018-05-04 21:52 ` Paolo Bonzini
2018-05-04 10:45 ` Peter Zijlstra
2018-05-04 21:44 ` Paolo Bonzini
2018-05-04 22:15 ` Peter Zijlstra
2018-05-07 10:47 ` Paolo Bonzini
2018-05-03 11:52 ` Paolo Bonzini
2018-05-03 12:09 ` Alexander Shishkin
2018-05-03 12:31 ` Paolo Bonzini
2018-05-03 12:08 ` [PATCH v7 07/13] KVM: x86: Add Intel Processor Trace cpuid emulation Luwei Kang
2018-05-03 12:08 ` [PATCH v7 08/13] KVM: x86: Add Intel processor trace context for each vcpu Luwei Kang
2018-05-03 11:39 ` Alexander Shishkin
2018-05-03 11:53 ` Paolo Bonzini
2018-05-03 12:08 ` [PATCH v7 09/13] KVM: x86: Implement Intel Processor Trace context switch Luwei Kang
2018-05-04 10:29 ` Alexander Shishkin
2018-05-04 21:49 ` Paolo Bonzini
2018-05-03 12:08 ` [PATCH v7 10/13] KVM: x86: Introduce a function to initialize the PT configuration Luwei Kang
2018-05-03 12:08 ` [PATCH v7 11/13] KVM: x86: Implement Intel Processor Trace MSRs read/write Luwei Kang
2018-05-04 10:11 ` Alexander Shishkin
2018-05-04 21:47 ` Paolo Bonzini
2018-05-03 12:08 ` [PATCH v7 12/13] KVM: x86: Set intercept for Intel PT " Luwei Kang
2018-05-03 12:08 ` [PATCH v7 13/13] KVM: x86: Disable Intel Processor Trace when VMXON in L1 guest Luwei Kang
2018-05-04 10:23 ` Alexander Shishkin
2018-05-04 21:49 ` Paolo Bonzini
2018-05-03 12:13 [PATCH v7 00/13] Intel Processor Trace virtualization enabling Luwei Kang
2018-05-03 12:13 ` [PATCH v7 05/13] perf/x86/intel/pt: Introduce a new function to get capability of Intel PT Luwei Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503105032.h73n5lcrwkdbahgm@um.fi.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.