From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Marc Zyngier <marc.zyngier@arm.com>, Ray Jui <rjui@broadcom.com>,
Alexander Graf <agraf@suse.de>,
linux-spi@vger.kernel.org, Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: bcm2835aux: ensure interrupts are enabled for shared handler
Date: Fri, 4 May 2018 08:06:02 +0900 [thread overview]
Message-ID: <20180503230602.GA13402@sirena.org.uk> (raw)
In-Reply-To: <20180503180945.3502-1-robh@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 657 bytes --]
On Thu, May 03, 2018 at 01:09:44PM -0500, Rob Herring wrote:
> The root cause however is a bug in the shared handler. Shared handlers
> must check that interrupts are actually enabled before servicing the
> interrupt. Add a check that the TXEMPTY or IDLE interrupts are enabled.
The requirement is more that the handler should correctly identify if it
actually handled an interrupt - especially if the driver doesn't enable
and disable the interrupt at runtime it's not going to upset anything to
always run the interrupt handling (and of course some hardware can't
disable things anyway) but if nohing happened then the handler needs to
return IRQ_NONE.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: bcm2835aux: ensure interrupts are enabled for shared handler
Date: Fri, 4 May 2018 08:06:02 +0900 [thread overview]
Message-ID: <20180503230602.GA13402@sirena.org.uk> (raw)
In-Reply-To: <20180503180945.3502-1-robh@kernel.org>
On Thu, May 03, 2018 at 01:09:44PM -0500, Rob Herring wrote:
> The root cause however is a bug in the shared handler. Shared handlers
> must check that interrupts are actually enabled before servicing the
> interrupt. Add a check that the TXEMPTY or IDLE interrupts are enabled.
The requirement is more that the handler should correctly identify if it
actually handled an interrupt - especially if the driver doesn't enable
and disable the interrupt at runtime it's not going to upset anything to
always run the interrupt handling (and of course some hardware can't
disable things anyway) but if nohing happened then the handler needs to
return IRQ_NONE.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180504/fb07c019/attachment.sig>
next prev parent reply other threads:[~2018-05-03 23:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 18:09 [PATCH] spi: bcm2835aux: ensure interrupts are enabled for shared handler Rob Herring
2018-05-03 18:09 ` Rob Herring
2018-05-03 18:31 ` Stefan Wahren
2018-05-03 18:31 ` Stefan Wahren
2018-05-03 21:15 ` Eric Anholt
2018-05-03 21:15 ` Eric Anholt
2018-05-03 22:06 ` Rob Herring
2018-05-03 22:06 ` Rob Herring
2018-05-03 22:36 ` Eric Anholt
2018-05-03 22:36 ` Eric Anholt
2018-05-03 23:06 ` Mark Brown [this message]
2018-05-03 23:06 ` Mark Brown
2018-05-03 23:19 ` Applied "spi: bcm2835aux: ensure interrupts are enabled for shared handler" to the spi tree Mark Brown
2018-05-03 23:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503230602.GA13402@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agraf@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.