All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [RFC PATCH 0/1] Yet another fixes for network
@ 2018-05-07 19:32 Petr Vorel
  2018-05-07 19:32 ` [LTP] [RFC PATCH 1/1] net/ipsec: Fix getopts parsing -s parameter Petr Vorel
  0 siblings, 1 reply; 14+ messages in thread
From: Petr Vorel @ 2018-05-07 19:32 UTC (permalink / raw)
  To: ltp

Hi,

My commit 89a83d8a0 ("net/ipsec_lib.sh: Process getopts parameters with
TST_OPTS and TST_PARSE_ARGS") broke parsing -s parameter ("array"
separated by space).

This patch fixes it by changing separator to ':'.
Other solution is just to revert it, not to block the release.

The same problem is with runtest/net.nfs, that's why we shouldn't
apply Xiao's patch [1] until we solve this.

To allow properly parse quoted parameters in the new API we'd have to
avoid shifting parameters before tst_run, but I haven't found a
solution.  I suppose, we are not going to change the way how getopts are
handled in the new API anyway, so we should document this feature in
doc/test-writing-guidelines.txt.

I apologize for complicating release by "last minute changes".


Kind regards,
Petr

[1] https://lists.linux.it/pipermail/ltp/2018-May/008021.html

Petr Vorel (1):
  net/ipsec: Fix getopts parsing -s parameter

 runtest/net_stress.ipsec_dccp               | 212 ++++++++++++++--------------
 runtest/net_stress.ipsec_icmp               | 168 +++++++++++-----------
 runtest/net_stress.ipsec_sctp               | 212 ++++++++++++++--------------
 runtest/net_stress.ipsec_tcp                | 212 ++++++++++++++--------------
 runtest/net_stress.ipsec_udp                | 208 +++++++++++++--------------
 testcases/network/stress/ipsec/ipsec_lib.sh |  12 +-
 6 files changed, 516 insertions(+), 508 deletions(-)

-- 
2.16.3


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2018-05-11  9:36 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 19:32 [LTP] [RFC PATCH 0/1] Yet another fixes for network Petr Vorel
2018-05-07 19:32 ` [LTP] [RFC PATCH 1/1] net/ipsec: Fix getopts parsing -s parameter Petr Vorel
2018-05-08  3:01   ` Xiao Yang
2018-05-08  7:50     ` Petr Vorel
2018-05-09 10:54       ` [LTP] [PATCH] lib/tst_test.sh: Detect quoted parameters correctly Xiao Yang
2018-05-09 11:31         ` Petr Vorel
2018-05-11  8:32           ` Xiao Yang
2018-05-11  9:14             ` Petr Vorel
2018-05-11  9:36               ` Xiao Yang
2018-05-09 11:01       ` [LTP] [RFC PATCH 1/1] net/ipsec: Fix getopts parsing -s parameter Xiao Yang
2018-05-09 11:34         ` Petr Vorel
2018-05-08  3:12   ` [LTP] [PATCH] lib/tst_net.sh: Detect quoted parameters correctly Xiao Yang
2018-05-08  8:05     ` Petr Vorel
2018-05-09 15:27     ` Petr Vorel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.